| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
new actions along with the existing ones
Signed-off-by: mahmadi <mahmadi@chromium.org>
BUG=552547
Review URL: https://codereview.chromium.org/1413833009
Cr-Commit-Position: refs/heads/master@{#358430}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This metric will be collected when
https://codereview.chromium.org/1413503007/ lands in
Chromium.
BUG=chromium:546603
R=asvitkine@chromium.org,rkaplow@chromium.org
Review URL: https://codereview.chromium.org/1414283008
Cr-Commit-Position: refs/heads/master@{#358426}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We need a way for users to explicitly disable Media Router if it were
enabled by experiment. This is currently not possible since Media Router
uses FeatureSwitch, and --enable-media-router is considered a "legacy"
switch, which means explicit disabling that overrides experiment
value is not supported (because the fallback value is to disable).
Changing to a tri value flag (1, 0, default) will solve this problem
and allow explicit enabling/disabling of MediaRouter overriding
experiment group.
BUG=552144
Review URL: https://codereview.chromium.org/1420423008
Cr-Commit-Position: refs/heads/master@{#358422}
|
|
|
|
|
|
|
|
|
|
| |
Since there are no products other that Chrome, it is better to fail with HIGHER_VERSION_EXISTS. This is largely a revert of r164040.
BUG=545181
Review URL: https://codereview.chromium.org/1429263002
Cr-Commit-Position: refs/heads/master@{#358353}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This introduces a new cache of ShaperCache instances to FontCache, which
manages the life time of said cache and purges it as needed. This allows
ShaperCache instances to be reused across FontDescriptions, resulting in
significantly higher cache hit rates and thus better layout performance.
R=drott@chromium.org
BUG=545147
Review URL: https://codereview.chromium.org/1411103009
Cr-Commit-Position: refs/heads/master@{#358321}
|
|
|
|
|
|
|
|
|
| |
BUG=51182
TBR=isherman@chromium.org
Review URL: https://codereview.chromium.org/1415573015
Cr-Commit-Position: refs/heads/master@{#358294}
|
|
|
|
|
|
|
|
|
|
| |
- send-side delay stats for sent video streams
BUG=512752
Review URL: https://codereview.chromium.org/1423713016
Cr-Commit-Position: refs/heads/master@{#358290}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL refactors engagement tracking into an abstract base class,
with subclasses for user input and media playing detection. Media
play and pause events are now periodically observed and
contribute to site engagement.
BUG=464234
Review URL: https://codereview.chromium.org/1427913002
Cr-Commit-Position: refs/heads/master@{#358254}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SecTrust API is used for making load/no-load decision and CertVerifier
is used for getting the reason of verification failure. It is expected
that mismatch will happen for those 2 approaches (e.g. SecTrust API
considers cert as good, but CertVerifier considers same cert as bad).
This metric helps to understand how common mismatches are.
BUG=535699
Review URL: https://codereview.chromium.org/1430953003
Cr-Commit-Position: refs/heads/master@{#358241}
|
|
|
|
|
|
|
|
|
|
|
|
| |
WKWebView Web Controller has a cache of pending cert verification
results to avoid extra verifications when presenting SSL interstitial.
This metric helps to understand whether or not cache miss is possible.
BUG=541736
Review URL: https://codereview.chromium.org/1414793014
Cr-Commit-Position: refs/heads/master@{#358240}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DidGetUserInteraction() is called for mouse clicks, keypresses, and
gesture taps. This CL additionally calls it for mouse wheel events.
Impact on scrolling performance is minimised by calling
DidGetUserInteraction only at the start of a series of mouse wheel
events; any further events which occur less than 0.1 seconds after a
previous mouse wheel do not trigger the callback.
This CL also allows the site engagement service to correctly log and
register mouse wheel events.
BUG=548011,464234
Committed: https://crrev.com/13ce0f2bf5ad77c9fbb272bd9f3736cae4a80d0b
Cr-Commit-Position: refs/heads/master@{#357963}
Review URL: https://codereview.chromium.org/1407053010
Cr-Commit-Position: refs/heads/master@{#358226}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds the Quota.EvictedOriginAccessCount and
Quota.EvictedOriginTimeSinceAccess histograms that track how many time an
evicted origin has been used and how long since it has been used respectively.
BUG=542075
Review URL: https://codereview.chromium.org/1424653002
Cr-Commit-Position: refs/heads/master@{#358210}
|
|
|
|
|
|
|
|
|
|
| |
Also took the opportunity to take out all the autofill form submitted states metric from UserHappiness and put them in a mutually exclusive histogram.
BUG=540507
Review URL: https://codereview.chromium.org/1407953008
Cr-Commit-Position: refs/heads/master@{#358106}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds histograms for time spent updating draw properties on
the compositor thread. This will allow us to compare the performance
of CalcDrawProps to property trees on real pages (after
compositor-thread property trees are enabled).
The broswer and renderer compositors each get a separate histogram.
BUG=524142
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1413523008
Cr-Commit-Position: refs/heads/master@{#358082}
|
|
|
|
|
|
|
|
| |
BUG=549021
Review URL: https://codereview.chromium.org/1428213002
Cr-Commit-Position: refs/heads/master@{#358035}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebContentsObserver::DidGetUserInteraction."
Sheriff reverting CL
This CL broke Chromium/chromium-rel-linux/sizes/chrome-si/initializers
by introducing another static initializer:
render_widget_host_impl.cc _GLOBAL__sub_I_render_widget_host_impl.cc+0xf
render_widget_host_impl.cc base::time_internal::FromCheckedNumeric(base::internal::CheckedNumeric<long long>)
TBR=dominickn
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=464234
This reverts commit 13ce0f2bf5ad77c9fbb272bd9f3736cae4a80d0b.
Review URL: https://codereview.chromium.org/1410333014
Cr-Commit-Position: refs/heads/master@{#358033}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
sheriff reverting CL
This CL depends on https://codereview.chromium.org/1407053010 which
broke Chromium/chromium-rel-linux/sizes / chrome-si / initializers
by introducing another static initializer:
render_widget_host_impl.cc _GLOBAL__sub_I_render_widget_host_impl.cc+0xf
render_widget_host_impl.cc
base::time_internal::FromCheckedNumeric(base::internal::CheckedNumeric<long
long>)
TBR=dominckn@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=464234
This reverts commit 8658a8950b57449582033d6a8085e06fc34aa8c7.
Review URL: https://codereview.chromium.org/1410993013
Cr-Commit-Position: refs/heads/master@{#358031}
|
|
|
|
|
|
|
|
|
|
|
| |
Let's count FontFace constructor's usage to be compared with @font-face
rule usage.
BUG=n/a
Review URL: https://codereview.chromium.org/1428093006
Cr-Commit-Position: refs/heads/master@{#357998}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL refactors engagement tracking into an abstract base class,
with subclasses for user input and media playing detection. Media
play and pause events are now periodically observed and
contribute to site engagement.
BUG=464234
Review URL: https://codereview.chromium.org/1427913002
Cr-Commit-Position: refs/heads/master@{#357978}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DidGetUserInteraction() is called for mouse clicks, keypresses, and
gesture taps. This CL additionally calls it for mouse wheel events.
Impact on scrolling performance is minimised by calling
DidGetUserInteraction only at the start of a series of mouse wheel
events; any further events which occur less than 0.1 seconds after a
previous mouse wheel do not trigger the callback.
This CL also allows the site engagement service to correctly log and
register mouse wheel events.
BUG=548011,464234
Review URL: https://codereview.chromium.org/1407053010
Cr-Commit-Position: refs/heads/master@{#357963}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Based on: https://github.com/WebBluetoothCG/web-bluetooth/pull/174
Implementation of requestDevice by name or namePrefix.
BUG=546141
Review URL: https://codereview.chromium.org/1415533006
Cr-Commit-Position: refs/heads/master@{#357926}
|
|
|
|
|
|
|
|
| |
BUG=NONE
Review URL: https://codereview.chromium.org/1419203006
Cr-Commit-Position: refs/heads/master@{#357925}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Command line switch is already there.
Switch name was chosen to match implementation, flag name
to match user visible changes.
R=mpearson@chromium.org
BUG=524788
Review URL: https://codereview.chromium.org/1425393008
Cr-Commit-Position: refs/heads/master@{#357888}
|
|
|
|
|
|
|
|
| |
Added metrics: https://codereview.chromium.org/1431443002
Review URL: https://codereview.chromium.org/1417573004
Cr-Commit-Position: refs/heads/master@{#357752}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(both for the in-memory DB and the in-memory URL index)
Copied these descriptions from the internal repository. I plan to
revise them a bit in a later changelist. I figured a
copy-submit-modify-submit process was better for tracking diffs and
history.
BUG=
Review URL: https://codereview.chromium.org/1432573003
Cr-Commit-Position: refs/heads/master@{#357678}
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Adding edit button to a snackbar:
"Viewing an offline copy [Edit]"
* Fixing calls to RecordUserAction.record in EB EditActivity
BUG=491352
Review URL: https://codereview.chromium.org/1428523004
Cr-Commit-Position: refs/heads/master@{#357671}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
And also removing the "simplifiable page" detection heuristics from consideration when displaying the "simplify page" check box on print preview.
Also adding a cmdline and UI switch to disable it (--disable-print-preview-simplify and accompanying UI switch at chrome://flags)
R=thakis@chromium.org, nyquist@chromium.org, vitalybuka@chromium.org, thestig@chromium.org, mdjones@chromium.org, bengr@chromium.org,
isherman@chromium.org, mpearson@chromium.org
BUG=490809
Review URL: https://codereview.chromium.org/1419063002
Cr-Commit-Position: refs/heads/master@{#357661}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add two histograms to monitor progress bar animation updates
in the real world:
- Omnibox.ProgressBarBreakPointUpdateCount: Progress bar break point
count.
- Omnibox.ProgressBarUpdateCount: Raw progress bar frame count. If
there is no animation, it matches ProgressBarBreakPointUpdateCount.
BUG=547860
Review URL: https://codereview.chromium.org/1407113006
Cr-Commit-Position: refs/heads/master@{#357654}
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/1426863007
Cr-Commit-Position: refs/heads/master@{#357630}
|
|
|
|
|
|
|
|
|
|
|
|
| |
When I replaced Omnibox.QueryTime (which uses suffixes to generate a
list of histograms) with Omnibox.QueryTime2, I forgot to update the
suffix section of histograms.xml with the new histogram prefix.
BUG=
Review URL: https://codereview.chromium.org/1429783002
Cr-Commit-Position: refs/heads/master@{#357626}
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds support for field trials for enabling the AppContainer
lockdown policy as well as exposing the setting via the chrome://flags page.
BUG=455496
Review URL: https://codereview.chromium.org/1407883005
Cr-Commit-Position: refs/heads/master@{#357620}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Update the policy for handling unverified downloads to allow downloads
that are requested by a document that's whitelisted. The whitelist being
used is the SafeBrowsing download whitelist and likely represents
legitimate downloads.
The requesting document is determined based on the originator of the
file chooser request. This originator is currently furnished by the
renderer and, as such, considered potentially tainted in the event of a
renderer compromise.
BUG=533579
Review URL: https://codereview.chromium.org/1410423003
Cr-Commit-Position: refs/heads/master@{#357568}
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/1410053005
Cr-Commit-Position: refs/heads/master@{#357536}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Initially when a frame is created with FrameHostMsg_CreateChildFrame, we
send all of these properties in WebFrameOwnerProperties struct. Later on,
if any of these properties change, upon receiving a
didChangeFrameOwnerProperties message from blink, we update our FTN data
structure. Once the browser process sees such a message, it notifies the
child renderer process with FrameMsg_SetFrameOwnerProperties. The renderer
then would store them as the frame's FrameOwner properties.
The blink part of this CL started here:
https://chromiumcodereview.appspot.com/1319863006/
and it was later merged here. Keeping the reference for initial
codereview comments.
BUG=524725
Review URL: https://codereview.chromium.org/1307013004
Cr-Commit-Position: refs/heads/master@{#357503}
|
|
|
|
|
|
|
|
| |
BUG=491352
Review URL: https://codereview.chromium.org/1425253002
Cr-Commit-Position: refs/heads/master@{#357477}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
buffers."
The second reland still induced flaky crashes in GPU conformance tests related
to over-releasing a scoped_refptr<MessageAttachment>. This CL should have fixed
the problem: https://codereview.chromium.org/1408793008/.
I can reproduce the failure non-deterministically locally. I get a crash every
2-3 runs of the ogles conformance tests. With the CL I mentioned above, I've had
20 runs with no crashes.
> The CL changes the default behavior of resource buffer to use a Mach-backed
> SharedMemory region. This CL adds a field trial to measure the effect of Mach vs
> POSIX backed SharedMemory regions.
>
> BUG=547261, 466437
> Committed: https://crrev.com/e0e2fd398f3d07c8eebbe662d71a0f9286862476
> Cr-Commit-Position: refs/heads/master@{#356513}
BUG=547261, 466437
TBR=mark@chromium.org, isherman@chromium.org, asvitkine@chromium.org, avi@chromium.org
Review URL: https://codereview.chromium.org/1420203008
Cr-Commit-Position: refs/heads/master@{#357407}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Code for the following histogram was deleted a while back, there
was no data for the following two histograms.
Net.QuicSession.HandshakeRoundTripsForHTTP
Net.QuicSession.HandshakeRoundTripsForHTTPS
BUG=549278
R=asvitkine@chromium.org, rch@chromium.org
Review URL: https://codereview.chromium.org/1406153012
Cr-Commit-Position: refs/heads/master@{#357391}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implement blink classes for the 'deviceorientationabsolute' event.
Also add and update layout tests and UseCounters.
The 'ondeviceorientationabsolute' event listener is currently
exposed behind the experimental features flag.
BUG=520546
Review URL: https://codereview.chromium.org/1416123002
Cr-Commit-Position: refs/heads/master@{#357374}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a merge of these two CLs
https://codereview.chromium.org/1386493002/
https://codereview.chromium.org/1374363002/
This adds a RAPPOR metric tracking the time to the first contentful paint (i.e. first image/text painted). We group eTLD+1's into a coarse timing histogram.
These were both previously reverted due to a use-after-free, which was fixed here
https://codereview.chromium.org/1394953003/
BUG=538217
Review URL: https://codereview.chromium.org/1419663002
Cr-Commit-Position: refs/heads/master@{#357359}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In this experiment, we're trying to study the impact to NAT by the number of bindings created in short intervals. The stunprober will send 1 ping to each server. There will be total |rounds| of probers. They will be grouped into batches. For example, we'll have the first N probers reporting the success rate of total recv over total send as the first batch, the next N as the 2nd batch. Each batch will report its own UMA. This way, we could observe whether the later batch has higher failure rate than the initial ones.
The list of important parameters will be
1. the interval b/w the pings
2. the batch size
3. the total rounds
This depends on ongoing CL https://codereview.webrtc.org/1422593002
BUG=549639
Review URL: https://codereview.chromium.org/1417663004
Cr-Commit-Position: refs/heads/master@{#357293}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Makes it possible for web apps to have three different types of splash screens,
keyed on the quality of the image used for the splash screen.
* Web app related dimensions are renamed to be more consistent with all of the
new dimensions needed, leading to minor changes to various web app related
classes.
* Changes WebappActivity#initializeSplashScreen to create an empty
RelativeLayout when first called. The splash screen is changed and the
controls for the layout are inflated when the splash screen image is
retrieved.
BUG=532563
Review URL: https://codereview.chromium.org/1414113007
Cr-Commit-Position: refs/heads/master@{#357270}
|
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=open UMA for Ash.Dock.ActionSource.
DockedActionSource column should include "Keyboard"
Review URL: https://codereview.chromium.org/1424353002
Cr-Commit-Position: refs/heads/master@{#357230}
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/1414093005
Cr-Commit-Position: refs/heads/master@{#357226}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
resource buffers.""
This reverts commit 91e69f97803b08f998079bd8ec4729b30e346fbb.
Still causing problems on GPU conformance tests:
http://build.chromium.org/p/chromium.gpu/builders/Mac%20Retina%20Debug/builds/40564/steps/webgl_conformance_tests/logs/stdio
http://build.chromium.org/p/chromium.gpu/builders/Mac%20Retina%20Debug/builds/40570/steps/webgl_conformance_tests/logs/WebglConformance.conformance_ogles_GL_smoothstep_smoothstep_001_to_006
BUG=547261, 466437
TBR=mark@chromium.org, isherman@chromium.org, asvitkine@chromium.org, avi@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/1426663006
Cr-Commit-Position: refs/heads/master@{#357194}
|
|
|
|
|
|
|
|
| |
which removes these actions from that file.
Review URL: https://codereview.chromium.org/1410313007
Cr-Commit-Position: refs/heads/master@{#357193}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Fix possible O(n^4) worst case behavior (processes x widgets x
frames x siteinstances) for stats gathering.
- Show subframe-only processes in about:memory, which also causes them to
be reported in SiteIsolation.CurrentRendererProcessCount.
- Because SiteIsolation.CurrentRendererProcessCount is fixed, we need
a new family of metrics, SiteIsolation.IsolateNothing*, which simulates
the process-per-siteinstance process model. In tests, IsolateNothing
is expected to have the value that CurrentRenderProcessCount used to.
- Implement a more correct treatment of site isolation stats, which looks at
parent/child transitions and handles ProcessPerSite properly. This is
required for IsolateNothing to work correctly. Since options for
walking the frame tree outside of content are pretty limited, this uses
WebContents::ForEachFrame and (!) memoization.
- Eliminate WebContents::GetSitesInTab; move its about:blank logic into
the new frametree walking code in SiteDetails, which was the only caller.
BUG=454526,542909
TEST=browser_tests
Review URL: https://codereview.chromium.org/1406133002
Cr-Commit-Position: refs/heads/master@{#357178}
|
|
|
|
|
|
|
|
|
|
| |
This more or less reverts commit 735b8fd7da4f08e3c85cb0794d34a9a773a3fa5f.
BUG=549161
Review URL: https://codereview.chromium.org/1422773003
Cr-Commit-Position: refs/heads/master@{#357175}
|
|
|
|
|
|
|
|
|
| |
R=simonhatch
BUG=548756
Review URL: https://codereview.chromium.org/1408243009
Cr-Commit-Position: refs/heads/master@{#357160}
|
|
|
|
|
|
|
|
| |
BUG=549021
Review URL: https://codereview.chromium.org/1407333005
Cr-Commit-Position: refs/heads/master@{#357129}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
RC4 may still be re-enabled via the RC4Enabled administrative policy, until
sometime around September. Also control it via a field trial so we still have
an escape hatch should something catastrophic happen.
Keep the deprecated cipher suite fallback around (rename the parameter since I
got the naming convention wrong) since it's still got the IIS AES-GCM
workaround in it, and it will be used in not too long for DHE_RSA instead.
BUG=375342
TEST=Loading https://rc4.badssl.com/ fails with ERR_SSL_VERSION_OR_CIPHER_MISMATCH
Relaunching Chrome with --force-fieldtrials=RC4Ciphers/Enabled/ makes that page succeed.
Relaunching Chrome after setting the RC4Enabled polcy to true makes that page succeed.
(Note: press refresh when loading the site to make sure it's not cached.)
Review URL: https://codereview.chromium.org/1422293002
Cr-Commit-Position: refs/heads/master@{#357114}
|