| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
Cr-Commit-Position: refs/heads/master@{#343634}
|
|
|
|
| |
Cr-Commit-Position: refs/heads/master@{#343630}
|
|
|
|
|
|
|
|
| |
BUG=517672
Review URL: https://codereview.chromium.org/1277813006
Cr-Commit-Position: refs/heads/master@{#342259}
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=bots green
TBR=miletus@chromium.org
Review URL: https://codereview.chromium.org/1265973002
Cr-Commit-Position: refs/heads/master@{#341121}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
nacl_helper
Expected improvement from https://codereview.chromium.org/1250043002
TBR=thestig
BUG=514902
Review URL: https://codereview.chromium.org/1262033002
Cr-Commit-Position: refs/heads/master@{#340817}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Nothing looks like a major regression, just gradual size creep.
Expectations now based on the range r339374 -- r339494 (which looks
relatively flat).
Note: There is a big spike after r339494 which I don't want included in
the expectation as it may be anomalous.
BUG=512340
TBR=majidvp@chromium.org
Review URL: https://codereview.chromium.org/1248653002
Cr-Commit-Position: refs/heads/master@{#339620}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This way we can pin the number to exactly those contributed from
ffmpeg. Otherwise, make_expectations will expand the range to allow
for some larger default tolerance.
Related change:
https://crrev.com/334076
BUG=511290
TESTS=No further changes from make_expectations.py
Review URL: https://codereview.chromium.org/1242833002
Cr-Commit-Position: refs/heads/master@{#339479}
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1239163002/.
NOPRESUBMIT=True (http://crbug.com/511290)
BUG=511392
Review URL: https://codereview.chromium.org/1237763003
Cr-Commit-Position: refs/heads/master@{#339314}
|
|
|
|
|
|
|
|
|
|
|
| |
Regressed in r339239:[blink]r199094, but is only organic growth.
NOPRESUBMIT=True (because r334076 made textrel expectations non make-expectations.py but this CL is the wrong place to fix it).
BUG=511265
Review URL: https://codereview.chromium.org/1239163002
Cr-Commit-Position: refs/heads/master@{#339262}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chrome originally had 0 text relocations, but ffmpeg has always had a
few (steadily decreasing). Since static linking ffmpeg, chrome's
count has come to contain those from ffmpeg. Pinning the max/min to
match the count from ffmpeg preserves our enforcement that chrome
should have no wiggle room to contribute additional text relocations.
This is a follow up cl to the expectations update I made upon landing
ffmpeg static linking.
https://codereview.chromium.org/1161633003
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/1177233007
Cr-Commit-Position: refs/heads/master@{#334076}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This updates bss sizes for the following:
- linux-release-64/sizes/chrome-bss/bss
- linux-release/sizes/chrome-bss/bss
- mac-release/sizes/ChromiumFramework/ChromiumFramework
- xp-release/sizes/chrome_child.dll/chrome_child.dll
It also updates linux-release chrome-textrel count to take on the textrelocations that were previously part of ffmpegsumo.so.
Since the introduction of textrel expectations (https://codereview.chromium.org/9187031), ffmpegsumo has been known to have textrelocations that are not trivial to remove. The good news is, the number of relocations has been steadily falling as we roll from upstream ffmpeg.
While chrome/chrome_child have grown significantly, the net change
(now that ffmpegsumo.dll is gone) is actually a savings of a few
hundred KB due to dead code elimination in static linking.
Static linking change:
https://codereview.chromium.org/1141703002/
Bugs motivating the original static linking change:
BUG=435455, 429131, 441908
Review URL: https://codereview.chromium.org/1161633003
Cr-Commit-Position: refs/heads/master@{#333462}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This updates bss sizes for the following:
- linux-release-64/sizes/chrome-bss/bss
- linux-release/sizes/chrome-bss/bss
- mac-release/sizes/ChromiumFramework/ChromiumFramework
- xp-release/sizes/chrome_child.dll/chrome_child.dll
Change https://codereview.chromium.org/1141703002/ causes ffmpeg
to be statically linked into chrome (or chrome_child on windows).
While chrome/chrome_child have grown significantly, the net change
(now that ffmpegsumo.dll is gone) is actually a savings of a few
hundred KB due to dead code elimination in static linking.
(Bugs motivating the original static linking change)
BUG=435455, 429131, 441908
Committed: https://crrev.com/41c1b31dc7983a1dca627f9e00ee3977b75e5b6f
Cr-Commit-Position: refs/heads/master@{#332938}
Review URL: https://codereview.chromium.org/1161633003
Cr-Commit-Position: refs/heads/master@{#333436}
|
|
|
|
|
|
|
|
|
|
|
| |
Sizes regression @ http://build.chromium.org/p/chromium/builders/Mac/builds/3230
Sizes changed from 159125504 to 159129600 with r333148:r33151
BUG=497447
Review URL: https://codereview.chromium.org/1152523008
Cr-Commit-Position: refs/heads/master@{#333189}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
#1 id:1 of https://codereview.chromium.org/1161633003/)
Reason for revert:
r332994 reverted the static linking ffmpeg CL and the size expectations is now red due to "improvement".
Original issue's description:
> Update sizes expectations since static linking ffmpeg.
>
> This updates bss sizes for the following:
> - linux-release-64/sizes/chrome-bss/bss
> - linux-release/sizes/chrome-bss/bss
> - mac-release/sizes/ChromiumFramework/ChromiumFramework
> - xp-release/sizes/chrome_child.dll/chrome_child.dll
>
> Change https://codereview.chromium.org/1141703002/ causes ffmpeg
> to be statically linked into chrome (or chrome_child on windows).
>
> While chrome/chrome_child have grown significantly, the net change
> (now that ffmpegsumo.dll is gone) is actually a savings of a few
> hundred KB due to dead code elimination in static linking.
>
> (Bugs motivating the original static linking change)
> BUG=435455, 429131, 441908
>
> Committed: https://crrev.com/41c1b31dc7983a1dca627f9e00ee3977b75e5b6f
> Cr-Commit-Position: refs/heads/master@{#332938}
TBR=mkwst@chromium.org,zea@chromium.org,calamity@chromium.org,dalecurtis@chromium.org,chcunningham@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=435455, 429131, 441908
Review URL: https://codereview.chromium.org/1157993006
Cr-Commit-Position: refs/heads/master@{#333000}
|
|
|
|
|
|
|
|
| |
BUG=492505
Review URL: https://codereview.chromium.org/1153333002
Cr-Commit-Position: refs/heads/master@{#332967}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This updates bss sizes for the following:
- linux-release-64/sizes/chrome-bss/bss
- linux-release/sizes/chrome-bss/bss
- mac-release/sizes/ChromiumFramework/ChromiumFramework
- xp-release/sizes/chrome_child.dll/chrome_child.dll
Change https://codereview.chromium.org/1141703002/ causes ffmpeg
to be statically linked into chrome (or chrome_child on windows).
While chrome/chrome_child have grown significantly, the net change
(now that ffmpegsumo.dll is gone) is actually a savings of a few
hundred KB due to dead code elimination in static linking.
(Bugs motivating the original static linking change)
BUG=435455, 429131, 441908
Review URL: https://codereview.chromium.org/1161633003
Cr-Commit-Position: refs/heads/master@{#332938}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mac Chromium.app sizes expectations were last updated after the switch
to 64-bit which had a large increase (r305043 and
http://crbug.com/435576).
Later, there was a large drop for Chromium.app in r314575 due to the PDF
plugin being combined into the ChromiumFramework. The perf expectations
for ChromiumFramework were updated, but not Chromium.app.
This has meant that large jumps are unlikely to affect the Mac sizes
tree-closers, since they are absorbed into the gains from r314575.
Instead, large jumps are getting picked up late because they are triaged
from perf graphs rather than the Chrome waterfall.
Chrome has been growing about 1MB per month on average. Set the
tolerance to 1% (rather than 5%) for something likely to detect the
recent large erroneous jumps.
After this, Chromium.app will close the tree once it gets to 159,128kB.
The prior threshold was 165,929kB. Chromium.app currently reports
157,589kB
Also update ChromiumFramework. It's not out of whack, but it makes sense
for it to share a common threshold tolerance with Chromium.app.
BUG=468637
Review URL: https://codereview.chromium.org/1101133004
Cr-Commit-Position: refs/heads/master@{#327179}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Sizes step went red on build #61122, where nacl_helper is 8529744.
http://build.chromium.org/p/chromium/builders/Linux/builds/61122
The previous build #61121 nacl_helper was 8529200 bytes:
http://build.chromium.org/p/chromium/builders/Linux/builds/61121
BUG=480093
Review URL: https://codereview.chromium.org/1080393010
Cr-Commit-Position: refs/heads/master@{#326455}
|
|
|
|
|
|
|
|
|
|
| |
xp-release/sizes/mini_installer.exe/mini_installer.exe
BUG=478938
Review URL: https://codereview.chromium.org/1084123003
Cr-Commit-Position: refs/heads/master@{#325930}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
release/sizes/chrome-data/data
Update perf_expectations to increase expected value of linux-release/sizes/chrome-
text/text
BUG=478588
Review URL: https://codereview.chromium.org/1093993002
Cr-Commit-Position: refs/heads/master@{#325842}
|
|
|
|
|
|
|
|
|
|
|
|
| |
linux-release/sizes/chrome-
text/text
BUG=477957
Review URL: https://codereview.chromium.org/1090093003
Cr-Commit-Position: refs/heads/master@{#325627}
|
|
|
|
|
|
|
|
| |
BUG=467249
Review URL: https://codereview.chromium.org/1001883005
Cr-Commit-Position: refs/heads/master@{#320631}
|
|
|
|
|
|
|
|
|
|
|
| |
Chrome size dropped significantly. nacl_helper grew a tiny bit.
BUG=444089
NOTRY=true
Review URL: https://codereview.chromium.org/984643002
Cr-Commit-Position: refs/heads/master@{#319278}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's pretty clear from the sizes graph (http://goo.gl/zdhb0b) that the cl
https://codereview.chromium.org/905023005 causes an increase of 40k
of nacl_helper on Linux x64.
As per Chrome policy on which states that increases < 100k are alright.
http://dev.chromium.org/developers/tree-sheriffs/perf-sheriffs says:
"If sizes fails and the jump is <100k, update expections."
TBR=bbudge
CC=piman,llandwerlin,jam,wfh
BUG=455409
Review URL: https://codereview.chromium.org/929483006
Cr-Commit-Position: refs/heads/master@{#318018}
|
|
|
|
|
|
|
|
|
|
| |
Size bots have been failing since ~Feb 11th. The size of the incorrect binaries is being measured, this patch is a short term fix to keep the bots green while a longer term solution is arrived at.
BUG=459260
Review URL: https://codereview.chromium.org/938573004
Cr-Commit-Position: refs/heads/master@{#316827}
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome
chrome-text
chrome-data
BUG=457454
Review URL: https://codereview.chromium.org/913143004
Cr-Commit-Position: refs/heads/master@{#315905}
|
|
|
|
|
|
|
|
|
| |
BUG=456109
R=alexclarke@chromium.org
Review URL: https://codereview.chromium.org/880603005
Cr-Commit-Position: refs/heads/master@{#315030}
|
|
|
|
|
|
|
|
| |
R=primiano@chromium.org
Review URL: https://codereview.chromium.org/875403007
Cr-Commit-Position: refs/heads/master@{#315026}
|
|
|
|
|
|
|
|
|
|
| |
We should investigate why the binaries generated by gold are bigger.
BUG=396333
Review URL: https://codereview.chromium.org/869043007
Cr-Commit-Position: refs/heads/master@{#314754}
|
|
|
|
|
|
|
|
| |
BUG=453844
Review URL: https://codereview.chromium.org/896303002
Cr-Commit-Position: refs/heads/master@{#314612}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Not in gcl, which probably these days nobody working on Chromium uses.
BUG=None
R=maruel@chromium.org
TBR=maruel@chromium.org
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/887033002
Cr-Commit-Position: refs/heads/master@{#314039}
|
|
|
|
|
|
|
|
|
| |
BUG=none
TBR=teravest
Review URL: https://codereview.chromium.org/849733002
Cr-Commit-Position: refs/heads/master@{#311164}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome-text/text (0.09%)
http://build.chromium.org/p/chromium/builders/Linux%20x64/builds/75733
Graph
https://chromeperf.appspot.com/report?masters=Chromium&bots=chromium-rel-linux-64&tests=sizes%2Fchrome-text&rev=310080&checked=all
NOTRY=true
Review URL: https://codereview.chromium.org/836123004
Cr-Commit-Position: refs/heads/master@{#310082}
|
|
|
|
|
|
|
|
|
|
| |
size changes are monitored.
BUG=443796
Review URL: https://codereview.chromium.org/818783002
Cr-Commit-Position: refs/heads/master@{#309254}
|
|
|
|
|
|
|
|
|
|
|
| |
Improvements range from 0.41% to 7.5% -- the 7.5%
improvement in chrome.exe triggered a sizes failure.
BUG=443793,441988
Review URL: https://codereview.chromium.org/816853002
Cr-Commit-Position: refs/heads/master@{#309134}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Regression introduced in crrev.com/47fa83a338df4e285112337d6afe102786e29028
TBR=fmeawad@chromium.org
NOTRY=true
BUG=443130
Review URL: https://codereview.chromium.org/811043003
Cr-Commit-Position: refs/heads/master@{#308782}
|
|
|
|
|
|
|
|
|
|
|
| |
changed about 5-15% for some binaries.
BUG=435304
R=dtu@chromium.org
Review URL: https://codereview.chromium.org/744223002
Cr-Commit-Position: refs/heads/master@{#305088}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
First attempt in https://codereview.chromium.org/701853003/ does not update Linux 64bit.
The WebRtc roll in VP9 dependency https://codereview.chromium.org/703443004/.
WebRtc submit: https://code.google.com/p/webrtc/source/detail?r=7588
"linux-release/sizes/chrome-bss/bss": {"reva": 302608, "revb": 302608, "type":
"absolute", "better": "lower", "improve": 501584, "regress": 554384, "sha1": "63
34ce61"},
BUG=424235
TBR=andrewhayden@chromium.org,tommi@chromium.org
Review URL: https://codereview.chromium.org/698313002
Cr-Commit-Position: refs/heads/master@{#302628}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The WebRtc roll in VP9 dependency https://codereview.chromium.org/703443004/.
WebRtc submit: https://code.google.com/p/webrtc/source/detail?r=7588
"linux-release/sizes/chrome-bss/bss": {"reva": 302608, "revb": 302608, "type":
"absolute", "better": "lower", "improve": 501584, "regress": 554384, "sha1": "63
34ce61"},
BUG=424235
R=tommi@chromium.org
TBR=andrewhayden@chromium.org
Review URL: https://codereview.chromium.org/701853003
Cr-Commit-Position: refs/heads/master@{#302616}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Update the perf expectations for nacl_helper-data to reflect the
binary size improvements from the recent ICU work.
BUG=
TBR=maruel@chromium.org,govind@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/655683002
Cr-Commit-Position: refs/heads/master@{#299410}
|
|
|
|
|
|
|
|
|
| |
BUG=422450
TBR=govind@chromium.org
Review URL: https://codereview.chromium.org/641183007
Cr-Commit-Position: refs/heads/master@{#299167}
|
|
|
|
|
|
|
|
|
| |
BUG=421831
TBR=rtenneti@chromium.org
Review URL: https://codereview.chromium.org/645703002
Cr-Commit-Position: refs/heads/master@{#299048}
|
|
|
|
|
|
|
|
| |
TBR=erikwright
Review URL: https://codereview.chromium.org/607683002
Cr-Commit-Position: refs/heads/master@{#296926}
|
|
|
|
|
|
|
|
|
|
|
| |
linux-release-64/sizes/chrome-data/data: https://chromeperf.appspot.com/report?masters=Chromium&bots=chromium-rel-linux&tests=sizes%2Fchrome-data&checked=all&rev=295451
BUG=415523
TBR=bokan@chromium.org
Review URL: https://codereview.chromium.org/578243005
Cr-Commit-Position: refs/heads/master@{#295557}
|
|
|
|
|
|
|
|
|
|
|
|
| |
linux-release-64/sizes/chrome/chrome : https://chromeperf.appspot.com/report?masters=Chromium&bots=chromium-rel-linux&tests=sizes%2Fchrome&checked=all&rev=295451
BUG=415523
TBR=bokan@chromium.org
Review URL: https://codereview.chromium.org/583603003
Cr-Commit-Position: refs/heads/master@{#295510}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Regression are tiny:
- nacl_helper/nacl_helper (0.04%)
- nacl_helper-text/text (0.06%)
http://build.chromium.org/p/chromium/builders/Linux/builds/53437
https://chromeperf.appspot.com/report?masters=Chromium&bots=chromium-rel-linux&tests=sizes%2Fnacl_helper&rev=294990&checked=all
https://chromeperf.appspot.com/report?masters=Chromium&bots=chromium-rel-linux&tests=sizes%2Fnacl_helper-text&rev=294990&checked=all
TBR=nhiroki@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/571313002
Cr-Commit-Position: refs/heads/master@{#295017}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #1 id:1 of https://codereview.chromium.org/575603003/)
Reason for revert:
I should have updated the expectation for linux-release (not linux-release-64).
Original issue's description:
> Perf: Update size expectation for nacl_helper/nacl_helper on linux
>
> Regression is tiny (0.04%).
>
> http://build.chromium.org/p/chromium/builders/Linux/builds/53433
> https://chromeperf.appspot.com/report?masters=Chromium&bots=chromium-rel-linux%2Cchromium-rel-xp&tests=sizes%2Fnacl_helper&rev=294900&checked=all
>
> TBR=nhiroki@chromium.org
> NOTRY=true
>
> Committed: https://crrev.com/bd700c84bf9132a96e17e0ea724d1855a8d01740
> Cr-Commit-Position: refs/heads/master@{#294991}
TBR=
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/574633002
Cr-Commit-Position: refs/heads/master@{#295016}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Regression is tiny (0.04%).
http://build.chromium.org/p/chromium/builders/Linux/builds/53433
https://chromeperf.appspot.com/report?masters=Chromium&bots=chromium-rel-linux%2Cchromium-rel-xp&tests=sizes%2Fnacl_helper&rev=294900&checked=all
TBR=nhiroki@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/575603003
Cr-Commit-Position: refs/heads/master@{#294991}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Regression is tiny (0.06%).
http://build.chromium.org/p/chromium/builders/Win/builds/24362
https://chromeperf.appspot.com/report?masters=Chromiqum&bots=chromium-rel-xp&tests=sizes%2Fchrome.dll&checked=all&start_rev=294698&end_rev=294959
TBR=nhiroki@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/575713002
Cr-Commit-Position: refs/heads/master@{#294990}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A 2MB+ regression was introduced but a cause cannot be identified.
https://chromeperf.appspot.com/report?masters=Chromium&bots=chromium-rel-xp&tests=sizes%2Fmini_installer.exe&checked=mini_installer.exe&rev=294272
BUG=413191
NOTRY=true
TBR=weitaosu,engedy
Review URL: https://codereview.chromium.org/569453002
Cr-Commit-Position: refs/heads/master@{#294512}
|