| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Wrap error reports in "### (BEGIN|END) MEMORY TOOL REPORT". This will allow us
to extract them with GTestLogParser and use them as snippets.
Re-land with syntax errors fixed.
BUG=453020
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/875353003
Cr-Commit-Position: refs/heads/master@{#313707}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of https://codereview.chromium.org/884813002/)
Reason for revert:
broke tree. don't use NOTRY=true again http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/38252
Original issue's description:
> Tweak output of (memcheck|drmemory)_analyze.py.
>
> Wrap error reports in "### (BEGIN|END) MEMORY TOOL REPORT". This will allow us
> to extract them with GTestLogParser and use them as snippets.
>
> BUG=453020
> R=thestig@chromium.org
> NOTRY=true
>
> Committed: https://crrev.com/9794e18ce8653e49c1b9f6da0033276a79f88579
> Cr-Commit-Position: refs/heads/master@{#313572}
TBR=thestig@chromium.org,earthdok@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=453020
Review URL: https://codereview.chromium.org/883073006
Cr-Commit-Position: refs/heads/master@{#313594}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Wrap error reports in "### (BEGIN|END) MEMORY TOOL REPORT". This will allow us
to extract them with GTestLogParser and use them as snippets.
BUG=453020
R=thestig@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/884813002
Cr-Commit-Position: refs/heads/master@{#313572}
|
|
|
|
|
|
|
|
|
|
|
| |
support. This avoids overhead from osmesa.dll and other suppressions. Also updates the Dr. Memory suppression parsing script to understand the imprecise counts for these suppressions.
TBR=zhaoqin@chromium.org
BUG=347967,364146
Review URL: https://codereview.chromium.org/259523003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265846 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Many more tools accept --build-dir, so try to standardize at that. (Keep
--build_dir around for a while longer so that we can change the bot configs to
the new flag first.)
Most of memory tools use --under_flags, so this increases self-inconsistency a bit, but they already have some --dash-flags (e.g. --help-tests) and the remaining flags are mostly --gtest_filter and friends. Change --source_dir to
--source-dir at least to keep it similar to --build-dir. (And remove --source_dir from tsan_analyze.py, where it was unused.)
BUG=294387
R=scottmg@chromium.org
TBR=thestig
Review URL: https://codereview.chromium.org/25815003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226623 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
the output may be interleaved with the reports.
Also, add a link to the docs on suppressing Dr.Memory reports.
TBR=bruening,glider
Review URL: http://codereview.chromium.org/9017012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115322 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=bruening
Review URL: http://codereview.chromium.org/8816013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113181 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
1) Add one more python builtin to avoid printing duplicate reports
2) Enable logging up to INFO level when invoking drmemory_analyze.py manually
3) "foo.exe!bar" -> "*!bar", not "*.exe!bar"
TBR=bruening
Review URL: http://codereview.chromium.org/8772039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This way it should be processed by the gtest_command log parser
(looks like it doesn't look into stderr...)
TBR=bruening
Review URL: http://codereview.chromium.org/8770007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112464 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The output format is very close to the one used by other tools, it should be
parseable by the buildbot log parsers.
Still TODO: the generated suppressions are too long since they disregard the
-callstack_truncate_below flag, see
http://code.google.com/p/drmemory/issues/detail?id=700
TBR=bruening
Review URL: http://codereview.chromium.org/8771003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make sure that:
- shebang is only present for executable files
- shebang is #!/usr/bin/env python
- __main__ is only present for executable files
- file's executable bit is coherent
Also fix EOF LF to be only one.
TBR=timurrrr@chromium.org
BUG=105108
TEST=
Review URL: http://codereview.chromium.org/8678023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111960 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also, clean-up and slightly re-design drmemory_analyze.py to be more like
memcheck_analyze.py
Looks like more refactoring can be done later to really share the code with
Valgrind and TSan, esp. the BROWSER_WRAPPER itself.
No idea why it was a bash script initially.
TBR=bruening,glider
TEST=ran tools\valgrind\chrome_tests.bat --tool drmemory_light --keep_logs -t base --gtest_filter="*Sanity*"
and ... -t ui --gtest_filter="RedirectTest.Server:RedirectTest.Client"
with tools/valgrind/drmemory/suppressions.txt removed
Review URL: http://codereview.chromium.org/8688006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111528 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=bruening
Review URL: http://codereview.chromium.org/8633013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Long term solution is to tweak Dr. Memory to print out such errors to stderr
TBR=bruening,rnk
Review URL: http://codereview.chromium.org/8638010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111138 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
mismatches
Also fix the printed suppression count regexp so it works with leaks again
BUG=101537,101717
TBR=bruening
Review URL: http://codereview.chromium.org/8437089
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108514 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This should automatically work with http://chromium-build-logs.appspot.com/ once we move to the Memory FYI waterfall
TBR=bruening
TEST=tools\valgrind\chrome_tests.bat -t base --tool drmemory_light --gtest_filter="ToolsSanity.*"
Review URL: http://codereview.chromium.org/8277002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105318 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=bruening
Review URL: http://codereview.chromium.org/8173003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104301 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=ran printing_unittests EmfTest w/ suppressions disabled
Review URL: http://codereview.chromium.org/8002011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103928 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=bruening
TEST=remove all DrM suppressions, then `tools\valgrind\chrome_tests.bat --tool drmemory -t base --gtest_filter="ToolsSanity*"`
Review URL: http://codereview.chromium.org/7849014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also:
* improve readability and completeness of the drmemory_analyze script
* add BROWSER_WRAPPER support to the Dr. Memory runner (for ui_tests, browser_tests, etc)
TBR=bruening
BUG=http://code.google.com/p/drmemory/issues/detail?id=546
Review URL: http://codereview.chromium.org/7491093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95803 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=bruening
Review URL: http://codereview.chromium.org/7474017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94666 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=bruening
Review URL: http://codereview.chromium.org/7404001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92849 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=bruening
Review URL: http://codereview.chromium.org/6969094
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87760 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=glider
Review URL: http://codereview.chromium.org/3461030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60644 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(found a small bug)
Review URL: http://codereview.chromium.org/3326002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58181 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Fixed a few style nits found in this file noted in Alexander's comments
at http://codereview.chromium.org/2455001/show
Review URL: http://codereview.chromium.org/3047015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53635 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
reports
TBR=glider
Review URL: http://codereview.chromium.org/2869010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
add some basic suppressions
TBR=glider
Review URL: http://codereview.chromium.org/2869009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50097 0039d316-1c4b-4281-b951-d872f2087c98
|
|
TBR=glider
Review URL: http://codereview.chromium.org/2455001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48622 0039d316-1c4b-4281-b951-d872f2087c98
|