| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
BUG=44580
TBR=cbentzel,glider
Review URL: http://codereview.chromium.org/2092016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47707 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
The new version of ThreadSanitizer (rev2088) finally has support for automatically suppressing benign data races on vfptr. The harmful data races will still be reported.
BUG=23245,25385
TEST=TSan bots should remain green
Review URL: http://codereview.chromium.org/2099009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The event_ signaling should already prevent the testcase from being deleted before the test is done, so we can just post the tasks directly.
BUG=24715
TEST=tools/valgrind/chrome_tests.sh --tool=tsan -t test_shell --gtest_filter='AppCache*'
Review URL: http://codereview.chromium.org/2121005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47605 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Looks like I wasn't running test_shell for a while when I decided that the race is gone
BUG=24715
TBR=glider
Review URL: http://codereview.chromium.org/2103004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47416 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Looks like we print different stacks for dtors on Valgrind and PIN
TBR=glider
Review URL: http://codereview.chromium.org/2086006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47403 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=glider
Review URL: http://codereview.chromium.org/2067012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47402 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
synchronization primitives.
TBR=timurrrr
Review URL: http://codereview.chromium.org/2107007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47398 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=glider
Review URL: http://codereview.chromium.org/2133001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47263 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
suppress one benign race in sync
BUG=25385,44168
TBR=glider
Review URL: http://codereview.chromium.org/2065005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47262 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=glider
Review URL: http://codereview.chromium.org/1990013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46919 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=glider
TEST=TSan/Linux should remain green, tested locally
Review URL: http://codereview.chromium.org/2048008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46914 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2030001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46563 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=glider
Review URL: http://codereview.chromium.org/1968002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46447 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1746010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45665 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=glider
Review URL: http://codereview.chromium.org/1729004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45182 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=glider
Review URL: http://codereview.chromium.org/1662002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44782 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
My first chrome patch :) --
Data race on boole in chrome/browser/sync/engine/syncer.cc
Fix uses Lock class to avoid any compiler/hardware optimizations.
BUG=37408
TEST=Ran Valgrind/ThreadSanitizer
Original Patch by raz@chromium.org
http://codereview.chromium.org/1621010
Review URL: http://codereview.chromium.org/1518023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44558 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=25385
TBR=glider
Review URL: http://codereview.chromium.org/1540023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43941 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=23423
TBR=glider
Review URL: http://codereview.chromium.org/1630009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43938 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Please not that a suppression is NOT a fix for the race!
BUG=40244
TBR=glider,tim
Review URL: http://codereview.chromium.org/1585015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43505 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=25913
TBR=glider
TEST=TSan should become green (not flaky) on sync_unit_tests
Review URL: http://codereview.chromium.org/1545016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43499 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This has started showing up on TSan/Linux/unit like this:
WARNING: Possible data race during write of size 4 at 0xAEF33E0: {{{
T0 (locks held: {}):
#0 ChromeThread::~ChromeThread() chrome/browser/chrome_thread.cc:44
#1 ImageLoadingTrackerTest::~ImageLoadingTrackerTest() chrome/browser/extensions/image_loading_tracker_unittest.cc:17
#2 ImageLoadingTrackerTest_Cache_Test::~ImageLoadingTrackerTest_Cache_Test() chrome/browser/extensions/image_loading_tracker_unittest.cc:95
#3 testing::internal::TestInfoImpl::Run() testing/gtest/src/gtest.cc:2319
Concurrent read(s) happened at (OR AFTER) these points:
T462 (Chrome_IOThread) (locks held: {}):
#0 base::Thread::ThreadMain() base/thread.cc:156
#1 ThreadFunc(void*) base/platform_thread_posix.cc:26
#2 ThreadSanitizerStartThread ts_valgrind_intercepts.c:571
}}}
http://build.chromium.org/buildbot/memory/builders/Linux%20Tests%20(tsan)/builds/3340
TBR=glider
BUG=25385
Review URL: http://codereview.chromium.org/1572008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43189 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=TSan/UI should become greener
TBR=glider
Review URL: http://codereview.chromium.org/1552003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43071 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
has been annotated.
BUG=32892
Review URL: http://codereview.chromium.org/1276002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43065 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
It will work on PIN, not Valgrind, but currently I'm adding it to tools valgrind.
We plan to merge tools/valgrind with tools/heapcheck intor tools/memory or something like that - later.
BUG=28363,39456
Review URL: http://codereview.chromium.org/1356006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42758 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=timurrrr
Review URL: http://codereview.chromium.org/1333002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42606 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=glider
Review URL: http://codereview.chromium.org/1333001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42605 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1216009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42598 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Ignore the accesses within SensitiveAllocator::free.
Suppress another report in -[NSOperationQueue dealloc]
TBR=timurrrr
Review URL: http://codereview.chromium.org/1281001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
SocketStreamTest.BasicAuthProxy under ThreadSanitizer on Mac, added an
appropriate suppression for NSOperationQueue.
TBR=timurrrr
Review URL: http://codereview.chromium.org/1239003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42469 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=glider
Review URL: http://codereview.chromium.org/1271001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42449 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=glider
Review URL: http://codereview.chromium.org/1082004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42105 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1100007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=glider
Review URL: http://codereview.chromium.org/1061001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41842 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/951001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41565 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
another one
BUG=37408,37496
TBR=glider
Review URL: http://codereview.chromium.org/668182
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40779 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=37408,37496
TBR=glider
Review URL: http://codereview.chromium.org/668175
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40764 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=glider,stuartmorgan
TEST=TSan/net_unittests should become green on Linux
Review URL: http://codereview.chromium.org/660015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39929 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Please note that suppression is NOT a fix for the race.
BUG=32892
TBR=pkasting
Review URL: http://codereview.chromium.org/548131
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36959 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The accesses happened in different order in
http://build.chromium.org/buildbot/waterfall/builders/Linux%20Tests%20(tsan)/builds/1998/steps/valgrind%20test:%20unit/logs/stdio
BUG=28396
TBR=dank
Review URL: http://codereview.chromium.org/548042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=30960
Review URL: http://codereview.chromium.org/508013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35127 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tools_sanity_test.cc contains positive tests for tools used on the buildbots.
ToolsSanityTest.MemoryLeak contains an memory leak reportable by Memcheck and
heap leak checker.
ToolsSanityTest.DataRace contains a data race reportable by ThreadSanitizer.
The corresponding suppressions are in
tools/valgrind/{memcheck,tsan}/suppressions.txt
The idea is to check the tools' reports for their presence when testing
base_unittests.
Review URL: http://codereview.chromium.org/491044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34826 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
There are a few false positives inside TCMalloc and it is almost useless
to race-test it inside Chromium.
BUG=28765
TBR=dank
Review URL: http://codereview.chromium.org/500038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This has started firing on TSan bot recently:
http://build.chromium.org/buildbot/waterfall/builders/Linux%20Tests%20(tsan)/builds/1540/steps/valgrind%20test:%20unit/logs/stdio
TBR=dank
TEST=TSAN unit should become green
BUG=30582
Review URL: http://codereview.chromium.org/487022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=21468,22520,28559
Review URL: http://codereview.chromium.org/490008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34302 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
We had a suppression for this race, but it couldn't hide the race in some rare cases like
http://build.chromium.org/buildbot/waterfall/builders/Linux Tests (tsan)/builds/1213/steps/valgrind test%3A base/logs/stdio
when the order of the racing accesses was different.
Review URL: http://codereview.chromium.org/466009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33603 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/449071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33498 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
net_unittests
TBR=dank
TEST=TSAN Mac bot should become ~20% faster on net_unittests
Review URL: http://codereview.chromium.org/443020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33210 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) Added the link to the ignore files documentation
2) Fixed a typo
3) Used new "fun_r" instead of "fun" for a couple of functions to speed up some large tests from net_, unit_ and ui_.
4) Used new "fun_hist" for unibrow namespace to do coarser history tracking - bottleneck on unit_.
Please see http://code.google.com/p/data-race-test/wiki/ThreadSanitizerIgnores
for the details of new ignore rules. They are present since the new TSAN version (rev1274)
TBR=dank
TEST=TSAN bots should remain green AND become faster.
Review URL: http://codereview.chromium.org/441028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33203 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=28765
TBR=dank,willchan
TEST=TSAN bots should stop skipping all tests
Review URL: http://codereview.chromium.org/434072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33058 0039d316-1c4b-4281-b951-d872f2087c98
|