summaryrefslogtreecommitdiffstats
path: root/tools/valgrind/tsan
Commit message (Collapse)AuthorAgeFilesLines
* Ignore accesses below ChromeThread::GetCurrentThreadIdentifiertimurrrr@chromium.org2010-05-192-14/+5
| | | | | | | | BUG=44580 TBR=cbentzel,glider Review URL: http://codereview.chromium.org/2092016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47707 0039d316-1c4b-4281-b951-d872f2087c98
* Remove suppressions for a couple of benign races in base::Threadtimurrrr@chromium.org2010-05-191-32/+0
| | | | | | | | | The new version of ThreadSanitizer (rev2088) finally has support for automatically suppressing benign data races on vfptr. The harmful data races will still be reported. BUG=23245,25385 TEST=TSan bots should remain green Review URL: http://codereview.chromium.org/2099009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47664 0039d316-1c4b-4281-b951-d872f2087c98
* AppCache*Test: do not use ScopedRunnableMethodFactory from multiple threads.mattm@chromium.org2010-05-191-8/+0
| | | | | | | | | | | The event_ signaling should already prevent the testcase from being deleted before the test is done, so we can just post the tasks directly. BUG=24715 TEST=tools/valgrind/chrome_tests.sh --tool=tsan -t test_shell --gtest_filter='AppCache*' Review URL: http://codereview.chromium.org/2121005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47605 0039d316-1c4b-4281-b951-d872f2087c98
* Restore a suppression for a race in test_shell.timurrrr@chromium.org2010-05-171-0/+8
| | | | | | | | | Looks like I wasn't running test_shell for a while when I decided that the race is gone BUG=24715 TBR=glider Review URL: http://codereview.chromium.org/2103004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47416 0039d316-1c4b-4281-b951-d872f2087c98
* Generalize vptr-related suppressions to work on Windows.timurrrr@chromium.org2010-05-171-5/+5
| | | | | | | | Looks like we print different stacks for dtors on Valgrind and PIN TBR=glider Review URL: http://codereview.chromium.org/2086006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47403 0039d316-1c4b-4281-b951-d872f2087c98
* Add some more TSan ignorestimurrrr@chromium.org2010-05-172-0/+5
| | | | | | | TBR=glider Review URL: http://codereview.chromium.org/2067012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47402 0039d316-1c4b-4281-b951-d872f2087c98
* Ignore the CFDictionary operations, which are known to use unannotatedglider@chromium.org2010-05-171-2/+3
| | | | | | | | | | synchronization primitives. TBR=timurrrr Review URL: http://codereview.chromium.org/2107007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47398 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a typo in suppressionstimurrrr@chromium.org2010-05-141-1/+1
| | | | | | | TBR=glider Review URL: http://codereview.chromium.org/2133001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47263 0039d316-1c4b-4281-b951-d872f2087c98
* Update race-on-vptr suppressions (TSan now supports a better format) and ↵timurrrr@chromium.org2010-05-141-4/+10
| | | | | | | | | | suppress one benign race in sync BUG=25385,44168 TBR=glider Review URL: http://codereview.chromium.org/2065005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47262 0039d316-1c4b-4281-b951-d872f2087c98
* Add more ignore rules to TSan/Wintimurrrr@chromium.org2010-05-111-1/+13
| | | | | | | TBR=glider Review URL: http://codereview.chromium.org/1990013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46919 0039d316-1c4b-4281-b951-d872f2087c98
* Move empty_rep-specific reports from cross-platform to Mac-specific file.timurrrr@chromium.org2010-05-112-12/+15
| | | | | | | | TBR=glider TEST=TSan/Linux should remain green, tested locally Review URL: http://codereview.chromium.org/2048008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46914 0039d316-1c4b-4281-b951-d872f2087c98
* Automatically run valgrind tryjobs for CLs modifying suppression filestimurrrr@chromium.org2010-05-061-0/+11
| | | | | | Review URL: http://codereview.chromium.org/2030001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46563 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress benign races in base/time_win.cctimurrrr@chromium.org2010-05-051-0/+7
| | | | | | | TBR=glider Review URL: http://codereview.chromium.org/1968002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46447 0039d316-1c4b-4281-b951-d872f2087c98
* Remove svn:executable property from the last few files that don't need it.thestig@chromium.org2010-04-272-0/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1746010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45665 0039d316-1c4b-4281-b951-d872f2087c98
* Ignore base/thread_local_storage, not just _posix (ThreadSanitizer)timurrrr@chromium.org2010-04-211-1/+1
| | | | | | | TBR=glider Review URL: http://codereview.chromium.org/1729004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45182 0039d316-1c4b-4281-b951-d872f2087c98
* Narrow TSan ignores on Windows a little bittimurrrr@chromium.org2010-04-161-1/+1
| | | | | | | TBR=glider Review URL: http://codereview.chromium.org/1662002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44782 0039d316-1c4b-4281-b951-d872f2087c98
* Land http://codereview.chromium.org/1621010tim@chromium.org2010-04-141-14/+0
| | | | | | | | | | | | | | | | | | | My first chrome patch :) -- Data race on boole in chrome/browser/sync/engine/syncer.cc Fix uses Lock class to avoid any compiler/hardware optimizations. BUG=37408 TEST=Ran Valgrind/ThreadSanitizer Original Patch by raz@chromium.org http://codereview.chromium.org/1621010 Review URL: http://codereview.chromium.org/1518023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44558 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress yet another benign race on base::Thread vfptrtimurrrr@chromium.org2010-04-081-0/+6
| | | | | | | | BUG=25385 TBR=glider Review URL: http://codereview.chromium.org/1540023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43941 0039d316-1c4b-4281-b951-d872f2087c98
* Remove suppression for bug 23423 as it doesn't show up on the bots anymoretimurrrr@chromium.org2010-04-081-6/+0
| | | | | | | | BUG=23423 TBR=glider Review URL: http://codereview.chromium.org/1630009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43938 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress a data race in WebDataServicetimurrrr@chromium.org2010-04-021-0/+7
| | | | | | | | | | Please not that a suppression is NOT a fix for the race! BUG=40244 TBR=glider,tim Review URL: http://codereview.chromium.org/1585015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43505 0039d316-1c4b-4281-b951-d872f2087c98
* Add yet another suppression for a data race on fStop_ in libjingletimurrrr@chromium.org2010-04-021-0/+6
| | | | | | | | | BUG=25913 TBR=glider TEST=TSan should become green (not flaky) on sync_unit_tests Review URL: http://codereview.chromium.org/1545016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43499 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress reports on benign race on vfptr in ChromeThread.timurrrr@chromium.org2010-03-311-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | This has started showing up on TSan/Linux/unit like this: WARNING: Possible data race during write of size 4 at 0xAEF33E0: {{{ T0 (locks held: {}): #0 ChromeThread::~ChromeThread() chrome/browser/chrome_thread.cc:44 #1 ImageLoadingTrackerTest::~ImageLoadingTrackerTest() chrome/browser/extensions/image_loading_tracker_unittest.cc:17 #2 ImageLoadingTrackerTest_Cache_Test::~ImageLoadingTrackerTest_Cache_Test() chrome/browser/extensions/image_loading_tracker_unittest.cc:95 #3 testing::internal::TestInfoImpl::Run() testing/gtest/src/gtest.cc:2319 Concurrent read(s) happened at (OR AFTER) these points: T462 (Chrome_IOThread) (locks held: {}): #0 base::Thread::ThreadMain() base/thread.cc:156 #1 ThreadFunc(void*) base/platform_thread_posix.cc:26 #2 ThreadSanitizerStartThread ts_valgrind_intercepts.c:571 }}} http://build.chromium.org/buildbot/memory/builders/Linux%20Tests%20(tsan)/builds/3340 TBR=glider BUG=25385 Review URL: http://codereview.chromium.org/1572008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43189 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress two benign races in sqlitetimurrrr@chromium.org2010-03-301-0/+14
| | | | | | | | TEST=TSan/UI should become greener TBR=glider Review URL: http://codereview.chromium.org/1552003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43071 0039d316-1c4b-4281-b951-d872f2087c98
* Remove suppression for bug 32892 as the race tim@chromium.org2010-03-301-7/+0
| | | | | | | | | | | has been annotated. BUG=32892 Review URL: http://codereview.chromium.org/1276002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43065 0039d316-1c4b-4281-b951-d872f2087c98
* Add ignores and suppression for TSan/Windows.timurrrr@chromium.org2010-03-262-0/+47
| | | | | | | | | It will work on PIN, not Valgrind, but currently I'm adding it to tools valgrind. We plan to merge tools/valgrind with tools/heapcheck intor tools/memory or something like that - later. BUG=28363,39456 Review URL: http://codereview.chromium.org/1356006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42758 0039d316-1c4b-4281-b951-d872f2087c98
* Ignore the CFBag* stuff on Mac.glider@chromium.org2010-03-251-0/+5
| | | | | | | | TBR=timurrrr Review URL: http://codereview.chromium.org/1333002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42606 0039d316-1c4b-4281-b951-d872f2087c98
* Ignore threadLockingTest from sqllitetimurrrr@chromium.org2010-03-251-0/+3
| | | | | | | TBR=glider Review URL: http://codereview.chromium.org/1333001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42605 0039d316-1c4b-4281-b951-d872f2087c98
* Join two suppressions for -[NSObject release] by removing an odd stack frame.glider@chromium.org2010-03-251-10/+0
| | | | | | Review URL: http://codereview.chromium.org/1216009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42598 0039d316-1c4b-4281-b951-d872f2087c98
* Enable SSLClientSocketTest.* on Mac under ThreadSanitizer.glider@chromium.org2010-03-242-0/+12
| | | | | | | | | | Ignore the accesses within SensitiveAllocator::free. Suppress another report in -[NSOperationQueue dealloc] TBR=timurrrr Review URL: http://codereview.chromium.org/1281001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42472 0039d316-1c4b-4281-b951-d872f2087c98
* Enable DiskCacheTest.*, DiskCacheEntryTest.*, FlipNetworkTransactionTest.*,glider@chromium.org2010-03-241-0/+8
| | | | | | | | | | SocketStreamTest.BasicAuthProxy under ThreadSanitizer on Mac, added an appropriate suppression for NSOperationQueue. TBR=timurrrr Review URL: http://codereview.chromium.org/1239003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42469 0039d316-1c4b-4281-b951-d872f2087c98
* Don't instrument set_jmptimurrrr@chromium.org2010-03-241-0/+1
| | | | | | | TBR=glider Review URL: http://codereview.chromium.org/1271001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42449 0039d316-1c4b-4281-b951-d872f2087c98
* One more attempt to ignore "???" functions on TSan/Mac/mediatimurrrr@chromium.org2010-03-191-0/+1
| | | | | | | TBR=glider Review URL: http://codereview.chromium.org/1082004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42105 0039d316-1c4b-4281-b951-d872f2087c98
* Ignore some pthread/libSystem internalstimurrrr@chromium.org2010-03-191-0/+1
| | | | | | Review URL: http://codereview.chromium.org/1100007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42100 0039d316-1c4b-4281-b951-d872f2087c98
* Widen one ignore rule for TSantimurrrr@chromium.org2010-03-171-1/+1
| | | | | | | TBR=glider Review URL: http://codereview.chromium.org/1061001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41842 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress a ThreadSanitizer report on retaining NSBundle.glider@chromium.org2010-03-151-0/+10
| | | | | | Review URL: http://codereview.chromium.org/951001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41565 0039d316-1c4b-4281-b951-d872f2087c98
* Widen one suppression for sync_unit_tests, add a second suppression for ↵timurrrr@chromium.org2010-03-051-1/+9
| | | | | | | | | | another one BUG=37408,37496 TBR=glider Review URL: http://codereview.chromium.org/668182 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40779 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress a couple of races in sync_unit_teststimurrrr@chromium.org2010-03-051-0/+13
| | | | | | | | BUG=37408,37496 TBR=glider Review URL: http://codereview.chromium.org/668175 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40764 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress PR_EnterMonitor reports in net_unitteststimurrrr@chromium.org2010-02-241-0/+6
| | | | | | | | TBR=glider,stuartmorgan TEST=TSan/net_unittests should become green on Linux Review URL: http://codereview.chromium.org/660015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39929 0039d316-1c4b-4281-b951-d872f2087c98
* Suppressing bug 32892 to make the TSan bot green.timurrrr@chromium.org2010-01-231-0/+7
| | | | | | | | | Please note that suppression is NOT a fix for the race. BUG=32892 TBR=pkasting Review URL: http://codereview.chromium.org/548131 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36959 0039d316-1c4b-4281-b951-d872f2087c98
* One more suppression for lazy initialization in libeventtimurrrr@chromium.org2010-01-141-1/+8
| | | | | | | | | | The accesses happened in different order in http://build.chromium.org/buildbot/waterfall/builders/Linux%20Tests%20(tsan)/builds/1998/steps/valgrind%20test:%20unit/logs/stdio BUG=28396 TBR=dank Review URL: http://codereview.chromium.org/548042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36233 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress NetworkChangeNotifierMac's destructor race.willchan@chromium.org2009-12-221-0/+6
| | | | | | | | BUG=30960 Review URL: http://codereview.chromium.org/508013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35127 0039d316-1c4b-4281-b951-d872f2087c98
* Added the ToolsSanityTest test case to base_unittests.glider@chromium.org2009-12-171-0/+6
| | | | | | | | | | | | | | | | tools_sanity_test.cc contains positive tests for tools used on the buildbots. ToolsSanityTest.MemoryLeak contains an memory leak reportable by Memcheck and heap leak checker. ToolsSanityTest.DataRace contains a data race reportable by ThreadSanitizer. The corresponding suppressions are in tools/valgrind/{memcheck,tsan}/suppressions.txt The idea is to check the tools' reports for their presence when testing base_unittests. Review URL: http://codereview.chromium.org/491044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34826 0039d316-1c4b-4281-b951-d872f2087c98
* Don't instrument tcmalloc under ThreadSanitizertimurrrr@chromium.org2009-12-161-0/+3
| | | | | | | | | | | There are a few false positives inside TCMalloc and it is almost useless to race-test it inside Chromium. BUG=28765 TBR=dank Review URL: http://codereview.chromium.org/500038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34752 0039d316-1c4b-4281-b951-d872f2087c98
* Supress bug 30582timurrrr@chromium.org2009-12-161-0/+7
| | | | | | | | | | | | This has started firing on TSan bot recently: http://build.chromium.org/buildbot/waterfall/builders/Linux%20Tests%20(tsan)/builds/1540/steps/valgrind%20test:%20unit/logs/stdio TBR=dank TEST=TSAN unit should become green BUG=30582 Review URL: http://codereview.chromium.org/487022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34724 0039d316-1c4b-4281-b951-d872f2087c98
* Remove suppressions for a few fixed racestimurrrr@chromium.org2009-12-101-27/+0
| | | | | | | BUG=21468,22520,28559 Review URL: http://codereview.chromium.org/490008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34302 0039d316-1c4b-4281-b951-d872f2087c98
* Annotate a test-only data race on booleantimurrrr@chromium.org2009-12-021-8/+0
| | | | | | | | | We had a suppression for this race, but it couldn't hide the race in some rare cases like http://build.chromium.org/buildbot/waterfall/builders/Linux Tests (tsan)/builds/1213/steps/valgrind test%3A base/logs/stdio when the order of the racing accesses was different. Review URL: http://codereview.chromium.org/466009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33603 0039d316-1c4b-4281-b951-d872f2087c98
* Widen one ignore rule for ThreadSanitizertimurrrr@chromium.org2009-12-011-1/+1
| | | | | | Review URL: http://codereview.chromium.org/449071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33498 0039d316-1c4b-4281-b951-d872f2087c98
* Ignore an icu_4_2 function that generates 25% of memory accesses in ↵timurrrr@chromium.org2009-11-261-0/+3
| | | | | | | | | | net_unittests TBR=dank TEST=TSAN Mac bot should become ~20% faster on net_unittests Review URL: http://codereview.chromium.org/443020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33210 0039d316-1c4b-4281-b951-d872f2087c98
* Update ThreadSanitizer ignore filetimurrrr@chromium.org2009-11-261-7/+10
| | | | | | | | | | | | | | | 1) Added the link to the ignore files documentation 2) Fixed a typo 3) Used new "fun_r" instead of "fun" for a couple of functions to speed up some large tests from net_, unit_ and ui_. 4) Used new "fun_hist" for unibrow namespace to do coarser history tracking - bottleneck on unit_. Please see http://code.google.com/p/data-race-test/wiki/ThreadSanitizerIgnores for the details of new ignore rules. They are present since the new TSAN version (rev1274) TBR=dank TEST=TSAN bots should remain green AND become faster. Review URL: http://codereview.chromium.org/441028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33203 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ThreadSanitizer suppressionstimurrrr@chromium.org2009-11-251-9/+7
| | | | | | | | | BUG=28765 TBR=dank,willchan TEST=TSAN bots should stop skipping all tests Review URL: http://codereview.chromium.org/434072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33058 0039d316-1c4b-4281-b951-d872f2087c98