| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=16579
TEST=watch valgrind ui bots go green
Review URL: http://codereview.chromium.org/159089
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21090 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/159065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21068 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=17184,17185,17187,17188
TEST=suppresses all warnings in sh tools/valgrind/valgrind_webkit_tests.sh LayoutTests/editing/pasteboard
Review URL: http://codereview.chromium.org/159058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21061 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/159047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21043 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=17129
TEST=none
Review URL: http://codereview.chromium.org/155726
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21025 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=16625
TEST=run UtilityProcessHostTest.ExtensionUnpacker under valgrind 40 times, verify no leaks reported
Review URL: http://codereview.chromium.org/159014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20979 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=16579
TEST=run ui tests all day, verify no reported leaks :-)
Review URL: http://codereview.chromium.org/159008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20970 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=stuart
Review URL: http://codereview.chromium.org/159007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20957 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removes the valgrind suppression for this leak.
Valgrind: 1, rohitrao: 0
BUG=17002
TEST=No more leaky.
Review URL: http://codereview.chromium.org/159005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20955 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Bug 15762 happens on Linux, too, so move suppression to generic file.
Also trim unneeded end of stack.
BUG=15762
TEST=watch valgrind test_shell_tests go greener on linux (and not redder on mac)
Review URL: http://codereview.chromium.org/155658
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20954 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/155659
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20953 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=17002
TBR=rohitrao
Review URL: http://codereview.chromium.org/159004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20947 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
output file, so generate them by hand, and always print them. Lets you
copy and paste from the bot into the suppressions file rather than having
to reproduce yourself, which is handy for hard-to-reproduce warnings.
BUG=none
TEST=watch the bot. See the suppressions.
Review URL: http://codereview.chromium.org/149762
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=16093,16908
TEST=run ui tests on Jaunty with ISP with highish packet loss, verify no getaddrinfo or cssyyparse valgrind warnings
Review URL: http://codereview.chromium.org/155638
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20875 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
First reviewed at http://codereview.chromium.org/125272
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/155528
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20870 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR: dkegel
Review URL: http://codereview.chromium.org/155483
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20597 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also trim unneeded end of stack.
BUG=15762
TEST=watch valgrind test_shell_tests go greener on linux
Review URL: http://codereview.chromium.org/155465
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20592 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=16161,16583
TEST=run ui tests under valgrind over and over on ghardy, watch them fail less
Review URL: http://codereview.chromium.org/149562
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20534 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=16089,16091,16576,16577,16578,16579,16583,16584,16586
TEST=watch valgrind ui bots go greener
Review URL: http://codereview.chromium.org/155410
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=thomasvl
Review URL: http://codereview.chromium.org/149451
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
binaries and fake dSYMs.
Review URL: http://codereview.chromium.org/155305
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20305 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/155216
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20290 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
fix the whitespace problem (again?!)
BUG=10737,10737,16129,16153,16156,16161,16324,16326
TEST=watch linux ui valgrind test bot go greener
Review URL: http://codereview.chromium.org/155196
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20262 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=16209,16210
TEST=somewhat happier Mac UI valgrind bots
Review URL: http://codereview.chromium.org/155232
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20189 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The problem is scoped_ptr<ResourceRequestDetails> is used to delete an instance of ResourceRedirectDetails, however the base class's destructor is non-virtual, so ResourceRedirectDetails extra field (GURL new_url_) does not get torn down properly.
Note that the blame callstacks in the bug report appear unrelated, because std::string is doing some fancy refcounting under the hood. So as GURLs get passed around, they take over the GURL::spec's memory that got allocated earlier by the network stack.
BUG=http://crbug.com/10873
TEST=The "RedirectTest.*" ui tests when run on linux valgrind bots should show no leaks
Review URL: http://codereview.chromium.org/155204
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
suppression file format. No actual changes to the suppressions except to get rid of a name duplication.
BUG=none
TEST=Mac valgrind bots should be unchanged.
Review URL: http://codereview.chromium.org/155225
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20176 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Fewer leaks on the Mac valgrind UI test bots
Review URL: http://codereview.chromium.org/155190
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20156 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
from a web page, and always run it through valgrind once no matter
how perfect it is visually.
Review URL: http://codereview.chromium.org/149271
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20065 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=16096, 10737, 10738
TEST=watch the linux ui buildbots for valgrind warnings; this should make several go away
Review URL: http://codereview.chromium.org/155152
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20050 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=12863,16093,16102,16103,16104
Review URL: http://codereview.chromium.org/155144
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20036 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=12863,16089,16091,16092,16093,16095,16096
TEST=run tools/valgrind/chrome_tests.sh -t ui and see many fewer warnings
Review URL: http://codereview.chromium.org/149250
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20025 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
so fork() doesn't corrupt log files; lets --generate_suppressions
work even with the hacky valgrind fix that makes anything but --log-file
crash on child of fork().
Also avoid killing user desktop session if zygote dies!
BUG=none, but related to fix for http://crbug.com/15771
TEST=patch valgrind with fork workaround; sh tools/valgrind/chrome_tests.sh --generate_suppressions -t ui logs you out on linux without this.
Review URL: http://codereview.chromium.org/155130
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20024 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Times out too often under Valgrind on Mac
Tracking bug: crbug.com/15817
Review URL: http://codereview.chromium.org/150218
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19846 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=check Mac valgrind bot
BUG=15819
Review URL: http://codereview.chromium.org/149129
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19831 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=jorlow
TEST=none
BUG=15762
Review URL: http://codereview.chromium.org/151175
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19774 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=jorlow
TEST=none
BUG=15762
Review URL: http://codereview.chromium.org/150173
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
enabled the ImageOperations test.
This should be fixed eventually, but suppressing it now
to get the build green since it's not a regression.
TEST=none
BUG=Issue tracker is down
Review URL: http://codereview.chromium.org/150172
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://build.chromium.org/buildbot/waterfall/builders/Modules%20Mac%20(valgrind)/builds/1303/steps/valgrind%20test:%20unit/logs/stdio
Review URL: http://codereview.chromium.org/151107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19666 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST="make -r base_unittests; sh tools/valgrind/chrome-tests.sh -t base_unittests" on 64 bit ubuntu and verify no valgrind warnings from ld-*.so
Review URL: http://codereview.chromium.org/147254
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19497 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Make build on Linux
BUG=http://crbug.com/15454
TEST=export GYP_GENERATORS=make; rm -rf sconsbuild; gclient runhooks --force; make -r base_unittests layout_tests; sh tools/valgrind/chrome_tests.sh -t base_unittests; verify that it finds and runs base_unittests; same thing with -t layout_tests
Review URL: http://codereview.chromium.org/147209
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Already filed with Apple.
BUG=none
TEST=fewer leaks reported from the UI tests under valgrind on Mac
Review URL: http://codereview.chromium.org/146115
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19195 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
valgrind is very slow on the Mac.
BUG=none
TEST=Most/all of the UI tests should pass on the Mac when run under valgrind.
Review URL: http://codereview.chromium.org/140008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18849 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
initialization.
BUG=none
TEST=Run ui_tests under valgrind; see fewer warning that we can't fix.
Review URL: http://codereview.chromium.org/131081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18824 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/10737
Review URL: http://codereview.chromium.org/118491
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18422 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/119445
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18162 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=12640
Review URL: http://codereview.chromium.org/119354
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17950 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert DCHECKs to what they used to be - turns out a bunch of stuff in the code depended on input.empty() == true.
---
I believe the code (with your width() * bbp fix) is correct.
The UMR errors occur when the source image contain alpha. I believe the issue
comes from webkit glue image decoder, and the reason this only started
triggering valgrind errors is that the old ones were masked by the change
detailed in bug 12640
Also adds valgrind suppression for the new code.
TBR=Nick
BUG=12891,12640
TEST=none
Review URL: http://codereview.chromium.org/119271
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17811 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17803 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The UMR errors occur when the source image contain alpha. I believe the issue comes from webkit glue image decoder, and the reason this only started triggering valgrind errors is that the old ones were masked by the change detailed in bug 12640
Also adds valgrind suppression for the new code.
BUG=12891,12640
TEST=none
Review URL: http://codereview.chromium.org/118297
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17792 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
this code changes infrequently.
Re-enable zip unit tests on mac.
Review URL: http://codereview.chromium.org/118087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17369 0039d316-1c4b-4281-b951-d872f2087c98
|