| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
Also fixed indentations for the last two suppressions
TBR=dank,stuartmorgan
BUG=24715,24724
Review URL: http://codereview.chromium.org/269073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28953 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
We've introduced a mistake recently which results in hiding the first race report.
The reason was the "main thread" line which doesn't contain "{{{" and doesn't have context printed.
Please note that after submitting of this CL ThreadSanitizer bots can become red for a while.
Review URL: http://codereview.chromium.org/272026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28806 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Fixed indentations and added comments for some old suppressions.
TBR=dank,stuartmorgan
Review URL: http://codereview.chromium.org/269053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28805 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=24503
TBR=abarth
Memory errors caused by WebKit roll to r49372.
Review URL: http://codereview.chromium.org/270060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28660 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
use-after-free. Like 23018, this is happening because valgrind is slowing the worker thread shutdown enough that the backup terminate process code executes.
BUG=24346
TEST=covered by valgrind
Review URL: http://codereview.chromium.org/266036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Original code review: http://codereview.chromium.org/270040
BUG=17067
TEST=none
Review URL: http://codereview.chromium.org/264024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28586 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=24419,24307
TBR=dank
Review URL: http://codereview.chromium.org/267038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28566 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move file accesses during initialization to file thread. Also fix a rare (and harmless) memory leak. Also introduce a rare (and harmless) memory leak.
TEST=added dchecks, ran spellcheck unit tests, clicked around, changed dictionaries, added words
BUG=22984
BUG=21924
BUG=1123096
Review URL: http://codereview.chromium.org/269020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This got triggered on the linux valgrind bot:
http://build.chromium.org/buildbot/waterfall/builders/Linux%20Tests%20(valgrind)(2)/builds/527/steps/valgrind%20test%3A%20ui/logs/stdio
And for whatever reason is constructing a different signature for KillProcessTask::Run().
BUG=23018
Review URL: http://codereview.chromium.org/266033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28490 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This has not reproduced in the past 40 runs of the valgrind bots.
Chromium Mac (valgrind)
Chromium Mac UI (valgrind)(1)
Chromium Mac UI (valgrind)(2)
Chromium Mac UI (valgrind)(3)
Linux Tests (valgrind)(1)
Linux Tests (valgrind)(2)
Linux Tests (valgrind)(3)
Linux Tests (valgrind)(4)
Webkit Linux (valgrind)
Webkit_Linux_(valgrind_layout)
BUG=22702
Review URL: http://codereview.chromium.org/269026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28467 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This hasn't shown up on the buildbots during the past 40 cycles of:
Chromium Mac (valgrind)
Chromium Mac UI (valgrind)(1)
Chromium Mac UI (valgrind)(2)
Chromium Mac UI (valgrind)(3)
Linux Tests (valgrind)(1)
Linux Tests (valgrind)(2)
Linux Tests (valgrind)(3)
Linux Tests (valgrind)(4)
Webkit Linux (valgrind)
Webkit_Linux_(valgrind_layout)
BUG=22559
Review URL: http://codereview.chromium.org/264017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28466 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This has not reproduced in the past 40 runs.
BUG=22031
Review URL: http://codereview.chromium.org/270031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28450 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
as the one-time leaks are intentional.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/270028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28442 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=24345,24346
TEST=none
Review URL: http://codereview.chromium.org/269023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28436 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=18984
Review URL: http://codereview.chromium.org/269017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28381 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
but still shows up on the bots.
BUG=20814
Review URL: http://codereview.chromium.org/268009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28343 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=20778
Review URL: http://codereview.chromium.org/266008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28328 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Also don't install anything until everything is built.
Review URL: http://codereview.chromium.org/262012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
on the Mac bots.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/262013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28317 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
suppressions.
This reverts,
"Update test_expectations.txt to match a flaky test and a new crasher."
TBR=dank
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/271006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28296 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=23579
TEST=should be no more CoreAudio-related races detected
Review URL: http://codereview.chromium.org/246082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28288 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the buildbots.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/257072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28195 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=23918
TEST=none
TBR=jhawkins
Review URL: http://codereview.chromium.org/258031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28090 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=17067
TEST=valgrind unit test bot green
Review URL: http://codereview.chromium.org/251092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/243091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28009 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Currently, RSAPrivateKeyUnitTest.InitRandomTest takes too long to pass.
We ignore istrumentation of libcrypto/Security libraries
to speed up the tests that use it.
This is similar to http://codereview.chromium.org/242032
Review URL: http://codereview.chromium.org/259033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27952 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
when I ran chomium interactively under valgrind.
BUG=20653
Review URL: http://codereview.chromium.org/259024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27904 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
stack traces much more informative.
Two TSAN-specific --show-pc=yes flag was added for the helper to operate.
This patch was prepared by Alexander Potapenko (cc'ed)
Review URL: http://codereview.chromium.org/256025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
and a relevant OpenRadar bug id (rdar://7223948)
This patch was prepared by Alexander Potapenko (cc'ed)
Review URL: http://codereview.chromium.org/251058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This will speed up ThreadSanitizer by 1.5-2x on some tests.
This may result in missing data races on V8 (will address later)
Review URL: http://codereview.chromium.org/255038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27730 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
current suppressions to match either. Matches
recent change in memcheck_analyze.py.
(Only doing it in suppressions_mac.txt in case
somebody decides to move a suppression to suppressions.txt.)
Also shorten a too-long suppression that was just checked in.
Review URL: http://codereview.chromium.org/255027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27656 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
This patch was prepared by Alexander Potapenko (cc'ed)
Review URL: http://codereview.chromium.org/242080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27645 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
between mac and linux, and to avoid droning on and on and on and on.
Review URL: http://codereview.chromium.org/255026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27642 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23450
TEST=none
Review URL: http://codereview.chromium.org/257006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27640 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
The suppression-count logic is copied from memcheck_analyze.py
Review URL: http://codereview.chromium.org/246046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/256011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27623 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This suppresses a warning that fired in SessionRestoreUITest.*
16 times during a five day fishing expedition on linux at r26941.
BUG=19371
TEST=run valgrind on ui tests
Review URL: http://codereview.chromium.org/242076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27621 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23416
TEST=none
TBR=stuartmorgan
Review URL: http://codereview.chromium.org/251040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27598 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
We expand the _M_mutate rule to match both _M_mutateEjjj (Linux) and
_M_mutateEmmm (Mac) and add a rule for _M_set_length_and_sharable
This patch was prepared by Alexander Potapenko (cc'ed)
Review URL: http://codereview.chromium.org/242054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27508 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Unfortunately, we can't make it more narrow since the stacktrace in the report looks like:
#0 base::Thread::ThreadMain()
#1 ThreadFunc(void*)
#2 ThreadSanitizerStartThread
Review URL: http://codereview.chromium.org/251028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27505 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
I've missed /usr/lib32/nss/libsoftokn3 in the previous patch
( http://codereview.chromium.org/242032 )
("ldd ./sconsbuild/Debug/base_unittests" doesn't show it)
Review URL: http://codereview.chromium.org/235054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27499 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23314
TEST=none
TBR=stuartmorgan
Review URL: http://codereview.chromium.org/245040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27461 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23310,23313
TEST=none
TBR=jhawkins
Review URL: http://codereview.chromium.org/251026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27460 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=16584
TEST=none
Review URL: http://codereview.chromium.org/251021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Currently, RSAPrivateKeyUnitTest.InitRandomTest takes too long to pass.
We ignore istrumentation of NSS to speed up the tests that use it.
Review URL: http://codereview.chromium.org/242032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27366 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Darwin-specific ignore files to ThreadSanitizer.
This is necessary because ThreadSanitizer cannot handle the dSYM files
properly and the "src:*" ignore rules don't work on Mac.
The ignores_mac file contains the rules that make ThreadSanitizer
ignore the false positives reported on
base::subtle::{NoBarrier_Load, Release_Store}
This patch was prepared by Alexander Potapenko (cc'ed)
Review URL: http://codereview.chromium.org/251017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27365 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
==25902== </valgrindoutput>
==25902== FATAL: in suppressions file "/b/slave/chromium-rel-linux-valgrind-tests-1/build/src/tools/valgrind/memcheck/suppressions.txt" near line 1081:
==25902== too many callers in stack trace
==25902== exiting now.
So, i'm making the stack trace smaller.
Review URL: http://codereview.chromium.org/244020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27358 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=senorblanco@chromium.org
BUG=23197
TEST=None
Review URL: http://codereview.chromium.org/243020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27338 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23151
TEST=none
TBR=dank
Review URL: http://codereview.chromium.org/242016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27314 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=22932
TEST=none
TBR=stuartmorgan
Review URL: http://codereview.chromium.org/243015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27309 0039d316-1c4b-4281-b951-d872f2087c98
|