| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
Otherwise, 'all' fails when using Express toolchain.
R=grt@chromium.org
BUG=https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/j5xzCWuwam4
Review URL: https://codereview.chromium.org/239603002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264305 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
VS2010 no longer supported, and the 2013 toolchain code was rolled into
depot_tools. Remove this outdated script.
TBR=cpu@chromium.org
BUG=309197
Review URL: https://codereview.chromium.org/195873007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=293764
R=rpaquay@chromium.org
Review URL: https://codereview.chromium.org/176893005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253981 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
(can't go in same CL since CQ doesn't like Batch files and I still want to CQ the other change...)
NOTRY=True
BUG=276953, 346843, 127233
R=robertshield@chromium.org
Review URL: https://codereview.chromium.org/181503002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253540 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
R=grt@chromium.org
Review URL: https://codereview.chromium.org/147583004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253005 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
subprocess.call handles pathnames containing spaces better.
R=scottmg@chromium.org
BUG=343904
TEST=run toolchain.py in a user account name containing a
space, such as "John Smith".
Review URL: https://codereview.chromium.org/168233002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251701 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The line endings were introduced at r251144
BUG=none
TBR=scottmg@chromium.org, cpu@chromium.org
Review URL: https://codereview.chromium.org/168063002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251460 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A tool to print out static initializers in the format below.
These static initializers cause problems for some sneakier CRT initialization
tricks we do, and they also were measured to have an appreciable slowdown
on startup time (at least on CrOS) so generally trending towards 0 is
desirable.
The basic approach is looking for symbols that have the magic VS name
`dynamic initializer for ' which is the demangled name that's used for
global C++ initializers. The binary is processed by using the DIA SDK
(some of the code is from the Dia2Dump sample), which means that the
target binary requires being built with symbols for this tool to work.
The intention is that a run of this tool will be hooked into the 'sizes'
step on clobber builders on the waterfall, similar to Linux and Mac.
===
Static initializers in a.exe:
d:\src\cr2\src\tools\win\static-initializers\a.obj: `dynamic initializer for 'std::_Error_objects<int>::_Generic_object''
d:\src\cr2\src\tools\win\static-initializers\a.obj: `dynamic initializer for 'std::_Error_objects<int>::_Iostream_object''
d:\src\cr2\src\tools\win\static-initializers\a.obj: `dynamic initializer for 'std::_Error_objects<int>::_System_object''
d:\src\cr2\src\tools\win\static-initializers\a.obj: `dynamic initializer for 'std::num_put<char,std::back_insert_iterator<std::basic_string<char,std::char_traits<char>,std::allocator<char> > > >::id''
...
===
See https://code.google.com/p/chromium/issues/detail?id=341941#c7 for logs of those found in Chromium.
R=cpu@chromium.org
BUG=341941
Review URL: https://codereview.chromium.org/66613003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This functionality for 2013 now lives in depot_tools.
TBR=maruel@chromium.org
BUG=323300
Review URL: https://codereview.chromium.org/150003008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249029 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=316496
R=gab@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/138333002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When cached timestamps are available, and toolchain is up-to-date,
reduces the runtime to ~.2s.
R=maruel@chromium.org
TBR=cpu@chromium.org
BUG=323300
Review URL: https://codereview.chromium.org/95983002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238217 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Updates third_party/win_toolchain to pull down a toolchain
based on SHA1. The intention is that this will be a DEPS hook
once it's ready for more broad usage and the rest of
infrastructure is ready.
R=maruel@chromium.org
TBR=cpu@chromium.org
BUG=323300
Review URL: https://codereview.chromium.org/70493006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Was causing some problems with $(VCInstallDir) in gyp files, just put
it in the root of the toolchain, the same as the 2010 script.
R=cpu@chromium.org
TBR=cpu@chromium.org
BUG=309197
Review URL: https://codereview.chromium.org/69383003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234417 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
d:\src>python cr\src\tools\win\toolchain\toolchain2013.py
...
d:\src>d:\src\win_toolchain_2013\env
...
d:\src>cd cr\src
d:\src\cr\src>gclient runhooks
...
d:\src\cr\src>ninja -C out\Debug chrome
Can also pass --express to toolchain2013.py for Express toolchain.
BUG=309197
R=zturner@chromium.org
Review URL: https://codereview.chromium.org/66263002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234244 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Added executable icon to list view rows.
* Use the actual module executable name instead of argv[0] (fixes issue
when running not through the shortcut)
* Fixes some button anchoring behavior.
* Moved the command to the Debug menu instead of Tools menu.
BUG=305760
Review URL: https://codereview.chromium.org/27183010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229941 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For C# projects, if a ProjectType GUID is not available, the vague error
"The project type is not supported by this installation" is given.
In this case the issue is usually that the Visual Studio SDK is not
installed.
R=zturner@chromium.org
Review URL: https://codereview.chromium.org/26460003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227550 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
For more context
BUG=none
TEST=none
Review URL: https://codereview.chromium.org/24051004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224165 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=0
notry=TRUE
Review URL: https://chromiumcodereview.appspot.com/23526064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Breaks license check.
> Initial submit of ChromeDebug extension.
>
> This is a re-upload of a previous patch due to some cs files
> breaking git's copy/rename detection, so a new issue had to be
> created and uploaded with --no-find-copies.
>
> New to this upload is the addition of a LICENSE file (which
> is displayed when you try to install the extension), as well
> as copyright headers in source files.
>
> BUG=0
>
> Review URL: https://chromiumcodereview.appspot.com/23480085
TBR=zturner@chromium.org
Review URL: https://codereview.chromium.org/23537062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223797 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a re-upload of a previous patch due to some cs files
breaking git's copy/rename detection, so a new issue had to be
created and uploaded with --no-find-copies.
New to this upload is the addition of a LICENSE file (which
is displayed when you try to install the extension), as well
as copyright headers in source files.
BUG=0
Review URL: https://chromiumcodereview.appspot.com/23480085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223758 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
NOTRY=True
BUG=*.pdb would catch things like browser_tests.exe.pdb which are HUGE and unnecessary.
TEST= Only copies desired binaries and pdbs.
R=grt@chromium.org
Review URL: https://codereview.chromium.org/23863005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222627 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome.dll (and optionally chrome_child.dll) must already be built
and must be built with symbols. Script does not take any arguments:
python tools\win\sizeviewer\sizeviewer.py
And generates html files parallel to the DLLs.
R=jamesr@chromium.org
BUG=237249
Review URL: https://codereview.chromium.org/21164002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@214231 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Pulls Update 3 (instead of 2) for VS2012. Uses the now available .iso
rather than the .exe downloader that was the only option previously (much
faster and download doesn't require elevation).
R=jschuh@chromium.org
TEST=win7 x64 vm, rollback, run, build chrome.
Review URL: https://codereview.chromium.org/18542003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209818 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Run as "python tools\win\split_link\graph_dependencies.py output.html"
Outputs a standalone html file so it can go on simple bot storage (coming
at some point).
R=jamesr@chromium.org
BUG=237249
Review URL: https://codereview.chromium.org/16196002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202896 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
After ninja runs our (fake) linker it tries to merge a
manifest that it expected the linker to generate. We are
generating two of these for the dlls, but in different
locations. To make existing ninja rules happy, copy the
first one to the location it's expecting.
TBR=cpu@chromium.org
Review URL: https://codereview.chromium.org/15781003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201635 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=cpu@chromium.org
BUG=none
Review URL: https://codereview.chromium.org/15571002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201339 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Requires https://codereview.chromium.org/15310002/ before landing.
TBR=brettw@chromium.org
R=cpu@chromium.org
BUG=237249
Review URL: https://chromiumcodereview.appspot.com/15300017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201264 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Generates proper .def files that include "DATA" so that non-functions are
correctly exported.
However, for split_link because the "other" side won't import them properly
(__declspec(dllimport) is required) split_link notes them, and errors out.
This also adds support for linking individual objs out of libs so that some
_constants.cc and _switches.cc files can easily be linked into both DLLs.
R=cpu@chromium.org
BUG=237249
Review URL: https://codereview.chromium.org/15310002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201119 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove from passed in linker command line, and generate our own.
NOTRY=true
R=cpu@chromium.org
BUG=237249
Review URL: https://chromiumcodereview.appspot.com/14952011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200267 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(Requires re-running tools\win\split_link\install_split_link.py)
R=cpu@chromium.org
BUG=237249
Review URL: https://codereview.chromium.org/14850021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200265 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It needed the bytes_read in the ReadFile param.
NOTRY=true
R=scottmg
BUG=237249
TEST=link.exe no longer crashes
Review URL: https://chromiumcodereview.appspot.com/15180002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200098 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(otherwise, presubmit whines about copyright now matching because it
contains \r)
I'm not 100% sure this will fix the problem because something will
do line ending changes, but... we will see.
TBR=cpu@chromium.org
BUG=none
Review URL: https://codereview.chromium.org/14655021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200079 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
First pass at split linker. Splits inputs based on json spec, uses .def files
to export symbols in the other half, relinks to generate an import lib, and
finally links again for the real link, using the generated def file and import
lib. And then, repeats those steps until success (not all unresolved externals
are reported by the linker on the first pass). It's necessary to use the
linker to report externals rather than cracking lib/objs because when doing
LTCG, the object files are in an undocumented compiler-internal format and the
exports can't be gathered (and probably aren't fully determined yet).
Currently this approach only handles chrome.dll, not other large targets that
are monolithic exes (rather than mostly in a DLL with an EXE loader).
Integrated with build system by a linker shim. Original link.exe is saved, and
replaced by split_link binary. If "/splitlink" is found on the command line,
then run our script that does the iterations/exporting magic. Otherwise,
fallback to the original linker.
When GYP_DEFINES includes chrome_split_dll=1, the split linker is invoked.
chrome.exe has not yet been modified to know how to load split binaries, so
the build flag will not yet be directly useful for those not working on this
problem.
Release, non-LTCG, non-split:
05/09/2013 04:57 PM 57,447,936 chrome.dll
Release, non-LTCG, split:
05/10/2013 12:47 PM 39,567,872 chrome0.dll
05/10/2013 12:48 PM 19,274,240 chrome1.dll
Release, partial-LTCG (same as current settings), split:
05/10/2013 03:56 PM 25,934,336 chrome0.dll
05/10/2013 04:13 PM 16,347,648 chrome1.dll
It should be possible to get higher optimization levels for chrome1.dll (or
perhaps both parts), but that can happen in subsequent changes after more
testing.
TBR=cpu@chromium.org, maruel@chromium.org
BUG=237249
Review URL: https://codereview.chromium.org/15067010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200049 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Handle command line flags properly.
Remove hard coded paths.
Fix issue with 8dot3 paths.
BUG=
Review URL: https://chromiumcodereview.appspot.com/14353003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195457 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Adds --vsversion=2012 option to install x86/x64 toolchain.
BUG=
TEST=on clean vmware win7 x64, and many rollbacks to 'fresh install' snapshot
Review URL: https://chromiumcodereview.appspot.com/12995005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously we pulled the update, then the old version, then the update's binaries. This was to get the new compiler binaries, but the old headers.
But, in x64 it turns out we actually need the new headers. So, now, pull the base version, then update in expected order, and patch the headers to work.
This matches the recently updated instructions on https://sites.google.com/a/chromium.org/dev/developers/how-tos/build-instructions-windows now, in creating a stub ammintrin.h.
Initial commit in http://src.chromium.org/viewvc/chrome?view=rev&revision=175004
BUG=169531
R=cpu@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11870002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176554 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The server sometimes seems to timeout, so we need to retry, rather than RunOrDie.
R=cpu@chromium.org
Review URL: https://codereview.chromium.org/11734026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175046 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=cpu@chromium.org
Review URL: https://codereview.chromium.org/11759014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175023 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Attempting to make it easier and more reliable to set up a windows build toolchain. No need to acquire/install IDEs, service packs, patch things, etc. This tool downloads and unpacks sdks and compiler from various freely available sources.
On a clean machine, after getting depot_tools, and running "gclient" (which installs python), and "git clone ..." or "svn co ..." to get the main chromium repo:
c:\chrome>python src\tools\win\toolchain\toolchain.py
...wait 2-10 minutes depending on download speed...
c:\chrome>win_toolchain\env.bat
c:\chrome>cd src
c:\chrome\src>gclient sync
c:\chrome\src>ninja -C out\Debug chrome
This script does not run any "installation" steps, it only extracts tools, and so avoids changing any global machine state. This way, it (intends to) avoid mucking up other compiler installations, and being mucked up by them.
Requires gyp patch at https://codereview.chromium.org/11637025 to avoid needing to add fake registry keys.
BUG=windows compilers is hard, let's go shopping
TEST=on clean vmware win7 x64, and many rollbacks to 'fresh install' snapshot. http://crbug.com/166949 is in progress for a bot that does this.
Review URL: https://codereview.chromium.org/11633012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175004 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
(notry for line endings)
BUG=NONE
TEST=NONE
NOTRY=true
Review URL: https://codereview.chromium.org/11412038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
builds.
Note that setup is already configured to use chrome.7z directly if chrome.packed.7z is absent.
Change setup to have it copy chrome.7z to the <version>\Installer folder (instead of moving it) for component builds (to allow developers to test installs more than once with the same archive).
BUG=None
TEST=Install/uninstall chrome after copying setup.exe to another machine using tools\win\copy-installer.bat
Test non-component build and make sure archive is still moved (i.e.not copied).
Review URL: https://chromiumcodereview.appspot.com/10825342
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152124 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
No longer required with 2010 builds, and not required (and doesn't-work-with)
ninja on 2008.
Deleted references to supalink here:
http://code.google.com/p/chromium/wiki/WindowsIncrementalLinking
R=thakis@chromium.orgo
BUG=140611
Review URL: https://chromiumcodereview.appspot.com/10832161
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150151 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=lambroslambrou
BUG=
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/10834163
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149927 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also:
- speed up re-copies the XP/xcopy case by skipping old files
- clean up output for re-copies in the robocopy case by ignoring "extra" files
NOTRY=true
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10837096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149912 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
occurances of link.exe and lib.exe can run concurrently.
Python builder emits link_limiter.exe and lib_limiter.exe.
Skeleton copied from supalink.
Seems to behave as expected. Tested with max-concurrency=1 on my
local machine.
Run python script with the argument 'clean' to... well... clean up.
R=cmp,nsylvain
BUG=
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/10826067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149911 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149487 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
for testing.
NOTRY=true
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10831087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
See http://code.google.com/p/chromium/source/search?q=back_inserter+-%23include%5C+%5C%3Citerator%5C%3E&origq=back_inserter+-%23include%5C+%5C%3Citerator%5C%3E&btnG=Search+Trunk
BUG= none
TEST= none
Review URL: http://codereview.chromium.org/9958156
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130893 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Annoyingly, _winreg doesn't exist in Cygwin Python. cygwinreg is a
third party compatible alternative, though. Installing it and making
these changes was the quickest way to get supalink working for me.
R=scottmg@chromium.org
BUG=
TEST=ran both scripts, supalink works for me
Review URL: http://codereview.chromium.org/9463015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123546 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make sure that:
- shebang is only present for executable files
- shebang is #!/usr/bin/env python
- __main__ is only present for executable files
- file's executable bit is coherent
Also fix EOF LF to be only one.
TBR=timurrrr@chromium.org
BUG=105108
TEST=
Review URL: http://codereview.chromium.org/8678023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111960 0039d316-1c4b-4281-b951-d872f2087c98
|