| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of the right alt key.
BUG=chromium-os:15469
TEST=Manual
Review URL: http://codereview.chromium.org/7043002
TBR=zork@chromium.org
Review URL: http://codereview.chromium.org/7108030
git-svn-id: svn://svn.chromium.org/chrome/branches/742/src@88455 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
background-image, but not background).
BUG=81071
TEST=icon at top of bookmark manager appears
Review URL: http://codereview.chromium.org/6889017
TBR=mihaip@chromium.org
Review URL: http://codereview.chromium.org/6912015
git-svn-id: svn://svn.chromium.org/chrome/branches/742/src@83829 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
so that it blends in with non-white NTP backgrounds. Since the
current markup doesn't handle alpha channels well (the different
sections overlap), redo it to use border-image.
Also makes the button not wrap for longer label names.
BUG=80233,80810
TEST=tried with non-default themes
R=arv@chromium.org
Review URL: http://codereview.chromium.org/6905089
TBR=mihaip@chromium.org
Review URL: http://codereview.chromium.org/6903176
git-svn-id: svn://svn.chromium.org/chrome/branches/742/src@83732 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DirectoryChangeListener interface.
All the changes_channel functionality has been replaced with calls to a new DirectoryChangeListener interface. This allows the passing of the models with changes directly to HandleTransactionCompleteEvent, instead of buffering in the SyncInternal object, which is what lead to the race conditions and possible crashes.
sync/util/channel.h is now finally redundant and has been removed.
BUG=80465
TEST=sync_unit_tests
Review URL: http://codereview.chromium.org/6903027
TBR=zea@chromium.org
Review URL: http://codereview.chromium.org/6880328
git-svn-id: svn://svn.chromium.org/chrome/branches/742/src@83573 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
actually read that field; need to use the glib accessor.)BUG=80282,20587TEST=valgrind goes green.Review URL: http://codereview.chromium.org/6896028
TBR=erg@google.com
Review URL: http://codereview.chromium.org/6880178
git-svn-id: svn://svn.chromium.org/chrome/branches/742/src@82901 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
patch.(Can't actually read that field; need to use the glib accessor.)BUG=80282,20587TEST=valgrind goes green.Review URL: http://codereview.chromium.org/6896028TBR=erg@google.comReview URL: http://codereview.chromium.org/6902005
TBR=erg@google.com
Review URL: http://codereview.chromium.org/6903002
git-svn-id: svn://svn.chromium.org/chrome/branches/742/src@82900 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
actually read that field; need to use the glib accessor.)BUG=80282,20587TEST=valgrind goes green.Review URL: http://codereview.chromium.org/6896028
TBR=erg@google.com
Review URL: http://codereview.chromium.org/6902005
git-svn-id: svn://svn.chromium.org/chrome/branches/742/src@82898 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
have caused a perf regression. To verify I'm reverting the following chnages: commit 3a360c6b3d2fc174cb7597d6365cfc5418d1442b r82326 Disable loading high res icons on Mac commit 3c39226937a39d0042b8a794f13505c7a25ca58b r82247 Fix reload button unit test commit f87ab117fc159566868e71e4df5672852bebd718 r82245 Unregister toolbar view from window notifications commit 0b287ba4a4ad5c19d901f973eb9af594dcf3dba1 r82239 Fix failing Mac unit tests commit 8b681c46a139d12151323952c58122f6805d7597 r82236 Mac: Remove custom drawn buttons commit 6ae8a2fe40485731b86267e362936db16b4c0706 r82209 Fix clang build break commit e8a19d1e0c76f204c834318566e4206320583449 r82185 Add support for multi resolution iconsBUG=NoneTEST=ComplingReview URL: http://codereview.chromium.org/6878077
TBR=sail@chromium.org
Review URL: http://codereview.chromium.org/6881114
git-svn-id: svn://svn.chromium.org/chrome/branches/742/src@82542 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
chromeos_login functionscros.git has been updated to no longer pull in some deprecated code.Roll DEPS to pull in the new cros.
BUG=None
TEST=build, unit_tests
TBR=cmasone@chromium.org
Review URL: http://codereview.chromium.org/6877106
git-svn-id: svn://svn.chromium.org/chrome/branches/742/src@82408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
setupSuppresses leak in webkit_fileapi_file_system_url_request_job_unittest.cc, introduced in r82266.Generalizes the suppressions to include Mac.BUG=80002TEST=Mac memory bots go green.TBR=zelidrag@chromium.orgReview URL: http://codereview.chromium.org/6883090
TBR=dhollowa@chromium.org
Review URL: http://codereview.chromium.org/6879094
git-svn-id: svn://svn.chromium.org/chrome/branches/742/src@82381 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
setupSuppresses leak in webkit_fileapi_file_system_url_request_job_unittest.cc, introduced in r82266.BUG=80002TEST=Linux and ChromeOS memory bots go green.TBR=zelidrag@chromium.orgReview URL: http://codereview.chromium.org/6873111
TBR=dhollowa@chromium.org
Review URL: http://codereview.chromium.org/6882103
git-svn-id: svn://svn.chromium.org/chrome/branches/742/src@82379 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Widening suppression of leak in GtkNativeViewManager::GetPermanentXIDForIdEPmi, introduced in r82165.
BUG=79966
TEST=Linux Valgrind bots go green.
TBR=backer@chromium.org
Review URL: http://codereview.chromium.org/6877069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Suppresses leak in gdk_event_dispatch, introduced in r82165.
BUG=79966
TEST=Linux Valgrind bots go green.
TBR=backer@chromium.org
Review URL: http://codereview.chromium.org/6883079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82225 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Suppresses leak in GtkNativeViewManager::GetPermanentXIDForIdEPmi, introduced in r82165.
BUG=79966
TEST=Linux Valgrind bots go green.
TBR=backer@chromium.org
Review URL: http://codereview.chromium.org/6877067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
signal
Adds a number of tests to the Mac Valgrind disabled list. An attempt to stem the redness while this apparent memory smash gets sorted out.
BUG=51716
TEST=Mac Valgrind bots go green.
TBR=glider@chromium.org
Review URL: http://codereview.chromium.org/6879069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To support HiDPI we need a way to load two copies of icons, a low resolution version and a high resolution version.
To support this, this change does the following:
- split theme_resource.grd into three files:
- theme_resources.grd: icons that only have one resolution
- theme_resources_standard.grd: low resolution icons
- theme_resources_large.grd: high resolution icons
- theme_resource.grd and theme_resources_standard.grd and compiled into chrome.pak/chrome.rc for all platforms.
- theme_resources_large.grd is compiled into theme_resources_large.pak for platforms that want high resolution icons (currently only Mac)
- gfx::Image now support icons with multiple resolution
Currently not all ThemeService APIs return multi-resolution images. Once this is checked in I'll work on converting them as I go.
Note, this change will have to be coordinated with the change to reorganize theme resources. I'll work with saintlou on that.
BUG=75812
TEST=Added a TIFF to theme_resources.grd. Verified that the toolbar icon had a mutliresolution image. Verified that unit tests passed.
Review URL: http://codereview.chromium.org/6849030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82185 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Suppresses leak within SSLConfigService::AddObserver.
BUG=79933
TEST=MalwareDetailsTest.HTTPCache
TBR=timurrrr@chromium.org
Review URL: http://codereview.chromium.org/6873092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82169 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Suppresses leaks in MalwareDetailsTest.HTTPCache and MalwareDetailsTest.HTTPCacheNoEntries.
BUG=79865
TEST=MalwareDetailsTest.HTTPCache:MalwareDetailsTest.HTTPCacheNoEntries go green.
TBR=panayiotis@google.com
Review URL: http://codereview.chromium.org/6873071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82103 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Hope I've got the idea right.
Review URL: http://codereview.chromium.org/6877033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82094 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
libcros CL:
http://git.chromium.org/gitweb/?p=cros.git;a=commit;h=4d7c3bf779fceacb90f0a1945573384735a681bf
BUG=chromium-os:12013
TEST=Make sure Chrome compiles
TBR=ers@chromium.org
Review URL: http://codereview.chromium.org/6883041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82090 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Widens suppression for SyncerThread::HandleConsecutiveContinuationError.
This leak appears to have resurfaced with revision r82026. Certainly within the range 81997:82033.
BUG=79568
TEST=Linux Valgrind bot goes green.
TBR=lipalani@chromium.org
Review URL: http://codereview.chromium.org/6877030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82066 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=evan
Review URL: http://codereview.chromium.org/6882028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82064 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Expands suppression for SessionService leak.
BUG=71152
TEST=Green ChromeOS Valgrind bot.
TBR=davemoore@chromium.org
Review URL: http://codereview.chromium.org/6881038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82059 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Disables WorkerFileSystemTest.SyncOperations, WorkerFileSystemTest.FileWriterSyncWriteOverlapped, WorkerFileSystemTest.AsyncOperations on Valgrind Mac.
BUG=79831
TEST=WorkerFileSystemTest.SyncOperations, WorkerFileSystemTest.FileWriterSyncWriteOverlapped, WorkerFileSystemTest.AsyncOperations
TBR=adamk@chromium.org
Review URL: http://codereview.chromium.org/6881034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82049 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Disables DomStorageEmptyDatabaseTest.EmptyDirAfterGet and DomStorageEmptyDatabaseTest.EmptyDirAfterClear on Valgrind Mac.
BUG=79827, 58146
TEST=DomStorageEmptyDatabaseTest.EmptyDirAfterGet and DomStorageEmptyDatabaseTest.EmptyDirAfterClear
TBR=glider@chromium.org
Review URL: http://codereview.chromium.org/6880023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82045 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Disable ResourceDispatcherTest.CrossSiteNavigationNonBuffered and CrossSiteNoUnloadOn204 on Mac Valgrind
BUG=75249
TEST=ResourceDispatcherTest.CrossSiteNavigationNonBuffered, ResourceDispatcherTest.CrossSiteNoUnloadOn204
TBR=jochen@chromium.org
Review URL: http://codereview.chromium.org/6881028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- linux-release-hardy/intl1/times/t (improvement between 81365:81390)
- linux-release-hardy/morejs/times/t (fixing false positives)
- xp-release-dual-core/moz/total_op_b/IO_op_b (regression from ~r81801)
- xp-release-dual-core/moz/total_op_r/IO_op_r (regression from ~r81801)
TEST=perf steps are green
TBR=nsylvain@chromium.org
Review URL: http://codereview.chromium.org/6883030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82032 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=47228, 79803
TEST=RepostFormWarningTest.TestLoginAfterRepost
TBR=baurb@chromium.org
Review URL: http://codereview.chromium.org/6879018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82012 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
resolved.
This is meant to be used mostly to measure how much IWYU saves on some files, so that we can brag about it.
Based on an almost identical script by jyrki@google.com (Jyrki Alakuijala)
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6873034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82006 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This might be an expected leak from UMA histograms, but the stack trace doesn't quite look like it. Needs investigation.
BUG=79794
TEST=none
Review URL: http://codereview.chromium.org/6877018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82005 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=79784
TEST=PPAPITest.Transport
TBR=timurrrr@chromium.org
Review URL: http://codereview.chromium.org/6881022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81997 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=79651
TEST=InvalidationNotifierTest_Basic_Test
TBR=sanjeevr@chromium.org
Review URL: http://codereview.chromium.org/6878024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81989 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6878018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81964 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6851020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=35879
TEST=linux perf lowmem steps are green
TBR=nsylvain@chromium.org
Review URL: http://codereview.chromium.org/6874034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This should make CrOS/Lucid/Valgrind bot green(er)
BUG=79671
TBR=glider
Review URL: http://codereview.chromium.org/6875023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81882 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Lucid/UI run
BUG=46643
TBR=glider
Review URL: http://codereview.chromium.org/6864037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81879 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=79656
TBR=zelidrag
TEST=Memory waterfall stays mostly green
Review URL: http://codereview.chromium.org/6870027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81876 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
tests
TEST=Memery waterfall switches its color.
BUG=57799, 73722, 78528, 78786, 79357, 79651, 79652, 79654, 79655, 79656, 79657, 81873
TBR=glider
Review URL: http://codereview.chromium.org/6873032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81875 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6864015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81758 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- use the options to get the root, don't assume the layout of sys.argv.
- if no root was set, use __file__ instead of assuming sys.argv[0] will be a full path.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6871014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=79533
TBR=rsleevi
Review URL: http://codereview.chromium.org/6865015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=73299
TBR=glider
Review URL: http://codereview.chromium.org/6869014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81747 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=79533,79570
Review URL: http://codereview.chromium.org/6869010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=73722, 79357, 79570
TBR=glider
Review URL: http://codereview.chromium.org/6873007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81734 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=79568,79569
TBR=glider
TEST=Memory waterfall goes greener
Review URL: http://codereview.chromium.org/6875004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81731 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
the OS settings on OS X.
R=agl
BUG=78523, 79533
TEST=See bug for test case
Review URL: http://codereview.chromium.org/6824069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81702 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
We're adding support for Content-Security-Policy (CSP) support to WebKit, which helps prevent XSS by letting sites whitelist where they can load scripts from. This patch adds a CSP policy to the bookmark manager that only allows script loads from extensions and from "chrome" URLs.
Adding the policy required only a tiny change the bookmark manager (moving the main script block to be external), but required changing some of the infrastructure for packing component extensions (to avoid inlining external scripts). CSP forbids inline script (and inline event handlers) because it can't tell whether those scripts are a result of XSS.
Review URL: http://codereview.chromium.org/6831008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81658 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=77990
TEST=none
TBR=wtc@chromium.org
Review URL: http://codereview.chromium.org/6849033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81624 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=51988
TEST=none
Review URL: http://codereview.chromium.org/6849032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81622 0039d316-1c4b-4281-b951-d872f2087c98
|