| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
GRIT is not thread safe, we shouldn't be running multiple copies at one time. This is causing the header files to have duplicates when it shouldn't.
I also removed some code in build.py which tried to prevent an identical regenerated header file from being used (so stuff doesn't rebuild unnecessarily). This code isn't necessary for our build since VS/xcode/scons handles the dependency for us (i.e., this isn't a blanket prebuild step).
Review URL: http://codereview.chromium.org/21191
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9488 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I removed the flatten_html visual studio rule and just rolled the
functionality directly into GRIT.
The sln change is to have browser depend on browser_resources (now needed for browser_resources.h).
Review URL: http://codereview.chromium.org/21148
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9418 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
that had a filename match of blocksort.c stopped working. To get it to work I had to change it to *\blocksort.c.
TBR=none
Review URL: http://codereview.chromium.org/20167
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9377 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
together (kind of like the windows RES builder).
I also moved the GRIT builder into the chromium site_scons since we
import it in lots of places. This seems cleaner.
Review URL: http://codereview.chromium.org/21115
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9331 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
the output data is written to.
Also, add a --buildbot flag which will default the report_dir to a specific directory on chrome-web.
Review URL: http://codereview.chromium.org/20097
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9286 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=evan
Review URL: http://codereview.chromium.org/21108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9275 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Cause the builder to have nicer output by removing a stray
print in rc_header.py and adding a custom print function to
the build action.
- Fix the source scanner by hooking it up directly to the Builder,
scanning for include dependencies and adding dependencies on
the grit python source.
Review URL: http://codereview.chromium.org/21102
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9271 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
default command and printing hints about likely next commands.
Review URL: http://codereview.chromium.org/20080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9230 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
tests that were previously disabled as well as dealing with a few occasional hangs and crashes.
Review URL: http://codereview.chromium.org/23006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
directory parent rules. Using copy.copy() solves the problem.Additional fix when "allow-current-directory" rules was not applied if DEPS file is missing.
Updated few DEPS file with reasonable rules.
To prevent tree closing other dependencies are added. These need to be either legitimated or dependency removed.
Review URL: http://codereview.chromium.org/21025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9221 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
instead of a wstring. Convert the linux data pack files to
pack message strings as utf16 instead of utf8.
Review URL: http://codereview.chromium.org/20060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9193 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
we can override the via custom_vars in .gclient on the bots
and official builds updates the merge script appropriately.
Also updates checkdeps to be Var-aware.
Review URL: http://codereview.chromium.org/19508
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9098 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the next modification.
Review URL: http://codereview.chromium.org/18719
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8645 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This adds <message> node to the types of GRIT nodes that we can stuff
into a data package file and removes a test shell hack.
Review URL: http://codereview.chromium.org/18478
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8431 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
we don't actually want to run this code on windows.
TBR=evanm
Review URL: http://codereview.chromium.org/18171
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
data is generated and included in the .pak file, we need to add
a dependency in the SCons build. Making the corresponding
changes to mac/win is harder, so punting for now.
Review URL: http://codereview.chromium.org/18127
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8220 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8160 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18295
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8152 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
webkit_resources.grd.
This only adds support for <include> nodes. <message> nodes are forthcoming.
The design doc describing the format is here:
http://dev.chromium.org/developers/design-documents/linuxresourcesandlocalizedstrings
I hooked into the <release> tag because we need to generate an index at the beginning of the file. The index contains the position of all the resources, so we walk the file at that point.
This currently only handles <include> tags, but will be extended to handle <message> as well.
Review URL: http://codereview.chromium.org/18215
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8147 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18293
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8137 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18292
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8133 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
allow tests that use inline calls to Sleep() to not delay too
long when running under Purify.
Review URL: http://codereview.chromium.org/18260
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Handle relative paths in source files from parents of SOURCE_ROOT.
Review URL: http://codereview.chromium.org/18064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8064 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
by grit into a single .pak file.
Review URL: http://codereview.chromium.org/18254
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8063 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=paulg
Review URL: http://codereview.chromium.org/18033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7991 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
data resource that we were loading from disk. This should
get compiled out in chrome. Rebaseline one test.
Review URL: http://codereview.chromium.org/18008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This allows memory errors to be isolated to a particular test and a crash
in one test to affect the tests of others.
Review URL: http://codereview.chromium.org/17634
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7938 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
webkit_resources.vcproj which creates the .rc files and have webkit
glue depend on it.
I had to add a flag to grit that allows a resource to be in the
header, but not in the .rc file. We do this for a test_shell only
resource that is not compiled in.
SCons build also works on windows.
I still need to update the other .sln files and mac build.
Review URL: http://codereview.chromium.org/17466
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7910 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=5469
TEST=make sure errors in _ignore files in, say, base/data/purify/ don't show
up in the buildbot's count of errors we need to fix
Review URL: http://codereview.chromium.org/17457
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7844 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Also fixes a typo in logging.
Review URL: http://codereview.chromium.org/17321
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7837 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=1573607
Review URL: http://codereview.chromium.org/17449
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7821 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the data files for the executable under test, to give it better visibility.
BUG=5469
TEST=look for 'Fixable errors' and 'Flakey errors' lines in output on buildbot;
verify counts from the lines output just before them
Review URL: http://codereview.chromium.org/17304
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7814 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently supports the following commands:
./chrome_tests.sh --test base
./chrome_tests.sh --test net
./chrome_tests.sh --test ipc
./chrome_tests.sh --test unit
The valgrind_*.py files are my first real big chunks of python, so any suggestions would be greatly appreciated.
Review URL: http://codereview.chromium.org/16583
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
pending the grand overall solution.
Review URL: http://codereview.chromium.org/15015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7773 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/17402
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
pass on the purify buildbot.
Review URL: http://codereview.chromium.org/16556
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
is the same as using_generated_resources.vsprops.
Replace existing paths with this scons file if the SConscript
file has already been converted to the using_ format.
Review URL: http://codereview.chromium.org/14902
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7583 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/14175
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7562 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moved the grit .vsprops file from chrome/tools/build/win/ to
/tools/grit/build and renamed to using_generated_resources.vsprops.
Updated non-chrome projects to use the this new vsprops file.
Created a new .rules file and renamed the old one. Now there are
grit_resources.rules and grit_localized_resources.rules. The latter
is what we use now, but I'll be adding some grd files that use the
former in a follow up change.
This is just vsprops reshuffling for now. I'll also add a
using_generated_resources.scons in a follow up change.
Review URL: http://codereview.chromium.org/14901
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I want to declare 1.1-dev users "on the Beta channel" and
create a new 2.0-dev tag for the Dev channel. To do that
I needed to make the Channel Changer recognize 1.1-dev as
Beta.
I also changed some strings:
* make the note about changing to a more stable channel
a little clearer
* make the dialog title 'Channel Changer' (instead of
Switcher)
The vcproj needed to be updated for the Release rule.
(Jungshik changed Debug in r7532.)
Review URL: http://codereview.chromium.org/17050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7559 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/17037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7532 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
necessary for
dynamic font support.
This is a re-run of http://codereview.chromium.org/14908/show (except that chrome_dll.deps file which needs to be updated along with the actual code change)
This will be followed by http://codereview.chromium.org/16494 (actual webkit code change) and changes in webkit/build
BUG=1303
Review URL: http://codereview.chromium.org/16496
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7520 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=nsylvain
Review URL: http://codereview.chromium.org/17021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7501 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
SDK upgrade is necessary to support dynamic/webfont because SDK 6.0 does not have
t2embapi.h and t2embed.lib. SDK 6.1 is compatible with WIn XP and VS 2005 or later.
FYI:
http://codereview.chromium.org/14084/show is the CL for adding web/dynamic font support.
Review URL: http://codereview.chromium.org/14908
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7500 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
privileges are required (in some cases).
Review URL: http://codereview.chromium.org/16232
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7465 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
By default, the subprocess is supposed to inherit these from its parent,
however when run under buildbot, it seems unable to read data
from a grandchild process, so we have to read the child and print the data
as if it came from us for buildbot to read it. We're not sure why this is
necessary.
Review URL: http://codereview.chromium.org/15092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7337 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
the chrome.dll re-instrumentation step when running tests manually.
Review URL: http://codereview.chromium.org/15085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7313 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
If System-level Chrome is installed, Channel Changer will choose that.
If not found, it will look for User-level Chrome and update that.
Review URL: http://codereview.chromium.org/15084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7312 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When Chrome is installed system wide, the Google Update keys reside under HKLM.
Under Vista, any writes to this key will get virtualized, unless we elevate
the channel_changer process. We don't want to elevate using a manifest, because
we don't want the UAC to pop up when the Channel Changer is used to configure a
user-level Chrome installation, so we detect at process startup whether we need
to elevate and relaunch the channel_changer process (elevated) if we need to
(before showing any UI).
Review URL: http://codereview.chromium.org/14855
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7260 0039d316-1c4b-4281-b951-d872f2087c98
|