summaryrefslogtreecommitdiffstats
path: root/tools
Commit message (Collapse)AuthorAgeFilesLines
* Fix a leak in MalwareDetailsTest.HTTPCacherlarocque@chromium.org2011-09-201-20/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The TestURLRequestContextGetter ensures that it is deleted by the IO thread. If the IO thread doesn't exist when it is deleted, then the object is leaked. This change stops the IO thread a bit later in the teardown, which ensure that it is around long enough to handle TestURLRequestContextGetter's deletion. It looks like willchan had fixed this error for a while with r85378. At that time, the profile may have been the only object to hold a reference to the TestURLRequestContextGetter. In the current codebase, however, my debugger tells me there are two other outstanding references to it, so clearing the profile's reference is not enough to ensure the object is deleted. I'm hoping this fix will be less likely to break as the code changes. This fixes issue 79933, but not the suppressions named after it. One of those suppressions seems to share a root cause with issue 80654, so it has been renamed accordingly. The other is so broad that it's not safe to delete it at this time, because it's likely to be suppressing other bugs, too. BUG=79933, 80654 TEST=MalwareDetailsTest.HTTPCache Review URL: http://codereview.chromium.org/7919023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101875 0039d316-1c4b-4281-b951-d872f2087c98
* Move NPObjectBase and PluginChannelBase from content/plugin to content/commonsteveblock@chromium.org2011-09-201-1/+1
| | | | | | | | | | | | Also rename PluginChannelBase to NPChannelBase, fix variable naming to be agnostic of plugins, and fix a comment in NPChannelBase. This change is refactoring only and introduces no change in behaviour. BUG=96703 Review URL: http://codereview.chromium.org/7891003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101874 0039d316-1c4b-4281-b951-d872f2087c98
* Make only slow (Valgrind and DR) tools use the *.gtest.txt files glider@chromium.org2011-09-191-1/+7
| | | | | | | | | | | As the number of our tools grows, it's correct no more to unconditionally append the contents of *.gtest.txt files to the gtest filters. Currently such files contain specific filters common for Memcheck and TSan on Linux and Mac, and Dr.Memory on Windows, so I propose to use these filters only for those tools. In the future those can be renamed to *.gtest_slow.txt. Anyway, I doubt there should be global test filters used by all the tools. Review URL: http://codereview.chromium.org/7926008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101848 0039d316-1c4b-4281-b951-d872f2087c98
* Updated *.pak file format to support both UTF8 and UTF16adriansc@chromium.org2011-09-194-35/+65
| | | | | | | | | | | | | | | | | Inserted a new field in the header that specifies which encoding is to be used for the text resources. I also upped file format to version 4. BUG=76281 TEST=unit_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100973 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101213 Review URL: http://codereview.chromium.org/7744017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101846 0039d316-1c4b-4281-b951-d872f2087c98
* Pull libcros v171satorux@chromium.org2011-09-191-1/+1
| | | | | | | | | | | | This should fix the linux clang build failure reported at crosbug.com/20578 BUG=chromium-os:20578 TEST=build chrome Review URL: http://codereview.chromium.org/7941018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101825 0039d316-1c4b-4281-b951-d872f2087c98
* Update expectations for new total_op_r on XP moz.cmp@chromium.org2011-09-191-1/+1
| | | | | | | | TBR=nsylvain@chromium.org Review URL: http://codereview.chromium.org/7945013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101805 0039d316-1c4b-4281-b951-d872f2087c98
* Wait for test script to be loaded before calling __get_timingscmp@chromium.org2011-09-191-2/+5
| | | | | | | | | | | | | | Set a variable to indicate that the result report page is loaded. See detailed analysis in crbug.com/53140. This is relanding r101718 after a revert at r101778. BUG=53140 TBR=jnd@chromium.org TEST=page cycler stays green Review URL: http://codereview.chromium.org/7941015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101798 0039d316-1c4b-4281-b951-d872f2087c98
* Valgrind: Disable RunInBackgroundTest.RunInBackgroundBasicTest which is failingjhawkins@chromium.org2011-09-191-2/+2
| | | | | | | | | | | | | consistently on Linux. BUG=97107 TEST=none R=thestig@chromium.org Review URL: http://codereview.chromium.org/7943011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101787 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r101718 "wait for test script to be loaded"cmp@chromium.org2011-09-191-4/+1
| | | | | | | | | | | | | This change broke all of the page cycler tests on the chromium.perf waterfall. TBR=jnd@chromium.org BUG=53140 TEST=page cyclers work again Review URL: http://codereview.chromium.org/7941010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101778 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 101756 (broke ChromeOS-clang) - Bump libcros to include the change to ↵sadrul@chromium.org2011-09-191-1/+1
| | | | | | | | | | | | | | allow triggering login-prompt-visible from chrome. BUG=chromium-os:20517 TEST=manually Review URL: http://codereview.chromium.org/7946002 TBR=sadrul@chromium.org Review URL: http://codereview.chromium.org/7945007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101762 0039d316-1c4b-4281-b951-d872f2087c98
* Bump libcros to include the change to allow triggering login-prompt-visible ↵sadrul@chromium.org2011-09-191-1/+1
| | | | | | | | | | | from chrome. BUG=chromium-os:20517 TEST=manually Review URL: http://codereview.chromium.org/7946002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101756 0039d316-1c4b-4281-b951-d872f2087c98
* Remove remaining valgrind suppressions for 52364, seems to be fixed.bradchen@google.com2011-09-191-27/+0
| | | | | | | | | BUG=52364 TEST=valgrind bots and drmemory tests Review URL: http://codereview.chromium.org/7941002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101750 0039d316-1c4b-4281-b951-d872f2087c98
* Switch clang download to https.thakis@chromium.org2011-09-191-1/+1
| | | | | | | | | | | | About 4% slower than downloading over http in my tests. BUG=96722 TEST=none Review URL: http://codereview.chromium.org/7931021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101742 0039d316-1c4b-4281-b951-d872f2087c98
* Remove suppressions for 48130 since we have removed the code path in r101476.yusukes@google.com2011-09-191-63/+0
| | | | | | | | | BUG=chromium:48130 TEST=ran unit_tests under valgrind (without suppressions) and confirmed that no leaks were reported. Review URL: http://codereview.chromium.org/7926005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101720 0039d316-1c4b-4281-b951-d872f2087c98
* Wait for test script to be loaded before calling __get_timings by setting a ↵jnd@chromium.org2011-09-191-1/+4
| | | | | | | | | variable to indicate that the result report page is loaded. See detailed analysis in crbug.com/53140. BUG=53140 Review URL: http://codereview.chromium.org/7904005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101718 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt at making checklicenses green after first run on the real bots.nsylvain@chromium.org2011-09-181-0/+19
| | | | | | Review URL: http://codereview.chromium.org/7935011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101714 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 101537 - Remove valgrind supression for ↵csilv@chromium.org2011-09-171-0/+3
| | | | | | | | | | | | | | OptionsUITest.LoadOptionsByURL temporarily to see if a leaks are still detected. TBR=jhawkins BUG=96342 TEST=Watch valgrind runs for supression results. Review URL: http://codereview.chromium.org/7919018 TBR=csilv@chromium.org Review URL: http://codereview.chromium.org/7904035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101643 0039d316-1c4b-4281-b951-d872f2087c98
* Fix missing conditional in last change.cmp@chromium.org2011-09-171-1/+2
| | | | | | | | | BUG=96937 TBR=nsylvain@chromium.org Review URL: http://codereview.chromium.org/7912007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101636 0039d316-1c4b-4281-b951-d872f2087c98
* Adjust make expectations to workaround regress/improve values that are the same.cmp@chromium.org2011-09-172-1/+6
| | | | | | | | | BUG=96937 TBR=nsylvain@chromium.org Review URL: http://codereview.chromium.org/7930006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101635 0039d316-1c4b-4281-b951-d872f2087c98
* Update expectations now that another static initializer on Linux has been ↵rsleevi@chromium.org2011-09-171-1/+1
| | | | | | | | | | | removed. BUG=96937 TEST=none Review URL: http://codereview.chromium.org/7932011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101633 0039d316-1c4b-4281-b951-d872f2087c98
* Rebase expectations for chrome static initializer sizesrsimha@chromium.org2011-09-171-1/+1
| | | | | | | | | | | | | The chromium linux builder complained about static initializer size when r101607 caused a decrease in binary size. However, the intention of the revision was to rip out files that were not in use, and the size decrease was expected. This patch updates the size expectations in perf_expectations.json. BUG=96937 TEST=watch linux builder (sizes step) Review URL: http://codereview.chromium.org/7933004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101620 0039d316-1c4b-4281-b951-d872f2087c98
* Provide an exact tolerance feature for expectations.cmp@chromium.org2011-09-162-9/+9
| | | | | | | | | | | | | | | | Make it possible to set the tolerance to any value on a test-by-test basis. Initially, set the tolerance to zero and update the revision range for the static initializers test on Linux. Updated the name of the variables from 'variance' to 'tolerance' which I believe is more accurate, as well. TBR=nsylvain@chromium.org Review URL: http://codereview.chromium.org/7925028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101593 0039d316-1c4b-4281-b951-d872f2087c98
* Prepare checklicenses.py for buildbot landing.phajdan.jr@chromium.org2011-09-161-1/+14
| | | | | | | | | | | | | | - suppress yet another regression - print info how to handle failures - don't turn the bot red, but orange in case of failure this is temporary, but will make it significantly easier to land the buildbot-side change BUG=28291 Review URL: http://codereview.chromium.org/7925024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101573 0039d316-1c4b-4281-b951-d872f2087c98
* Remove an obsolete suppression for AccessibilityController.tony@chromium.org2011-09-161-25/+0
| | | | | | | | | | | This was for test_shell, but we've moved to DumpRenderTree so the stack doesn't match. BUG=51822 Review URL: http://codereview.chromium.org/7922019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101571 0039d316-1c4b-4281-b951-d872f2087c98
* Remove valgrind supression for OptionsUITest.LoadOptionsByURL temporarily to ↵csilv@chromium.org2011-09-161-3/+0
| | | | | | | | | | | see if a leaks are still detected. TBR=jhawkins BUG=96342 TEST=Watch valgrind runs for supression results. Review URL: http://codereview.chromium.org/7919018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101537 0039d316-1c4b-4281-b951-d872f2087c98
* Autofill/Valgrind: Fix a leak in AutofillDownloadTest.jhawkins@chromium.org2011-09-161-6/+0
| | | | | | | | | | | | | | URLRequestContextGetter requires the object to be released on the IO thread. Also made quite a few cleanups. BUG=75247 TEST=AutofillDownloadTest.* R=isherman@chromium.org Review URL: http://codereview.chromium.org/7886047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101433 0039d316-1c4b-4281-b951-d872f2087c98
* Remove suppressions for bug 34554 since the underlying code has changed ↵sullivan@chromium.org2011-09-161-16/+0
| | | | | | | | | | significantly. BUG=34554 Review URL: http://codereview.chromium.org/7901003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101430 0039d316-1c4b-4281-b951-d872f2087c98
* Write tests for FFmpegAudioDecoder so I can rewrite the class sans regressions.scherkus@chromium.org2011-09-161-0/+14
| | | | | | | | | TEST=media_unittests BUG=96773 Review URL: http://codereview.chromium.org/7891050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101429 0039d316-1c4b-4281-b951-d872f2087c98
* Remove valgrind suppression fixed upstreamadamk@chromium.org2011-09-151-23/+0
| | | | | | | | | | | in http://trac.webkit.org/changeset/95071. BUG=60653 TBR=thestig@chromium.org Review URL: http://codereview.chromium.org/7918002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101407 0039d316-1c4b-4281-b951-d872f2087c98
* Removed dead data_pack code.adriansc@chromium.org2011-09-152-122/+0
| | | | | | | | | | | Followup for WebKit rev95132. BUG=none TEST=builds Review URL: http://codereview.chromium.org/7901023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101406 0039d316-1c4b-4281-b951-d872f2087c98
* Remove suppressions for bug 81753, fixed by CL 7891051bradchen@google.com2011-09-152-68/+0
| | | | | | | | | | BUG=81753 TEST=unit_tests on valgrind bots Review URL: http://codereview.chromium.org/7892036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101384 0039d316-1c4b-4281-b951-d872f2087c98
* Remove suppression for bug_88863asatorux@chromium.org2011-09-151-8/+0
| | | | | | | | | | | | I was able to reproduce this locally a couple of days ago but now the leak is gone. Some recent patch must have fixed the issue. BUG=88863 TEST=run AutomationProxyTest.GetBrowserWindowCount under valgrind. Review URL: http://codereview.chromium.org/7910005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101380 0039d316-1c4b-4281-b951-d872f2087c98
* Remove an outdated suppression.mmenke@chromium.org2011-09-151-3/+0
| | | | | | | | BUG=43179 TEST=SpdyNetworkTransactionTest.PostWithEarlySynReply Review URL: http://codereview.chromium.org/7906010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101363 0039d316-1c4b-4281-b951-d872f2087c98
* Remove suppression for memory leak which should be fixed by sullivan@chromium.org2011-09-151-11/+0
| | | | | | | | | | http://trac.webkit.org/changeset/84665. BUG=36062 Review URL: http://codereview.chromium.org/7889052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101345 0039d316-1c4b-4281-b951-d872f2087c98
* mac: Warn people on Xcode <= 3.2.2 that they should upgrade.thakis@chromium.org2011-09-151-0/+8
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/7904019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101316 0039d316-1c4b-4281-b951-d872f2087c98
* Remove suppression for bug 58074.xiyuan@chromium.org2011-09-151-11/+0
| | | | | | | | | | | | libpng 1.2.45 fixed the uninitialized bits issue. BUG=58074 TEST=Valgrind failure in 58074 does not happen. TBR=oshima@chromium.org Review URL: http://codereview.chromium.org/7892042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101312 0039d316-1c4b-4281-b951-d872f2087c98
* Remove suppressions for bug 87380 now that DEPS have been rolled past WebKit ↵sullivan@chromium.org2011-09-151-30/+0
| | | | | | | | | | changeset 94844. BUG=87380 Review URL: http://codereview.chromium.org/7901005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101307 0039d316-1c4b-4281-b951-d872f2087c98
* Remove suppression for bug_50252satorux@chromium.org2011-09-151-12/+0
| | | | | | | | | | | | The suppression is obsolete, and the root cause of the issue was fixed in crrev.com/101162. TEST=temporarily enable NewTabUITest.NTPHasThumbnail and run it. BUG=50252 Review URL: http://codereview.chromium.org/7901011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101304 0039d316-1c4b-4281-b951-d872f2087c98
* Remove suppression for issue 35182bsalomon@google.com2011-09-151-13/+0
| | | | | | | BUG=35182 Review URL: http://codereview.chromium.org/7889034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101286 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress a Mac valgrind issue with SSLHostInfo::ParseInnerstuartmorgan@chromium.org2011-09-151-0/+19
| | | | | | | | | | | | | One more clang fallout suppression TBR=thakis BUG=96689 TEST=Greener Mac valgrind bots Review URL: http://codereview.chromium.org/7904013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101282 0039d316-1c4b-4281-b951-d872f2087c98
* Fix uninitialized memory access in DeviceManagementServiceFailedRequestTest.mnissler@chromium.org2011-09-151-6/+0
| | | | | | | | | BUG=90654 TEST=drmemory doesn't complain on DeviceManagementServiceFailedRequestTest* Review URL: http://codereview.chromium.org/7870009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101281 0039d316-1c4b-4281-b951-d872f2087c98
* Add Mac valgrind suppression for SocketHost issuestuartmorgan@chromium.org2011-09-151-0/+12
| | | | | | | | | | | | | More clang fallout. TBR=thakis BUG=96684 TEST=Greener Mac valgrind bots Review URL: http://codereview.chromium.org/7886063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101280 0039d316-1c4b-4281-b951-d872f2087c98
* Disable even more tests for Mac valgrind UIstuartmorgan@chromium.org2011-09-151-3/+3
| | | | | | | | | | | | | I hate to remove the handful of tests we were still running, but the failure-to-launch problem is killing these often enough that it's turning thing red a good chunk of the time. TBR=glider BUG=75249 TEST=Less flake in Mac valgrind bots Review URL: http://codereview.chromium.org/7886062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101279 0039d316-1c4b-4281-b951-d872f2087c98
* Initial commit for the ASan test runner.glider@chromium.org2011-09-154-0/+538
| | | | | | | | | | This is forked from tools/heapcheck and simplified a little. I'll send a refactoring CL soon. TBR=timurrrr Review URL: http://codereview.chromium.org/7904011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101277 0039d316-1c4b-4281-b951-d872f2087c98
* Widen valgrind suppression for MockKeychainstuartmorgan@chromium.org2011-09-151-1/+1
| | | | | | | | | | | | | Missed the second form of this when adding the suppression TBR=thakis BUG=96671 TEST=Greener Mac valgrind bots Review URL: http://codereview.chromium.org/7886061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101274 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress an uninitialized condition check in MockKeychain for Mac valgrindstuartmorgan@chromium.org2011-09-151-0/+7
| | | | | | | | | | | | | Started with the switch to clang. TBR=thakis BUG=96671 TEST=Greener valgrind bots Review URL: http://codereview.chromium.org/7888073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101273 0039d316-1c4b-4281-b951-d872f2087c98
* Update valgrind suppression stacks for clang changesstuartmorgan@chromium.org2011-09-153-42/+29
| | | | | | | | | | | | | | | A number of suppressions were no longer matching since the switch to clang on Mac, mostly due to slight differences in inlining and in edge-case name mangling. Most of the changes here shouldn't widen suppressions in any material way, just make the existing suppressions more tolerent of the gcc/clang differences. One exception is a widening of the new bloom filter suppression, since it turns out different call stacks can get to the same issue. TBR=thakis BUG=None TEST=Greener Mac valgrind bots Review URL: http://codereview.chromium.org/7890066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101268 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 96532 - Valgrind: Disable a bunch of tests that are consistently ↵nkostylev@chromium.org2011-09-151-9/+0
| | | | | | | | | | | | | | | | | | timing out. Waiting for this CL http://codereview.chromium.org/7885017/. Turns out it helps with tests timeouts. BUG=92630 TEST=none TBR=jhawkins Review URL: http://codereview.chromium.org/7634021 TBR=thestig@chromium.org Review URL: http://codereview.chromium.org/7891044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101267 0039d316-1c4b-4281-b951-d872f2087c98
* Add a supression for an uninitialized read in LoadBloomFilter on Mac valgrindstuartmorgan@chromium.org2011-09-151-0/+8
| | | | | | | | | | | TBR=thakis BUG=96663 TEST=Greener mac valgrind bots Review URL: http://codereview.chromium.org/7906001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101260 0039d316-1c4b-4281-b951-d872f2087c98
* There is a complain from Valgrind about invalid memory access in ↵xians@chromium.org2011-09-151-21/+0
| | | | | | | | | | | | | | snd_device_name_hint(-1, ..) // -1 means all cards. It looks like the problem is actually because we use -1 to loop through all the soundcards. And this patch will loop through the soundcard manually, which should resolve the Valgrind problem. Bug=96207 Test=media_unittests with Valgrind Review URL: http://codereview.chromium.org/7888011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101240 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-11 11:14:58 +0000