| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
Fix sync-webkit-git.py when there is multiple upstreams by forcing it to use 'origin/master' instead of 'origin'.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3380003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59522 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=glider
TEST=Less reports on the Dr. Memory bot
Review URL: http://codereview.chromium.org/3453002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also, fix constructors for classes multiple inheritance.
Commiting the patch for Evgeniy Stepanov,
originally reviewed as http://codereview.chromium.org/3418008
TBR=glider
TEST=memory waterfall should not be affected by this change
Review URL: http://codereview.chromium.org/3418009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59488 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The annotations include a list of supported platforms for each policy. Depending on this, only the supported policies are written for each template type.
BUG=54665
TEST=PolicyTemplateGeneratorUnittest.testPolicyFiltering, {Adm,Plist,PlistStrings}WriterUnittest.testNonSupportedPolicy, {Admx,Adml}WriterUnittest.testPlatform
Review URL: http://codereview.chromium.org/3303027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
README.chromium is now in place.
TBR=evan
BUG=28291
TEST=tools/licenses.py scan
Review URL: http://codereview.chromium.org/3418006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59431 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
names.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3343020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59405 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The patch was prepared by Evgeniy Stepanov and
reviewed as http://codereview.chromium.org/3296016
TBR=glider
TEST=TSan bots shouldn't be affected by this for now
Review URL: http://codereview.chromium.org/3418003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59370 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=55533
TBR=glider
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59358 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This change removes supression rules for Bug 54689 because Jay landed its WebKit fix. (See <https://bugs.webkit.org/show_bug.cgi?id=45287>.)
BUG=54689
TEST=keep the "Linux Tests (valgrind)(1)" bot green.
Review URL: http://codereview.chromium.org/3417002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=53936
TEST=see bug
Review URL: http://codereview.chromium.org/3296021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59287 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Following upstream WebKit perf slowdown and possible
V8 regression.
- mac-release-10.5/morejs/times/t
- mac-release-10.6/morejs/times/t
- xp-release-dual-core/morejs/times/t
BUG=none
TEST=mac10.5, mac10.6, and xpdual morejs is green
TBR=nsylvain@chromium.org
Review URL: http://codereview.chromium.org/3367027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59282 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=Valgrind doesn't fail
BUG=52836
Review URL: http://codereview.chromium.org/3345022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59220 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=39963
TBR=glider
TEST=Valgrind Mac UI should go green
Review URL: http://codereview.chromium.org/3337023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59216 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
slowed due to WebKit bug 45524.
Hopefully I am adjusting the expectations correctly.
BUG=https://bugs.webkit.org/show_bug.cgi?id=45524
TEST=page cycle bots green up
TBR=chase@chromium.org
Review URL: http://codereview.chromium.org/3306017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3324015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59161 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=28291
Review URL: http://codereview.chromium.org/3362015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59154 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
bug 30k and up)
BUG=Too many to list
TEST=Valgrind stays green-ish.
Review URL: http://codereview.chromium.org/3301018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59153 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
up to bug 30k)
BUG=Too many to list
TEST=Valgrind stays green-ish.
Review URL: http://codereview.chromium.org/3373005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=54376
TEST=admx_writer_unittest.py
adml_writer_unittest.py
Review URL: http://codereview.chromium.org/3290018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59092 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Basically, checkdeps on OS X and git is a no-op without this fix, as
OS X (almost always) has a case-insensitive file system and checkdeps
does case-sensitive comparisons.
BUG=none
TEST=ran checkdeps before/after
Review URL: http://codereview.chromium.org/3356015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59066 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
json and grd files that are used to generate the policy templates.
Added matching constants for the policy elements to the policy_constants files.
Added support for a new template value, $3, that represents the Chrome Frame product name in policy templates.
TEST=none
BUG=29349
Review URL: http://codereview.chromium.org/3325011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59050 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
being created but not handed over to the syncer thread.
BUG=55031
TEST=unit tests
Review URL: http://codereview.chromium.org/3374002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59031 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=55031
TEST=Heapcheck and Valgrind
Review URL: http://codereview.chromium.org/3351020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59023 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
ProfileSyncServicePreferenceTest.
TBR=johnnyg
BUG=55031
TEST=Valgrind and Heapcheck
Review URL: http://codereview.chromium.org/3302021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59015 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=54098
Review URL: http://codereview.chromium.org/3302020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59001 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The original problem was that the test plays an animation that outlives the test. When the animation is done, the tab strip model observer tries to unregister itself, but the registry died when the test exited already.
My faulty fix was to reset the observer as soon as the end animation starts. This has the problem that the end animation will try to access stale objects: TabContentss are destroyed when the test exits, but the exit animation still tries to access them when drawing ThumbnailLayers (because the observer didn't get a notification that these were dead, since it was unregistered).
This (hopefully better) fix now unregisters the observer directly before the tab strip goes away.
BUG= 54323,53893,54342
TEST=unit tests pass, valgrind stays green
Review URL: http://codereview.chromium.org/3304014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58945 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a leak suppression for browser_sync::ClearDataCommandTest_ClearDataCommandExpectSucess test.
TBR=tim
BUG=54915
TEST=Linux Valgrind 3
Review URL: http://codereview.chromium.org/3302018
TBR=rsesek@chromium.org
Review URL: http://codereview.chromium.org/3362013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
browser_sync::ClearDataCommandTest_ClearDataCommandExpectSucess test.
TBR=tim
BUG=54915
TEST=Linux Valgrind 3
Review URL: http://codereview.chromium.org/3302018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=oshima
BUG=54308
TEST=ChromeOS Valgrind
Review URL: http://codereview.chromium.org/3371007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58853 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add protection against hang when the child leaks a process.
BUG=54098
TEST=none
Review URL: http://codereview.chromium.org/3360008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58741 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
RenderViewTest_PageClickTracker leak.
TBR=jcivelli
BUG=54689
TEST=Heapcheck and Linux Valgrind
Review URL: http://codereview.chromium.org/3297018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58722 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=jcivelli
BUG=54689
TEST=Heapcheck bot
Review URL: http://codereview.chromium.org/3366014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58706 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=jcivelli
BUG=54689
TEST=Linux and Mac valgrind
Review URL: http://codereview.chromium.org/3332008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58697 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Set the Chrome policy registry keyname to "Software\\Policies\\Google\\Chrome" for ADM output. Move all such constant strings to a common place for ADM, ADMX and plist output. (So that such bugs will be harder to overlook next time.)
BUG=54630
TEST=manual + grit/format/policy_templates/writer/*
Review URL: http://codereview.chromium.org/3299009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58696 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before this fix, <message> elements with use_name_for_id attribute,
inside <if expr='pp_ifdef(...)'> were falling back to English,
because defines information was not present when evaluating conditions.
TEST=wrote and ran testUseNameForIdAndPpIfdef (python grit.py unit). There were failing tests before this change, and this change did not increase the number of failing tests. Also confirmed that http://codereview.chromium.org/3275008/show worked fine with this patch.
BUG=54360
Review URL: http://codereview.chromium.org/3335003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58678 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=glider
Review URL: http://codereview.chromium.org/3293012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58636 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=timurrrr
Review URL: http://codereview.chromium.org/3354010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58628 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
krb5int_getaddrinfo while terminating Kerberos.
TBR=timurrrr
Review URL: http://codereview.chromium.org/3299007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58624 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=rafaelw@chromium.org
BUG=39963
TEST=none
Review URL: http://codereview.chromium.org/3361006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58557 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=46678,53277
TEST=remove 2 suppressions, run valgrind linux
Review URL: http://codereview.chromium.org/3170049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58496 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Fix is in this CL http://codereview.chromium.org/3264001 so may as well remove the suppression now.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3341006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58470 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
PListStringsWriter.
BUG=53953
TEST=adm_writer_unittest.py, plist_strings_writer_unittest.py
Review URL: http://codereview.chromium.org/3214014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3342013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58465 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=50638
TEST=none
Review URL: http://codereview.chromium.org/3311010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58450 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=thakis@chromium.org,phajdan.jr@chromium.org,dtseng@chromium.org
BUG=54342
TEST=none
Review URL: http://codereview.chromium.org/3334006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58437 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- mac-release-10.5/intl1/times/t
- mac-release-10.5/startup/warm/t
- mac-release-10.6/intl2/times/t
- xp-release-dual-core/intl2/times/t
- xp-release-dual-core/moz/total_byte_r/IO_r
- xp-release-dual-core/moz/total_op_r/IO_op_r
- xp-release-dual-core/moz/vm_peak_r/vm_pk_r
BUG=none
TEST=these are green: mac10.5 perf (1) intl1 and
startup, mac10.6 (perf) intl2, xp perf(1) intl2 and moz
TBR=nsylvain@chromium.org
Review URL: http://codereview.chromium.org/3328007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=thestig@chromium.org
BUG=35182
TEST=none
Review URL: http://codereview.chromium.org/3347011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58420 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=54098
TEST=none
Review URL: http://codereview.chromium.org/3329003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58418 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=kbr@chromium.org
BUG=50638
TEST=none
Review URL: http://codereview.chromium.org/3331010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58401 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removed 51134 that has been fixed&removed but put back by merge error in r54943.
TBR=dhg@chromium.org
BUG=54308
TEST=none
Review URL: http://codereview.chromium.org/3294006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58399 0039d316-1c4b-4281-b951-d872f2087c98
|