| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
BUG=22109
TBR=mbelshe
TEST=none
Review URL: http://codereview.chromium.org/210008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26436 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=agl
BUG=22098
TEST=none
Review URL: http://codereview.chromium.org/215005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=22021
Review URL: http://codereview.chromium.org/211001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26406 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
today's WebKit roll.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26403 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
like this is already being worked on in bug 22021.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26386 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=18597
TBR=nsylvain
Review URL: http://codereview.chromium.org/201138
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26380 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=22021
Review URL: http://codereview.chromium.org/201136
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26377 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Set the perf expectations on linux, mac, and windows
perf systems for the morejs and warm startup tests.
The variance assumptions might require fine-tuning on
the master to get right. We might be flaky to begin
with, or may want to turn off the variance reporting
altogether.
BUG=18597
TEST=build.chromium.org perf slaves stay green
Review URL: http://codereview.chromium.org/193083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26376 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=22021
Review URL: http://codereview.chromium.org/204042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Why: Simpler build code. If everybody includes it, it should be included automatically.
Why now: The webkit chromium builds need it be specified, since can't default to build/common.gypi.
What was done:
1. build/common.gypi's contents were moved to a new file build/gyp_chromium.gypi
2. tools/gyp/gyp_chromium was moved to build/gyp_chromium and made to automatically include build/gyp_chromium.gypi.
3. lots of gyp files were fixed to not refer to build/common.gypi any more.
4. o3d which also builds independently of chrome, was fixed to have a gyp_o3d that includes gyp_chromium.gypi too.
5. build/common.gypi was left empty, because there are some external projects that still refer to it.
Things that are left to do after this patch is in:
1. The following external files (in other repositories) need to stop include common.gypi
./third_party/hunspell/hunspell.gyp
./third_party/icu/icu.gyp
./v8/tools/gyp/v8.gyp
2. Once nobody refers to common.gypi anymore, delete common.gypi
-or-
Delete gyp_chromium.gypi and move its content back to common.gypi
Tested on mac, win and linux. On win, got a few unit tests errors on chrome bookmarks, which should not be related. I'm running again with clobber to verify.
Review URL: http://codereview.chromium.org/206006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26302 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
I had committed before I got Tony's feedback. This change does
some of his suggestions and migrates some info to the wiki.
Review URL: http://codereview.chromium.org/195098
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26286 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also a slight variation on an existing font suppression.
BUG=20508,20580
TEST=Mac valgrind UI bots
Review URL: http://codereview.chromium.org/195089
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
because the valgrind logs
have astronomical suppression counts for this.
BUG=17966,17996
Review URL: http://codereview.chromium.org/204009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This patch was prepared by Alexander Potapenko (cc'ed),
we work together on ThreadSanitizer for Chromium.
Review URL: http://codereview.chromium.org/194106
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26146 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/204003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26086 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
instead of tcmalloc.
BUG=21432
Review URL: http://codereview.chromium.org/192081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26083 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
and make it take commandline arguments so people don't have to
edit it. Have it build the tests, too.
Review URL: http://codereview.chromium.org/203036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26060 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
compiler options.
BUG=21645
TEST=verdant, shining mac ui buildbots
Review URL: http://codereview.chromium.org/203045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26055 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
possible. (it can now see which tests were run each chunk)
BUG=18475
Review URL: http://codereview.chromium.org/173595
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26024 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/199095
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25995 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/203030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25983 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The leak appears to been fixed. Cannot repro anymore.
TEST=valgrind ui bot should not show this
BUG=16628
Review URL: http://codereview.chromium.org/197058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25980 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Expand the regex used to test keys so "." is an allowed
character. Needed for perf ids like "mac-release-10.5".
BUG=18597
TEST=a perf_expectations dict with keys containing
"." passes presubmit tests
Review URL: http://codereview.chromium.org/194084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25978 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=5027
TEST=none
Review URL: http://codereview.chromium.org/196081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25925 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=21479
Review URL: http://codereview.chromium.org/203021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25918 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
section of the xml file is missing/empty
Review URL: http://codereview.chromium.org/203018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25876 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
We run diff-index to see if there are any changes we need to pull in,
but we don't need it to print all of those changes.
Review URL: http://codereview.chromium.org/202045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25869 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=20653
TEST=Mac Valgrind UI bots
Review URL: http://codereview.chromium.org/199062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25868 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit r25825, 12ccd8bcd7b19a818d47f983f617539232cfc20f.
TBR=dkegel
Review URL: http://codereview.chromium.org/202037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25827 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/203009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25825 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/193049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25747 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- verify main object is a dictionary
- verify load key is present and points to a bool
- verify all key values are dictionaries
- verify all key values have (correct) delta/var keys
- verify all keys are in correct format (a/b/c/d)
BUG=18597
TEST=verify unit tests catches these errors
Review URL: http://codereview.chromium.org/194032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25656 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix a suppression and remove one that duplicates it.
Widen a suppression
Add a bunch of new suppressions.
BUG=11333,21137,21279,21280,20580,21286
TEST=More green on the Mac valgrind bots.
Review URL: http://codereview.chromium.org/197043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25645 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
AutocompleteTextFieldCell calls -keyboardFocusIndicatorColor when
drawing the focus ring, which valgrind considers a leak. While we
were testing drawing when not focussed, unit tests could not test
drawing when focussed without the window being made key, which is bad
for many reasons.
This change adds some code to allow faking the key window, then adds
tests for drawing when focussed which exposes the memory leak, then
adds a suppression for that memory leak.
http://crbug.com/21137
TEST=valgrind AutocompleteTextFieldCellTest.Display
Review URL: http://codereview.chromium.org/192031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25567 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/199034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25543 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
especially when define changes.
TEST=none
BUG=20889
Review URL: http://codereview.chromium.org/171118
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25511 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously headers were handled differently only as an optimization.
This thwarts vstudio + gyp.
Adding a grit_info python stub so that gyp can get an accurate list of
inputs and outputs from a grd file. Currently only using it for the inputs,
because there's no good way in gyp to have rules invoke a !@( expansion
once per rule instance.
This change will over-specify dependencies for these modules,
but it will at least not under-specify them anymore.
BUG=24836
TEST=None
Review URL: http://codereview.chromium.org/197007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25499 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=20580,20814
TEST=Mac UI valgrind bots
Review URL: http://codereview.chromium.org/200022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25489 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
vCMMVectorConvert8BitRGBToRGB on Mac
Doesn't occur anymore on my machine.
BUG=11134
TEST=mac valgrind bot running test_shell_tests should stay green
Review URL: http://codereview.chromium.org/196028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
warning. This is useful particularly in the case of ui
tests, where the --test-name parameter directly identifies
the test case.
Review URL: http://codereview.chromium.org/194025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
grit to replace \n to actual new lines in data pack files.
Windows' MessageBox automatically converts \n to a new line, but
GTK+ doesn't.
BUG=20943
Review URL: http://codereview.chromium.org/196007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also use it if present. Especially use its new xml suppression record
if present, which is more correct than the one we synthesize.
Also fix a warning about global use before declare in memcheck_analyze.py.
Review URL: http://codereview.chromium.org/191006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25353 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=21010
TEST=Happier valgrind bots
Review URL: http://codereview.chromium.org/201006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25352 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
when running the RenderView unit tests. The tests create a RenderView object using the default constructor of RendererPreferences. The uninitialized values are then passed through to WebKit to set the focus ring color.
BUG=20964
TEST=Covered by valgrinding unit tests.
Review URL: http://codereview.chromium.org/194009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25343 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=20997
TEST=Mac UI valgrind bots may actually go green
Review URL: http://codereview.chromium.org/201004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=20941
TEST=none
TBR=hclam
Review URL: http://codereview.chromium.org/198005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25310 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This should help building in UNICODE (but there might be other problems).
Review URL: http://codereview.chromium.org/194011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25308 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=20964
TEST=none
TBR=estade
Review URL: http://codereview.chromium.org/192006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25307 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=20964
TEST=none
TBR=estade
Review URL: http://codereview.chromium.org/192005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25304 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix a Mac valgrind exception and widen another a bit.
Add two new exceptions for issues that popped up on the Linux bots.
BUG=20653,20939,20941
TEST=Watch the valgrind bots. Be soothed by green.
Review URL: http://codereview.chromium.org/189009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25275 0039d316-1c4b-4281-b951-d872f2087c98
|