| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/22923
Review URL: http://codereview.chromium.org/455006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33308 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
net_unittests
TBR=dank
TEST=TSAN Mac bot should become ~20% faster on net_unittests
Review URL: http://codereview.chromium.org/443020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33210 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) Added the link to the ignore files documentation
2) Fixed a typo
3) Used new "fun_r" instead of "fun" for a couple of functions to speed up some large tests from net_, unit_ and ui_.
4) Used new "fun_hist" for unibrow namespace to do coarser history tracking - bottleneck on unit_.
Please see http://code.google.com/p/data-race-test/wiki/ThreadSanitizerIgnores
for the details of new ignore rules. They are present since the new TSAN version (rev1274)
TBR=dank
TEST=TSAN bots should remain green AND become faster.
Review URL: http://codereview.chromium.org/441028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33203 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/399073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=atwilson
BUG=28847
TEST=none
Review URL: http://codereview.chromium.org/434111
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33199 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=jorlow
BUG=11838
TEST=none
Review URL: http://codereview.chromium.org/437086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33195 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=stuartmorgan
BUG=28824
TEST=none
Review URL: http://codereview.chromium.org/443018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33194 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBT=atwilson
BUG=28847
TEST=none
Review URL: http://codereview.chromium.org/444013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33191 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=atwilson
BUG=28847
TEST=none
Review URL: http://codereview.chromium.org/443016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33181 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When releasing the lock, I incorrectly set the thread owner for the lock
to the current thread, rather than resetting it to zero. The result is that
some number of stacks were not being recorded into the stack map (because
the recursion blocking logic aborted the attempt to gather the lock).
If I ever do a recursive acquisition (i.e., my logic is faulty), then
an assertion will fire in the Acquire() for the lock. This in turn
guarantees that when I Release() the lock, it was not a (windows
allowed) recursive acquisition of the lock, and hence the
thread owning the lock should indeed be zeroed.
r=mbelshe
Review URL: http://codereview.chromium.org/443009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=28824
TEST=none
Review URL: http://codereview.chromium.org/435051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33138 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
r33010 enabled tcmalloc by default on Linux, which
gives a startup speedup of ~30 ms.
BUG=none
TEST=linux startup test is green
Review URL: http://codereview.chromium.org/432024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33106 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=valgrind bots don't complain about line 393 of suppressions.txt
Review URL: http://codereview.chromium.org/434078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=28765
TBR=dank,willchan
TEST=TSAN bots should stop skipping all tests
Review URL: http://codereview.chromium.org/434072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33058 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/28765
Review URL: http://codereview.chromium.org/441010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33045 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/28149
Review URL: http://codereview.chromium.org/434069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/28149
Review URL: http://codereview.chromium.org/440014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33027 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This change also reworks the tcmalloc dependency to be added only to chrome and test_shell, instead of base. This is necessary since otherwise tcmalloc will be double initialized (by both the main executable and dlopen'd shared objects like the npapitestplugin.so).
Add valgrind suppressions. This are invalid reads on static initialization in the VDSOSupport module. I haven't investigated it yet, but I suspect they're benign.
BUG=http://crbug.com/28149, http://crbug.com/28385
Review URL: http://codereview.chromium.org/399081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33010 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Here's the recent report
http://build.chromium.org/buildbot/waterfall/builders/Linux%20Tests%20(tsan)/builds/1084/steps/valgrind%20test:%20unit/logs/stdio
BUG=25913
TBR=dank
TEST=unit should become green under TSAN
Review URL: http://codereview.chromium.org/440010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32981 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
FlipIOBuffer::release() was broken. It called release() on scoped_refptrs which does not decrease refcount, hence it leaked IOBuffers and FlipStreams.
Redo the memory management for FlipSession. Stop using raw pointers in FlipSessionPool to hold onto FlipSession. FlipSessionPool uses scoped_refptr now to track Fli
pSessions. Instead of having FlipSession call Release() on itself, it now calls FlipSessionPool to remove itself from the pool when the tcp connection is closed.
In FlipStreamTest, manually call FlipSessionPool::Remove() since there is no tcp connection event to trigger FlipSession to remove itself.
BUG=http://crbug.com/28493
Review URL: http://codereview.chromium.org/438014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32945 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=ananta
BUG=28662
Review URL: http://codereview.chromium.org/435023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32944 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=levin
BUG=28027
Review URL: http://codereview.chromium.org/434029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=timurrrr
BUG=28633
Review URL: http://codereview.chromium.org/439012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32878 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=valgrind works
BUG=none
Review URL: http://codereview.chromium.org/437014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32836 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Sample reports:
http://build.chromium.org/buildbot/waterfall.fyi/builders/Linux%20Tests%20(tsan%20ui)/builds/208/steps/valgrind%20test%3A%20ui_6/logs/stdio
TEST=TSAN UI bot should become greener
BUG=https://bugs.launchpad.net/ubuntu/+source/glibc/+bug/59449
Review URL: http://codereview.chromium.org/435005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32822 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=OminiboxTest (and a couple of others) were reporting this in valgrind test. They should be gone with this patch.
Review URL: http://codereview.chromium.org/414067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32805 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=28559
TBR=dank
Review URL: http://codereview.chromium.org/434007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=28559
TBR=dank
TEST=TSAN UI bot should become greener
Review URL: http://codereview.chromium.org/437002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32799 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=28943
Review URL: http://codereview.chromium.org/429008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32797 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=28493
Review URL: http://codereview.chromium.org/431006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32782 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=28493
Review URL: http://codereview.chromium.org/431005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32771 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/418050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32769 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=28386
Review URL: http://codereview.chromium.org/418037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32715 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/425008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32711 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
signature I originally put in as we don't care about browser_main
and that other stuff (and it changed), only the tooltip part.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/424008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
suppression.
TBR=dank
BUG=28386
Review URL: http://codereview.chromium.org/418033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32704 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=28396
TBR=dank,stuartmorgan
TEST=ipc_unittests should become green on TSAN bots
Review URL: http://codereview.chromium.org/422006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32682 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This has started firing recently, like
http://build.chromium.org/buildbot/waterfall/builders/Linux%20Tests%20(tsan)/builds/1030/steps/valgrind%20test:%20unit/logs/stdio
BUG=25385
TBR=dank,stuartmorgan
TEST=unit_tests should become green on TSAN bots
Review URL: http://codereview.chromium.org/426001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32665 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I did htis instead of disabling the tests because it seems like it could
affect many different tests and I'd be chasing them down all day :)
+dank because:
The stack trace looks weird because it includes a path on the specific machine.
c++filt de-mangled that part of the symbol into "(anonymous-namespace)".
I hope this doesn't mean the suppression will only work on the specific machine.
TBR=ananta
BUG=28386
TEST=UnloadTest, SharedWorkerTest
Review URL: http://codereview.chromium.org/418023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32660 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
leak. As far as I can tell the first two are bugs in gtk.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/414012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32615 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The primary issue was that OnDestroy didn't change the entangled port
to have its entangled port be none.
A secondary issues that came up is that in very rare circumstances (like a crash
happening early in a worker process), it seemed like it may be possible that one
of the message ports may think it is entangled and the other half may not, so
the Erase method guards against this.
Also, some code was added to verify the internal structure before running code
and after.
BUG=27839
TEST=valgrind on linux running ui tests, specifically WorkerTest.WorkerFastLayoutTests.
Review URL: http://codereview.chromium.org/402106
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32586 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=28279
TEST=none
TBR=stuartmorgan
Review URL: http://codereview.chromium.org/402096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32557 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I cannot repro locally, and the bot logs do not show the suppression
ever firing. Reviewing the specific log, there was a timeout starting
the Chromium subprocess for one test (which failed), I suspect that
the resulting unclean shutdown may be related.
BUG=26964
TEST=valgrind stays green.
Review URL: http://codereview.chromium.org/415002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32542 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/399099
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32516 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
__NSAutoreleaseObject.
This patch was prepared by Alexander Potapenko (cc'ed)
BUG=http://openradar.appspot.com/7396501
TBR=dank,stuartmorgan
Review URL: http://codereview.chromium.org/409002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32510 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=28200
TEST=Tree goes green?
Review URL: http://codereview.chromium.org/402076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32456 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
but we don't care.
BUG=28179
TEST=none
Review URL: http://codereview.chromium.org/404036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32437 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=28179
TEST=valgrind bot goes green.
TBR=tony
Review URL: http://codereview.chromium.org/406008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32432 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=28179
TEST=none
Review URL: http://codereview.chromium.org/406007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32423 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
r32264 causes the linux startup test to appear to
regress. Until the reference build is updated, mark
the current behavior as expected.
BUG=6844
TEST=linux startup perf test goes green
Review URL: http://codereview.chromium.org/403016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32360 0039d316-1c4b-4281-b951-d872f2087c98
|