| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
Also exit with nonzero status if valgrind errors are found in log -- else tree is falsely shown as green.
Review URL: http://codereview.chromium.org/48085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/48081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11907 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42291
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11883 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We'll re-enable them once we fix more serious problems.
One would think that passing --leak-check=no to
valgrind would suppress leak reports, sadly, --xml=yes
forces them on.
Review URL: http://codereview.chromium.org/42183
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11874 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/48035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11813 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/48016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Add suppression for a small filename leak in our logging system
which would be too hard to fix properly.
Review URL: http://codereview.chromium.org/48010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add suppression for libevent oneshot timers; libevent
doesn't provide a way to free unexpired oneshot timers
at exit.
Refer to /usr/lib*/ rather than /usr/lib32, so
suppressions also work on 32 bit systems.
Review URL: http://codereview.chromium.org/46093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11726 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
e.g. during base_unittest's HMACTest.HmacSafeBrowsingResponseTest
Use wildcard to make glibc suppression match on Ubuntu 8.10 as well as 8.04
Review URL: http://codereview.chromium.org/42185
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11714 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/43148
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11590 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Add some more suppressions to the suppressions file. I don't have any errors when running Chromium on my workstation.
Review URL: http://codereview.chromium.org/43129
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11546 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
in Purify script, for convenience.
BUG=7810
TEST=covered by buildbot
Review URL: http://codereview.chromium.org/42082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11463 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Normalize end of file newlines in build/ media/ printing/ testing/ and tools/. All files end in a single newline.
Review URL: http://codereview.chromium.org/43082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11449 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the tree.
I made a small change to grit so we can use our resource ID as the translation ID making it a bit easier to read.
The old locale_settings*.rc files would #include the google_strings.rc or chromium_strings.rc. Instead, I added it to the vcproj file using $(CHROMIUM_BUILD) to grab the right file. This required changing the output names in the grd files.
TBR=deanm
Review URL: http://codereview.chromium.org/39152
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10955 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
tests.
LGTM-ed here: http://codereview.chromium.org/27306/show
(I didn't have my @chromium.org account then)
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
remove one assert as it's not correct
BUG=8298,8299
Review URL: http://codereview.chromium.org/40073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
files from the tree."
Revert "window_ is null during BrowserWindow creation. Assume full screen"
Revert "Move SupportsWindowFeature from BrowserView to Browser so"
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10814 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the tree.
I made a small change to grit so we can use our resource ID as the translation ID making it a bit easier to read.
I also used a script to convert the existing .rc files to .xtb files.
Review URL: http://codereview.chromium.org/28327
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10809 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This lets the child process exit even if there are errors and causes
the main scons process to identify these errors as build failures.
Review URL: http://codereview.chromium.org/28282
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
systems.
Review URL: http://codereview.chromium.org/27253
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10588 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
platform.
Review URL: http://codereview.chromium.org/28237
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10556 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
LGTMed by Elliot Glaysher.
See http://codereview.chromium.org/27079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10552 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
included in data pack files.
Review URL: http://codereview.chromium.org/28222
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10525 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
bug=8139
Review URL: http://codereview.chromium.org/28225
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10519 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/28218
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10515 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Re-enable the scons code that walks a grd file and adds its dependencies as
build dependencies. This requires that all our dependencies are files in our
source tree (which is what motivated getting rid of the tld data as a
generated resource). I had to fix up the terms of service for this.
Also remove some code that disabled .pak file generation on windows which was
broken because it couldn't find the tld data.
Review URL: http://codereview.chromium.org/28194
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10494 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/27216
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10478 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/27153
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10446 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
for each grit builder. This speeds up the build a bit.
Review URL: http://codereview.chromium.org/27118
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10401 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
it's in the os module, not os.path.
tbr=deanm
Review URL: http://codereview.chromium.org/27114
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10312 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes some linux/mac issues that were pending and fix up the scons build to
expect the file in the grit subdir.
BUG=7537
Review URL: http://codereview.chromium.org/28035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10306 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the headers too.
Review URL: http://codereview.chromium.org/21472
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10167 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
are occasionally hanging and can't be killed.
TBR=erikkay
BUG=7834
TEST=none
Review URL: http://codereview.chromium.org/27039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10156 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The previous startup-off2.json didn't have stack traces. It was also quite large, it was unfiltered and contained every single system call event.
Include a program to filter a JSON data set to only include events that took a worthwhile amount of time. This greatly reduces the size of the JSON data.
A new filtered JSON dataset startup-release.json is included, much smaller and with stack traces.
Added an ignore for checkdeps on traceline/.
Review URL: http://codereview.chromium.org/20535
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10094 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This imports both the hook / event logger (traceline), and the SVG based UI for displaying trace results as a timeline (svgui).
Review URL: http://codereview.chromium.org/20494
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10091 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
based on locale_settings_en-US.rc.
We don't use this anywhere yet, just putting things in place.
- Fix preprocessor defines in grit vcproj files (needs to be defined
everywhere) and update grit_localized_resources.rules to pass the
preprocessor define to grit.
- Add generated .h files to chrome_strings.vcproj so people can ctrl+alt+a
open them.
- Update GRIT so it knows how to substitute [GRITLANGCODE] in strings
to the locale value.
Review URL: http://codereview.chromium.org/20440
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=tony@chromium.org
Review URL: http://codereview.chromium.org/20428
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=tony@chromium.org
Review URL: http://codereview.chromium.org/20422
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9880 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
We were trying to include all resources, even those hidden behind an
preprocessor #if.
Review URL: http://codereview.chromium.org/20311
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9680 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- fix scons dependencies by adding a target for grit/theme_resources.h
- fix mac build by adding grit to unittest include path
- fix check deps by adding rules for /grit dir.
Create a chrome_resources.vcproj that holds grd files that hold
non-string resources. Put browser_resources.grd into this vcproj.
Port theme_resources.rc/theme_resources.h to theme_resources.grd
and put it in the vcproj too.
I did a find/replace on the theme_resources include line.
Modify grit so header files go in grit_generated_resources/grit/
so the include path can be cleaner. I'll migrate the others
in follow up patches.
theme_resources.rc had a conditional include of distribution_resources.rc
so I had to add support for preprocessor defines to visual studio.
Review URL: http://codereview.chromium.org/24011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit r9631.
TBR=deanm
Review URL: http://codereview.chromium.org/23023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9634 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
non-string resources. Put browser_resources.grd into this vcproj.
Port theme_resources.rc/theme_resources.h to theme_resources.grd
and put it in the vcproj too.
I did a find/replace on the theme_resources include line.
Modify grit so header files go in grit_generated_resources/grit/
so the include path can be cleaner. I'll migrate the others
in follow up patches.
theme_resources.rc had a conditional include of distribution_resources.rc
so I had to add support for preprocessor defines to visual studio.
Review URL: http://codereview.chromium.org/20247
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
file in the report dir.
Review URL: http://codereview.chromium.org/20166
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9590 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
layout tests.
Change layout tests to mark builder as orange on failure (BUG=7516).
Review URL: http://codereview.chromium.org/21161
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9589 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
doesn't kill us when we're taking a long time. Also clean up the subprocess wait loop.
BUG=7514
Review URL: http://codereview.chromium.org/20165
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9588 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
GRIT is not thread safe, we shouldn't be running multiple copies at one time. This is causing the header files to have duplicates when it shouldn't.
I also removed some code in build.py which tried to prevent an identical regenerated header file from being used (so stuff doesn't rebuild unnecessarily). This code isn't necessary for our build since VS/xcode/scons handles the dependency for us (i.e., this isn't a blanket prebuild step).
Review URL: http://codereview.chromium.org/21191
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9488 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I removed the flatten_html visual studio rule and just rolled the
functionality directly into GRIT.
The sln change is to have browser depend on browser_resources (now needed for browser_resources.h).
Review URL: http://codereview.chromium.org/21148
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9418 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
that had a filename match of blocksort.c stopped working. To get it to work I had to change it to *\blocksort.c.
TBR=none
Review URL: http://codereview.chromium.org/20167
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9377 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
together (kind of like the windows RES builder).
I also moved the GRIT builder into the chromium site_scons since we
import it in lots of places. This seems cleaner.
Review URL: http://codereview.chromium.org/21115
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9331 0039d316-1c4b-4281-b951-d872f2087c98
|