| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
These suppressions don't match anything on the bot since r66071
BUG=61585,61753
TBR=glider
TEST=TSan/UI remains green
Review URL: http://codereview.chromium.org/5008001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66119 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=glider
Review URL: http://codereview.chromium.org/4970001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66063 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=62943
TEST=Heapchecker goes green?
TBR=noelutz
Review URL: http://codereview.chromium.org/4963001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66048 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=46161
TEST=none
TBR=timurrrr
Review URL: http://codereview.chromium.org/4962001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66047 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=63024
TEST=none
Review URL: http://codereview.chromium.org/4890003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66021 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=63015
TEST=none
TBR=dglazkov
Review URL: http://codereview.chromium.org/4913001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65993 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=62943
TEST=Heapchecker goes green
TBR=noelutz
Review URL: http://codereview.chromium.org/4895002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65992 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
race in CookieMonster Histogram handling
For the first race, the reports look like this:
WARNING: Possible data race during write of size 4 at 0080F90C: {{{
T26 (L{}):
#0 base::subtle::NoBarrier_Store base/atomicops_internals_x86_msvc.h:67
#1 base::ThreadCollisionWarner::Leave base/thread_collision_warner.cc:60
...
Concurrent write(s) happened at (OR AFTER) these points:
T27 (L{}):
#0 base::subtle::NoBarrier_Store base/atomicops_internals_x86_msvc.h:66
#1 base::ThreadCollisionWarner::Leave base/thread_collision_warner.cc:60
And the code is:
void ThreadCollisionWarner::Leave() {
if (subtle::Barrier_AtomicIncrement(&counter_, -1) == 0) {
subtle::NoBarrier_Store(&valid_thread_id_, 0);
}
}
TBR=glider
BUG=62694
Review URL: http://codereview.chromium.org/4837004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65941 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
safe_browsing::ClientSideDetectionService::StartClientReportPhishingRequest
BUG=62943
TBR=glider
TEST=./tools/valgrind/waterfall.sh says they are all suppressed
Review URL: http://codereview.chromium.org/4890001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65932 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
AutomatedUITestBase.OpenCloseBrowserWindowWithAccelerator)
Suppress bug 62801 (invalid read in PR_Lock)
TBR=timurrrr
BUG=57949,62801
Review URL: http://codereview.chromium.org/4802001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65788 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
It has all sorts of +x files. We'll just be careful.
Review URL: http://codereview.chromium.org/4771005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65756 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
suppresion.
TEST=mac_valgrind
BUG=58244
Review URL: http://codereview.chromium.org/4755002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
a little too slow
BUG=59642
TBR=rdsmith
Review URL: http://codereview.chromium.org/4646007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65671 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=62461
TBR=glider
Review URL: http://codereview.chromium.org/4747003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65662 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
They account for quite a lot of memory accesses and result in a significant
slowdown on some tests
TBR=glider
TEST=TSan/Win should become faster
Review URL: http://codereview.chromium.org/4643006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65661 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=62674
TBR=glider
Review URL: http://codereview.chromium.org/4639004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65660 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=timurrrr
BUG=50297,58145
Review URL: http://codereview.chromium.org/4644005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65657 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=62511
TBR=glider
Review URL: http://codereview.chromium.org/4708004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65655 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=61753,62461
TBR=glider
TEST=./tools/valgrind/waterfall.sh
Review URL: http://codereview.chromium.org/4651004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65647 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a) Unknown nonzero error codes disappeared after the bot recovery
(it was showing a "Recovered from a BSOD" message)
b) The CookieMonster tests were failing due to slow stl checks in Debug mode.
This should be fixed by r65377 and r65384
BUG=62512,59642
TEST=TSan/Win should remain green
TBR=glider
Review URL: http://codereview.chromium.org/4713003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=timurrrr
Review URL: http://codereview.chromium.org/4734003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65640 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=62505
TEST=mac valgrind
Review URL: http://codereview.chromium.org/4707002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65568 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=glider
BUG=62560
Review URL: http://codereview.chromium.org/4732003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65564 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=62505
TBR=danno
TEST=Heapchecker bot should go green
Review URL: http://codereview.chromium.org/4673005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65561 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=glider
BUG=62512
Review URL: http://codereview.chromium.org/4683009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65538 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=62505
TBR=glider
TEST=./tools/valgrind/waterfall.sh
Review URL: http://codereview.chromium.org/4683008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65533 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
use-after-free's
TBR=glider
BUG=61753,62461
TEST=waterfall.sh shows a dramatic decrease of the number of reports
Review URL: http://codereview.chromium.org/4742001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65531 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=glider
Review URL: http://codereview.chromium.org/4722002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65525 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=62461
TBR=glider
Review URL: http://codereview.chromium.org/4738002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
By checking the source code of gtk+-2.12.x, I believe it's a bug of gtk
and should already be fixed in recent version.
See the source code of gtk+-2.12.9: http://git.gnome.org/browse/gtk+/tree/gtk/gtkimmulticontext.c?id=GTK_2_12_9#n230
global_context_id is allocated in _gtk_im_module_get_default_context_id() by calling g_strdup(), but it never gets freed.
In the latest gtk code: http://git.gnome.org/browse/gtk+/tree/gtk/gtkimmodule.c?id=2.20.1#n663
_gtk_im_module_get_default_context_id() just returns a pointer to a string literal instead of a duplicated string.
BUG=61685
TEST=none
Review URL: http://codereview.chromium.org/4715002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65441 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
According to the comment in the reverse-engineered header, the returned arrays are allocated by the function, which would mean the client is responsible for freeing them.
BUG=None
TEST=Greener valgrind bots.
Review URL: http://codereview.chromium.org/4545002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=62346
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65380 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=62314
TBR=glider
Review URL: http://codereview.chromium.org/4682001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65370 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=62314
TEST=Valgrind&TSan mac bots should go green
TBR=glider
Review URL: http://codereview.chromium.org/4675001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65359 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TEST=TSan bots on the memory waterfall should remain green
Review URL: http://codereview.chromium.org/4671001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=62314
TBR=glider
TEST=Valgrind&TSan Mac bots should go green
Review URL: http://codereview.chromium.org/4670001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65356 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- total_op_b went up around r65182, bug for that
is 62272
- total_byte_r and total_byte_b went up around r64763,
bug for that is 62274.
BUG=62272, 62274
TEST=xp perf is green
TBR=nsylvain@chromium.org
Review URL: http://codereview.chromium.org/4652001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65343 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
PersonalDataManager unit test fixed
[Redness was not healed... so I'm reverting the revert]
An early return in the WebDataService was the source of a leak in PersonalDataManagerTest.Refresh test. This fixes it. Also, some small cleanup in the test itself.
BUG=61988
TEST=Memory bots stay green.
Review URL: http://codereview.chromium.org/4612001
TBR=dhollowa@chromium.org
Review URL: http://codereview.chromium.org/4641001
TBR=jar@chromium.org
Review URL: http://codereview.chromium.org/4643001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65330 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
unit test fixed
[There is a lot of red on valgrind now... so trying a revert]
An early return in the WebDataService was the source of a leak in PersonalDataManagerTest.Refresh test. This fixes it. Also, some small cleanup in the test itself.
BUG=61988
TEST=Memory bots stay green.
Review URL: http://codereview.chromium.org/4612001
TBR=dhollowa@chromium.org
Review URL: http://codereview.chromium.org/4641001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65329 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=62078
TEST=heapcheck
Review URL: http://codereview.chromium.org/4584002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65278 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
An early return in the WebDataService was the source of a leak in PersonalDataManagerTest.Refresh test. This fixes it. Also, some small cleanup in the test itself.
BUG=61988
TEST=Memory bots stay green.
Review URL: http://codereview.chromium.org/4612001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65272 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=mattm
BUG=60890
TEST=Greener valgrind bots
Review URL: http://codereview.chromium.org/4518004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=akalin
BUG=62078
TEST=Green heapcheck bot
Review URL: http://codereview.chromium.org/4577002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65209 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=dhollowa
BUG=61988
TEST=Greener valgrind bots
Review URL: http://codereview.chromium.org/4578002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
suppression
BUG=61988
TEST=Memory bots go green.
Review URL: http://codereview.chromium.org/4541001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65143 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(intentional/won't fix).
BUG=61816
TEST=no change
Review URL: http://codereview.chromium.org/4435004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65112 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=thakis
BUG=61929
TEST=Greener valgrind bots
Review URL: http://codereview.chromium.org/4491001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65090 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=61424
TEST=valgrind tests should pass.
Review URL: http://codereview.chromium.org/4104016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=61908
TBR=glider
Review URL: http://codereview.chromium.org/4484001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65056 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
case being renamed
BUG=57832
TBR=garykac
Review URL: http://codereview.chromium.org/4425003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65049 0039d316-1c4b-4281-b951-d872f2087c98
|