summaryrefslogtreecommitdiffstats
path: root/tools
Commit message (Collapse)AuthorAgeFilesLines
* Allocate SocketController lazily.miket@chromium.org2011-12-132-16/+0
| | | | | | | | | | | | | | | | | | | | | | To work around some unit tests that use ExtensionService but don't provide an IO thread that SocketController now needs to completely tear itself down, we allocate SocketController lazily and DCHECK on destruction that there is an IO thread message loop. This is a reasonable compromise for getting the benefit of lifetime management by sticking SocketController in ExtensionService. BTW, aa said putting random crap in ExtensionService wasn't a good idea. Our chickens are coming home to roost. As platform APIs get bigger, we should provide our own dumping ground for these classes, and then callers won't get hung up in surprising lifetime issues like this one. BUG=106969 TEST=existing unit/heap/mem checks should cover us. Verified memcheck behavior manually. Review URL: http://codereview.chromium.org/8925001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114287 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Options2: Pull the trigger."jhawkins@chromium.org2011-12-131-3/+0
| | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 11079a4772dacf7865c3d650b7aa911242bb782e. Revert "Fix build after code changed from underneath." This reverts commit 93b43a2cd246c85ee6159a70223966f5efe2af86. Revert "Moar build fix." This reverts commit bf84b5766d5d05466da641685a1f554786598310. Revert "Fix the fix." This reverts commit 4aecf275ac5c7163483f48ffa2abcfa1481ffd53. R=csilv@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/8937011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114276 0039d316-1c4b-4281-b951-d872f2087c98
* Options2: Pull the trigger.jhawkins@chromium.org2011-12-131-0/+3
| | | | | | | | | | | | Options2 is a copy of the resources for and implementation of chrome://settings that will be pared down significantly for UberPage (see bug). BUG=100885 TEST=none R=csilv Review URL: http://codereview.chromium.org/8895023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114267 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 114236 - Options2: Pull the trigger.jhawkins@chromium.org2011-12-131-3/+0
| | | | | | | | | | | | | BUG=none TEST=none R=csilv Review URL: http://codereview.chromium.org/8895023 TBR=jhawkins@chromium.org Review URL: http://codereview.chromium.org/8930012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114239 0039d316-1c4b-4281-b951-d872f2087c98
* Options2: Pull the trigger.jhawkins@chromium.org2011-12-131-0/+3
| | | | | | | | | | BUG=none TEST=none R=csilv Review URL: http://codereview.chromium.org/8895023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114236 0039d316-1c4b-4281-b951-d872f2087c98
* update suppression for http://crbug.com/96010 until this real bug is fixedbruening@google.com2011-12-131-2/+3
| | | | | | | | | BUG=96010 TEST=Ran Release unit_tests BrowserAboutHandlerTest.WillHandleBrowserAboutURL and confirmed suppression is used and no errors reported; confirmed in Debug by hand with build that disables the DCHECK that kills child before this error is hit Review URL: http://codereview.chromium.org/8935005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114224 0039d316-1c4b-4281-b951-d872f2087c98
* Remove bug_86483a valgrind suppression.shess@chromium.org2011-12-131-13/+0
| | | | | | | | | | | Hasn't fired since October 18, and it should be fixed. BUG=86483 Review URL: http://codereview.chromium.org/8897016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114134 0039d316-1c4b-4281-b951-d872f2087c98
* Removing valgrind suppression for bug 76370.scherkus@chromium.org2011-12-131-12/+0
| | | | | | | | | | | In addition to being unable to repro locally, the stack trace has been incorrect for a while and there are no reports from linux/mac valgrind bots. BUG=76370 TBR=timurrr Review URL: http://codereview.chromium.org/8923018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114130 0039d316-1c4b-4281-b951-d872f2087c98
* chromeos: Update system_api dep to 58d34158.derat@chromium.org2011-12-121-1/+1
| | | | | | | | | | | | | | I'm doing this to pick up a naming change for a not-yet-used D-Bus signal that'll be sent by the power manager ("PowerButtonEvent" becomes "ButtonEvent"). BUG=98328 TEST=ran "gclient sync" TBR=satorux@chromium.org Review URL: http://codereview.chromium.org/8919023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114108 0039d316-1c4b-4281-b951-d872f2087c98
* ThreadSanitizer: Expand one suppression, add another.jhawkins@chromium.org2011-12-121-1/+13
| | | | | | | | | | BUG=100026,107181 TEST=none TBR=vrk Review URL: http://codereview.chromium.org/8920010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114075 0039d316-1c4b-4281-b951-d872f2087c98
* Roll clang 145842:146361thakis@chromium.org2011-12-121-1/+1
| | | | | | | | | | | | New in this roll: ASan! (for mac and linux64 for now) BUG=none TEST=none TBR=hans Review URL: http://codereview.chromium.org/8918007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114055 0039d316-1c4b-4281-b951-d872f2087c98
* Fix supressions for CreateOSCertHandleFromBytesgspencer@chromium.org2011-12-121-1/+1
| | | | | | | | | | | | | | because the call stack changed due to adding a new variation of this function. TBR=wtc@chromium.org BUG=chromium:82974 TEST=none Review URL: http://codereview.chromium.org/8917003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113998 0039d316-1c4b-4281-b951-d872f2087c98
* Valgrind: Suppress an uninitialized mem access injhawkins@chromium.org2011-12-121-0/+26
| | | | | | | | | | | | InlineTextBox::expansionBehavior(). BUG=107179 TEST=none TBR=epoger Review URL: http://codereview.chromium.org/8919001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113992 0039d316-1c4b-4281-b951-d872f2087c98
* Valgrind: Add a suppression for a leak in Skia.jhawkins@chromium.org2011-12-121-1/+27
| | | | | | | | | | BUG=107177 TEST=none TBR=epoger Review URL: http://codereview.chromium.org/8918001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113990 0039d316-1c4b-4281-b951-d872f2087c98
* Update 10.5 intl expectations.thakis@chromium.org2011-12-121-1/+1
| | | | | | | | | | | | I tried to do this in http://codereview.chromium.org/8897020 but failed. See: http://build.chromium.org/f/chromium/perf/mac-release-10.5/intl1/report.html?history=150&rev=113976 TBR=cmp Review URL: http://codereview.chromium.org/8911003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113980 0039d316-1c4b-4281-b951-d872f2087c98
* Valgrind: Add a suppression for new leaks from Skia.jhawkins@chromium.org2011-12-111-0/+25
| | | | | | | | | | BUG=107158 TEST=none TBR=epoger Review URL: http://codereview.chromium.org/8911002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113972 0039d316-1c4b-4281-b951-d872f2087c98
* Valgrind: Add suppression for a new leak in SkCreateCGImageRefWithColorspace.jhawkins@chromium.org2011-12-111-0/+22
| | | | | | | | | | BUG=107154 TEST=none TBR=thestig@chromium.org Review URL: http://codereview.chromium.org/8914004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113971 0039d316-1c4b-4281-b951-d872f2087c98
* Update text expectations to be in line with ↵thakis@chromium.org2011-12-111-1/+1
| | | | | | | | | | http://codereview.chromium.org/8890066 BUG=106966 TBR=cmp Review URL: http://codereview.chromium.org/8910002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113970 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 113966 (updated revision range, but not actual expectations data)thakis@chromium.org2011-12-111-12/+12
| | | | | | | | | | - Update Linux size expectations to recent range of my code addition. Review URL: http://codereview.chromium.org/8913001 TBR=brettw@chromium.org Review URL: http://codereview.chromium.org/8914003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113969 0039d316-1c4b-4281-b951-d872f2087c98
* Valgrind: Add back the suppression for bug 106402 which was unfortunately notjhawkins@chromium.org2011-12-111-0/+10
| | | | | | | | | | | | fixed by r113954. BUG=106402 TEST=none TBR=brettw Review URL: http://codereview.chromium.org/8914002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113968 0039d316-1c4b-4281-b951-d872f2087c98
* Valgrind: Expand the suppression for bug 102255.jhawkins@chromium.org2011-12-111-0/+25
| | | | | | | | | | | | Happening in a new place after a refactoring. BUG=102255 TEST=none TBR=rdsmith Review URL: http://codereview.chromium.org/8914001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113967 0039d316-1c4b-4281-b951-d872f2087c98
* Update Linux size expectations to recent range of my code addition.brettw@chromium.org2011-12-111-12/+12
| | | | | | Review URL: http://codereview.chromium.org/8913001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113966 0039d316-1c4b-4281-b951-d872f2087c98
* Update Linux size expectations.brettw@chromium.org2011-12-113-1/+5
| | | | | | | I added a bunch of pepper code that pushed us over the previous limit. I also added several links to the perf instructions since it took me a while to figure this out. Review URL: http://codereview.chromium.org/8910001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113962 0039d316-1c4b-4281-b951-d872f2087c98
* Always run Flush completion callbacks in Graphics2D.brettw@chromium.org2011-12-101-10/+0
| | | | | | | | | | | | | | | | This fixes a leak because the completion callbacks were not getting run on resource destruction. This leaves the calling code waiting for the callbacks with leaked data associated with the callback. This patch just always runs the callbacks with PP_ERROR_ABORTED. I tweaked the callback code to use the (newer than the original code) "run and clear" completion callback macro which also cleans up the code a little. BUG=106402 Review URL: http://codereview.chromium.org/8801027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113954 0039d316-1c4b-4281-b951-d872f2087c98
* increase number of static initalizers allowed for linux and macestade@chromium.org2011-12-101-2/+2
| | | | | | | | | BUG=107070 TBR=cmp@chromium.org Review URL: http://codereview.chromium.org/8897023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113935 0039d316-1c4b-4281-b951-d872f2087c98
* increase number of static initalizers allowed for linux-64estade@chromium.org2011-12-101-1/+1
| | | | | | | | | BUG=107070 TBR=cmp@chromium.org Review URL: http://codereview.chromium.org/8895021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113934 0039d316-1c4b-4281-b951-d872f2087c98
* Fix cause of uninitialized memory read in ExtensionService unit_testsasargent@chromium.org2011-12-101-6/+0
| | | | | | | | | | | | | | | In crrev.com/113111 I checked in code that reads a app state boolean from an ExtensionSyncData object which is uninitialized. This fixes the initialization for the relevant constructor, and also limits reading that value to only when the extension is an app. BUG=106549 TEST=valgrind run of ExtensionService sync-related unit_tests should come back clean Review URL: http://codereview.chromium.org/8899010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113926 0039d316-1c4b-4281-b951-d872f2087c98
* Update expectations.cmp@chromium.org2011-12-101-1/+1
| | | | | | | | | | | | | Regressions: xp-release-dual-core/intl2/times/t: http://build.chromium.org/f/chromium/perf/xp-release-dual-core/intl2/report.html?history=150&rev=113640 BUG=106888 TBR=nsylvain@chromium.org Review URL: http://codereview.chromium.org/8892008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113897 0039d316-1c4b-4281-b951-d872f2087c98
* Update perf expectations.thakis@chromium.org2011-12-101-4/+4
| | | | | | | | | | | | | | | 3 fewer files with static initializers on linux & mac: http://build.chromium.org/f/chromium/perf/linux-release/sizes/report.html?history=150&rev=-1&graph=chrome-si http://build.chromium.org/f/chromium/perf/linux-release-64/sizes/report.html?history=150&rev=-1&graph=chrome-si http://build.chromium.org/f/chromium/perf/mac-release/sizes/report.html?history=150&rev=-1&graph=chrome-si Much better t on Mac 10.5 Intl1: http://build.chromium.org/f/chromium/perf/mac-release-10.5/intl1/report.html?history=150&rev=-1 TBR=cmp Review URL: http://codereview.chromium.org/8897020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113886 0039d316-1c4b-4281-b951-d872f2087c98
* Remove BrowserAboutHandlerTest.WillHandleBrowserAboutURL suppression.rnk@chromium.org2011-12-091-6/+0
| | | | | | | | | | | | | This suppression is too broad, and I can't reproduce the original stack trace I saw anyway, so let's remove this for now and see if it comes up on the bots. TBR=timurrrr@chromium.org BUG=96010 TEST=drm release bot Review URL: http://codereview.chromium.org/8895005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113844 0039d316-1c4b-4281-b951-d872f2087c98
* Update "sizes" expectations to account for turning on Skia on Macepoger@chromium.org2011-12-091-4/+4
| | | | | | | BUG=106984 Review URL: http://codereview.chromium.org/8899003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113816 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress leaks in ExtensionServiceTestSimple_Enabledness_Test.cbentzel@chromium.org2011-12-092-0/+16
| | | | | | | | | BUG=106969 TBR=miket@chromium.org Review URL: http://codereview.chromium.org/8883045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113790 0039d316-1c4b-4281-b951-d872f2087c98
* Update linux and linux-64 chrome sizes expectations.bashi@chromium.org2011-12-091-2/+2
| | | | | | | | | | | | Recent large increase was r102341. BUG=106966 TEST=None TBR=cmp@chromium.org,tony@chromium.org Review URL: http://codereview.chromium.org/8890066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113778 0039d316-1c4b-4281-b951-d872f2087c98
* Update expectations.cmp@chromium.org2011-12-091-1/+1
| | | | | | | | | | | | Regression: linux-release-lowmem/bloat-http/times/t: http://build.chromium.org/f/chromium/perf/linux-release-lowmem/bloat-http/report.html?history=150&rev=113768 BUG=106888 TBR=nsylvain@chromium.org Review URL: http://codereview.chromium.org/8890064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113773 0039d316-1c4b-4281-b951-d872f2087c98
* linux: Lower static initializer file count by 3.thakis@chromium.org2011-12-091-2/+2
| | | | | | | | | | | http://build.chromium.org/f/chromium/perf/linux-release/sizes/report.html?history=150&rev=113760&graph=chrome-si http://build.chromium.org/f/chromium/perf/linux-release-64/sizes/report.html?history=150&rev=113760&graph=chrome-si BUG=94925 TBR=cmp Review URL: http://codereview.chromium.org/8890062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113764 0039d316-1c4b-4281-b951-d872f2087c98
* Don't initialize NSS before calling SSL_ClearSessionCache.wtc@chromium.org2011-12-092-19/+0
| | | | | | | | | | | | | | | | | | | If NSS is not initialized, conceptually the SSL session cache is empty. So it doesn't make sense to initialize NSS just to clear an empty SSL session cache. Remove the suppression for the leak this CL fixes from suppressions_mac.txt. Widen a related suppression in suppressions.txt to cover this leak. R=mattm@chromium.org,cbentzel@chromium.org BUG=105431,95718 TEST=valgrind bots should not report a leak in SSL_ClearSessionCache. Review URL: http://codereview.chromium.org/8849005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113715 0039d316-1c4b-4281-b951-d872f2087c98
* Delete UDPClientSocket on same thread as creation. Also refactor.miket@chromium.org2011-12-092-22/+0
| | | | | | | | | | | | | | | | I investigated deriving from IOThreadExtensionFunction, but we need access to Profile in the midst of our work. Deriving from UIThreadExtensionFunction appears to be the right way to do that. It's possible that we'll want to address performance issues caused by jumping back and forth between threads, but for now this seems to work well enough. See http://code.google.com/p/chromium/issues/detail?id=106802 for future plans to deal with lifetime more elegantly. Also reapply http://codereview.chromium.org/8819029/, which is what led to this bug/fix. BUG=106656 TEST=no new ones; just refactoring. Review URL: http://codereview.chromium.org/8857004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113710 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress PlatformThread::SetName leak on mac.cbentzel@chromium.org2011-12-081-0/+7
| | | | | | | | | BUG=106912 TBR=jar@chromium.org Review URL: http://codereview.chromium.org/8872042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113685 0039d316-1c4b-4281-b951-d872f2087c98
* Update CrxUpdateService Memcheck::Leak suppression to match new signature.cbentzel@chromium.org2011-12-081-1/+1
| | | | | | | | | BUG=100777 TBR=thestig@chromium.org Review URL: http://codereview.chromium.org/8888029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113675 0039d316-1c4b-4281-b951-d872f2087c98
* chromeos: Update system_api dep to bb9b9a70.derat@chromium.org2011-12-081-1/+1
| | | | | | | | | | | | | This updates the dependency to pick up power_manager::kPowerButtonEventSignal. BUG=98328 TEST=synced and built successfully TBR=satorux@chromium.org Review URL: http://codereview.chromium.org/8889028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113674 0039d316-1c4b-4281-b951-d872f2087c98
* Disable ConnectionTestTest.DeleteWhileInProgress on heapcheck.cbentzel@chromium.org2011-12-081-0/+3
| | | | | | | | | BUG=88221 TBR=wtc@chromium.org Review URL: http://codereview.chromium.org/8872039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113673 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for configs where the Chrome checkout is under user's home directory (in ↵joi@chromium.org2011-12-081-3/+11
| | | | | | | | | | which case buffer-file-truename returns a path starting with ~). BUG=none Review URL: http://codereview.chromium.org/8872013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113664 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable BrowserMainTest.WarmConnectionFieldTrial_WarmestSocketstevenjb@chromium.org2011-12-081-3/+0
| | | | | | | | | | BUG=105335 TEST=Watch heapcheck for failures in BrowserMainTest.WarmConnectionFieldTrial_WarmestSocket Review URL: http://codereview.chromium.org/8883006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113654 0039d316-1c4b-4281-b951-d872f2087c98
* Isolates generic DnsClient from AsyncHostResolver. szym@chromium.org2011-12-082-6/+0
| | | | | | | | | | | | | | | | | | | | | DnsClient provides a generic DNS client that allows fetching resource records. DnsClient is very lightweight and does not support aggregation, queuing or prioritization of requests. This is the first CL in a series to merge AsyncHostResolver into HostResolverImpl. Also introduces general-purpose BigEndianReader/Writer. Removes DnsTransactionTest-related suppressions. BUG=90881,80225,106688 TEST=./net_unittests Review URL: http://codereview.chromium.org/8852009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113640 0039d316-1c4b-4281-b951-d872f2087c98
* Update memcheck suppressions to match NavigationController::LoadURL ↵cbentzel@chromium.org2011-12-081-2/+2
| | | | | | | | | | | signature change. BUG=101335,104998 TBR=jochen@chromium.org Review URL: http://codereview.chromium.org/8888016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113627 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress CandidateWindowViewTest_MozcUpdateCandidateTest_Test leaks.cbentzel@chromium.org2011-12-081-0/+17
| | | | | | | | | BUG=106850 TBR=nona@chromium.org Review URL: http://codereview.chromium.org/8889015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113605 0039d316-1c4b-4281-b951-d872f2087c98
* Fix tsan_rv as it was broken due to recent "testcase" failurestimurrrr@chromium.org2011-12-082-1/+1
| | | | | | | | It was failing with a "_cur_testcase not defined" error. TBR=eugenis Review URL: http://codereview.chromium.org/8872016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113598 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a typo in the excluded test nametimurrrr@chromium.org2011-12-081-4/+4
| | | | | | | | | Also, improve the comment and add a link to the bug BUG=106829 TBR=cbentzel Review URL: http://codereview.chromium.org/8889006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113587 0039d316-1c4b-4281-b951-d872f2087c98
* clang packaging script: Build compiler-rt, package ASan.thakis@chromium.org2011-12-082-0/+18
| | | | | | | | | | | | This has no effect until the next clang roll. On linux, only 64bit is supported for now. BUG=none TEST=`clang -faddress-sanitizier test.c` works. Running the generated a.out reports memory errors if test.c contained any. TBR=kcc Review URL: http://codereview.chromium.org/8852008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113546 0039d316-1c4b-4281-b951-d872f2087c98
* Exclude SamplingProfileTest.Sample from win valgrind bots.cbentzel@chromium.org2011-12-081-0/+5
| | | | | | | | | | | This test makes assumptions that the native code will run, which is at odds with how valgrind works. BUG=None TBR=siggi@chromium.org Review URL: http://codereview.chromium.org/8882001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113517 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 17:58:42 +0000