| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
We leaked the SpdySessionPool and SpdySession in the test since they have a circular reference.
This is usually broken by a GOAWAY frame in real code, but we have to manually break the circular reference here.
BUG=42084
Review URL: http://codereview.chromium.org/1695001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45198 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DownloadTest.CloseNewTab2 is failing (ASSERT failure, not memory leak) under valgrind because of a timeout.
This patch increases the sleep timeout for UI tests to the same value as the action timeout (when running the test normally, the default value for the sleep timeout is also the action timeout).
BUG=none
TEST=DownloadTest.CloseNewTab2 (run under valgrind)
Review URL: http://codereview.chromium.org/1725003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45183 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=glider
Review URL: http://codereview.chromium.org/1729004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45182 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=42185
Review URL: http://codereview.chromium.org/1756001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45176 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=42153
TEST=make heapcheck bots green.
Review URL: http://codereview.chromium.org/1694002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=mmoss
BUG=42084
TEST=none
Review URL: http://codereview.chromium.org/1697001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45051 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=tvl
Review URL: http://codereview.chromium.org/1520043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45036 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=tvl
Review URL: http://codereview.chromium.org/1681001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add the pattern for the mac leak.
Add the pattern for the linux leak.
TBR=mmoss
TEST=none
BUG=42084
Review URL: http://codereview.chromium.org/1677003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45030 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Contributed by Hans Wennborg <hans@chromium.org>.
BUG=41695
TEST=Ran the script from different dirs to cover all paths through affected code.
Review URL: http://codereview.chromium.org/1582033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44921 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Modify the license script to have a "credits" mode, which uses
two templates derived from the existing about:credits HTML.
BUG=39240
Review URL: http://codereview.chromium.org/1520039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44863 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=glider
Review URL: http://codereview.chromium.org/1662002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44782 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=valgrind bots more green
R=jochen@chromium.org
Review URL: http://codereview.chromium.org/1508038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44758 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
These 2 were generating false positives and negatives.
BUG=none
TEST=intl1 and dhtml remain green
TBR=nsylvain@chromium.org
Review URL: http://codereview.chromium.org/1566046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44703 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=28386
TEST=valgrind tests passes
Review URL: http://codereview.chromium.org/1527034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44701 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We're now down to only 4 dirs that don't pass the license checker.
They will require separate changes.
Modify the license checker to only print failing dirs.
BUG=39240
Review URL: http://codereview.chromium.org/1530040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44656 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=40429
Review URL: http://codereview.chromium.org/1551031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44576 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
suppression for code that no longer exists.
BUG=none
TEST=no memcheck changes
Review URL: http://codereview.chromium.org/1572039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44573 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
My first chrome patch :) --
Data race on boole in chrome/browser/sync/engine/syncer.cc
Fix uses Lock class to avoid any compiler/hardware optimizations.
BUG=37408
TEST=Ran Valgrind/ThreadSanitizer
Original Patch by raz@chromium.org
http://codereview.chromium.org/1621010
Review URL: http://codereview.chromium.org/1518023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44558 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=41343
TEST=vista intl* is green
TBR=nsylvain@chromium.org
Review URL: http://codereview.chromium.org/1559031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44557 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=pinkerton
BUG=none
TEST=Mac valgrind bots
Review URL: http://codereview.chromium.org/1513040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44554 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=36799
TEST=mac 10.6 tests are green
Review URL: http://codereview.chromium.org/1613017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44503 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=41485
TEST=linux startup perf is green
TBR=nsylvain@chromium.org
Review URL: http://codereview.chromium.org/1525033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44494 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Recently the tarball got approx. 2x bigger because of that.
TBR=nsylvain
TEST=none
BUG=29044
Review URL: http://codereview.chromium.org/1545036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44458 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
isn't completely fixed yet.
TBR=jrg@chromium.org
BUG=40429
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(e.g. fire and forget). As implemented on the Mac, the termination
chain (e.g. when OK is pressed) is to call [NSApp endSheet:].
didEndSheet then closes the window, and the controller (set as the
delegate of the window) gets a windowWillClose: callback (so the
controller knows to delete itself).
The problem here was that the window was ordered out (offscreen) but
not actually closed, so we didn't clean up properly.
BUG=40429
TEST=no valgrind suppression needed and unit_tests stay happy.
nib change: window controller (file's owner) is the delegate of the window
(for both nibs)
Review URL: http://codereview.chromium.org/1654003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44383 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=xpdual moz step is green
TBR=nsylvain@chromium.org
Review URL: http://codereview.chromium.org/1613014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44376 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The leaking code has been removed so the leak is gone.
BUG=33427
TEST=Valgrind should be green.
TBR=sky
Review URL: http://codereview.chromium.org/1627020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44371 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=jrg,aa
BUG=40429
TEST=Mac Valgrind goes green
Review URL: http://codereview.chromium.org/1633010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44358 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts r44299.
BUG=none
TEST=perf steps return to normal
TBR=nsylvain@chromium.org
Review URL: http://codereview.chromium.org/1625012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44353 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=perf steps are green
Review URL: http://codereview.chromium.org/1582025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44299 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44287 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=41186
TEST=none
TBR=skrul@chromium.org,akalin@chromium.org
Review URL: http://codereview.chromium.org/1623010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44257 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=41177
TEST=none
TBR=senorblanco@chromium.org,gregspencer@chromium.org
Review URL: http://codereview.chromium.org/1623009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44252 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=40505
TEST=existing test under valgrind.
Review URL: http://codereview.chromium.org/1589028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44175 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=linux perf page_cycler_dhtml is green
TBR=nsylvain@chromium.org
Review URL: http://codereview.chromium.org/1539029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1561020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=40879
TEST=greener Mac UI Valgrind
TBR=viettrungluu@chromium.org, stuartmorgan@chromium.org
Review URL: http://codereview.chromium.org/1612012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44030 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=40877
TEST=greener valgrind unit_tests
TBR=viettrungluu@chromium.org, stuartmorgan@chromium.org
Review URL: http://codereview.chromium.org/1602014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44025 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
I'm working on addressing that separately, but in the meantime,
the webkit train must keep rolling.
Review URL: http://codereview.chromium.org/1560022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44007 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reverts r43973. Found some good stuff to take a closer
look at.
BUG=none
TEST=perf steps behave normally
TBR=nsylvain@chromium.org
Review URL: http://codereview.chromium.org/1525020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43981 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=test steps are green
TBR=nsylvain@chromium.org
Review URL: http://codereview.chromium.org/1605019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43973 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=25385
TBR=glider
Review URL: http://codereview.chromium.org/1540023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43941 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=23423
TBR=glider
Review URL: http://codereview.chromium.org/1630009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43938 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
caps, numbers and underscores.
BUG=37254
Review URL: http://codereview.chromium.org/1527013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a chromium build, this should produce no output. For official
builds, we print warnings about untranslated strings.
This is the first step in trying to have grit produce useful
warning messages.
BUG=39417
Review URL: http://codereview.chromium.org/1518018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43900 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. Adds unit test for BoundsAnimator and SlideAnimation.
. Fixes leak in BoundsAnimator.
. Fixes possibility of deleting delegate twice.
. Makes sure delegate is notified when new animation is set for view.
. Fixes crashes in TabStrip that resulted from dragging a tab back in.
BUG=40475
TEST=make sure dragging tabs out/in to a tabstrip doesn't cause
problems.
Review URL: http://codereview.chromium.org/1585020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43864 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=40661
TEST=none
Review URL: http://codereview.chromium.org/1609010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43843 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
CrxInstaller::CompleteInstall
BUG=40659
TEST=none
Review URL: http://codereview.chromium.org/1508024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43842 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
tests. They're failing frequently.
BUG=40587
TEST=None
TBR=arv@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43769 0039d316-1c4b-4281-b951-d872f2087c98
|