| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
TBR=nduca@chromium.org
BUG=
Review URL: https://codereview.chromium.org/322553003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275541 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
content_browsertests (https://codereview.chromium.org/322463004/)
Reason for revert:
Should no longer be needed.
Original issue's description:
> suppress uninit error at SkUnPreMultiply::PMColorToColor in content_browsertests
>
> BUG=380680
> TBR=reed@google.com
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275306
TBR=reed@google.com,zhaoqin@google.com
NOTREECHECKS=true
NOTRY=true
BUG=380680
Review URL: https://codereview.chromium.org/324513004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275521 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The previous code made it possible to try to access tabs prior to the session
restore completing. This should make the benchmark much more deterministic.
BUG=375979
Review URL: https://codereview.chromium.org/313923003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275509 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
API Proposal http://goo.gl/V7xcu3
BUG=374383
R=binji@chromium.org, dmichael@chromium.org, mpearson@chromium.org, piman@chromium.org, raymes@chromium.org, yzshen@chromium.org
Review URL: https://codereview.chromium.org/292523003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275490 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Change PerformActionAndWaitForNavigate to WaitForNavigate.
BUG=361809
Review URL: https://codereview.chromium.org/317913003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275487 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/307333003/)
Reason for revert:
Still referenced from blink
Original issue's description:
> Remove now obsolete checkdeps copy
>
> BUG=none
> R=brettw@chromium.org
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275419
TBR=brettw@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=none
Review URL: https://codereview.chromium.org/320043002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275482 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=381742
TBR=tonyg@chromium.org
NOTRY=true
NOTREECHECKS=true
Review URL: https://codereview.chromium.org/320013002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275476 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, this benchmark required a separate profile generation step as wel
as arguments. This isn't a Telemetric way to write a benchmark. Now, if a
profile isn't given, it generates the correct profile for the benchmark.
BUG=
Review URL: https://codereview.chromium.org/317733002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275458 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Unfortunately, TSan doesn't handle operator(), neither does the PRESUBMIT script.
We're going to deprecate v1 soon, so it doesn't worth fixing.
TBR=bruening@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/320593002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275448 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=381584,344704
TBR=bruening@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/319943002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275424 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
R=brettw@chromium.org
Review URL: https://codereview.chromium.org/307333003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275419 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It times out.
TBR=dtu@chromium.org
NOTRY=True
BUG=
Review URL: https://codereview.chromium.org/321483005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275416 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The unit test was unfortunately written in a way that didn't catch it.
BUG=376793
R=pasko@chromium.org
Review URL: https://codereview.chromium.org/319053004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This optional property indicates the reason why this BookmarkTreeNode can't
be modified by the user nor the extension. For now the only value defined is
"managed", indicating that this bookmark was configured by the system
administrator.
If the property is not present then the bookmark is modifiable (default).
BUG=49598
R=kalman@chromium.org
Review URL: https://codereview.chromium.org/320473002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=dtu@chromium.org
Review URL: https://codereview.chromium.org/317273002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275377 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'm tired of copy/pasting the wrong style :)
http://www.chromium.org/developers/coding-style#TOC-File-headers
BUG=
Review URL: https://codereview.chromium.org/319813004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275374 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes:
- Update the copy of the string that describes giving Chrome access to the
user's Address Book.
- When the user selects the option to pull autofill suggestions from the
Address Book, Chrome immediately prompts the user for permission to use the
Address Book. I considered delaying the prompt until the option screen is
dismissed, but that works less because there are too many ways to dismiss the
screen that cause the prompt to appear contextless. (e.g. The user
performs a history navigation).
- Add a resource for the Contacts icon for the autofill entry.
- Add metrics for the autofill entry that suggests that the user give Chrome
access to the Address Book.
- The pref for auxiliary profiles should default to NO on mac, and should not
be syncable.
- Update the logic in PersonalDataManagerMac to reflect the new default state
of the pref.
- Update layout logic of the autofill entry to move the text up by 1 pt, to
better account for the weighting of the Contacts icon asset.
BUG=139154
Review URL: https://codereview.chromium.org/301343002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/313993003/)
Reason for revert:
Other patches need to land before this. This broke bots.
Original issue's description:
> [Telemetry] Overhaul startup metric.
>
> This focuses us on the user-perceived aspects of startup.
>
> BUG=
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275194
TBR=aiolos@chromium.org,jeremy@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/317743003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275345 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) BeginInteraction+EndInteraction becomes
interaction = action_runner.BeginInteraction(...)
interaction.End()
2) Add action_runner.ExecuteJavaScript.
3) Replaced all existing use cases.
Other cleanups:
1) s/JavascriptAction/JavaScriptAction/
2) s/GetJavascriptMarker/GetJavaScriptMarker/
BUG=361809
Review URL: https://codereview.chromium.org/313383002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275341 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
DownloadRequestTimeoutDuration histograms.
BUG=378911
Review URL: https://codereview.chromium.org/303123006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=381374
Review URL: https://codereview.chromium.org/317153003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275321 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=380680
TBR=reed@google.com
Review URL: https://codereview.chromium.org/322463004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275306 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=381180
Review URL: https://codereview.chromium.org/314263002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275304 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=378064
Review URL: https://codereview.chromium.org/312043003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275302 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=371692
Review URL: https://codereview.chromium.org/304793002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275260 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=322664
Review URL: https://codereview.chromium.org/319493007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275252 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It now works when flash is disabled, previously it hung.
PERF SHERIFFS: This will change results on benchmarks that use typical_25.
BUG=
TBR=dtu@chromium.org
NOTRY=True
Review URL: https://codereview.chromium.org/313373002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275251 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This happens to work correctly even if it's uninitialized, but it was causing an MSan error.
BUG=376814
TBR=piman@chromium.org
Review URL: https://codereview.chromium.org/319603002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275238 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=nduca@chromium.org
BUG=
Review URL: https://codereview.chromium.org/318843005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275221 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
To support cross-compiling, the the rule needs to be prefixed by the toolchain name. This was missing in this case.
BUG=
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/314053004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275217 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This additionally has the following patch checked in:
https://codereview.chromium.org/314053004/
which fixes the V8 build with this new version.
Updates the freetype2 build file to account for the new escaping rules.
R=scottmg@chromium.org
TBR=scottmg
Review URL: https://codereview.chromium.org/317053004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275215 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=381233
TBR=eugenis@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/315233003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275195 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This focuses us on the user-perceived aspects of startup.
BUG=
Review URL: https://codereview.chromium.org/313993003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275194 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
VideoCaptureDeviceTest::OpenInvalidDevice QTKit
TBR=timurrrr@chromium.org
NOTRY=true
BUG=380568
Review URL: https://codereview.chromium.org/314013006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275182 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This extracts various parts of paths, like get_label_info does for labels.
BUG=
Review URL: https://codereview.chromium.org/316623004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes Windows escaping more correct and handles Posix shell characters better as well. Now there are completely different codepaths for Windows and Posix escaping.
I removed JSON escaping since this is no longer needed now that we no longer write GYP files.
I no longer have a separate SHELL and NINJA modes. Instead, I have pure NINJA mode for writing file names for Ninja to interpret, and NINKA_FORK mode which does NINJA escaping plus the correct platform-specific rules for the method Ninja uses for running build steps on the current system.
Includes used to always be quoted ("-I../..") which was ugly. Now they're not quoted unless necessary (which is almost never). If it requires quoting, it will do -I"foo bar" which looks a bit odd but saves a bunch of special casing in the output code.
Previously defines weren't quoted at all. Now they work like include dirs.
Removed the convert_slashes flag on PathOutput which is no longer used.
Removed some backslash special-casing in the unit tests on Windows. These are no longer necessary since we changed path output on Windows to use forward-slashes.
Fix base's StackString on GCC. Previously this was only used on Windows-specific code.
Fix mesa Windows GN build.
BUG=358764
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/311733002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275174 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=380968
TEST="gn_unittests --gtest_filter=BuilderTest.BasicDeps --gtest_repeat=50" on OpenBSD
Review URL: https://codereview.chromium.org/311263002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275171 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=381156
TBR=bruening@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/317823004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275170 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I believe it was disabled because the clear_system_cache binary wasn't checked
into cloud storage yet. It is now.
BUG=325479
Review URL: https://codereview.chromium.org/311053006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=128664
R=maruel@chromium.org
Review URL: https://codereview.chromium.org/311353002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275147 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=99191
R=maruel@chromium.org
Review URL: https://codereview.chromium.org/318863006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275146 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change replaces constructors with Create() methods of
ChannelProxy and SyncChannel. This open the possibility to introduce
polymorphism to these classes.
This is a revision of r274310 (https://codereview.chromium.org/301973003/)
in which I added bunch of Create*() method variants.
The chagne was reverted. This change no longer does it and just keeps
using Channel::Mode to specify the channel type.
TEST=none
BUG=377980
R=darin@chromium.org,jam@chromium.org
Review URL: https://codereview.chromium.org/310853003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=357693
Review URL: https://codereview.chromium.org/308053015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275133 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds the following metrics to UMAs:
- Reuse count of the cache entry, at cache hit
- Reuse count of the cache entry, at eviction
- Cache hit / miss count
For web fonts served by Google Fonts. Histograms are suffixed with
font names: "roboto", "opensans", or "others".
BUG=379670
Review URL: https://codereview.chromium.org/298273007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275108 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=380568
Review URL: https://codereview.chromium.org/313943002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275099 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=bungeman@chromium.org
BUG=346842
Review URL: https://codereview.chromium.org/317803007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is used to make the order of functions not depend on thread-scheduling
which can be greatly impacted when profiling is done with cygprofile.
As a result each thread has its own contiguous segment of code (ordered by
timestamp) and processes also have their code isolated (i.e. not interleaved).
BUG=372323
R=pasko@chromium.org
Review URL: https://codereview.chromium.org/281093002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=381065,266484
TBR=bruening@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/318913003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275056 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of just throwing away everything if the user presses
Ctrl-c, write down whatever data we have to the disk. By asking for
the largest symbols first, it's sometimes possible to get a quite
good picture after only 10-15% of the total runtime.
BUG=377466
Review URL: https://codereview.chromium.org/305503002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275053 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This refactors cygprofile.cc by:
- Removing unnecessary uses of pthread_self().
- Splitting the CygTlsLog class into two pieces: ThreadLog and
ThreadLogsManager. ThreadLog is the per-thread trace log while
ThreadLogsManager is the global instance that manages individual trace logs
and handles flushing through its internal thread.
- Encapsulating more state (e.g. the vector of trace logs).
- Minimizing global state by removing the CygCommon class.
- Enforcing immutability in various places which allows more type-safety and
less locking in particular.
- Sanitizing locking mechanisms: |ThreadLogsManager::lock_| and
|ThreadLog::lock_| are now never acquired at the same time and critical
sections are shortened to avoid subtle lock interactions.
- Flushing only from the background flush thread to mitigate the observer
effect.
This also drops support for non-Android platforms since it was randomly
deadlocking at best. See the detailed comment at the top of cygprofile.h for
more information.
Additionally this introduces cygprofile.h which exposes the necessary bits for
the new unit tests added in cygprofile_unittest.cc.
BUG=372323
R=pasko@chromium.org
Review URL: https://codereview.chromium.org/296793004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275045 0039d316-1c4b-4281-b951-d872f2087c98
|