summaryrefslogtreecommitdiffstats
path: root/tools
Commit message (Collapse)AuthorAgeFilesLines
* Re-Retry. This is the change from hell.glen@chromium.org2009-06-061-0/+10
| | | | | | | | | | | | | | | | | | | | | | | Revert DCHECKs to what they used to be - turns out a bunch of stuff in the code depended on input.empty() == true. --- I believe the code (with your width() * bbp fix) is correct. The UMR errors occur when the source image contain alpha. I believe the issue comes from webkit glue image decoder, and the reason this only started triggering valgrind errors is that the old ones were masked by the change detailed in bug 12640 Also adds valgrind suppression for the new code. TBR=Nick BUG=12891,12640 TEST=none Review URL: http://codereview.chromium.org/119271 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17811 0039d316-1c4b-4281-b951-d872f2087c98
* Revert pngencoder changes.glen@chromium.org2009-06-051-10/+0
| | | | | | | BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17803 0039d316-1c4b-4281-b951-d872f2087c98
* Retry. I believe the code (with your width() * bbp fix) is correct.glen@chromium.org2009-06-051-0/+10
| | | | | | | | | | | | | The UMR errors occur when the source image contain alpha. I believe the issue comes from webkit glue image decoder, and the reason this only started triggering valgrind errors is that the old ones were masked by the change detailed in bug 12640 Also adds valgrind suppression for the new code. BUG=12891,12640 TEST=none Review URL: http://codereview.chromium.org/118297 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17792 0039d316-1c4b-4281-b951-d872f2087c98
* Add unit_tests (Chrome browser unit tests) to Mac/Linux coverage.jrg@chromium.org2009-06-051-24/+77
| | | | | | | | Minor fixes to coverage related scripts. Review URL: http://codereview.chromium.org/118298 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17785 0039d316-1c4b-4281-b951-d872f2087c98
* Add example .croc file.rspangler@google.com2009-06-051-0/+222
| | | | | | Review URL: http://codereview.chromium.org/119209 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17776 0039d316-1c4b-4281-b951-d872f2087c98
* Convert to gyp generation of chrome_resources and chrome_strings.sgk@chromium.org2009-06-043-5/+5
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/119128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17609 0039d316-1c4b-4281-b951-d872f2087c98
* Revert last checkin to fix resources in Release builds.sgk@chromium.org2009-06-033-5/+5
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/119075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17468 0039d316-1c4b-4281-b951-d872f2087c98
* Convert to gyp generation of chrome_resources and chrome_strings.sgk@chromium.org2009-06-033-5/+5
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/119061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17467 0039d316-1c4b-4281-b951-d872f2087c98
* Broaden valgrind supression for known issue in zlib. This seems ok because ↵aa@chromium.org2009-06-011-2/+1
| | | | | | | | | | this code changes infrequently. Re-enable zip unit tests on mac. Review URL: http://codereview.chromium.org/118087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17369 0039d316-1c4b-4281-b951-d872f2087c98
* Forgot the CSS file.rspangler@google.com2009-05-291-0/+124
| | | | | | Review URL: http://codereview.chromium.org/118034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17249 0039d316-1c4b-4281-b951-d872f2087c98
* Remove checked-in memory_watcher.vcproj.sgk@google.com2009-05-291-203/+0
| | | | | | | | | svn:ignore gyp-generated memory_watcher.{sln,vcproj}. BUG=none TEST=none Review URL: http://codereview.chromium.org/118026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17232 0039d316-1c4b-4281-b951-d872f2087c98
* Fix branded resource buiding.jrg@chromium.org2009-05-291-2/+8
| | | | | | | | | | | One visible change: new tab page has Google icon, not Chromium. Gyp doesn't have a set environment variable facility; hence the addition of a command line option to grit. Review URL: http://codereview.chromium.org/113974 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17148 0039d316-1c4b-4281-b951-d872f2087c98
* Major refactoring of Croc.rspangler@google.com2009-05-295-220/+1215
| | | | | | | | | | | | Add support for scanning missing source files for executable lines. Add support for HTML output. Now reports percent coverage. BUG=none TEST=by hand on experimental buildbot Review URL: http://codereview.chromium.org/113980 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17141 0039d316-1c4b-4281-b951-d872f2087c98
* Set svn:eol-style LF on all gyp files.sgk@google.com2009-05-281-41/+41
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/113957 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17090 0039d316-1c4b-4281-b951-d872f2087c98
* Small fix for cases where the data or report dirs are not specified.mad@google.com2009-05-281-0/+1
| | | | | | | | BUG=none TEST=We should run those scripts with and without the optional arguments :-) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17088 0039d316-1c4b-4281-b951-d872f2087c98
* Add .dll (and a .exe) files to the gyp build:sgk@google.com2009-05-271-0/+41
| | | | | | | | | | | | | | | | * activex_test_control.dll * browser_tests.dll * browser_tests.exe * memory_watcher.dll * rlz.dll * security_tests.dll * test_chrome_plugin.dll * themes/default.dll BUG=none TEST=none Review URL: http://codereview.chromium.org/113915 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17023 0039d316-1c4b-4281-b951-d872f2087c98
* Add suppressions for uninitialized memory reference in ↵thestig@chromium.org2009-05-261-6/+24
| | | | | | | | | | | | | PNGEncoder::EncodeBGRASkBitmap on Mac. Remove suppression for leak in bug 12571. (should be fixed by r16879) BUG=12571 BUG=12640 TEST=Valgrind Mac bot should turn green(er) Review URL: http://codereview.chromium.org/113828 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16888 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress a leak caused by NSS_InitReadWrite.thestig@chromium.org2009-05-251-0/+9
| | | | | | | | | | TBR=dank BUG=12614 TEST=Modules Linux (valgrind) should turn green. Review URL: http://codereview.chromium.org/113826 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16860 0039d316-1c4b-4281-b951-d872f2087c98
* Add a suppression for the Mac Valgrind test_shell_test leak.thestig@chromium.org2009-05-231-2/+11
| | | | | | | BUG=12571 Review URL: http://codereview.chromium.org/115739 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16844 0039d316-1c4b-4281-b951-d872f2087c98
* Supress a leak in ExtensionsServiceTest.InstallExtension.thestig@chromium.org2009-05-231-0/+8
| | | | | | | | | Remove old, empty suppressions file. BUG=12539 Review URL: http://codereview.chromium.org/115738 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16841 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress jump on uninitialized value noticed by Valgrind on Mac innirnimesh@chromium.org2009-05-221-0/+22
| | | | | | | | OpenGL.framework's GLEngine.bundle Review URL: http://codereview.chromium.org/113770 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16763 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a leak in BookmarkBarController, and remove the valgrind suppression for it.stuartmorgan@chromium.org2009-05-221-14/+0
| | | | | | | BUG=11286 Review URL: http://codereview.chromium.org/113742 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16744 0039d316-1c4b-4281-b951-d872f2087c98
* Add Valgrind suppressions for bug 12366. Loosen one of the sqlite ↵thestig@chromium.org2009-05-211-1/+8
| | | | | | | | | suppressions so it matches in Release builds. BUG=12366 Review URL: http://codereview.chromium.org/115617 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16568 0039d316-1c4b-4281-b951-d872f2087c98
* Tidy the valgrind suppressions filedank@chromium.org2009-05-191-61/+83
| | | | | | | | | Split into three categories. The third category is for real bugs. (This makes periodic sweeps to find unused bug suppressions a bit easier.) Review URL: http://codereview.chromium.org/113596 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16421 0039d316-1c4b-4281-b951-d872f2087c98
* Fix memory leak in corrupt JPEG decoding.thestig@chromium.org2009-05-191-11/+0
| | | | | | | BUG=10945 Review URL: http://codereview.chromium.org/113433 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16352 0039d316-1c4b-4281-b951-d872f2087c98
* valgrind: with my fix upstreamed, we can now remove this suppression.evan@chromium.org2009-05-181-7/+0
| | | | | | | | | | | See also: https://bugs.webkit.org/show_bug.cgi?id=25760 BUG=9475 Review URL: http://codereview.chromium.org/115325 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16314 0039d316-1c4b-4281-b951-d872f2087c98
* Also scan .m and .mm files in checkdeps.pyphajdan.jr@chromium.org2009-05-181-11/+10
| | | | | | | | | | - add necessary DEPS rules - fix skia includes in test_shell to contain full path (third_party/skia/include/core/SkBitmap.h instead of just SkBitmap.h) - remove forbidden chrome/common include from app/resource_bundle_mac.mm Review URL: http://codereview.chromium.org/113147 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16273 0039d316-1c4b-4281-b951-d872f2087c98
* Example script to run all tests under valgrinddkegel@google.com2009-05-141-0/+75
| | | | | | Review URL: http://codereview.chromium.org/113365 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16085 0039d316-1c4b-4281-b951-d872f2087c98
* valgrind: print the gtest suppression list on startup.evan@chromium.org2009-05-131-0/+1
| | | | | | | | | This is in the docs, but there are a lot of docs, and all the other files it's pulling flags from are printed during startup. Review URL: http://codereview.chromium.org/113358 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15990 0039d316-1c4b-4281-b951-d872f2087c98
* Add croc code coverage tool. (Same change as yesterday, but now made in therspangler@google.com2009-05-132-0/+1363
| | | | | | | | writable repository) Review URL: http://codereview.chromium.org/113346 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15974 0039d316-1c4b-4281-b951-d872f2087c98
* Add valgrind suppression for libxml error in http://crbug.com/11838thestig@chromium.org2009-05-121-0/+12
| | | | | | Review URL: http://codereview.chromium.org/115266 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15913 0039d316-1c4b-4281-b951-d872f2087c98
* Add a script that runs cov-build, cov-analyze, andwtc@chromium.org2009-05-121-0/+136
| | | | | | | | | | | cov-commit-defects on a Chromium tree. R=patrick BUG=N/A TEST=N/A Review URL: http://codereview.chromium.org/99264 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15831 0039d316-1c4b-4281-b951-d872f2087c98
* Remove executable bit from a bunch of files that shouldn't have it.evan@chromium.org2009-05-1119-0/+0
| | | | | | | | | | (No code change.) git ls-tree -r HEAD | grep '^100755' | cut -f2 | egrep '\.(png|txt|mm|cc|h|checksum|asm|js|html|c|css|xml|grd|json)$' | xargs chmod a-x git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15809 0039d316-1c4b-4281-b951-d872f2087c98
* Move timeout to right spot in tools/valgrind/chrome_tests.py. Fixes thinko ↵dkegel@google.com2009-05-111-1/+1
| | | | | | | | committed in issue 114012. Review URL: http://codereview.chromium.org/115191 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15770 0039d316-1c4b-4281-b951-d872f2087c98
* Raise timeout on ui tests to 12000 seconds, since on thedkegel@google.com2009-05-111-0/+1
| | | | | | | | | | | | | | | | | Mac it was regularly hitting the default timeout of 10000 seconds. (Really should take the size of the shard into account, but we can do that later if we have lots of hangs.) Should fix error 14:37:55 common.py [INFO] process timed out 14:37:55 common.py [ERROR] KILLED 17207 14:37:56 common.py [ERROR] TIMEOUT waiting for src/xcodebuild/Debug/ui_tests in http://build.chromium.org/buildbot/waterfall/builders/Modules%20Mac%20(valgrind)/builds/479/steps/valgrind%20test%3A%20ui/logs/stdio Review URL: http://codereview.chromium.org/114012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15747 0039d316-1c4b-4281-b951-d872f2087c98
* Stop leaking RenderWidgetHostViewGtk.willchan@chromium.org2009-05-081-15/+0
| | | | | | | | | | | | | | | Don't bother calling gfx::RemoveAllChildren() in TabContentsViewGtk when creating a new RWHV, since any previously existing RWHV widget should already have been deleted. This also fixes interstitial pages crashing. Although instead we have two RWHV widgets in the same TabContentsView vbox :) I'll fix that in a later changelist. Also update the valgrind suppressions file. BUG=http://www.crbug.com/10747 BUG=http://www.crbug.com/8486 Review URL: http://codereview.chromium.org/115145 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15695 0039d316-1c4b-4281-b951-d872f2087c98
* Broaden mac valgrind suppression for color space related leak.thestig@chromium.org2009-05-081-15/+0
| | | | | | Review URL: http://codereview.chromium.org/113160 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15674 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a xml parser crash in the valgrind analyze script.thestig@chromium.org2009-05-071-6/+25
| | | | | | | I.e. http://build.chromium.org/buildbot/waterfall/builders/Modules%20Mac%20(valgrind)/builds/477/steps/valgrind%20test%3A%20ui/logs/stdio Review URL: http://codereview.chromium.org/115093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15563 0039d316-1c4b-4281-b951-d872f2087c98
* Fix timeout when not detacheddkegel@google.com2009-05-061-4/+12
| | | | | | | | Also fix how timeout kills subprocess on Linux and Mac Review URL: http://codereview.chromium.org/115042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15466 0039d316-1c4b-4281-b951-d872f2087c98
* Have the grit rules depend on the .pak files.tc@google.com2009-05-062-2/+2
| | | | | | | | | | | chrome_resources and chrome_strings was continually rebuilding because it depended on the .h file, but the .h file doesn't get written if there are no changes. The .pak file always gets written. Review URL: http://codereview.chromium.org/115035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15432 0039d316-1c4b-4281-b951-d872f2087c98
* mac valgrind bot: Make running dsymutil an option for now, since it slows ↵dkegel@google.com2009-05-062-11/+22
| | | | | | | | down the run a lot, and causes timeouts. Reenable by default once we have multiple mac bots. Review URL: http://codereview.chromium.org/114003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15431 0039d316-1c4b-4281-b951-d872f2087c98
* Doesn't fix anything at all but make it clearer.maruel@chromium.org2009-05-061-28/+28
| | | | | | Review URL: http://codereview.chromium.org/109051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15375 0039d316-1c4b-4281-b951-d872f2087c98
* Move the shared JS and CSS out of the HTML files and into separate files.arv@chromium.org2009-05-051-5/+36
| | | | | | Review URL: http://codereview.chromium.org/99151 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15323 0039d316-1c4b-4281-b951-d872f2087c98
* Add valgrind suppressions for a well-known fontconfig leak anddkegel@google.com2009-05-051-5/+36
| | | | | | | | | | for http://crbug.com/6547 and http://crbug.com/11462, and loosen up another couple a bit. Review URL: http://codereview.chromium.org/108001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15309 0039d316-1c4b-4281-b951-d872f2087c98
* mac valgrind: remove special case in python script.dkegel@google.com2009-05-041-49/+13
| | | | | | | | | Also have --generate_suppressions output to normal log file for now. Review URL: http://codereview.chromium.org/99356 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15243 0039d316-1c4b-4281-b951-d872f2087c98
* mac valgrind: media_tests: add suppression for second trace in ↵dkegel@google.com2009-05-041-0/+8
| | | | | | | | http://crbug.com/11327 Review URL: http://codereview.chromium.org/99359 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15242 0039d316-1c4b-4281-b951-d872f2087c98
* Don't analyze incomplete valgrind log files (as the parser crashes),dkegel@google.com2009-05-041-11/+20
| | | | | | | | make timeout global instead of per-file, shorten it. Review URL: http://codereview.chromium.org/100340 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15224 0039d316-1c4b-4281-b951-d872f2087c98
* Rebase valgrind suppressions, add one for http://crbug.com/11130dkegel@google.com2009-05-041-2/+15
| | | | | | Review URL: http://codereview.chromium.org/100341 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15222 0039d316-1c4b-4281-b951-d872f2087c98
* Add suppressions for two mac audio bugs: http://crbug.com/11327dkegel@google.com2009-05-021-14/+34
| | | | | | | | | | broadened a few other suppressions, and split one bug out of 9563 into http://crbug.com/11333 Review URL: http://codereview.chromium.org/99303 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15130 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress valgrind warnings fordank@chromium.org2009-05-011-0/+89
| | | | | | | | | | | | | | | http://crbug.com/9561 http://crbug.com/11270 http://crbug.com/11271 http://crbug.com/11286 and a couple of things that seem clearly to be system issues rather than chromium issues. Just trying to get the mac unit_test valgrind builder green. Review URL: http://codereview.chromium.org/99259 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15071 0039d316-1c4b-4281-b951-d872f2087c98