| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
context menu.
o Updated some comments that were using the outdated NOTIFY_PREF_CHANGED notification.
o Make LAUNCH_PINNED the default type returned by ExtensionPrefs if it does not already exist.
o Some minor refactoring within the code to reduce duplication.
BUG=54731
TEST=NONE
patch from issue 3419010
Review URL: http://codereview.chromium.org/3453029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60997 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
E.g.
#0 0xBD108DD: Replace_memcpy vgpreload_tsan-x86-darwin.so
#1 0xBD136C5: memcpy vgpreload_tsan-x86-darwin.so
#2 0x120C7B94: thread_encoding_proc src/xcodebuild/Release/libffmpegsumo.dylib
#3 0xBD14CD7: ThreadSanitizerStartThread vgpreload_tsan-x86-darwin.so
BUG=57266
TBR=glider
TEST=TSan/Mac should go green
Review URL: http://codereview.chromium.org/3516006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60947 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=57266
TBR=glider
Review URL: http://codereview.chromium.org/3573004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60943 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=timurrrr
Review URL: http://codereview.chromium.org/3584002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60941 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3527002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60937 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=timurrrr
Review URL: http://codereview.chromium.org/3583001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60931 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
E.g. like this:
http://build.chromium.org/buildbot/memory/builders/Linux%20Tests%20(tsan)/builds/6149/steps/memory%20test:%20remoting/logs/stdio
WARNING: Possible data race during read of size 4 at 0x91974F4: {{{
T19 (L{}):
#0 ??? sconsbuild/Release/libffmpegsumo.so sconsbuild/Release/libffmpegsumo.so
#1 ThreadSanitizerStartThread ts_valgrind_intercepts.c:609
BUG=57266
TBR=glider
TEST=TSan/Linux should go green
Review URL: http://codereview.chromium.org/3561004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This change suppresses the leak of a base::NativeLibrary object because I cannot find the good place to delete it. (It is definitely a better solution to call base::UnloadNativeLibrary() when we do not need a static variable |vp8_cx_algo_address| any longer.)
BUG=57268
TEST=make the "WebKit Mac (valgrind)" bot green.
Review URL: http://codereview.chromium.org/3580001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60928 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=glider
BUG=57266
Review URL: http://codereview.chromium.org/3533004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60917 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This change updates a suppression rule to catch up with r60569 <http://crrev.com/60569>, which changed the parameter of RenderProcessHost::Init().
BUG=39963
TEST=make the valgrind bots green.
Review URL: http://codereview.chromium.org/3511001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Order policies alphabetically for all the generated templates.
Show group descriptions in the generated documentation.
BUG=56358,56654
TEST=DocWriterUnittest.testAddPolicySection,DocWriterUnittest.testAddPolicyRow, PolicyTemplateGenerator.testSorting
Review URL: http://codereview.chromium.org/3431031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60789 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch is already been reviewed in:
http://codereview.chromium.org/3005036/show
Splitting this out inorder to make changes to FFmpeg build.
TBR=ajwong
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3391027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60700 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Not clear why getcwd() doesn't end with 'build' when run on buildbot.
http://buildbot.jail.google.com/buildbot/waterfall.fyi/builders/Linux%20Coverage%20(dbg)/builds/6081/steps/Run%20Coverage%20Bundles/logs/stdio
Review URL: http://codereview.chromium.org/3506006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60687 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
issue 49)
TBR=glider
Review URL: http://codereview.chromium.org/3509002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit fce05cef2591e1d00b31ab756e91a37f5a66dabc.
Fix memory leak in OnlineAttempt
BUG=56704
TEST=valgrind the unit tests
Review URL: http://codereview.chromium.org/3440023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=glider
Review URL: http://codereview.chromium.org/3461030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60644 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
file.
BUG=57025
TEST=Current unit-tests need to pass.
Review URL: http://codereview.chromium.org/3390031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
policies to "policy" element. This will fix issue 55722 for ADMX/ADML policy templates.
BUG=55722
TEST=admx_writer_unittest.py, adml_writer_unittest.py
Review URL: http://codereview.chromium.org/3439011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60629 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
It seems some unit tests do not delete MockRenderProcessHost objects created via the MockRenderProcessHostFactory class. This change adds a list of MockRenderProcessHost objects to the MockRenderProcessHostFactory class so it can delete them in its destructor when tests do not delete them.
BUG=52834
TEST=make the "Linux Test (valgrind)(1)" bot green without suppressions.
Review URL: http://codereview.chromium.org/3431006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60617 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Should fix the "zero percent coverage" problem.
Review URL: http://codereview.chromium.org/3396024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60554 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=dumi
BUG=56676
TEST=Green heapcheck bot
Review URL: http://codereview.chromium.org/3454029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60487 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the old model each policy had to be in a group, and messages could be inherited from groups to policies.
In the new model single policies does not have to be in groups and there is no inheritance of messages across policies/groups. Instead of that, policies have now two captions for different purposes. (Documented in policy_templates.json.) This is a more simple concept.
BUG=55722,56512
TEST=covered by policy template generator unit tests
Review URL: http://codereview.chromium.org/3454017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60458 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
instance
log to its own log file.
Otherwise each launched browser would overwrite the shared log. The test infrastructure
relies on the log file to detect assertion failures.
BUG=54098
TEST=none
Review URL: http://codereview.chromium.org/3405025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60441 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=56495, 54149
TEST=valgrind, see bugs
Review URL: http://codereview.chromium.org/3498002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60439 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=thestig
BUG=56704
TEST=Greener ChromeOS valgrind bot
Review URL: http://codereview.chromium.org/3479009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3440022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60323 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Heapcheck version of revision 60311.
TBR=dumi
BUG=56676
TEST=Green heapcheck bot.
Review URL: http://codereview.chromium.org/3414018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60313 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=dumi
BUG=56676
TEST=Green WebKit valgrind bots
Review URL: http://codereview.chromium.org/3467012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60311 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
policy_generator.py to the template_writer.py.
This is the first CL in a couple of refactoring steps.
BUG=56512
TEST=Current tests need to pass
Review URL: http://codereview.chromium.org/3496001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60276 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=timurrrr
Review URL: http://codereview.chromium.org/3447020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60273 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TEST=./tools/valgrind/chrome_tests.sh -t base --gtest_filter="Sanity*" on Linux and Mac
Review URL: http://codereview.chromium.org/3470006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60271 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=56511
TBR=glider
TEST=unit_tests should become 10-15% faster under TSan.
Review URL: http://codereview.chromium.org/3443016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60173 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
DOMStorageTest.RootLayoutTests)
Add suppression for bug 56495 (Leak in SavePackage::Init())
BUG=56495,50297
TBR=hbono
Review URL: http://codereview.chromium.org/3382016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60164 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome_tests/valgrind_test.py a bit
The patch was prepared by Eugeniy Stepanov (eugenis@) and orignally reviewed as
http://codereview.chromium.org/3436022
TBR=glider
TEST=./tools/valgrind/chrome_tests.sh -t <test> [--tool={tsan,tsan_rv,memcheck}] ...
Review URL: http://codereview.chromium.org/3389023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is necessary because the Windows Group Policy editor does not support setting a list to empty, but if the list is in a separate policy, then it can be set to disabled or not configured.
BUG=55722
TEST=AdmWriterUnittest.*
Review URL: http://codereview.chromium.org/3436013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60160 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adjust after a slight intl1/intl2 perf improvement,
and avoid false alarms on other tests.
- linux-release-hardy/startup/warm/t
- mac-release-10.5/intl2/times/t
- mac-release-10.6/intl1/times/t
- mac-release-10.6/moz/times/t
- vista-release-dual-core/dhtml/times/t
- vista-release-dual-core/intl1/times/t
BUG=none
TEST=perf steps are green
TBR=nsylvain@chromium.org
Review URL: http://codereview.chromium.org/3441023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60134 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
http://buildbot.jail.google.com/buildbot/waterfall.fyi/builders/Mac%20Coverage%20(dbg)/builds/6765/steps/Run%20Coverage%20Bundles/logs/stdio
Also fix paths for Mac (r54844 fixed it for windows but broke Mac)
Review URL: http://codereview.chromium.org/3416017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
_ZN11ProfileImpl20CreateWebDataServiceEv)
Extend the suppression for bug 22450 (Memory leak in
URLRequestTestHTTP.UnexpectedServerAuthTest, .ProxyTunnelRedirectTest)
BUG=56090,22450
TBR=timurrrr
Review URL: http://codereview.chromium.org/3416016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60055 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moved one suppression from bug 51057 ( leaks below
net::HttpNetworkTransaction::DoInitConnection()) to 56359
BUG=51057,56359
TBR=timurrrr
Review URL: http://codereview.chromium.org/3427015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60045 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Suppress analyzer report for the first pass.
* Cleanup the logs from the first pass.
The patch was prepared by Evgeniy Stepanov (eugenis@)
and originally reviewed as http://codereview.chromium.org/3440013
TEST=./tools/valgrind/chrome_tests.sh -t ... --tool tsan_rv
TBR=glider
Review URL: http://codereview.chromium.org/3440015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60037 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Use the .json and .grd description of the policies to generate HTML markup that can be uploaded straight to dev.chromium.org.
BUG=54712
TEST=DocWriterUnittest.*
Review URL: http://codereview.chromium.org/3452006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60032 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This widens or otherwise adjust perf expectations to
avoid false negatives:
- linux-release-hardy/dhtml/times/t
- mac-release-10.6/dhtml/times/t
- mac-release-10.6/intl1/times/t
- mac-release-10.6/intl2/times/t
- vista-release-dual-core/dhtml/times/t
- xp-release-dual-core/moz/times/t
- xp-release-dual-core/moz/total_byte_r/IO_r
- xp-release-dual-core/startup/warm/t
BUG=none
TEST=perf steps are green
TBR=nsylvain@chromium.org
Review URL: http://codereview.chromium.org/3466004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59968 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Extend a suppression for bug 52834(Memory leaks under
RenderProcessHost/MockRenderProcessHost/.../RenderViewHostTestHarness)
BUG=39963,52834
TBR=timurrrr
Review URL: http://codereview.chromium.org/3420013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
ExntesionService::Init in Linux/CrOS ui tests)
BUG=39963
TBR=timurrrr
Review URL: http://codereview.chromium.org/3421018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59932 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(RenderProcessHost/MockRenderProcessHost/.../RenderViewHostTestHarness)
BUG=52834
TBR=timurrrr
Review URL: http://codereview.chromium.org/3427013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59921 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=56090
TEST=None
TBR=tim
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
invalid read.
BUG=56018
TEST=None
TBR=xiyuan
TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/3463003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59875 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SearchProviderInstallData on the I/O thread).
I also added several DCHECKs to make this bug apparent in a normal test run.
BUG=56002
TEST=unit_tests --gtest_filter=SearchProviderInstallDataTest.GetInstallState
Review URL: http://codereview.chromium.org/3383012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59819 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=56018
TEST=None
TBR=xiyuan
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59793 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=56002
TBR=glider
TEST=TSan/unit should go green
Review URL: http://codereview.chromium.org/3453009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59779 0039d316-1c4b-4281-b951-d872f2087c98
|