| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
Please advice if there are other trybots I should throw this at before attempting a commit.
None of the redness from the trybots are related to those leaks reported in the bug.
BUG=131668
TEST=No leaks.
Review URL: https://chromiumcodereview.appspot.com/10882019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153281 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Same as patch here: https://chromiumcodereview.appspot.com/10827429/
except that warnings as errors is off if buildtype=Official. The previous CL
was OK everywhere that's visible on build.chromium.org including "Official"
but fails on internal builds.
R=thakis@chromium.org
BUG=126483, 140121, 143877
Review URL: https://chromiumcodereview.appspot.com/10867058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153278 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Windows
Is causing warnings for Official build in PDF code. Boo.
-----------------
Can't quite be fully enabled yet due to not-yet-fixed third party
dependencies. Without it enabled, other packages regress while we're fixing
things. So, add a flag for now so warnings-freeness can be ratcheted forward
by having it on for most packages, but off for a few.
Also, disable warning in qcms (fixed upstream by a large refactoring, not
worth rolling for), and disable two minor warnings in yasm (patch posted
upstream for a few months, but maintainer does not seem motivated to merge).
Fix release-only warning in leveldatabase/env_chromium.cc. Was calling exit(1)
in a leaky destructor.
Fix a warning in lzma_sdk (missing an include).
Disable a silly warning in Release builds of skia and memory_watcher (that
/GS is not working because optimization is disabled).
Warning are currently tolerated in libvpx and mesa.
Cannot be committed until http://chromiumcodereview.appspot.com/10823426/ has
landed.
R=thakis@chromium.org
BUG=126483,140121, 143877
TEST=
Review URL: https://chromiumcodereview.appspot.com/10827429
TBR=scottmg@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10872063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This hasn't been hit for a month already
TBR=benwells
BUG=132230
Review URL: https://chromiumcodereview.appspot.com/10875046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153188 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=144613
TBR=battre,cmp
Review URL: https://chromiumcodereview.appspot.com/10873059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153187 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Can't quite be fully enabled yet due to not-yet-fixed third party
dependencies. Without it enabled, other packages regress while we're fixing
things. So, add a flag for now so warnings-freeness can be ratcheted forward
by having it on for most packages, but off for a few.
Also, disable warning in qcms (fixed upstream by a large refactoring, not
worth rolling for), and disable two minor warnings in yasm (patch posted
upstream for a few months, but maintainer does not seem motivated to merge).
Fix release-only warning in leveldatabase/env_chromium.cc. Was calling exit(1)
in a leaky destructor.
Fix a warning in lzma_sdk (missing an include).
Disable a silly warning in Release builds of skia and memory_watcher (that
/GS is not working because optimization is disabled).
Warning are currently tolerated in libvpx and mesa.
Cannot be committed until http://chromiumcodereview.appspot.com/10823426/ has
landed.
R=thakis@chromium.org
BUG=126483,140121, 143877
TEST=
Review URL: https://chromiumcodereview.appspot.com/10827429
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153092 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://code.google.com/p/drmemory/issues/detail?id=983
TBR=rnk@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10874032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153016 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Modify the code in run_test_cases.py to allow other classes to use it's sharding and filtering code in an optionparser right away.
Also update what output is logged when run_test_cases.py fails to run a test and cleanup some of the environment variable settings.
NOTRY=true
BUG=
Review URL: https://chromiumcodereview.appspot.com/10875020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152996 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SQLite-based database.
The protobuf-based cache was only being read at startup and written at shutdown. (Except that when the cache could not be read at startup the cache would immediately be saved upon private data reconstruction from the History database.) With the new implementation using an SQLite database for the HQP cache the private data will be restored from the cache database at startup and continually updated during normal operation. There is no need to flush or write the cache at shutdown as it is constantly kept up-to-date.
Detailed comments about the changes made in this CL can be found in the document shared separately.
Previous reviewers: sky, pkasting, shess.
BUG=95686, 95876, 131668
TEST=New tests added, old tests updated, all tests pass.
To manually verify changes:
NOTE: For tests using chrome://omnibox be sure to check the "Show results per provider" and then look at the results for the HistoryQuickProvider.
1) New visits: Type an URL never visited before. Bring up new tab. Start typing the URL or parts of the page title or both and verify that the page is offered as a suggestion.
2) New visits: Type an URL never visited before. Do search using chrome://omnibox. New visit should show.
3) Delete visit: Visit some pages and verify they have been recorded. Bring up history and delete one of the visits. Check via chrome://omnibox that it was deleted.
4) Clear history: Visit some pages. Clear the visit history. Check via chrome://omnibox that none of the visits are still returned by the HQP.
5) Updated site: Create a local page and visit it. Search using chrome://omnibox by page title and verify it can be found. Change the page title dramatically and revisit the page. Verify via chrome://oomnibox that the page can be found by words from the new title.
Previously reviewed as: http://codereview.chromium.org/10477018/.
10477018 was reverted due to memory leaks detected by build bots.
Review URL: https://chromiumcodereview.appspot.com/10837244
TBR=mrossetti@chromium.org
This is causing performance regressions across a range of perf bots.
Review URL: https://chromiumcodereview.appspot.com/10872032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This is a re-land of 152439, which bounced because of checklicenses issues.
Review URL: https://chromiumcodereview.appspot.com/10872022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152948 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
database.
The protobuf-based cache was only being read at startup and written at shutdown. (Except that when the cache could not be read at startup the cache would immediately be saved upon private data reconstruction from the History database.) With the new implementation using an SQLite database for the HQP cache the private data will be restored from the cache database at startup and continually updated during normal operation. There is no need to flush or write the cache at shutdown as it is constantly kept up-to-date.
Detailed comments about the changes made in this CL can be found in the document shared separately.
Previous reviewers: sky, pkasting, shess.
BUG=95686, 95876, 131668
TEST=New tests added, old tests updated, all tests pass.
To manually verify changes:
NOTE: For tests using chrome://omnibox be sure to check the "Show results per provider" and then look at the results for the HistoryQuickProvider.
1) New visits: Type an URL never visited before. Bring up new tab. Start typing the URL or parts of the page title or both and verify that the page is offered as a suggestion.
2) New visits: Type an URL never visited before. Do search using chrome://omnibox. New visit should show.
3) Delete visit: Visit some pages and verify they have been recorded. Bring up history and delete one of the visits. Check via chrome://omnibox that it was deleted.
4) Clear history: Visit some pages. Clear the visit history. Check via chrome://omnibox that none of the visits are still returned by the HQP.
5) Updated site: Create a local page and visit it. Search using chrome://omnibox by page title and verify it can be found. Change the page title dramatically and revisit the page. Verify via chrome://oomnibox that the page can be found by words from the new title.
Previously reviewed as: http://codereview.chromium.org/10477018/.
10477018 was reverted due to memory leaks detected by build bots.
Review URL: https://chromiumcodereview.appspot.com/10837244
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152946 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=rnk@chromium.org
BUG=http://code.google.com/p/drmemory/issues/detail?id=980
Review URL: https://chromiumcodereview.appspot.com/10872014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152765 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reproduced with:
isolate.py trace -r .../net_unittests.results
isolate.py read -r .../net_unittests.results
It happens randomly whenever Windows decides to reuse a process id so it tends
to happens often with browser_tests.
This happened because stale processes are not removed from the map but set to
None instead.
R=cmp@chromium.org
NOTRY=true
BUG=
Review URL: https://chromiumcodereview.appspot.com/10824409
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152755 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Will add more test cases as features are added to run_test_from_archive.py.
R=cmp@chromium.org
NOTRY=true
BUG=
Review URL: https://chromiumcodereview.appspot.com/10823438
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add limited support for openat() trace on strace. These are appearing on ubuntu
12.04 with strace version 4.5.20.
Fix a race condition where trace_test_cases.py could not print all the output.
R=cmp@chromium.org
NOTRY=true
BUG=
Review URL: https://chromiumcodereview.appspot.com/10854252
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=rnk@chromium.org
BUG=144087
Review URL: https://chromiumcodereview.appspot.com/10868015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152736 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
http://code.google.com/p/drmemory/issues/detail?id=979 and http://code.google.com/p/drmemory/issues/detail?id=978
TBR=rnk@chromium.org
BUG=144018
Review URL: https://chromiumcodereview.appspot.com/10868007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152656 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=110729
Review URL: https://chromiumcodereview.appspot.com/10825400
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152644 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Update merge_isolate.py to know that if a file is marked as both touched and tracked or untracked, the touched element should be drop, since both tracked and untracked are stronger.
R=maruel@chromium.org
NOTRY=true
BUG=
Review URL: https://chromiumcodereview.appspot.com/10832417
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152605 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/10831376
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152601 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=87222
TBR=mad
Review URL: https://chromiumcodereview.appspot.com/10832414
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152558 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, there aren't any APIs that use filtered events, but webNavigation
will soon.
BUG=142560
Review URL: https://chromiumcodereview.appspot.com/10828403
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152490 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=137639
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10857052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152485 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Based off: https://chromiumcodereview.appspot.com/10834329
This adds a few things to speed up performance:
1. Caches items in memcache from FileSystemCache.
2. Caches everything primarily in memory, and falls back on memcache.
3. 5 minute timeout on stats.
4. Cron job to update memcache every 5 minutes (just enough time to update expired stats).
5. Memcache uses set_multi_async and get_multi_async where applicable.
I have an instance at chrome-docs-test.appspot.com, but the cron job is only running
every 10 minutes so I don't go over quota.
After the cron job is run, even samples.html is fast!
Review URL: https://chromiumcodereview.appspot.com/10829348
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It fails check_licenses.
Review URL: https://chromiumcodereview.appspot.com/10825463
TBR=nduca@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10831399
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152445 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/10825463
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152439 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=143793
TBR=cmp
Review URL: https://chromiumcodereview.appspot.com/10829441
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=143748,143751
TBR=cmp@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10824382
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Each test only gets 3 chances to pass when running in run_test_case.py. If it fails those 3 it no longer gets to be retried running alone.
BUG=
Review URL: https://chromiumcodereview.appspot.com/10825448
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152366 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
IWYU in its current form doesn't work well, and this script
fell victim to bitrot due to being unused.
BUG=143643
Review URL: https://chromiumcodereview.appspot.com/10828383
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152320 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=134717
TEST=try bot
Review URL: https://chromiumcodereview.appspot.com/10826201
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152312 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=ajwong@chromium.org
BUG=143565
TEST=waterfall.sh
Review URL: https://chromiumcodereview.appspot.com/10824369
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152278 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=143563
TBR=ccameron@chromium.org
TEST=waterfall.sh
Review URL: https://chromiumcodereview.appspot.com/10823403
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152276 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome/browser/resources/options.
BUG=none
TEST=none
R=csilv
Review URL: https://chromiumcodereview.appspot.com/10809005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152267 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
suppression to heapcheck
TBR=davemoore@chromium.org
BUG=143545,143431
TEST=waterfall.sh
Review URL: https://chromiumcodereview.appspot.com/10829406
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152244 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=143401
Review URL: https://chromiumcodereview.appspot.com/10832354
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152229 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also suppress two warnings in third_party targets.
gyp changes reviewed by willchan in
http://codereview.chromium.org/10832369/
BUG=141532,138571
TBR=hans,willchan
Review URL: https://chromiumcodereview.appspot.com/10827405
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152187 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=bauerb@chromium.org
BUG=143431
TEST=waterfall.sh
Review URL: https://chromiumcodereview.appspot.com/10825423
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152134 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
builds.
Note that setup is already configured to use chrome.7z directly if chrome.packed.7z is absent.
Change setup to have it copy chrome.7z to the <version>\Installer folder (instead of moving it) for component builds (to allow developers to test installs more than once with the same archive).
BUG=None
TEST=Install/uninstall chrome after copying setup.exe to another machine using tools\win\copy-installer.bat
Test non-component build and make sure archive is still moved (i.e.not copied).
Review URL: https://chromiumcodereview.appspot.com/10825342
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152124 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is useful in situations where a checkout excludes some DEPS directories.
In this case, a checkout may include the README.chromium file for a particular
third-party project, but not the license file to which it refers.
This change adds a new require_license_file argument to licenses.ParseDir(), with
a default value of true. When true, there is no change in behaviour and if the
license file is missing, an exception is raised. When false, if the license
file is missing, we simply set the value of the 'License File' field of the
returned metadata to None.
This change also makes use of the new feature in
webview_licenses.GetIncompatibleDirectories() and
webview_licenses.GenerateNoticeFile().
BUG=138921
Review URL: https://chromiumcodereview.appspot.com/10829355
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152091 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=penghuang@chromium.org
BUG=143401
TEST=waterfall.sh
Review URL: https://chromiumcodereview.appspot.com/10837311
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152088 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TBR=cmp@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10857047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152055 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
http://build.chromium.org/f/chromium/perf/linux-release/sizes/report.html?history=150&rev=152008&graph=nacl_helper-data
NOTRY=1
BUG=143313
Review URL: https://chromiumcodereview.appspot.com/10855214
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152051 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=cmp
Review URL: https://chromiumcodereview.appspot.com/10832361
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
linux-release/sizes/chrome/chrome: http://build.chromium.org/f/chromium/perf/linux-release/sizes/report.html?history=150&rev=151900
Also contains a change to linux-release/sizes/chrome-text/text.
I think this was due to the range being placed to include possible
builds that weren't yet complete.
TBR=nsylvain@chromium.org
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/10823367
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before considering a test failed in run_test_cases.py try running the failed tests serial, since they may have only failed before because they were conflicting with other tests running at the same time.
BUG=
Review URL: https://chromiumcodereview.appspot.com/10831330
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151893 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/10824332
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Android builds currently rely on the STRIP environment variable to be available
during build time, rather than just at project generation time. It shouldn't.
BUG=142642
Review URL: https://chromiumcodereview.appspot.com/10832295
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151886 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151821 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
r151720 sadly, but unavoidably, pulled in zlib. This change
updates our size expectations to reflect this.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151742 0039d316-1c4b-4281-b951-d872f2087c98
|