| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
valgrind-friendly
BUG=25346
Review URL: http://codereview.chromium.org/335026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30044 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=dank
Review URL: http://codereview.chromium.org/332025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
been seen on the bots in a while (if I'm reading the output correctly).
BUG=24345
TEST=green valgrind bots
Review URL: http://codereview.chromium.org/333014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30005 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29952 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=25648,20814,25656,20113,20508,25661
TEST=Greener Mac UI valgrind bots
Review URL: http://codereview.chromium.org/332008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29914 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=25645
TBR=dank
Review URL: http://codereview.chromium.org/337001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29894 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
to the list of functions ignored by ThreadSanitizer on Mac OS.
This patch was prepared by Alexander Potapenko (cc'ed)
TBR=dank
Review URL: http://codereview.chromium.org/333012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29893 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Add extra unit test bundles (all platforms).
Review URL: http://codereview.chromium.org/307032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29845 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=20805
TEST=green linux ui valgrind bots
Review URL: http://codereview.chromium.org/320002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29790 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This hasn't reproduced in the past bunch of runs of net_unittests; I believe it was fixed by r26611.
BUG=15147
Review URL: http://codereview.chromium.org/294034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29680 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
running wine.
BUG=valgrind_210481, valgrind_205541
TEST=valgrind net_unittests --gtest_filter=ProxyResolverV8Test.LoadLog ; valgrind wine's unit tests and see no HEAP_CreateSubHeap valgrind warnings
Review URL: http://codereview.chromium.org/306020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29655 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG:19546
Review URL: http://codereview.chromium.org/300038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=25385
TBR=dank
Review URL: http://codereview.chromium.org/306024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29634 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
(see third_party/icu/source/common/umutex.c)
When two concurrent threads try to call umtx_lock(mutex) for an uninitialized mutex simultaneously, *mutex is read without taking any lock.
However, if *mutex is NULL, a DCLP inside umtx_init(mutex) guarantees that *mutex is initialized exactly once. Otherwise, if *mutex is already a valid pthread_mutex_t, the behavior of the program is not affected.
This patch was prepared by Alexander Potapenko (cc'ed)
TBR=dank
Review URL: http://codereview.chromium.org/303019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29633 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This roll should fix a valgrind error (issue 25297).
R=jamesr
BUG=25297
TEST=none
Review URL: http://codereview.chromium.org/292039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29613 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=awalker
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/293041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29605 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=sh tools/valgrind/chrome_tests.sh -t base on a 64 bit build
Review URL: http://codereview.chromium.org/300024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29585 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=jamesr
BUG=25297
TEST=none
Review URL: http://codereview.chromium.org/306003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29505 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=20939
TEST=valgrind_webkit_tests.sh LayoutTests/fast/css/invalid-percentage-property.html
Review URL: http://codereview.chromium.org/273077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29231 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=N/A
Review URL: http://codereview.chromium.org/282009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29180 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=24503,24936
TBR=dank
Review URL: http://codereview.chromium.org/273070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29175 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
The race is known but is not very severe and cannot be easily
fixed using locks due to the complexity of the third-party audio code.
BUG=24801
Review URL: http://codereview.chromium.org/282001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With the previous patch, the try bots failed with mysterious messages, so I ignored them, patched it into my windows box and tested it there manually, and found no problems. As it turns out, the try failures were real :(. But nsylvain and I found the problem: the behavior of file_util::GetDirectoryFromPath() differs from DirName() when the path is empty (officially, GetDirectoryFromPath is not supposed to support non-absolute paths, but that is not enforced).
Here is a green win try result: http://build.chromium.org/buildbot/try-server/builders/win/builds/3705
mac: http://build.chromium.org/buildbot/try-server/builders/mac/builds/3491
linux: http://build.chromium.org/buildbot/try-server/builders/linux/builds/3466
I also applied this patch locally in Windows to test that it doesn't break the chrome frame compile or tests, since that's not covered by the trybots yet.
Review URL: http://codereview.chromium.org/271099
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29094 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
r28006 reverted to an earlier version of tcmalloc,
and consequently we got slower by 15ms on the morejs
page cycler.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/280001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29091 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
on the buildbots.
TBR=nsylvain
Review URL: http://codereview.chromium.org/280004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29085 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23450
TEST=valgrind_webkit_tests.sh LayoutTests/fast/text/drawBidiText.html
Review URL: http://codereview.chromium.org/271098
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29080 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
death to the wstring
TEST=trybots
BUG=none
Review URL: http://codereview.chromium.org/276016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29078 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Replace it with base_i18n which encapsulates all ICU dependencies.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/267048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29036 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Also fixed indentations for the last two suppressions
TBR=dank,stuartmorgan
BUG=24715,24724
Review URL: http://codereview.chromium.org/269073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28953 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
We've introduced a mistake recently which results in hiding the first race report.
The reason was the "main thread" line which doesn't contain "{{{" and doesn't have context printed.
Please note that after submitting of this CL ThreadSanitizer bots can become red for a while.
Review URL: http://codereview.chromium.org/272026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28806 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Fixed indentations and added comments for some old suppressions.
TBR=dank,stuartmorgan
Review URL: http://codereview.chromium.org/269053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28805 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/270062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28779 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/266055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28770 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
app/gfx in preparation for removing the base_gfx project. This also moves
base/window_impl.cc to app/win/window_impl because this file shouldn't be in
base.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/273017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28691 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=24503
TBR=abarth
Memory errors caused by WebKit roll to r49372.
Review URL: http://codereview.chromium.org/270060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28660 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
use-after-free. Like 23018, this is happening because valgrind is slowing the worker thread shutdown enough that the backup terminate process code executes.
BUG=24346
TEST=covered by valgrind
Review URL: http://codereview.chromium.org/266036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Original code review: http://codereview.chromium.org/270040
BUG=17067
TEST=none
Review URL: http://codereview.chromium.org/264024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28586 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=24419,24307
TBR=dank
Review URL: http://codereview.chromium.org/267038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28566 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Relax "Linux perf morejs" variance. (Test variance too
high to give us useful "improved" results.) Repin and
relax "XP perf warm startup".
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/266041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28561 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move file accesses during initialization to file thread. Also fix a rare (and harmless) memory leak. Also introduce a rare (and harmless) memory leak.
TEST=added dchecks, ran spellcheck unit tests, clicked around, changed dictionaries, added words
BUG=22984
BUG=21924
BUG=1123096
Review URL: http://codereview.chromium.org/269020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This got triggered on the linux valgrind bot:
http://build.chromium.org/buildbot/waterfall/builders/Linux%20Tests%20(valgrind)(2)/builds/527/steps/valgrind%20test%3A%20ui/logs/stdio
And for whatever reason is constructing a different signature for KillProcessTask::Run().
BUG=23018
Review URL: http://codereview.chromium.org/266033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28490 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This has not reproduced in the past 40 runs of the valgrind bots.
Chromium Mac (valgrind)
Chromium Mac UI (valgrind)(1)
Chromium Mac UI (valgrind)(2)
Chromium Mac UI (valgrind)(3)
Linux Tests (valgrind)(1)
Linux Tests (valgrind)(2)
Linux Tests (valgrind)(3)
Linux Tests (valgrind)(4)
Webkit Linux (valgrind)
Webkit_Linux_(valgrind_layout)
BUG=22702
Review URL: http://codereview.chromium.org/269026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28467 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This hasn't shown up on the buildbots during the past 40 cycles of:
Chromium Mac (valgrind)
Chromium Mac UI (valgrind)(1)
Chromium Mac UI (valgrind)(2)
Chromium Mac UI (valgrind)(3)
Linux Tests (valgrind)(1)
Linux Tests (valgrind)(2)
Linux Tests (valgrind)(3)
Linux Tests (valgrind)(4)
Webkit Linux (valgrind)
Webkit_Linux_(valgrind_layout)
BUG=22559
Review URL: http://codereview.chromium.org/264017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28466 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This has not reproduced in the past 40 runs.
BUG=22031
Review URL: http://codereview.chromium.org/270031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28450 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
as the one-time leaks are intentional.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/270028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28442 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=24345,24346
TEST=none
Review URL: http://codereview.chromium.org/269023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28436 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=18984
Review URL: http://codereview.chromium.org/269017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28381 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Refactored out UrlIsAlive to live outside the ApacheHttpd class and imported http_utils.py into http_server.py
Now they share common code.
BUG=6784
TEST=started and stopped http_server successfully.
Review URL: http://codereview.chromium.org/243022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28351 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
but still shows up on the bots.
BUG=20814
Review URL: http://codereview.chromium.org/268009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28343 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=20778
Review URL: http://codereview.chromium.org/266008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28328 0039d316-1c4b-4281-b951-d872f2087c98
|