| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=27149
TEST=Valgrind
Review URL: http://codereview.chromium.org/380010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31558 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=26216
Review URL: http://codereview.chromium.org/372079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31538 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=27149
Review URL: http://codereview.chromium.org/381004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31440 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
v8 proved to be a very coarse bucket, and was too high up.
I've added several buckets, and put in a section for drilling
down on a specific bucket (contributions over a specific value).
r=mbelshe
Review URL: http://codereview.chromium.org/376003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=27035
Review URL: http://codereview.chromium.org/376020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=stuartmorgan
BUG=27035
TEST=none
Review URL: http://codereview.chromium.org/373023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=26966
Review URL: http://codereview.chromium.org/371042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31319 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=26326
Review URL: http://codereview.chromium.org/377012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31311 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
accumulate for a while, wasting memory and causing unneeded wakeups.
BUG=25641
TEST=green valgrind or heapchecker on net_unittests
Previously reviewed as
http://codereview.chromium.org/370005/
TBR=timurrrr
Review URL: http://codereview.chromium.org/372033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31306 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This version of memory_watcher can run under Vista, even though the
recursive calls that it handles are appearing often enough that there
is a performance penalty. With this landed, it may be possible for other
folks to run the tool, and I can work on improving its performance.
This CL also resolves the problem with hanging processes. Although
memory reporting can only be done once, and it leaves a pile of memory
"hanging around," the browser can be cleanly exited.
Tweaks include outputing the aggregate stacks such that the largest
stacks appear at the start of the output file.
This version avoids ongoing aggregation of stats in favor of only
doing the aggregation at dump-time. This probably enhances performance
at run-time, although it is hidden (on Vista) by the recursive calling.
This also simplifies the tracking code a fair amount.
There is some evidence that a small number of duplicate calls are being
made to "track" the same memory region, without an intervening free (i.e.,
call to "untrack"). The code to better diagnose this is currently in
place, but ifdef'ed, as it is only useful under a debugger. Exercise
of this code (turning a stack-frame list into a human readable stack
trace string) currently causes some corruption shortly after it triggers,
so I can't leave it on full time.
r=mbelshe
Review URL: http://codereview.chromium.org/366031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31299 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=26966
Review URL: http://codereview.chromium.org/371028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31286 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=26964
Review URL: http://codereview.chromium.org/378018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31279 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=dank
Review URL: http://codereview.chromium.org/371022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31231 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=25952
TEST=no more verbosity!
Review URL: http://codereview.chromium.org/368002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31150 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=24724
TEST=TSAN UI should remain green
Review URL: http://codereview.chromium.org/360010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31114 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Refactored WebWorkerClientProxy into two classes - WebWorkerDispatcher which dispatches incoming IPCs for the worker, and WebWorkerClientProxy, which handles outgoing API calls from WebWorkerImpl. This allows WebWorkerClientProxy to be reused by WebSharedWorkerDispatcher.
BUG=26233
TEST=none (will enable layout tests when basic functionality available)
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31077
Review URL: http://codereview.chromium.org/351004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
expected leak in CheckOpString
Review URL: http://codereview.chromium.org/361021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31053 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=26324
TEST=none
Review URL: http://codereview.chromium.org/342113
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=build bots should start spitting out debug info to stdio
BUG=25952
TBR=maruel
Review URL: http://codereview.chromium.org/342115
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30932 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
valgrind as valgrind.sh.
Add script to locally reproduce the nonleak valgrind errors
found recently by the linux valgrind layout bot.
Review URL: http://codereview.chromium.org/351017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30904 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=20111,26582
Review URL: http://codereview.chromium.org/346039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30837 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
See the report that didn't match the current suppression:
http://build.chromium.org/buildbot/waterfall/builders/Linux Tests (valgrind)(4)/builds/1395/steps/valgrind test: ui/logs/stdio
BUG=20111
TBR=dank,stuartmorgan
TEST=Valgrind bots should become green
Review URL: http://codereview.chromium.org/345047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30809 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Profiler log saver is now not engaged until profiling is really started, which should never happen in currently valgdrinded tests. Let's see if it's true.
BUG=24503
TEST=linux valgrind should not complain about the stack deleted from suppressions
Review URL: http://codereview.chromium.org/342094
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30808 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove some dead code.
Remove valgrind suppression which suppressed this error.
BUG=http://crbug.com/26489
TEST=Mac valgrind bot stays green for ui_test BrowserEncodingTest.TestEncodingAliasMapping
Review URL: http://codereview.chromium.org/355006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30793 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=26493
Review URL: http://codereview.chromium.org/353011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30789 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
instances.
BUG=26493
TBR=tim
Review URL: http://codereview.chromium.org/342081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=26489
TEST=Mac UI valgrind bots
Review URL: http://codereview.chromium.org/348040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30715 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=darin
Review URL: http://codereview.chromium.org/354001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30691 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The results are now sorted before being output, so there is no need
to pass the results through a sort filter.
Byte counts are now printed with comma separators between groups of
3 digits, so that 1234567 is now output as 1,234,567.
The summary.pl now has a number of more precise matches to better
give a quick estimate of blame for each allocation stack.
r=mbelshe
Review URL: http://codereview.chromium.org/348034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30673 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I removed a leak of "stack" objects, and made them a little
more lightweight by removing an unused member.
This change is only part of an option for chrome, that is not currently
linked in during any tests. It can only currently be used under XP, so
build-bot tests are not currently appropriate.
r=mbelshe
Review URL: http://codereview.chromium.org/345033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30672 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=dank
TEST=media should stop being flaky on TSAN/Mac bot
Review URL: http://codereview.chromium.org/344046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30665 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=25952
TEST=always exists "successfully"
Review URL: http://codereview.chromium.org/343068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
My local bots (both Linux and Mac) were cycling green with this option all the last week
except for one real race (fixed tonight) and two benign reports suppressed recently.
This option will help us find more races, especially my beloved ref-counter races.
TEST=TSAN bots should remain green
Review URL: http://codereview.chromium.org/348020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30636 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
appropriate place.
TBR=dank
Review URL: http://codereview.chromium.org/344040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30635 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23314,26324,26326
TEST=Mac UI valgrind bot green-ness
Review URL: http://codereview.chromium.org/341053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30589 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=dank
TEST=Linux TSAN bot green on unit_tests
Review URL: http://codereview.chromium.org/343058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30579 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds a suppression for a warning reported by
ThreadSanitizer with --ignore-in-dtor=no when a ClientAudioQueue
object is destroyed.
This appears to be a benign one.
This patch was prepared by Alexander Potapenko (cc'ed)
Review URL: http://codereview.chromium.org/348011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30475 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=26213
Review URL: http://codereview.chromium.org/346014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=26213,26216
TEST=Linix valgrind 1 bot
Review URL: http://codereview.chromium.org/339067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30459 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=dank
Review URL: http://codereview.chromium.org/348009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=25952
TEST=still executes regardless of where you run the script from
Review URL: http://codereview.chromium.org/347008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30396 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
svn properties.
TBR=maruel
BUG=25952
Review URL: http://codereview.chromium.org/345015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
correctly.
It looks for binaries built with /NXCOMPAT and /DYNAMICBASE, two important security features for Windows binaries.
BUG=25952
TEST=try running it on the output of /src/chrome/Debug
Review URL: http://codereview.chromium.org/338052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30304 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The race was specific to unit-test code (see r29826) and should be fixed now.
BUG=22272
Review URL: http://codereview.chromium.org/293042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30301 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=25913
TBR=dank
Review URL: http://codereview.chromium.org/343004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30247 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
reporteed.
I think this may increase the popularity and usability of our tools.
Review URL: http://codereview.chromium.org/343002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30246 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=24715
TBR=dank
Review URL: http://codereview.chromium.org/339022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30182 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This race was already suppressed, but the existing suppression doesn't
work if the order of accesses is different. We can prepare a suppression to make TSAN bots silent
but it will be way too wide. I think adding one line of annotation with comment (twice) is better in terms of precision.
BUG=25841
Review URL: http://codereview.chromium.org/339008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30181 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=25915
TBR=dank
Review URL: http://codereview.chromium.org/340001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30180 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
third_party races.
BUG=25913
TBR=dank
Review URL: http://codereview.chromium.org/333047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30178 0039d316-1c4b-4281-b951-d872f2087c98
|