| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
Removed LOAD_FROM_CACHE_IF_OFFLINE flag and related test cases.
BUG=426442
Review URL: https://codereview.chromium.org/1080673004
Cr-Commit-Position: refs/heads/master@{#327015}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
VideoRecorder.IsStarted (patchset #1 id:1 of https://codereview.chromium.org/1093923004/)
Reason for revert:
It still times out:
http://build.chromium.org/p/chromium.perf/builders/Android%20One%20Perf/builds/615/steps/service_worker.service_worker/logs/stdio
Original issue's description:
> Telemetry: Re-enable ServiceWorkerPerfTest, increase timeout for VideoRecorder.IsStarted
>
> ServiceWorkerPerfTest was failing on Android One, due to timeouts of
> VideoRecorder.IsStarted(). This patch attempts to fix this by increasing
> the timeout from 5 seconds to 10 seconds, and re-enable the test.
>
> BUG=469841
> TEST=tools/perf/run_benchmark --browser=trybot-all-android service_worker.service_worker
>
> Committed: https://crrev.com/42ce01867659573b37b46df12a3db18ba26674b9
> Cr-Commit-Position: refs/heads/master@{#326820}
TBR=sullivan@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=469841
Review URL: https://codereview.chromium.org/1099033005
Cr-Commit-Position: refs/heads/master@{#327005}
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/1067583004
Cr-Commit-Position: refs/heads/master@{#326982}
|
|
|
|
|
|
|
|
|
|
|
|
| |
The bug is in Apple's CL_extractCSSMKeyNSS, specifically when it allocates some
memory directly at the top of the function. Move it out of the Chromium bugs
section and cite openradar.
BUG=481286
Review URL: https://codereview.chromium.org/1102673006
Cr-Commit-Position: refs/heads/master@{#326977}
|
|
|
|
|
|
|
|
|
|
| |
BUG=430156,345874
TBR=inferno@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/1103023003
Cr-Commit-Position: refs/heads/master@{#326969}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, telemetry read the whole '/proc/timer_list' file just to parse the
first occurence of "jiffies". In case the file is big and telemetry is run
against remote device, this can create a big delay for transferring the file
to host device.
This patch modify it so that telemetry just use
'grep jiffies /proc/timer_list' to get the only lines that contain 'jiffies'.
Context: https://groups.google.com/a/chromium.org/forum/#!topic/telemetry/SblQqF0tHbc
Try job runs:
./tools/perf/run_benchmark --browser=trybot-all-android page_cycler.top_10_mobile --also-run-disabled-tests
https://codereview.chromium.org/1100233003
./tools/perf/run_benchmark --browser=trybot-all-mac page_cycler.intl_ja_zh
https://codereview.chromium.org/1106833004
./tools/perf/run_benchmark --browser=trybot-all-linux page_cycler.intl_ja_zh
https://codereview.chromium.org/1102673005
Review URL: https://codereview.chromium.org/1106043003
Cr-Commit-Position: refs/heads/master@{#326961}
|
|
|
|
|
|
|
|
|
| |
BUG=481305
TBR=emircan@chromium.org,hanxi@chromium.org
Review URL: https://codereview.chromium.org/1085323004
Cr-Commit-Position: refs/heads/master@{#326958}
|
|
|
|
|
|
|
|
|
| |
BUG=481290
TBR=chirantan@chromium.org
Review URL: https://codereview.chromium.org/1107733007
Cr-Commit-Position: refs/heads/master@{#326951}
|
|
|
|
|
|
|
|
|
| |
BUG=481286
TBR=davidben@chromium.org
Review URL: https://codereview.chromium.org/1100563003
Cr-Commit-Position: refs/heads/master@{#326950}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Prior to this CL, if there were multiple targets ina GN build
with the name 'unit_tests', we would not generate a top-level
phony ninja target for them; you would have to specify either
the full path to the output or the label name.
This is confusing for things like 'browser_tests' and 'unit_tests',
where in Chromium we might have multiple targets with that name,
but only one of those is an executable (at least in the default
toolchain).
This CL adds logic to handle that case (so that 'unit_tests' does work).
R=brettw@chromium.org
BUG=480042
Review URL: https://codereview.chromium.org/1101323005
Cr-Commit-Position: refs/heads/master@{#326942}
|
|
|
|
|
|
|
|
|
|
|
| |
error in DrMemory.
TBR=bruening@chromium.org,sebmarchand@chromium.org
BUG=481231
Review URL: https://codereview.chromium.org/1105523006
Cr-Commit-Position: refs/heads/master@{#326934}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
crrev.com/318812 switched our latency metrics from using
the end of GPU swap to the beginning. The abrupt switch
makes it difficult to compare latency in M43 to previous
versions.
This patch restores the old behavior for the existing
latency metrics and adds new metrics instead for the
new behavior.
Only UMA is affected. The abrupt switch for telemetry
remains in place.
BUG=476213
Review URL: https://codereview.chromium.org/1093923002
Cr-Commit-Position: refs/heads/master@{#326931}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We want to change activate so that rejecting the waitUntil promise
is the same as resolving it. Adding UMA to get an idea of the impact
of the change. It could be useful to have this data anyway, so also
adding it for Install.
BUG=480050
Review URL: https://codereview.chromium.org/1098953005
Cr-Commit-Position: refs/heads/master@{#326925}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds SERVICE_WORKER_ERROR_DISK_CACHE to indicate
failure to read from the disk cache. It also re-enables
logging of StartWorker for redundant workers. This was
previously disabled because we got a lot of "failed" spam
for updates that get aborted when there is no script change,
so I've changed StartWorker to fail with SW_ERROR_EXISTS in
that case.
This patch is a step in the direction of evicting a SW
that can't be read from disk cache.
BUG=448003
Review URL: https://codereview.chromium.org/1054033004
Cr-Commit-Position: refs/heads/master@{#326923}
|
|
|
|
|
|
|
|
|
|
| |
Debugging some tests that were unblocked by codereview.chromium.org/1084793002, I found that waiting for the password field to disappear sometimes fails. We need to wait for the OOBE page to disappear before continuing to the test logic.
BUG=480571
Review URL: https://codereview.chromium.org/1063853008
Cr-Commit-Position: refs/heads/master@{#326915}
|
|
|
|
|
|
|
|
|
|
| |
Depend on https://codereview.chromium.org/999243003/.
BUG=466867
Review URL: https://codereview.chromium.org/1061133002
Cr-Commit-Position: refs/heads/master@{#326913}
|
|
|
|
|
|
|
|
|
|
|
| |
It is not implemented yet. So all InstanceID***Functions are just placeholders.
BUG=477084
TEST=none
Review URL: https://codereview.chromium.org/1088593004
Cr-Commit-Position: refs/heads/master@{#326909}
|
|
|
|
|
|
|
|
|
| |
R=mdempsky@chromium.org
BUG=468851
Review URL: https://codereview.chromium.org/1106003002
Cr-Commit-Position: refs/heads/master@{#326905}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
adding a chrome flag.
This will also be enabled on Aura when Aura and Android touch selection flows
finally unified. I also plan to have at least one more experimental strategy
implmenented.
Prerequisite CL: https://codereview.chromium.org/988023005/
BUG=451255
Review URL: https://codereview.chromium.org/1096773002
Cr-Commit-Position: refs/heads/master@{#326896}
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the underlying call to 'gn gen' (or gyp_chromium) failed,
mb was swallowing the error.
R=brettw@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1078913003
Cr-Commit-Position: refs/heads/master@{#326892}
|
|
|
|
|
|
|
|
|
|
|
| |
The out-of-bounds access leads to a test failure under DrMemory.
BUG=480650
TBR=eae@chromium.org
Review URL: https://codereview.chromium.org/1109533003
Cr-Commit-Position: refs/heads/master@{#326888}
|
|
|
|
|
|
|
|
|
|
| |
See https://docs.google.com/document/d/1AZmbifXOirRdIcAkhgXT_u1wam5FRxy-Wt7I-kv3CCg/edit?usp=sharing for details.
BUG=479306
Review URL: https://codereview.chromium.org/1099313003
Cr-Commit-Position: refs/heads/master@{#326864}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
search engines.
Also add the first parts of the Search settings UI in MD-settings, namely the 'default search engine' dropdown. Follow-up CLs will fill in the remaining functionality.
(Disabling presubmit because it requires a manual confirmation that permission_message.h looks ok. I confirmed this.)
BUG=479359
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/1096143003
Cr-Commit-Position: refs/heads/master@{#326844}
|
|
|
|
|
|
|
|
|
| |
These were removed in https://codereview.chromium.org/969973002
Please see that CL for why.
Review URL: https://codereview.chromium.org/1059803003
Cr-Commit-Position: refs/heads/master@{#326843}
|
|
|
|
|
|
|
|
|
|
|
| |
This CL also instruments the function to better understand which edge case
triggers the issue in the first place.
BUG=471586
Review URL: https://codereview.chromium.org/1054113004
Cr-Commit-Position: refs/heads/master@{#326835}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Launcher_MinimzeTask user action is recorded when the user activates a
shelf icon causing a window to be minimized.
TEST=ShelfViewTest.Launcher_MinimizeTaskIsRecordedWhenWindowIsMinimized
BUG=471358
Review URL: https://codereview.chromium.org/1098193003
Cr-Commit-Position: refs/heads/master@{#326834}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
VideoRecorder.IsStarted
ServiceWorkerPerfTest was failing on Android One, due to timeouts of
VideoRecorder.IsStarted(). This patch attempts to fix this by increasing
the timeout from 5 seconds to 10 seconds, and re-enable the test.
BUG=469841
TEST=tools/perf/run_benchmark --browser=trybot-all-android service_worker.service_worker
Review URL: https://codereview.chromium.org/1093923004
Cr-Commit-Position: refs/heads/master@{#326820}
|
|
|
|
|
|
|
|
| |
BUG=480999
Review URL: https://codereview.chromium.org/1109553002
Cr-Commit-Position: refs/heads/master@{#326810}
|
|
|
|
|
|
|
|
| |
BUG=476648,479710
Review URL: https://codereview.chromium.org/1100413002
Cr-Commit-Position: refs/heads/master@{#326784}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix bugs related to the latest GN roll.
1) the new GN binary will return an error if you pass it
a file it doesn't know anything about in 'gn refs'.
2) for some reason with the new GN binary we're triggering a
code path in gyp_flag_compare.py that wasn't running before,
and that code path was busted.
TBR=brettw@chromium.org
BUG=
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg;tryserver.chromium.win:win8_chromium_gn_rel
Review URL: https://codereview.chromium.org/1109453002
Cr-Commit-Position: refs/heads/master@{#326736}
|
|
|
|
|
|
|
|
|
|
|
| |
under DrMemory for flakiness.
BUG=480750
TBR=prabhur@chromium.org
Review URL: https://codereview.chromium.org/1105793003
Cr-Commit-Position: refs/heads/master@{#326730}
|
|
|
|
|
|
|
|
|
| |
TBR=reveman@chromium.org
BUG=480741
Review URL: https://codereview.chromium.org/1093693007
Cr-Commit-Position: refs/heads/master@{#326725}
|
|
|
|
|
|
|
|
|
| |
R=phajdan.jr@chromium.org
BUG=479509
Review URL: https://codereview.chromium.org/1061983006
Cr-Commit-Position: refs/heads/master@{#326722}
|
|
|
|
|
|
|
|
|
|
|
| |
read on DrMemory.
BUG=480721
TBR=amistry@chromium.org
Review URL: https://codereview.chromium.org/1108493002
Cr-Commit-Position: refs/heads/master@{#326711}
|
|
|
|
|
|
|
|
|
| |
BUG=477457
R=rdevlin.cronin@chromium.org
Review URL: https://codereview.chromium.org/1100333006
Cr-Commit-Position: refs/heads/master@{#326703}
|
|
|
|
|
|
|
|
|
|
|
| |
Add benchmark and measurement for measuring quiescent power, and enable
it on Mac.
Moved the workaround for http://crbug.com/419786 so that we don't lose idle
wakeups numbers for the renderer process.
Review URL: https://codereview.chromium.org/1092393002
Cr-Commit-Position: refs/heads/master@{#326698}
|
|
|
|
|
|
|
|
|
| |
TBR=eae@chromium.org
BUG=480650
Review URL: https://codereview.chromium.org/1100423002
Cr-Commit-Position: refs/heads/master@{#326677}
|
|
|
|
|
|
|
|
|
|
| |
Adds a copied version of base::WriteFile with extra logging turned on, and the FILE_SHARE_READ flag set which speculatively might fix the issue.
BUG=468437
Review URL: https://codereview.chromium.org/1098963003
Cr-Commit-Position: refs/heads/master@{#326663}
|
|
|
|
|
|
|
|
|
|
|
|
| |
And remove a now-redundant suppression.
The new report started in http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28valgrind%29%284%29/builds/41916, so https://crrev.com/326138 probably kicked it off, but these leaks are expected on shutdown.
TBR=jeremyim@chromium.org,glider@chromium.org
Review URL: https://codereview.chromium.org/1101193002
Cr-Commit-Position: refs/heads/master@{#326658}
|
|
|
|
|
|
|
|
| |
BUG=476043
Review URL: https://codereview.chromium.org/1080463003
Cr-Commit-Position: refs/heads/master@{#326657}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL rewrites the unit tests for buildbot_output_formatter to pertain only
to the summary module, in preparation for removing buildbot_output_formatter.
BUG=477056
R=nednguyen
Review URL: https://codereview.chromium.org/1092593004
Cr-Commit-Position: refs/heads/master@{#326650}
|
|
|
|
|
|
|
|
| |
BUG=480590
Review URL: https://codereview.chromium.org/1103773002
Cr-Commit-Position: refs/heads/master@{#326645}
|
|
|
|
|
|
|
|
| |
Remove SupervisedUserHandler - this is now implemented by SupervisedUserWhitelistInstaller
Review URL: https://codereview.chromium.org/1093953003
Cr-Commit-Position: refs/heads/master@{#326643}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Helpers that allow ChromeOS tests to invoke and complete the
enterprise enrollment flow.
BUG=chromium:474707
TEST=Ran with my unsubmitted CrOS autotest cases
Review URL: https://codereview.chromium.org/1084793002
Cr-Commit-Position: refs/heads/master@{#326611}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This new feature allows enterprises to set a policy
such that users will not be allowed to override any
SSL errors.
BUG=440949
Review URL: https://codereview.chromium.org/1060833003
Cr-Commit-Position: refs/heads/master@{#326607}
|
|
|
|
|
|
|
|
| |
BUG=475714
Review URL: https://codereview.chromium.org/1100233002
Cr-Commit-Position: refs/heads/master@{#326588}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Plumb the "painting disabled" mode through to disable the GraphicsContext
in Slimming Paint perf testing. This mode causes Graphics Context to do
no work, producing empty SkPictures for all drawing display items. This
seems the best interpretation of "painting disabled".
The perf results lines for slimming_paint record_time_null_canvas will
go to zero after this patch, and the record_time_construction_disabled
result will start appearing and be zero for non slimming paint.
R=sullivan,skyostil,enne,ajuma
BUG=471348
Review URL: https://codereview.chromium.org/1104433005
Cr-Commit-Position: refs/heads/master@{#326586}
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/1082723009
Cr-Commit-Position: refs/heads/master@{#326557}
|
|
|
|
|
|
|
|
|
|
|
| |
Sometimes it is confusing to see ScrollUpdate slippage is traced
under name InputLatency. Lets rename it to be Latency::ScrollUpdate.
BUG=None
Review URL: https://codereview.chromium.org/1096413002
Cr-Commit-Position: refs/heads/master@{#326548}
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/1101863002
Cr-Commit-Position: refs/heads/master@{#326527}
|