| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make it possible to specify on a GPU vendor/device basis whether a
telemetry test is expected to pass on Android. On desktop and CrOS we
use the PCI device identifiers for this purpose, but they are not
available on Android. Instead, this patch makes lets us match
expectations against the GL_VENDOR and GL_RENDERER strings.
BUG=306462
Review URL: https://codereview.chromium.org/27009002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228446 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/27054004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228411 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=None
Review URL: https://codereview.chromium.org/26932003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228410 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=304342
Review URL: https://codereview.chromium.org/26093002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228378 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
record_wpr tries to __init__ all measurements, so a measurement that
isn't supported on a platform should not raise in its __init__.
BUG=296172
Review URL: https://codereview.chromium.org/26769002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228351 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This relands the clang roll from r226920. The symbol issue
(http://crbug.com/304846) should be fixed by now, on the crash server side.
> Revert 226920 "Roll Clang 188423:191856."
>
> Possibly broke crash symbolication on mac.
>
> > Roll Clang 188423:191856.
> >
> > Remove libprofile_rt from package.sh, it doesn't exist after LLVM r191835
> >
> > BUG=290204,303886
> > R=thakis@chromium.org
> > TBR=net owner
> > NOTRY=true
> >
> > Review URL: https://codereview.chromium.org/25875004
>
> TBR=thakis@chromium.org
>
> Review URL: https://codereview.chromium.org/26145004
TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/27092002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228318 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=306729
TBR=jochen@chromium.org
Review URL: https://codereview.chromium.org/27091002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
scons hasn't been used in a long time.
BUG=305702
NOTRY=true
Review URL: https://codereview.chromium.org/26718002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228308 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Suppression introduced in https://codereview.chromium.org/24731002,
fix attempted in https://codereview.chromium.org/24615004.
BUG=298788
TBR=timurrrr@chromium.org
Review URL: https://codereview.chromium.org/27013005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228301 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rename it to page_cycler.indexed_db.basic_insert. Make page_cycler.indexeddb an alias for it.
BUG=None.
TEST=tools/perf/run_benchmark list page_cycler.indexeddb # Gives a result.
R=tonyg@chromium.org
Review URL: https://codereview.chromium.org/27051006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228286 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
[Broke android dbg tests.]
> Recover version 6 Favicons, fix meta table.
>
> Version 6 is exactly like version 7, except it has an extra trailing
> column on favicons which was never used. The version-7 recovery code
> works for it, so long as the meta table is updated correctly.
>
> In writing this change, I realized that the meta table wasn't being
> created for recovered databases. Instead, SQLite was resolving to the
> corrupt.meta table. This works so long as the version doesn't change
> (next open will populate meta with kCurrentVersion). This change
> makes the table references absolute, and fixes the meta table setup.
>
> BUG=240396
> R=jar@chromium.org, pkotwicz@chromium.org, sky@chromium.org
>
> Review URL: https://codereview.chromium.org/25032004
TBR=shess@chromium.org
Review URL: https://codereview.chromium.org/27062003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228260 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- switched rasterize_and_record benchmark to new benchmark architecture.
- detailled traces are not required anymore, fixing the issue with trace
event buffer overflows.
- changed output to show pixels rasterized and recorded for one iteration of the raster/record loop.
- Further reduced variance by excluding lowres tiles and adding another sleep to the measurement. Stdev of pixel counts is now zero (except for amazon.com). Stdev of time metrics with 100 repetitions is well below 1% of the mean for most pages in the top_25.
R=nduca@chromium.org
BUG=280638
Review URL: https://codereview.chromium.org/25353009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228253 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
It didn't exactly match the histogram being recorded.
BUG=301511
NOTRY=true
Review URL: https://codereview.chromium.org/26839005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228251 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
These aliases are hidden from the user, but entering the exact phrase (as the bots do) will automatically convert to the canonical name.
BUG=None.
TEST=tools/perf/run_benchmark list page_cycler.pica # lists pica.pica
R=tonyg@chromium.org
Review URL: https://codereview.chromium.org/26988002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
than prompt the user to figure it out and do it.
Review URL: https://codereview.chromium.org/26116005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228241 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since ViewVC is now not showing raw files. This is still fragile and should be improved, but we need to rethink the whole bootstrap story.
This is a rework of http://crrev.com/13646020
BUG=227224
Review URL: https://codereview.chromium.org/26221005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Version 6 is exactly like version 7, except it has an extra trailing
column on favicons which was never used. The version-7 recovery code
works for it, so long as the meta table is updated correctly.
In writing this change, I realized that the meta table wasn't being
created for recovered databases. Instead, SQLite was resolving to the
corrupt.meta table. This works so long as the version doesn't change
(next open will populate meta with kCurrentVersion). This change
makes the table references absolute, and fixes the meta table setup.
BUG=240396
R=jar@chromium.org, pkotwicz@chromium.org, sky@chromium.org
Review URL: https://codereview.chromium.org/25032004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228217 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/25500002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228184 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch reverts https://codereview.chromium.org/23831002/
This is to try and see whether that patch caused a 7% regression on
JSGameBench.
BUG=294358
Review URL: https://codereview.chromium.org/26698004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=263162
TEST=None
Review URL: https://codereview.chromium.org/26225004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228154 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium:304950
TEST=Validated the XML, pretty print succeeded.
Review URL: https://codereview.chromium.org/26882007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228085 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
With "add_browser_metrics" options, the media measurements will record
memory and cpu metrics per test.
BUG=280326
Review URL: https://codereview.chromium.org/25084004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228083 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Originally added in https://codereview.chromium.org/23825004/
R=asvitkine@chromium.org, yoz@chromium.org
BUG=304905
Review URL: https://codereview.chromium.org/26304003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228061 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Android which may commit the initial page after telemetry begins another navigation, at which point RenderViewHostManager::DidNavigateMainFrame() will toss the other navigation because it's pending.
Review URL: https://codereview.chromium.org/23468031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I need to merge this into m30 or even m29 so trying to find a happy place to gather this.
It can be found as Platform.LogicalCpuCount
BUG=none
TBR=sky
TEST=none
Review URL: https://codereview.chromium.org/25647002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will avoid the problem, in most cases, where we prerender a login page,
don't commit fast enough, and then incorrectly use it after the user has
already logged in.
BUG=292121
TEST=PrerenderBrowserTest.PrerenderNoCommitNoSwap
Review URL: https://codereview.chromium.org/26638004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228012 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=304970
Review URL: https://codereview.chromium.org/26713004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227964 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=timurrrr@chromium.org
TBR=thestig@chromium.org
BUG=297040
NOTRY=true
Review URL: https://codereview.chromium.org/26675005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227957 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This makes the code a lot simpler.
BUG=none
Review URL: https://codereview.chromium.org/26736002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227848 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
CL for the actions landed in https://codereview.chromium.org/25657010
BUG=305723
NOTRY=true
Review URL: https://codereview.chromium.org/26605003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227810 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently AppsModelBuilder assumes all items are ExtensionAppItems.
This will no longer be true as soon as we add AppListFolderItems.
We need to make AppsModelBuilder only apply to extension items.
By design we no longer wish to sync app list ordering with the extension
ordering used by the NTP. This CL will only use the extension ordering
for initial sorting, and as a result app list order changes will not be
preserved until we start saving / syncing the app list order separately,
crbug.com/305024
BUG=303839
For ash/shell/app_list.cc
R=jennyz@chromium.org, koz@chromium.org, xiyuan@chromium.org
TBR=jamescook@chromium.org
Review URL: https://codereview.chromium.org/26328004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227808 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=NONE
Review URL: https://codereview.chromium.org/26605002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227803 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Older version of stdio.h in glibc (before 2.17) has warn_unused_result attribute on fwrite.
That causes build failure.
This CL change suppress the warning.
NOTRY=true
Review URL: https://codereview.chromium.org/26587006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227721 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=294387
Review URL: https://codereview.chromium.org/26647002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227718 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Simplify Close() to always tear down the underlying socket
- Always close the TestCastSocket in TearDown()
- Keep track of whether the mock socket was actually passed to CastSocket and destroy it if necessary
- Fix virtual dtor
TESTED=$ASAN_OPTIONS="detect_leaks=1 strict_memcmp=0" out/{Debug,Release}/unit_tests --gtest_filter="CastSocket*"
BUG=304970
Review URL: https://codereview.chromium.org/26358004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Added the Prerender.ModPagespeedHeader.* histograms to histograms.xml.
> Extended the data extraction to also handle X-Page-Speed headers.
>
> (dup of 20832003 which I can't commit with my personal email account)
>
> BUG=267695
>
> Review URL: https://codereview.chromium.org/26279004
This test caused a leak on the memory bots. Details can be found here:
http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28valgrind%29%283%29/builds/30782/
TBR=matterbury@google.com
Review URL: https://codereview.chromium.org/26670002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227696 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Extended the data extraction to also handle X-Page-Speed headers.
(dup of 20832003 which I can't commit with my personal email account)
BUG=267695
Review URL: https://codereview.chromium.org/26279004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227685 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Put category-remaining node into this category node rather than parallel with it.
2. Fix a bug in menu-view.js.
BUG=259206,305097
NOTRY=True
Review URL: https://codereview.chromium.org/26478002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227678 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Removed everything except for frame count, paint/record/rasterize time and
pixel count.
- Cleaned up variable naming.
- Removed RasterStats struct. Replaced by direct usage of
RenderingStatsInstrumentation.
R=nduca@chromium.org
BUG=234308,280638
Review URL: https://codereview.chromium.org/26031002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227666 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is reporting race conditions on TSAN v2.
NOTRY=true
TBR=glider@chromium.org
BUG=305459
Review URL: https://codereview.chromium.org/26434003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227657 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This speeds up requests on Windows significantly.
BUG=305367
R=dtu@chromium.org, kbr@chromium.org
Review URL: https://codereview.chromium.org/26595002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
apply.
BUG=225939
R=dtu@chromium.org
Review URL: https://codereview.chromium.org/26616003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227630 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=294923
NOTRY=true
Review URL: https://codereview.chromium.org/26552003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227618 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
HostFileSystemProvider class, basically a rename of HostFileSystemCreator with
a stricter notion of trunk vs branches.
In some ways this is a follow-up to r218556, except solving the problem in a
type-safe (rather than special-case) way, as requested in that review. I also
need it to be able to support "host" file systems as a content provider, see
bug 293678.
This patch also enforces that the "branch" of a channel is a string, and fixes a
bunch of callers, because a bug there was exposed as part of this work.
BUG= 273105, 293678
R=jyasskin@chromium.org
Review URL: https://codereview.chromium.org/26418002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227602 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The bot config passes an empty "" parameter, which makes optparse stop parsing
arguments -- on linux, the empty parameter gets filtered out before reaching
this script. There's no reason to stop option parsing on the first non-flag
as far as I can see, so don't do that.
See the bug for details.
BUG=305292
NOTRY=true
Review URL: https://codereview.chromium.org/26548002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227601 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A source set acts like a static library in most cases, but doesn't actually make the library. The object files will be added to targets that depend on it.
I changed the default component mode to be a "source set" rather than a shared library in non-component mode.
This fixes the script target writer unit test on Windows.
BUG=
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/26267003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227596 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=tonyg@chromium.org, bulach@chromium.org
NOTRY=true
BUG=305302
Review URL: https://codereview.chromium.org/26513003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227572 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For C# projects, if a ProjectType GUID is not available, the vague error
"The project type is not supported by this installation" is given.
In this case the issue is usually that the Visual Studio SDK is not
installed.
R=zturner@chromium.org
Review URL: https://codereview.chromium.org/26460003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227550 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For Mac/ASan builds, a .dylib file containing ASan runtime functions is
copied into the build directory from LLVM. To make sure that the .dylib
file is updated when Clang is updated, we clobber all .dylib files in
the build directory, similarly to how we clobber .o files.
BUG=304125
Review URL: https://codereview.chromium.org/26424002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227545 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
includes everything from discrepancy.py and all of the statistical functions in smoothness.py.
These are utility functions that could be used by other modules.
BUG=
Review URL: https://codereview.chromium.org/26203005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227530 0039d316-1c4b-4281-b951-d872f2087c98
|