| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changing the default allocator from TCMalloc to
JEMalloc introduced a page load perf regression.
The change is experimental on the trunk. While in
place, adjust expectations to avoid firing the perf
regression framework.
BUG=23565
TEST=XP perf morejs goes green
Review URL: http://codereview.chromium.org/255043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27757 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
stack traces much more informative.
Two TSAN-specific --show-pc=yes flag was added for the helper to operate.
This patch was prepared by Alexander Potapenko (cc'ed)
Review URL: http://codereview.chromium.org/256025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
and a relevant OpenRadar bug id (rdar://7223948)
This patch was prepared by Alexander Potapenko (cc'ed)
Review URL: http://codereview.chromium.org/251058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This will speed up ThreadSanitizer by 1.5-2x on some tests.
This may result in missing data races on V8 (will address later)
Review URL: http://codereview.chromium.org/255038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27730 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
current suppressions to match either. Matches
recent change in memcheck_analyze.py.
(Only doing it in suppressions_mac.txt in case
somebody decides to move a suppression to suppressions.txt.)
Also shorten a too-long suppression that was just checked in.
Review URL: http://codereview.chromium.org/255027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27656 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
This patch was prepared by Alexander Potapenko (cc'ed)
Review URL: http://codereview.chromium.org/242080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27645 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
between mac and linux, and to avoid droning on and on and on and on.
Review URL: http://codereview.chromium.org/255026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27642 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23450
TEST=none
Review URL: http://codereview.chromium.org/257006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27640 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
The suppression-count logic is copied from memcheck_analyze.py
Review URL: http://codereview.chromium.org/246046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/256011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27623 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This suppresses a warning that fired in SessionRestoreUITest.*
16 times during a five day fishing expedition on linux at r26941.
BUG=19371
TEST=run valgrind on ui tests
Review URL: http://codereview.chromium.org/242076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27621 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23416
TEST=none
TBR=stuartmorgan
Review URL: http://codereview.chromium.org/251040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27598 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/235056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
We expand the _M_mutate rule to match both _M_mutateEjjj (Linux) and
_M_mutateEmmm (Mac) and add a rule for _M_set_length_and_sharable
This patch was prepared by Alexander Potapenko (cc'ed)
Review URL: http://codereview.chromium.org/242054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27508 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Unfortunately, we can't make it more narrow since the stacktrace in the report looks like:
#0 base::Thread::ThreadMain()
#1 ThreadFunc(void*)
#2 ThreadSanitizerStartThread
Review URL: http://codereview.chromium.org/251028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27505 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
I've missed /usr/lib32/nss/libsoftokn3 in the previous patch
( http://codereview.chromium.org/242032 )
("ldd ./sconsbuild/Debug/base_unittests" doesn't show it)
Review URL: http://codereview.chromium.org/235054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27499 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23314
TEST=none
TBR=stuartmorgan
Review URL: http://codereview.chromium.org/245040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27461 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23310,23313
TEST=none
TBR=jhawkins
Review URL: http://codereview.chromium.org/251026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27460 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=16584
TEST=none
Review URL: http://codereview.chromium.org/251021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Currently, RSAPrivateKeyUnitTest.InitRandomTest takes too long to pass.
We ignore istrumentation of NSS to speed up the tests that use it.
Review URL: http://codereview.chromium.org/242032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27366 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Darwin-specific ignore files to ThreadSanitizer.
This is necessary because ThreadSanitizer cannot handle the dSYM files
properly and the "src:*" ignore rules don't work on Mac.
The ignores_mac file contains the rules that make ThreadSanitizer
ignore the false positives reported on
base::subtle::{NoBarrier_Load, Release_Store}
This patch was prepared by Alexander Potapenko (cc'ed)
Review URL: http://codereview.chromium.org/251017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27365 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
==25902== </valgrindoutput>
==25902== FATAL: in suppressions file "/b/slave/chromium-rel-linux-valgrind-tests-1/build/src/tools/valgrind/memcheck/suppressions.txt" near line 1081:
==25902== too many callers in stack trace
==25902== exiting now.
So, i'm making the stack trace smaller.
Review URL: http://codereview.chromium.org/244020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27358 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=senorblanco@chromium.org
BUG=23197
TEST=None
Review URL: http://codereview.chromium.org/243020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27338 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23151
TEST=none
TBR=dank
Review URL: http://codereview.chromium.org/242016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27314 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=22932
TEST=none
TBR=stuartmorgan
Review URL: http://codereview.chromium.org/243015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27309 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=20113
TEST=none
Review URL: http://codereview.chromium.org/248008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27292 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG:19833
Review URL: http://codereview.chromium.org/212040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27244 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
widening of the call stack).
BUG=22923, 22932
TEST=Suppressed tests will work again, when fixed.
Review URL: http://codereview.chromium.org/235020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27236 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=22031
TEST=none
Review URL: http://codereview.chromium.org/235024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23018
TEST=none
TBR=dank
Review URL: http://codereview.chromium.org/235021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27175 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=23014
TEST=none
TBR=jhawkins
Review URL: http://codereview.chromium.org/241003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27173 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
already in the Win+Linux list.
BUG=22923,22932
TEST=remove suppressions and nothing bad happens.
TBR=leiz
Review URL: http://codereview.chromium.org/245001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27170 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(Doesn't cover suppressions_mac.txt)
Some suppressions didn't trigger because the test was disabled. It is assumed that before re-enabling such a test someone would fix it and check that it doesn't still need any suppressions:
BUG=6522
BUG=11838
Not reproducible, bug is already closed:
BUG=10750
BUG=11117
BUG=12539,12549,12661
Not reproducible (or not enough info to try):
BUG=4609
BUG=16103
BUG=16129 (probably fixed by r20100)
BUG=16578
BUG=16584
BUG=16586
BUG=16625
BUG=16908
BUG=18654
BUG=19385
BUG=19490
Review URL: http://codereview.chromium.org/219021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27168 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
SessionHistoryTest.HistorySearchXSS to the valgrind suppression list.
BUG=22984
TEST=Valgrind bot does not report this leak any more when running SessionHistoryTest.HistorySearchXSS
TBR=dank
Review URL: http://codereview.chromium.org/223030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27155 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
and r27060.
BUG=22932
TEST=Linux valgrind bots do not fail.
TBR=dank
Review URL: http://codereview.chromium.org/235009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27116 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=18268
TEST=run the included test under valgrind without the navigation_controller.cc change, then with. The memcheck condititional jump error shouldn't fire with the fix.
Review URL: http://codereview.chromium.org/220002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27105 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is to cover one more instance (that shares the stack except for the 1st several frames)
with the existing signature.
BUG=22923
TEST=Linux valgrind bots do not spit errors with WorkerTest.
TBR=atwilson
Review URL: http://codereview.chromium.org/218031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
used. This fixes a bug were we skip numbers in a header file.
Review URL: http://codereview.chromium.org/233004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27087 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/224011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27081 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=paul
BUG=22923
Review URL: http://codereview.chromium.org/235006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27080 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Set the perf expectations on linux, mac, and windows
perf systems for the morejs and warm startup tests.
Update comment in the perf_expectations unit test regex.
BUG=18597
TEST=build.chromium.org perf slaves stay green
Review URL: http://codereview.chromium.org/231017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27068 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR: mark@chromium.org
(Since this looks like something you've dealt with before)
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27050 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This relands: http://codereview.chromium.org/208032.
Additionally, it fixes a memleak unconvered by valgrind, and adds a valgrind supression for a memleak discovered in the nss library. https://bugzilla.mozilla.org/show_bug.cgi?id=518443
BUG=20669
Review URL: http://codereview.chromium.org/218010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27033 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This should be OK since http://src.chromium.org/viewvc/chrome?view=rev&revision=23306
This can speed up some tests by 10%...20%
I was running Valgrind & TSAN with both patches locally for more than a month and everything was fine.
Review URL: http://codereview.chromium.org/220013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26988 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=22563
Review URL: http://codereview.chromium.org/229001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26974 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
(oops)
Also say which valgrind is being used
Review URL: http://codereview.chromium.org/233003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26967 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Account for a new frame in a leak.
Widen a Cond suppression substantially, since it doesn't seem to matter how it was called.
TBR=dank
BUG=22702,22021
TEST=Mac and Linux valgrind bots
Review URL: http://codereview.chromium.org/222006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26932 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
(This changelist is prepared by Alexander Potapenko, cc'ed)
This is a small refactoring that moves the GDB querying logic into a
separate module to allow us using it from tsan_analyze as well (we need it finally).
The diff is almost equal to http://codereview.chromium.org/175026,
I've only swapped two lines to make it applicable to the current trunk version.
Review URL: http://codereview.chromium.org/211023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26911 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/216050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26910 0039d316-1c4b-4281-b951-d872f2087c98
|