summaryrefslogtreecommitdiffstats
path: root/tools
Commit message (Collapse)AuthorAgeFilesLines
* grit: Set first_id XML attribute as a string.estade@chromium.org2010-07-171-1/+1
| | | | | | | | | BUG=none TEST=compile works again (not sure why it was only failing for me and a few others) Review URL: http://codereview.chromium.org/3018006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52772 0039d316-1c4b-4281-b951-d872f2087c98
* checkperms: update to handle autoconf more generallyevan@chromium.org2010-07-161-22/+21
| | | | | | | | Fixes recent libxml change. Simplifies code a bit. Review URL: http://codereview.chromium.org/3028008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52768 0039d316-1c4b-4281-b951-d872f2087c98
* Restore previous dribbling-subprocess-output code for non-Windows.jrg@chromium.org2010-07-161-0/+39
| | | | | | | | | | | | | | | | | | | | | | | | (Windows code adds buffering when used on POSIX adding uncomfortable delays in output). Windows code retained for use on Windows only. Add command line flag --dont-clear-coverage-data to facilitate tester use. Workflow: 1. compile for coverage 2. run chrome and do whatever 3. Run coverage script by hand; e.g. tools/code_coverage/coverage_posix.py --directory out/Debug --genhtml out/index.html --dont-clear-coverage-data The coverage_posix.py tool otherwise deletes all coverage data when it starts since it assumes it only wants coverage data generated by it's subprocesses. BUG=none TEST=coverage bots stay green; Anantha happier. Review URL: http://codereview.chromium.org/2870054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52713 0039d316-1c4b-4281-b951-d872f2087c98
* Generalize suppression rule for leak in ↵tyoshino@chromium.org2010-07-161-1/+1
| | | | | | | | | | | ExtensionPrefStoreTest_NotifyWhenNeeded_Test detected by heapchecker BUG=48980 TEST=none Review URL: http://codereview.chromium.org/3005011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52667 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress leak in TemplateURLPrepopulateDataTest detected by heapcheckertyoshino@chromium.org2010-07-161-0/+18
| | | | | | | | | BUG=49310 TEST=none Review URL: http://codereview.chromium.org/3026003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52665 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress leaks in DownloadManagerTest detected by heapcheckertyoshino@chromium.org2010-07-161-0/+21
| | | | | | | | | BUG=49307 TEST=none Review URL: http://codereview.chromium.org/3029005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52663 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress disk_cache related leaks found by heapcheckertyoshino@chromium.org2010-07-161-0/+20
| | | | | | | | | BUG=49300 TEST=none Review URL: http://codereview.chromium.org/3012005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52661 0039d316-1c4b-4281-b951-d872f2087c98
* Generalize heapcheck suppression rule bug_46678_e to match Callback2 casetyoshino@chromium.org2010-07-161-1/+1
| | | | | | | | | BUG=46678 TEST=none Review URL: http://codereview.chromium.org/2842053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52653 0039d316-1c4b-4281-b951-d872f2087c98
* Generalize suppression for BUG 49260 to match new failuretyoshino@chromium.org2010-07-161-2/+1
| | | | | | | | | | | http://build.chromium.org/buildbot/memory/builders/Webkit%20Mac%20(valgrind)/builds/13166/steps/memory%20test:%20test_shell/logs/stdio BUG=49260 TEST=none Review URL: http://codereview.chromium.org/2847055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52647 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress one more similar leak in SessionManager::DoEncode detected by Valgrindtyoshino@chromium.org2010-07-161-0/+9
| | | | | | | | | BUG=46678 TEST=none Review URL: http://codereview.chromium.org/3034006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52646 0039d316-1c4b-4281-b951-d872f2087c98
* Add one more suppression for DownloadManagerTesttyoshino@chromium.org2010-07-161-1/+9
| | | | | | | | | BUG=49268 TEST=none Review URL: http://codereview.chromium.org/2812058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52645 0039d316-1c4b-4281-b951-d872f2087c98
* Generalize leak suppression rule for one more leak pasted on BUG49280tyoshino@chromium.org2010-07-161-1/+1
| | | | | | | | | BUG=49279 TEST=none Review URL: http://codereview.chromium.org/2827054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52633 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress new leak in ChromeCookieMonsterDelegate found on Chromium Mac UI ↵tyoshino@chromium.org2010-07-161-0/+10
| | | | | | | | | | | (valgrind)(1) BUG=49279 TEST=none Review URL: http://codereview.chromium.org/2834049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52631 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress valgrind leak detection in DownloadManagerTest::DownloadManagerTesttyoshino@chromium.org2010-07-161-0/+7
| | | | | | | | | BUG=49268 TEST=none Review URL: http://codereview.chromium.org/2884023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52622 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress valgrind Memcheck:Cond detected in ProfileSyncService::Observetyoshino@chromium.org2010-07-161-0/+7
| | | | | | | | | BUG=49266 TEST=none Review URL: http://codereview.chromium.org/3028004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52621 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress leak in PrefServicetyoshino@chromium.org2010-07-161-0/+12
| | | | | | | | | BUG=49262 TEST=none Review URL: http://codereview.chromium.org/3028003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52620 0039d316-1c4b-4281-b951-d872f2087c98
* Valgrind Mac: Suppress another variant of a leaky remoting test.thestig@chromium.org2010-07-161-0/+11
| | | | | | | | BUG=46678 TEST=none Review URL: http://codereview.chromium.org/3010006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52594 0039d316-1c4b-4281-b951-d872f2087c98
* Valgrind Mac: Widen a suppression.thestig@chromium.org2010-07-161-1/+1
| | | | | | | | | TBR=stuartmorgan BUG=9351 TEST=none Review URL: http://codereview.chromium.org/3013005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52593 0039d316-1c4b-4281-b951-d872f2087c98
* Valgrind Mac: Suppress another error in remoting tests.thestig@chromium.org2010-07-161-1/+10
| | | | | | | | BUG=49250 TEST=none Review URL: http://codereview.chromium.org/3040002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52592 0039d316-1c4b-4281-b951-d872f2087c98
* Video Buffering: Caches data to disk when paused (resubmit)vrk@google.com2010-07-151-0/+21
| | | | | | | | | | | | | Resubmitting this buffering patch because original patch was reverted. This patch clears up the memory leak issue in the unit tests and adds valgrind suppressions to silence the uninitialized variable false positives. BUG=42285 TEST=test_shell_tests Review URL: http://codereview.chromium.org/2908003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52569 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 52460 - Suppress intentional leaks in sanity tests on Mac valgrind bots.thestig@chromium.org2010-07-151-16/+0
| | | | | | | | | | | | | This change adds suppression rules to cover the recent symbol changes in ToolsSanityTests. BUG=none TEST=none Review URL: http://codereview.chromium.org/3021001 TBR=hbono@chromium.org Review URL: http://codereview.chromium.org/3035001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52529 0039d316-1c4b-4281-b951-d872f2087c98
* Fix uninitialized memory error caused by r50606.pinkerton@chromium.org2010-07-151-10/+0
| | | | | | | BUG=48269 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52514 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress intentional leaks in sanity tests on Mac valgrind bots.hbono@chromium.org2010-07-151-0/+16
| | | | | | | | | | | This change adds suppression rules to cover the recent symbol changes in ToolsSanityTests. TBR=thesig BUG=none TEST=none Review URL: http://codereview.chromium.org/3021001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52460 0039d316-1c4b-4281-b951-d872f2087c98
* Relaxing suppression for ExtensionPrefStoreTestoshima@chromium.org2010-07-141-1/+1
| | | | | | | | | | TBR=stuartmorgan@chromium.org BUG=48980 TEST=none Review URL: http://codereview.chromium.org/3002002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52404 0039d316-1c4b-4281-b951-d872f2087c98
* Convert some helper tools to use FilePaths for file names.evan@chromium.org2010-07-141-22/+39
| | | | | | | | | | | | | | Add a "PRFilePath" macro to file_path.h for use in printf'ing a FilePath. These are some of the last users of deprecated file_util functions (e.g. OpenFile(wstring, ...)). BUG=24672 Review URL: http://codereview.chromium.org/2929002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52391 0039d316-1c4b-4281-b951-d872f2087c98
* Suppression for memory leak in TemplateURLPrepopulateDataTest_ProvidersFromPrefsoshima@chromium.org2010-07-142-0/+18
| | | | | | | | | | TBR=cpu@chromium.org BUG=49086 TEST=none Review URL: http://codereview.chromium.org/2903015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52373 0039d316-1c4b-4281-b951-d872f2087c98
* Relaxing the suppression to cover all memory error in ExtensionPrefStoreTestoshima@chromium.org2010-07-141-2/+1
| | | | | | | | | | TBR=stuartmorgan@chromium.org BUG=48980 TEST=none Review URL: http://codereview.chromium.org/2998007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52371 0039d316-1c4b-4281-b951-d872f2087c98
* When about to close bookmark bar folder window, stop hover timers.jrg@chromium.org2010-07-141-10/+0
| | | | | | | | | BUG=http://crbug.com/46894 TEST=tree goes green (or would go green if not swamped by unrelated redness) Review URL: http://codereview.chromium.org/2989005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52359 0039d316-1c4b-4281-b951-d872f2087c98
* Get Mac ui valgrind greener.jrg@chromium.org2010-07-141-0/+36
| | | | | | | | | | | | I am able to "remove" these valgrind errors with some contortions in the code but don't think it's worth it. BUG=none TEST=greener tree Review URL: http://codereview.chromium.org/2313004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52353 0039d316-1c4b-4281-b951-d872f2087c98
* Updating suppression due to namespace changeoshima@chromium.org2010-07-131-1/+1
| | | | | | | | | | TBR=albertb@chromium.org BUG=41186 TEST=none Review URL: http://codereview.chromium.org/2900010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52244 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress all the leaks from ExtensionPrefStoreTeststuartmorgan@chromium.org2010-07-131-0/+32
| | | | | | | | | | | TBR=pam BUG=48980 TEST=Green heapcheck bot Review URL: http://codereview.chromium.org/2913011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52243 0039d316-1c4b-4281-b951-d872f2087c98
* Suppressing leak in BrowserMainPartsPosixoshima@chromium.org2010-07-131-0/+9
| | | | | | | | | | BUG=48998 TBR=viettrungluu@chromium.org, willchan@chromium.org TEST=none Review URL: http://codereview.chromium.org/2943011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52212 0039d316-1c4b-4281-b951-d872f2087c98
* Assign resource ids from a central file.tony@chromium.org2010-07-137-10/+245
| | | | | | | | | | | This allows us to control resource id assignment across all grd files so we can avoid id collisions. BUG=48625 Review URL: http://codereview.chromium.org/2961002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52211 0039d316-1c4b-4281-b951-d872f2087c98
* relaxing suppression to cover more pulseaudio issue on valgrind botoshima@chromium.org2010-07-131-1/+1
| | | | | | | | | | TBR=cbentzel@chromium.org BUG=48553 TEST=none Review URL: http://codereview.chromium.org/2964008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52208 0039d316-1c4b-4281-b951-d872f2087c98
* Add valgrind suppressions for leaks in a new set of testsstuartmorgan@chromium.org2010-07-131-20/+21
| | | | | | | | | | | | | Also trims cruft from the stacks of some recently-added suppressions. TBR=pam BUG=48980 TEST=Greener valgrind bots Review URL: http://codereview.chromium.org/2995002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52200 0039d316-1c4b-4281-b951-d872f2087c98
* SPDY leak found on linux valgrind jrg@chromium.org2010-07-121-0/+26
| | | | | | | | BUG=48865 TBR=arv@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52129 0039d316-1c4b-4281-b951-d872f2087c98
* Rename a header and some methods to make way for subsequent audio recording ↵satish@chromium.org2010-07-121-1/+1
| | | | | | | | | | | | | additions. Renaming audio_output.h to audio_io.h as future patches will add audio recording code to this file. Also renamed a couple of methods to make it clear that these are for audio playback/output and similar methods will be added for audio capture/recording soon. BUG=none TEST=no change in functionality. Review URL: http://codereview.chromium.org/2962006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52125 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some suppressions. These pass locally. Will try on the trybots.mbelshe@chromium.org2010-07-111-50/+0
| | | | | | | | | BUG=29392,42877 TEST=N/A Review URL: http://codereview.chromium.org/2974002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52065 0039d316-1c4b-4281-b951-d872f2087c98
* Solving an issue with subprocess.POpen on Windows.mad@google.com2010-07-091-18/+56
| | | | | | | | | | And also improving the coverage analysis speed by not generating useless xml, and also making that the timeout option is always of the right type and not cause exceptions later on. TEST=Run the coverage build. BUG=0 Review URL: http://codereview.chromium.org/2927001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51954 0039d316-1c4b-4281-b951-d872f2087c98
* Widen heapchecker suppression for SPDY test.willchan@chromium.org2010-07-081-1/+1
| | | | | | | | BUG=46886 Review URL: http://codereview.chromium.org/2911002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51889 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Spdy heapchecker suppression.willchan@chromium.org2010-07-081-1/+1
| | | | | | | | BUG=46886 Review URL: http://codereview.chromium.org/2932002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51883 0039d316-1c4b-4281-b951-d872f2087c98
* Allow data_packages outputs to include flattened items withouttony@chromium.org2010-07-082-7/+20
| | | | | | | | | | | | | | | | | | rc_all outputs. This fixes a bug where the code to flatten an html file was in the rc_all output step. So if a data_package output came before the rc_all output in the grd file, we would get a build error. Just refactor the code to flatten for both output types (but only flatten once). BUG=48253 TEST=build completes succesfully Review URL: http://codereview.chromium.org/2889001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51868 0039d316-1c4b-4281-b951-d872f2087c98
* Valgrind suppression for r51743hclam@chromium.org2010-07-081-0/+36
| | | | | | | | | BUG=48557 TBR=cbentzel Review URL: http://codereview.chromium.org/2919002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51865 0039d316-1c4b-4281-b951-d872f2087c98
* Deprecate most of the remaining wstring file_util functions.evan@chromium.org2010-07-081-2/+4
| | | | | | | | | | | | | These still exist on Windows due to being used by the installer, but by moving them into the Windows-only block we prevent them from being used in new code. (I am already finding new code using some of these! I am glad to be rid of them.) BUG=24672 Review URL: http://codereview.chromium.org/2850042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51862 0039d316-1c4b-4281-b951-d872f2087c98
* Supression for Pulseaudio.cbentzel@chromium.org2010-07-081-0/+19
| | | | | | | | | BUG=48553 TEST=None Review URL: http://codereview.chromium.org/2921002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51861 0039d316-1c4b-4281-b951-d872f2087c98
* Presumbit check for 'Suppression:' in valgrind suppressionsstuartmorgan@chromium.org2010-07-071-0/+17
| | | | | | | | | BUG=None TEST=Try to accidentally break the valgrind suppressions by pasting too much into the file; fail. Review URL: http://codereview.chromium.org/2847044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51717 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Make valgrind suppression for Sandbox tests permanent.jeremy@chromium.org2010-07-051-17/+18
| | | | | | | | | | | The code in question registers a string -> Sandbox test case mapping in a global variable. BUG=44090 TEST=Valgrind bots should stay green. Review URL: http://codereview.chromium.org/2136005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51641 0039d316-1c4b-4281-b951-d872f2087c98
* Valgrind: Suppress a new Mac memory error.thestig@chromium.org2010-07-031-0/+10
| | | | | | | | BUG=48269 TEST=Chromium Mac UI (valgrind)(2) gets a bit greener. Review URL: http://codereview.chromium.org/2824051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51609 0039d316-1c4b-4281-b951-d872f2087c98
* Valgrind: Widen a CrOS suppression.thestig@chromium.org2010-07-031-2/+1
| | | | | | | | | BUG=48130 TEST=ChromeOS Valgrind goes green. TBR=stuartmorgan Review URL: http://codereview.chromium.org/2799055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51608 0039d316-1c4b-4281-b951-d872f2087c98
* Valgrind: Widen a sqlite related suppression.thestig@chromium.org2010-07-031-1/+1
| | | | | | | | | BUG=19775 TEST=Linux Tests (valgrind)(1) goes green. TBR=stuartmorgan Review URL: http://codereview.chromium.org/2809050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51607 0039d316-1c4b-4281-b951-d872f2087c98