| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=351115
TEST=manual
Review URL: https://codereview.chromium.org/196223002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256578 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=348324
NOTRY=true
Review URL: https://codereview.chromium.org/196473006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256571 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch associates the tough_animation_cases page set with its own WPR
archive instead of reusing the existing robohornet_pro archive.
The robohornet_pro WPR doesn't seem to be accessible outsite of the perf
bots, this replacement will make problems with tough_animation_cases easier
to debug.
NOTRY=TRUE
BUG=350692
Review URL: https://codereview.chromium.org/189113013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256549 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TODO: policy test
BUG=320696
Review URL: https://codereview.chromium.org/110443009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256546 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add metrics to SyncFileSystem API usage and configuration of conflict resolution policy.
Corresponding to http://crrev.com/255678
BUG=347424
Review URL: https://codereview.chromium.org/190223002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
When checking whether a category filter is a subset of another, consider
which synthetic delays are defined by each filter. If filter A defines
more or different delays than filter B, then it is not a subset.
BUG=349077
Review URL: https://codereview.chromium.org/194573004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256461 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch turns on GPU benchmarking extension for all runs [unless opted out via BrowserOptions]. This is done mainly to simplify the actions system. Right now, we have to programmatically inspect a pageset's actions in order to determine if it might
eventually scroll or do a synthetic gesture, and then if it will, we add in the gpu
benchmarking extension. This is not possible when pagesets are python-based.
In reality, the only side effect of the extension being on is that render stats are tracked. We believe this to be effectively free: rather than trying to add more complexity into the actions and pageset system in order to figure out if gestures are needed, I propose we try moving this to always be on and see if we can get by. The intent in the long term is to make gesture creation available on devtools or in the platform, anyway, so this seems like a low architectural risk.
Review URL: https://codereview.chromium.org/189463007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256451 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's expected that the results should be slightly more steady. (I didn't measure this on my local machine before-hand, but after the new version of the Endure benchmarks are being run, we could see the results.)
Note: I should wait until crrev.com/187173002 is submitted and merge in those changes before submitting this.
BUG=
Review URL: https://codereview.chromium.org/183663029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256447 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a histogram that records how many users are using Google Public DNS, other
public resolver addresses, private resolver addresses, or a mix of the above
for their DNS servers.
BUG=350908
Review URL: https://codereview.chromium.org/187673005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Script extracts resource IDs from the build output for the resources
that cause an "unknown pragma" warning.
BUG=338759
R=newt@chromium.org
Review URL: https://codereview.chromium.org/195513003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
* CryptohomePath and IsCryptohomeMounted moved to CrosInterface
* Move _GetLoginStatus and _IsCryptohomeMounted closer to where they are used.
BUG=308757
TEST=manual
NOTRY=True
Review URL: https://codereview.chromium.org/189953002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256394 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This CL reverts r215423 and r230644.
TBR=isherman@chromium.org,teravest@chromium.org
Review URL: https://codereview.chromium.org/193753002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256393 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is pre-requisite for https://codereview.chromium.org/189403006/
which implements zero suggest with personalized suggestions. This CL
moves the deletion logic into the superclass for both search and
zero suggest to use it.
BUG=324043
TBR=mpearson
Review URL: https://codereview.chromium.org/189833003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Final rename of ChromiumTestShell to ChromeShell.
Now the new targets to build ChromeShell and ChromeShellTest APKs will be:
chrome_shell_apk
chrome_shell_test_apk
This will better align with ContentShell and ContentShellTest APKs' targets:
content_shell_apk
content_shell_test_apk
BUG=348137
TBR=mnaganov@chromium.org
Review URL: https://codereview.chromium.org/189133005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256382 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to the base namespace
This function is only used in a few places and can trivially be implemented by passing the whitespace constant to the existing ContainsOnlyChars function.
This changes the ContainsOnlyChars function signature to take a StringPiece to avoid a copy from a literal to a standard string in the above-mentioned use-base.
Re-implement ContainsOnlyChars to use the find_first_not_of function on StringPiece.
BUG=
R=viettrungluu@chromium.org
Review URL: https://codereview.chromium.org/183683024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
multiple-tryserver-compatible protocol
BUG=334892
R=maruel@chromium.org
Review URL: https://codereview.chromium.org/194903007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256318 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This moves AppendFile, GetCurrentDirectory, and SetCurrentDirectory to the base namespace.
TBR=jam
Review URL: https://codereview.chromium.org/177923007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256309 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=350415
Review URL: https://codereview.chromium.org/190063007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256299 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
generally hurting performance.
Introduces a new validation level (VALID_LEGACY_DEVICE_ID) from PrefHashCalculator and a new UMA histogram to go along with it.
The MAC address gathering code is a pure copy/paste from chrome/browser/extensions/api/music_manager_private/device_id_win.cc from an M33 checkout which is the implementation we want to keep around (see bug for a broader duplicate code justification).
BUG=350028
TEST=Run a chrome with this CL against an M33 User Data dir and confirm that every pref reports Settings.TrackedPreferenceUnchangeLegacyDeviceId (except for kExtensionsPref which is initialized to split pref as expected).
R=asvitkine@chromium.org, erikwright@chromium.org
First Committed In: https://src.chromium.org/viewvc/chrome?view=rev&revision=256047
Revert In (XP/Vista unit_tests failure): https://src.chromium.org/viewvc/chrome?view=rev&revision=256069
Review URL: https://codereview.chromium.org/190183002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256296 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
information from disk cache on 0-RTT.
R=jar@chromium.org
Review URL: https://codereview.chromium.org/193253002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256281 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
-- races in third_party/WebKit/Source/heap/ThreadState.cpp (issue 347559)
BUG=347559
TBR=timurrrr@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/195173002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256230 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change also checks the formal parameter type is Visitor when identifying tracing methods.
R=ager@chromium.org
BUG=334149
NOTRY=true
Review URL: https://codereview.chromium.org/190543011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256229 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
under both TSan v1 and TSan v2.
BUG=350982
TBR=timurrrr@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/194573003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256214 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some small architectural changes required for the upcoming www UI.
The main change introduced by this CL is moving the deps inclusion
from run_tests to the main module initializer.
Rationale: in the next cl, a new binary (start_web_ui) will need to
include the same deps, so moving that to a common place.
BUG=340294
NOTRY=true
Review URL: https://codereview.chromium.org/192033003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a follow-up of "Issue 177003019: Add video
capture UMA histograms: width, height, frame rate,
pixel format.", adding the UMA histogram sampling
aspect ratio. The aspect ratio is calculated and
sampled using UMA_HISTOGRAM_ASPECT_RATIO(), which is
a forwarding to UMA_HISTOGRAM_SPARSE_SLOWLY().
BUG=309554
TBR=wjia@chromium.org
Review URL: https://codereview.chromium.org/185233014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256202 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is now always on.
BUG=287029
TEST=url_unittets builds under clang plugin without warnings/errors.
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/185543003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256191 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add documentation for the following metrics:
Power.ExternalBrightnessReadResult
Power.ExternalBrightnessRequestResult
Power.ExternalBrightnessWriteResult
Power.ExternalDisplayOpenResult
BUG=chromium:315371
Review URL: https://codereview.chromium.org/192563002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This flag forces gpu rasterization for all layers (that is, it behaves the
way --enable-gpu-rasterization behaved previously).
--enable-gpu-rasterization now enables gpu rasterization only on layers
that have a GPU rasterization hint. Since this hint will be added in a
later CL, this flag is currently a no-op.
BUG=329722
Review URL: https://codereview.chromium.org/189883009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256143 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=317194
Review URL: https://codereview.chromium.org/81403003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256120 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes an immediate failure with "Tried to RegisterCallback without an
AtExitManager" when running ipc_fuzzer_replay in debug builds.
R=inferno@chromium.org
Review URL: https://codereview.chromium.org/191293016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256104 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Follow-up to https://codereview.chromium.org/189663018
BUG=350462
TBR=scherkus@chromium.org
Review URL: https://codereview.chromium.org/194083002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256099 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the page cycler measurement, the call that verifies that a page has finished loading could throw a timeout exception causing the power metric to not be properly shut down.
This can cause many instances of powermetric to run in parallel.
This patch adds additional cleanup code to the powermetric to make sure the backing utility is well dead.
BUG=339162
Review URL: https://codereview.chromium.org/192243002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256078 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
breaks: http://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%283%29/builds/38323
> Validate hashes based on the legacy device id from M33 on Windows without generally hurting performance.
>
> Introduces a new validation level (VALID_LEGACY_DEVICE_ID) from PrefHashCalculator and a new UMA histogram to go along with it.
>
> The MAC address gathering code is a pure copy/paste from chrome/browser/extensions/api/music_manager_private/device_id_win.cc from an M33 checkout which is the implementation we want to keep around (see bug for a broader duplicate code justification).
>
> BUG=350028
> TEST=Run a chrome with this CL against an M33 User Data dir and confirm that every pref reports Settings.TrackedPreferenceUnchangeLegacyDeviceId (except for kExtensionsPref which is initialized to split pref as expected).
> R=asvitkine@chromium.org, erikwright@chromium.org
>
> Review URL: https://codereview.chromium.org/190183002
TBR=gab@chromium.org
Review URL: https://codereview.chromium.org/193553002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256069 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When an SSL interstitial is displayed, we want to understand whether it's potentially caused by a captive portal or not. This CL records the following flags when the interstitial is closed:
1) Whether captive portal detection is enabled in Chrome (disabled on some OS).
2) Whether a captive portal probe result was received.
3) Whether the captive portal probe result returned no response, indicating a network or HTTP error or a non-HTTP captive portal login page.
4) Whether a captive portal was detected.
BUG=335933
Review URL: https://codereview.chromium.org/164843003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256063 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
generally hurting performance.
Introduces a new validation level (VALID_LEGACY_DEVICE_ID) from PrefHashCalculator and a new UMA histogram to go along with it.
The MAC address gathering code is a pure copy/paste from chrome/browser/extensions/api/music_manager_private/device_id_win.cc from an M33 checkout which is the implementation we want to keep around (see bug for a broader duplicate code justification).
BUG=350028
TEST=Run a chrome with this CL against an M33 User Data dir and confirm that every pref reports Settings.TrackedPreferenceUnchangeLegacyDeviceId (except for kExtensionsPref which is initialized to split pref as expected).
R=asvitkine@chromium.org, erikwright@chromium.org
Review URL: https://codereview.chromium.org/190183002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256047 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=wangxianzhu
Review URL: https://codereview.chromium.org/189663018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256043 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This also removes a redundant histogram from the bookmark provider.
BUG=350463
TEST=none
R=mpearson@chromium.org
Review URL: https://codereview.chromium.org/189463009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256030 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=350125
TBR=erg@chromium.org
Review URL: https://codereview.chromium.org/192943003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256000 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=350125
TBR=erg@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/192453008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255998 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=350125
TBR=erg@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/192453008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255996 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Remove DCHECK in non-official-release build by default
- Gyp variable dcheck_always_on=1 (existing) forces to enable DCHECK
in release build
- Remove flag --enable-dcheck
Other effects/notes:
- Now allow "buildtype=Official dcheck_always_on=1" (which will
enable DCHECK in official build) combination.
- Gyp variable logging_like_official_build no longer has an effect
- Leave DCHECK_IS_ON() unchanged. May deal with it in a later change
if needed.
This won't affect bots which use dcheck_always_on=1.
BUG=350462
TEST=LoggingTest.Dcheck
R=thakis@chromium.org
TBR=darin,sehr (command line changes in components/nacl and mojo)
Review URL: https://codereview.chromium.org/189603007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255987 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Gather separate histograms for for first 100 received, and for missing (NACKed) packets.
We should be able to take the ratio, and see any correlation of packet loss with position
in the server transmitted stream.
r=rch
BUG=349314
Review URL: https://codereview.chromium.org/180833004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255986 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Rename to reflect what this actually does.
BUG=350832
TBR=kbr@chromium.org
Review URL: https://codereview.chromium.org/192613002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255937 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This introduces the final piece to the classifier which are
able to do basic parsing for mmap and native heap traces.
BUG=340294
NOTRY=true
Review URL: https://codereview.chromium.org/184043006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255933 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Measure power instead of CPU usage in tab switching measurement.
* Fix a bug in said measurement where the initial open tab in the browser window was not navigated.
* Add a benchmark that switches between 5 blank tabs.
BUG=339180
Review URL: https://codereview.chromium.org/178363005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255925 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Note that private dirty is already measured on Android.
BUG=347919
Review URL: https://codereview.chromium.org/190743002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255913 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
while and is now removed.
R=asvitkine@chromium.org
BUG=287730
Review URL: https://codereview.chromium.org/179873004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/187173002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255883 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
changes for sessions which can do multi profile
The old absolute UMA counter was stored upon shutdown. Unfortunately only one in 33 users is shutting down the system properly. As such only a fraction of sessions were accounted for => the values were useless. Furthermore we have decided to only count sessions which could be multi profile sessions.
The new values are recording state changes like e.g. going from one user to two in a single session. As such you might get a resulting stat counter list of:
1: 320 => 320 - 15 - 4 - 1 = 300 single user sessions
2: 15 => 15 - 4 - 1 = 10 two user sessions
3: 4 => 4 - 1 = 3 three user sessions
4: 1 => 1 four user session
Note that it is not possible for a single user to leave a multi profile session - so the counter will always count up.
BUG=349055
TEST=none
Review URL: https://codereview.chromium.org/180243025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255865 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Move quiescence test used by speed index so we can more easily reuse it in other parts of the code.
BUG=339180
Review URL: https://codereview.chromium.org/185413005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255851 0039d316-1c4b-4281-b951-d872f2087c98
|