| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
BUG=16209,16210
TEST=somewhat happier Mac UI valgrind bots
Review URL: http://codereview.chromium.org/155232
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20189 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The problem is scoped_ptr<ResourceRequestDetails> is used to delete an instance of ResourceRedirectDetails, however the base class's destructor is non-virtual, so ResourceRedirectDetails extra field (GURL new_url_) does not get torn down properly.
Note that the blame callstacks in the bug report appear unrelated, because std::string is doing some fancy refcounting under the hood. So as GURLs get passed around, they take over the GURL::spec's memory that got allocated earlier by the network stack.
BUG=http://crbug.com/10873
TEST=The "RedirectTest.*" ui tests when run on linux valgrind bots should show no leaks
Review URL: http://codereview.chromium.org/155204
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
suppression file format. No actual changes to the suppressions except to get rid of a name duplication.
BUG=none
TEST=Mac valgrind bots should be unchanged.
Review URL: http://codereview.chromium.org/155225
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20176 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/155199
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20161 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Fewer leaks on the Mac valgrind UI test bots
Review URL: http://codereview.chromium.org/155190
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20156 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
from a web page, and always run it through valgrind once no matter
how perfect it is visually.
Review URL: http://codereview.chromium.org/149271
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20065 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=16096, 10737, 10738
TEST=watch the linux ui buildbots for valgrind warnings; this should make several go away
Review URL: http://codereview.chromium.org/155152
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20050 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/155123
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20045 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=12863,16093,16102,16103,16104
Review URL: http://codereview.chromium.org/155144
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20036 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=12863,16089,16091,16092,16093,16095,16096
TEST=run tools/valgrind/chrome_tests.sh -t ui and see many fewer warnings
Review URL: http://codereview.chromium.org/149250
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20025 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
so fork() doesn't corrupt log files; lets --generate_suppressions
work even with the hacky valgrind fix that makes anything but --log-file
crash on child of fork().
Also avoid killing user desktop session if zygote dies!
BUG=none, but related to fix for http://crbug.com/15771
TEST=patch valgrind with fork workaround; sh tools/valgrind/chrome_tests.sh --generate_suppressions -t ui logs you out on linux without this.
Review URL: http://codereview.chromium.org/155130
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20024 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/155139
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20023 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/155136
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20022 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Times out too often under Valgrind on Mac
Tracking bug: crbug.com/15817
Review URL: http://codereview.chromium.org/150218
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19846 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=check Mac valgrind bot
BUG=15819
Review URL: http://codereview.chromium.org/149129
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19831 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=jorlow
TEST=none
BUG=15762
Review URL: http://codereview.chromium.org/151175
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19774 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=jorlow
TEST=none
BUG=15762
Review URL: http://codereview.chromium.org/150173
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
enabled the ImageOperations test.
This should be fixed eventually, but suppressing it now
to get the build green since it's not a regression.
TEST=none
BUG=Issue tracker is down
Review URL: http://codereview.chromium.org/150172
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://build.chromium.org/buildbot/waterfall/builders/Modules%20Mac%20(valgrind)/builds/1303/steps/valgrind%20test:%20unit/logs/stdio
Review URL: http://codereview.chromium.org/151107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19666 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
These common files are used by page cyclers to provide a
standard JS test harness and report base.
Add acid3 page cycler to chromium checkout.
Review URL: http://codereview.chromium.org/151053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19564 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST="make -r base_unittests; sh tools/valgrind/chrome-tests.sh -t base_unittests" on 64 bit ubuntu and verify no valgrind warnings from ld-*.so
Review URL: http://codereview.chromium.org/147254
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19497 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Make build on Linux
BUG=http://crbug.com/15454
TEST=export GYP_GENERATORS=make; rm -rf sconsbuild; gclient runhooks --force; make -r base_unittests layout_tests; sh tools/valgrind/chrome_tests.sh -t base_unittests; verify that it finds and runs base_unittests; same thing with -t layout_tests
Review URL: http://codereview.chromium.org/147209
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Already filed with Apple.
BUG=none
TEST=fewer leaks reported from the UI tests under valgrind on Mac
Review URL: http://codereview.chromium.org/146115
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19195 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/141016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18921 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
valgrind is very slow on the Mac.
BUG=none
TEST=Most/all of the UI tests should pass on the Mac when run under valgrind.
Review URL: http://codereview.chromium.org/140008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18849 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
try:-finally: so builds will work without forced upgrades to Python 2.5.
BUG=12818
TEST=successful build
Review URL: http://codereview.chromium.org/140005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18848 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
initialization.
BUG=none
TEST=Run ui_tests under valgrind; see fewer warning that we can't fix.
Review URL: http://codereview.chromium.org/131081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18824 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This will be used by the buildbots after Xvfb is executated to make sure that Xvfb is alive.
Review URL: http://codereview.chromium.org/126165
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18549 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/10737
Review URL: http://codereview.chromium.org/118491
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18422 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the magic value in buildbot changed.
TEST=Buildbot will turn orange if there is a warning
BUG=None
Review URL: http://codereview.chromium.org/126048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18270 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/119445
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18162 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=13695
TEST=None
Review URL: http://codereview.chromium.org/119374
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17969 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=12640
Review URL: http://codereview.chromium.org/119354
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17950 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
name installer_util_unittests instead of util_unittests.
BUG=12849
Review URL: http://codereview.chromium.org/119322
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17916 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SVG UI:
- Fix some TODOs about clipping SVG objects to the scene. This fixes bugs
where a rectangle is too large and not displayed at all.
- Fix the calculation of the thread endms done time. This fixes the thread
gray background not being drawn for the full length of the thread.
Traceline tracer:
- Enable PatchCreateThread on XP. This fixes not having the thread creation
information output in the JSON files on XP. Still doesn't work on Vista.
- Print the manual-quit message to stderr, so it doesn't end up in the JSON.
- Cast a symbol API callback to compile with both older and newer SDKs.
- Add two small scripts for breaking apart large JSON files into smaller
pieces, so that the Python tools can handle processing the smaller files.
Review URL: http://codereview.chromium.org/118377
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17859 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/118361
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17829 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert DCHECKs to what they used to be - turns out a bunch of stuff in the code depended on input.empty() == true.
---
I believe the code (with your width() * bbp fix) is correct.
The UMR errors occur when the source image contain alpha. I believe the issue
comes from webkit glue image decoder, and the reason this only started
triggering valgrind errors is that the old ones were masked by the change
detailed in bug 12640
Also adds valgrind suppression for the new code.
TBR=Nick
BUG=12891,12640
TEST=none
Review URL: http://codereview.chromium.org/119271
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17811 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17803 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The UMR errors occur when the source image contain alpha. I believe the issue comes from webkit glue image decoder, and the reason this only started triggering valgrind errors is that the old ones were masked by the change detailed in bug 12640
Also adds valgrind suppression for the new code.
BUG=12891,12640
TEST=none
Review URL: http://codereview.chromium.org/118297
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17792 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Minor fixes to coverage related scripts.
Review URL: http://codereview.chromium.org/118298
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17785 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/119209
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/119128
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17609 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/119075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/119061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17467 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
this code changes infrequently.
Re-enable zip unit tests on mac.
Review URL: http://codereview.chromium.org/118087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/118034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
svn:ignore gyp-generated memory_watcher.{sln,vcproj}.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/118026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17232 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
One visible change: new tab page has Google icon, not Chromium.
Gyp doesn't have a set environment variable facility; hence the
addition of a command line option to grit.
Review URL: http://codereview.chromium.org/113974
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17148 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add support for scanning missing source files for executable lines.
Add support for HTML output.
Now reports percent coverage.
BUG=none
TEST=by hand on experimental buildbot
Review URL: http://codereview.chromium.org/113980
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/113957
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17090 0039d316-1c4b-4281-b951-d872f2087c98
|