| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
Downstream packagers are (rightly) careful about the license of code
that they distribute and so we want to dot our i's.
http://codereview.chromium.org/174372
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24311 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the the platform utils.
BUG=15470
Review URL: http://codereview.chromium.org/174378
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24254 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=18540
TEST=Valgrind Mac bots should stay green
Review URL: http://codereview.chromium.org/174293
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24138 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=16579,20111,20113
TEST=green valgrind bots
Review URL: http://codereview.chromium.org/174321
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=mnaganov
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/174319
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
until mgr agreeement.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/173267
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24094 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
After running several iterations of unittests and ui_tests under
valgrind, I was unable to reproduce the error.
BUG=18705 (http://crbug.com/18705)
TEST=Run unit tests and see that we don't get WindowSizer errors on Mac.
Review URL: http://codereview.chromium.org/174266
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24039 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
layout_package.platform_utils.
Deltas from that change:
* Don't enable 'win-xp' as the default platform
* Don't assume 'webkit/Release' exists (it doesn't by default on mac and
linux), and fix the output results directory path in run_webkit_tests
* Update tools/valgrind/chrome_tests.py (which I didn't realize
depended on the layout_package code).
BUG=none
R=tony@chromium.org
TEST=none
Review URL: http://codereview.chromium.org/174209
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24007 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tools/valgrind/chrome_test.sh
gdb interface functions by Alexander Potapenko.
Happily, mac gdb knows how to use our fake .dSYM files,
so no change is needed to the build on the mac to use this with release builds.
(On Linux, we'll need to set 'release_extra_cflags' to '-g' to get
line numbers, but that has nothing to do with this change.)
Review URL: http://codereview.chromium.org/174129
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23991 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Make comments a bit clearer.
Review URL: http://codereview.chromium.org/173088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23764 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
don't always get a chance to cleanup all their state.
BUG=16096
TEST=none
Review URL: http://codereview.chromium.org/159306
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/174071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23730 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This has been suppressed in Valgrind upstream in r10380
BUG=9565
TEST=valgrind bots should not show leaks with setenv() on Mac
Review URL: http://codereview.chromium.org/174051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=19546
TEST=green
Review URL: http://codereview.chromium.org/172079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23609 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=19490
TEST=green ui tests
Review URL: http://codereview.chromium.org/172042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23555 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Will do more artful one later if this gets the mac ui bots
to yield good partial results instead of dying 100% of the time as
they do now.
TBR=thestig
TEST=mac valgrind ui bot 1 of 3 should produce some useful results
BUG=none
Review URL: http://codereview.chromium.org/171044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23544 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/172017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23539 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=19463
TEST=valgrind unit tests green
Review URL: http://codereview.chromium.org/172033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23534 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This one showed up several times today on the unit test bot.
TBR=thestig
BUG=19377
TEST=unit tests green
Review URL: http://codereview.chromium.org/171031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23533 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=17795
TEST=green
Review URL: http://codereview.chromium.org/170006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23463 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=16089,16583,18984,19369,19371,19377,19385
TEST=valgrind tests green for a week
Review URL: http://codereview.chromium.org/170001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23458 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=16089,16579
TEST=green
Review URL: http://codereview.chromium.org/165544
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23445 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
source tarballs, needed for deploying on jailed bots
Also change usage message to match last commit
Review URL: http://codereview.chromium.org/164434
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23251 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
v8::RegisterExtension()
BUG=19191,19196
TEST=valgrind ui bot 1 of 3 green more often
Review URL: http://codereview.chromium.org/165401
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23220 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
New fork and possible patches from Timur.
Accept new xml output format.
Use --xml-file option if present.
Drop two patches already in trunk.
Remove obsolete --generate_suppressions code.
Accept but ignore --generate_dsym option on non-darwin platforms, so scripts don't need conditionals
Switch to using svn revision numbers rather than dates,
because svn uses the local timezone to interpret the dates,
and this caused patches to fail. Feh.
Check to make sure a good copy of valgrind was found before trying to
use valgrind.
Review URL: http://codereview.chromium.org/160392
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23214 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/165342
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23112 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/165334
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23106 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/165329
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/165326
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/165325
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=10737
TEST=Watch the valgrind bot stay green.
Review URL: http://codereview.chromium.org/164294
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23078 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(wasn't useful on Goobuntu anyway, where some other valgrind came first in the PATH)
Don't hardcode versions/dates.
Add usage message.
Remove URLs to some patches (they go stale fast)
chrome_tests.sh: use the valgrind built by build-valgrind-for-chrome.sh by
default, but provide way to override
Review URL: http://codereview.chromium.org/165317
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
apparently introduced by the webkit roll in r47010.
BUG=18984
TEST=green
Review URL: http://codereview.chromium.org/165291
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23013 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
for us
BUG=18984
Review URL: http://codereview.chromium.org/165276
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22971 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It looks like this one arrived via http://trac.webkit.org/changeset?new=46977@trunk/WebCore&old=46910@trunk/WebCore
TBR=awalker
BUG=16908
TEST=none
Review URL: http://codereview.chromium.org/165264
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22959 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Watch the valgrind bots stay green.
Review URL: http://codereview.chromium.org/165254
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22943 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
WebKit Inspector is localized using a JS file containing the following map:
localizedStrings[<english text>] = <translated text>;
Review URL: http://codereview.chromium.org/164066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22900 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and shorten a suppression that was so long valgrind barfed.
Add suppressions for two new valgrind warnings that are extremely reproducible on the mac.
Add variant of an old suppression.
BUG=11333,18661,18705
TEST=none
Review URL: http://codereview.chromium.org/165100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22699 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is very similar to the one just above it. SVGNames are part of
the WebKit startup and are singleton strings. Since it's an O(1)
'leak', it's not really a leak at all.
BUG=17966
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22698 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
valgrind run.
Move one suppression from 6547 to new bug 18664 as we widen it, 'cause 6547 was marked closed, and the history was messy.
Also disable ErrorPageTest.DNSError_GoBack2Forward2 -- it hangs often on mac under valgrind, possibly a bug in valgrind.
BUG=6547,16628,18661,18664
TEST=swing mac around your head on its power cord, see if any memory leaks out
Review URL: http://codereview.chromium.org/165076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22661 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
for trace).
BUG=http://crbug.com/18654
TEST=Linux valgrind UI tests greener
Review URL: http://codereview.chromium.org/164082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=16128
TEST=Less red on the Mac valgrind bot.
Review URL: http://codereview.chromium.org/165019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=agl
BUG=18590
TEST=watch ui valgrind bots for a week
Review URL: http://codereview.chromium.org/165027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22572 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds suppressions for lots of bugs. The only
problems left I know of result in valgrind internal
error messages.
Widen suppression for 16128 to match on Mac.
Remove suppression for 16210, which is a dup of 16128, and was out of date.
The reference builds don't have symbols on the mac,
so suppressions don't work. And they have old known
valgrind issues. Disable
SunSpiderReferenceTest.Perf and
V8BenchmarkReferenceTest.Perf under valgrind until
those problems are addressed (and possibly longer --
reference builds tend to have old valgrind errors
since fixed and no longer of interest).
Also, disable DownloadTest.UnknownSize under valgrind,
it is known to send garbage.
None of these errors are showing up on the bots
for some reason; they only show up when you do
a local run of shard_all_tests.sh, which does one
test at a time instead of the normal batches of 30.
It seems valgrind on the mac isn't stable enough
to do large batches of ui tests in a single run.
BUG=6522,16128,16210,17113,17451,18189,18223,18236,18252,18253,18268,18540
TEST=run tools/valgrind/shard_all_tests.sh for ui_tests on mac, verify it finds no normal valgrind warnings
Review URL: http://codereview.chromium.org/159770
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22533 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Refactor bookmark util clipboard code to be cross platform.
- Add a CBF_DATA format for writing arbitrary data to the clipboard.
- Change MenuGtk so that showing a menu only makes the menu items update asynchronously. This way we can show the menu immediately and we won't get in trouble if the delegate's IsCommandEnabled() runs a nested message loop.
I did not do any mac-side implementation of the new clipboard stuff. The implementation should be easy when they get around to writing the bookmark manager.
Review URL: http://codereview.chromium.org/159815
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22419 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=18070
TEST=none
Review URL: http://codereview.chromium.org/160509
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
warnings.
TBR: brettw, dank, jshin
Review URL: http://codereview.chromium.org/159797
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22287 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
SpellCheckStrings_EN_US test.
TBR=dank
BUG=18254
TEST=Watch the linux valgrind bot turn green
Review URL: http://codereview.chromium.org/159764
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22263 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
SpellCheckTest_GetAutoCorrectionWord_EN_US test.
TBR=dank
BUG=18254
TEST=Watch the valgrind bot turn green.
Review URL: http://codereview.chromium.org/160515
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22257 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=16661,18215,18218,18219
TEST=watch mac valgrind ui tests go greener
Review URL: http://codereview.chromium.org/159757
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22239 0039d316-1c4b-4281-b951-d872f2087c98
|