| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=57799
TEST=None
Review URL: http://codereview.chromium.org/7003156
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(and remove no-longer necessary valgrind suppression).
BUG=85825
TEST=trybots
Review URL: http://codereview.chromium.org/7003139
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88835 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This change disables SyncerThreadTest.ThrottlingDoesThrottle on the "Mac (tsan)" bot because it has been exceeding timeouts on the bot since Build #6475: <http://chromegw.corp.google.com/i/chromium.memory/builders/Chromium%20Mac%20%28tsan%29/builds/6475>.
TBR=timurrrr,glider,thestig
BUG=85892
TEST=make the "Chromium Mac (tsan)" bot greener.
Review URL: http://codereview.chromium.org/7104134
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88820 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This change just update a suppression rule for Bug 80462 to catch up with the recent WebKit roll.
TBR=timurrrr,glider
BUG=80462
TEST=make the "Webkit Linux (valgrind layout)" bot greener.
Review URL: http://codereview.chromium.org/7003142
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88814 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=40429
TEST=none
R=thestig@chromium.org
Review URL: http://codereview.chromium.org/7134088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88802 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=85867,85868
TEST=none
TBR=thestig
Review URL: http://codereview.chromium.org/7104131
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=85865,85866
TEST=none
TBR=thestig
Review URL: http://codereview.chromium.org/7003137
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88794 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=40429
TEST=none
TBR=thestig
Review URL: http://codereview.chromium.org/7129070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88790 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=85825
TEST=none
R=thestig@chromium.org
Review URL: http://codereview.chromium.org/7134084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88781 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=bruening
BUG=DrMemory i#454, i#455
Review URL: http://codereview.chromium.org/7003120
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88670 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The continuous archive's index file appears to be incomplete/problematic for
some platforms and revision ranges, so go back to just using directory lists
via the CDS API.
This also cleans up the code by using a PathContext object rather than a slew of
global variables to format/create the various URLs.
BUG=85498
TEST=See bug.
Review URL: http://codereview.chromium.org/6995117
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88658 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
These reports have not been seen on the bots, but they are very common with
NaCl browser_tests. They also happen with cross_fuzz a lot.
Review URL: http://codereview.chromium.org/7046085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88656 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is going to be used for fixing crosbug.com/13374, by
adding a display area for preedits on a candidate window.
This patch is just for updating libcros in Chromium to version 150:
http://gerrit.chromium.org/gerrit/2288
BUG=chromium-os:13374
TEST=boot ChromeOS and verify it runs safely.
Review URL: http://codereview.chromium.org/7108022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88640 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=85641
TEST=no
Review URL: http://codereview.chromium.org/7046082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88625 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=58449
TBR=jhawkins
Review URL: http://codereview.chromium.org/7134062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88624 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=85641
TEST=no
Review URL: http://codereview.chromium.org/7108052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88607 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=35318
BUG=58449
R=phajdan.jr@chromium.org
TEST=None
Review URL: http://codereview.chromium.org/6993031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88580 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Notable in this roll: hans' ?: warning now works for overloaded operators.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7129042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88576 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=bruening
Review URL: http://codereview.chromium.org/6995104
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88511 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This doesn't solve the underlying problem (see crbug.com/85481) but will
enable re-landing 88151 for crbug.com/85296.
BUG=82279
TEST=
Review URL: http://codereview.chromium.org/7046067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=72913
TEST=unit tests with tsan
Review URL: http://codereview.chromium.org/7044059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=60890
TEST=memory bots
Review URL: http://codereview.chromium.org/7046036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88463 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
unsymbolized backtraces.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7003046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Notable changes in the range:
* r132735 (hopefully) fixes a bug introduced in r131951 that made
gold 1.10 crash with
/usr/bin/ld: internal error in set_offset, at output.cc:4030
* r132535 fixes the crash at -O3 on mac
* r132565 adds a warning for "x + y ? a : b" to -Wparentheses
BUG=85289,84424
TEST=none
TBR=evan
Review URL: http://codereview.chromium.org/7046048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If my theory is correct, this will break the chromeos build and I'll revert this CL.
BUG=85289
TEST=none
TBR=evan
Review URL: http://codereview.chromium.org/7137001
TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/7134009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88295 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
If my theory is correct, this will break the chromeos build and I'll revert this CL.
BUG=85289
TEST=none
TBR=evan
Review URL: http://codereview.chromium.org/7137001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88285 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
If my theory is correct, that should be the last revision without the bug.
BUG=none
TEST=none
TBR=evan
Review URL: http://codereview.chromium.org/7104047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88283 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
To see if that fixes the problem. (Else I need to clobber that bot after every roll.)
BUG=84424
TEST=none
TBR=evan
Review URL: http://codereview.chromium.org/7003050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88278 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=85289
TEST=none
TBR=evan
Review URL: http://codereview.chromium.org/6995065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88275 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
clang recently added a warning that warns when invoking 'delete' on a polymorphic non-final class without a virtual destructor. This finds real bugs – see the bug referenced below for a few examples.
However, one common pattern where it fires is this case:
class SomeInterface {
public:
virtual void interfaceMethod() {} // or = 0;
protected:
~SomeInterface() {}
}
class WorkerClass : public SomeInterface {
public:
// many non-virtual functions, but also:
virtual void interfaceMethod() override { /* do actual work */ }
};
void f() {
scoped_ptr<WorkerClass> c(new WorkerClass); // simplified example
}
(See the 2nd half of http://www.gotw.ca/publications/mill18.htm for an explanation of this pattern.)
It is arguably correct to fire the warning here, since someone might make a subclass of WorkerClass and replace |new WorkerClass| with |new WorkerClassSubclass|. This would be broken since WorkerClass doesn't have a virtual destructor.
The solution that the clang folks recommend is to mark WorkerClass as |final| (a c++0x keyword that clang supports as an extension in normal c++ mode – like override). But chrome's base/OWNERS deemed that as too complicated and we decided to make virtual the destructors of leaf classes that implement these interfaces and that are deleted dynamically. All of the changes in this CL are to shut up the warning, not because of real problems (I fixed these in separate CLs).
(For the gtk files, this is necessary because the CHROMEGTK_CALLBACK_ macros add virtual functions.)
BUG=84424
TEST=none
Review URL: http://codereview.chromium.org/7087028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88270 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- linux-release-hardy/dhtml/times/t
- linux-release-hardy/dhtml/total_byte_b/IO_b
- linux-release-hardy/dhtml/vm_rss_final_r/vm_rss_f_r
- linux-release-hardy/intl1/times/t
TBR=nsylvain@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88225 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=thestig@chromium.org
BUG=16089,72547
Review URL: http://codereview.chromium.org/7058063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88175 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=mark
BUG=85213
TEST=Greener valgrind bots
Review URL: http://codereview.chromium.org/7129005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88169 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=mark
BUG=85213
TEST=Greener valgrind bots
Review URL: http://codereview.chromium.org/7129003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88165 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=dgrogan
BUG=85151
TEST=Greener memory bots
Review URL: http://codereview.chromium.org/6995056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=dgrogan
BUG=85151
TEST=Greener valgrind/heapcheck bots
Review URL: http://codereview.chromium.org/7031077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
- mac-release-10.6/dhtml/times/t (from webkit roll at r87776)
TBR=nsylvain@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- xp-release-dual-core/moz/vm_peak_b/vm_pk_b (expected regression, switch to tcmalloc from winheap at r85998)
- xp-release-dual-core/moz/total_op_b/IO_op_b (webkit roll at r85865)
- xp-release-dual-core/moz/total_byte_b/IO_b (from webkit roll at r85865)
- xp-release-dual-core/moz/total_op_r/IO_op_r (from webkit roll at r85865)
TBR=nsylvain@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88136 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=83626
TEST=none
Review URL: http://codereview.chromium.org/7125007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88118 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:14017
TEST=build chrome
Review URL: http://codereview.chromium.org/7113003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87968 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
InfoBar* instead of InfoBarDelegate*. We can't do this separately from the larger TabContentsWrapper rewrite to make the TCW own InfoBars, because until then, the infobar container is responsible for deleting the created infobars, and not all tests have infobar containers. (After the revert, the container is once again the object creating the InfoBars, so tests without containers still don't delete them but also don't create them in the first place.)
BUG=62154,84835
TEST=none
Review URL: http://codereview.chromium.org/7054054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=bruening
Review URL: http://codereview.chromium.org/7112008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87783 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=http://code.google.com/p/drmemory/issues/detail?id=435
TBR=bruening
Review URL: http://codereview.chromium.org/7058045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87772 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=http://code.google.com/p/drmemory/issues/detail?id=425
TBR=bruening
Review URL: http://codereview.chromium.org/7111004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=84835
TEST=Valgrind Mac unit tests goes green.
Review URL: http://codereview.chromium.org/7056040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87765 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=84833
TEST=CrOS valgrind goes green
Review URL: http://codereview.chromium.org/7112006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87762 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
suppressions for similar errors triggered by autofill.
BUG=81753
TEST=none
TBR=timurrrr
Review URL: http://codereview.chromium.org/7058044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87761 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=bruening
Review URL: http://codereview.chromium.org/6969094
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87760 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also write up a lengthy comment about why we think valgrind is wrong
here. The suppression for this report is kept.
Along the way, remove the suppresion for a memory leak in ThumbnailGenerator.
The leak is gone now.
TEST=confirm that valgrind doesn't complain by tools/valgrind/chrome_tests.sh -v -b ninja -t unit --tool_flags='--track-origins=yes' --gtest_filter='ThumbnailGenerator*'
BUG=80458
Review URL: http://codereview.chromium.org/7074045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87757 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=84777,84779,84780
TEST=none
TBR=dglazkov
Review URL: http://codereview.chromium.org/7066066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87704 0039d316-1c4b-4281-b951-d872f2087c98
|