| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
Remove some dead code.
Remove valgrind suppression which suppressed this error.
BUG=http://crbug.com/26489
TEST=Mac valgrind bot stays green for ui_test BrowserEncodingTest.TestEncodingAliasMapping
Review URL: http://codereview.chromium.org/355006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30793 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=26493
Review URL: http://codereview.chromium.org/353011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30789 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
instances.
BUG=26493
TBR=tim
Review URL: http://codereview.chromium.org/342081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=26489
TEST=Mac UI valgrind bots
Review URL: http://codereview.chromium.org/348040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30715 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=darin
Review URL: http://codereview.chromium.org/354001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30691 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The results are now sorted before being output, so there is no need
to pass the results through a sort filter.
Byte counts are now printed with comma separators between groups of
3 digits, so that 1234567 is now output as 1,234,567.
The summary.pl now has a number of more precise matches to better
give a quick estimate of blame for each allocation stack.
r=mbelshe
Review URL: http://codereview.chromium.org/348034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30673 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I removed a leak of "stack" objects, and made them a little
more lightweight by removing an unused member.
This change is only part of an option for chrome, that is not currently
linked in during any tests. It can only currently be used under XP, so
build-bot tests are not currently appropriate.
r=mbelshe
Review URL: http://codereview.chromium.org/345033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30672 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=dank
TEST=media should stop being flaky on TSAN/Mac bot
Review URL: http://codereview.chromium.org/344046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30665 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=25952
TEST=always exists "successfully"
Review URL: http://codereview.chromium.org/343068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
My local bots (both Linux and Mac) were cycling green with this option all the last week
except for one real race (fixed tonight) and two benign reports suppressed recently.
This option will help us find more races, especially my beloved ref-counter races.
TEST=TSAN bots should remain green
Review URL: http://codereview.chromium.org/348020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30636 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
appropriate place.
TBR=dank
Review URL: http://codereview.chromium.org/344040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30635 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23314,26324,26326
TEST=Mac UI valgrind bot green-ness
Review URL: http://codereview.chromium.org/341053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30589 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=dank
TEST=Linux TSAN bot green on unit_tests
Review URL: http://codereview.chromium.org/343058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30579 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds a suppression for a warning reported by
ThreadSanitizer with --ignore-in-dtor=no when a ClientAudioQueue
object is destroyed.
This appears to be a benign one.
This patch was prepared by Alexander Potapenko (cc'ed)
Review URL: http://codereview.chromium.org/348011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30475 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=26213
Review URL: http://codereview.chromium.org/346014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=26213,26216
TEST=Linix valgrind 1 bot
Review URL: http://codereview.chromium.org/339067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30459 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=dank
Review URL: http://codereview.chromium.org/348009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=25952
TEST=still executes regardless of where you run the script from
Review URL: http://codereview.chromium.org/347008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30396 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
svn properties.
TBR=maruel
BUG=25952
Review URL: http://codereview.chromium.org/345015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
correctly.
It looks for binaries built with /NXCOMPAT and /DYNAMICBASE, two important security features for Windows binaries.
BUG=25952
TEST=try running it on the output of /src/chrome/Debug
Review URL: http://codereview.chromium.org/338052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30304 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The race was specific to unit-test code (see r29826) and should be fixed now.
BUG=22272
Review URL: http://codereview.chromium.org/293042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30301 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=25913
TBR=dank
Review URL: http://codereview.chromium.org/343004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30247 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
reporteed.
I think this may increase the popularity and usability of our tools.
Review URL: http://codereview.chromium.org/343002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30246 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=24715
TBR=dank
Review URL: http://codereview.chromium.org/339022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30182 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This race was already suppressed, but the existing suppression doesn't
work if the order of accesses is different. We can prepare a suppression to make TSAN bots silent
but it will be way too wide. I think adding one line of annotation with comment (twice) is better in terms of precision.
BUG=25841
Review URL: http://codereview.chromium.org/339008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30181 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=25915
TBR=dank
Review URL: http://codereview.chromium.org/340001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30180 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
third_party races.
BUG=25913
TBR=dank
Review URL: http://codereview.chromium.org/333047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30178 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=25200
TEST=perf bots stay green
Review URL: http://codereview.chromium.org/334034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30151 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=24307
TEST=tsan mac bot should remain green - (http://build.chromium.org/buildbot/waterfall/waterfall?builder=Linux+Tests+(tsan)&builder=Chromium+Mac+(tsan))
Review URL: http://codereview.chromium.org/333029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30120 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=25656
TEST=Mac UI valgrind bots
Review URL: http://codereview.chromium.org/330022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30112 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
valgrind-friendly
BUG=25346
Review URL: http://codereview.chromium.org/335026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30044 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=dank
Review URL: http://codereview.chromium.org/332025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
been seen on the bots in a while (if I'm reading the output correctly).
BUG=24345
TEST=green valgrind bots
Review URL: http://codereview.chromium.org/333014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30005 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29952 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=25648,20814,25656,20113,20508,25661
TEST=Greener Mac UI valgrind bots
Review URL: http://codereview.chromium.org/332008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29914 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=25645
TBR=dank
Review URL: http://codereview.chromium.org/337001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29894 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
to the list of functions ignored by ThreadSanitizer on Mac OS.
This patch was prepared by Alexander Potapenko (cc'ed)
TBR=dank
Review URL: http://codereview.chromium.org/333012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29893 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Add extra unit test bundles (all platforms).
Review URL: http://codereview.chromium.org/307032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29845 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=20805
TEST=green linux ui valgrind bots
Review URL: http://codereview.chromium.org/320002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29790 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This hasn't reproduced in the past bunch of runs of net_unittests; I believe it was fixed by r26611.
BUG=15147
Review URL: http://codereview.chromium.org/294034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29680 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
running wine.
BUG=valgrind_210481, valgrind_205541
TEST=valgrind net_unittests --gtest_filter=ProxyResolverV8Test.LoadLog ; valgrind wine's unit tests and see no HEAP_CreateSubHeap valgrind warnings
Review URL: http://codereview.chromium.org/306020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29655 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG:19546
Review URL: http://codereview.chromium.org/300038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=25385
TBR=dank
Review URL: http://codereview.chromium.org/306024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29634 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
(see third_party/icu/source/common/umutex.c)
When two concurrent threads try to call umtx_lock(mutex) for an uninitialized mutex simultaneously, *mutex is read without taking any lock.
However, if *mutex is NULL, a DCLP inside umtx_init(mutex) guarantees that *mutex is initialized exactly once. Otherwise, if *mutex is already a valid pthread_mutex_t, the behavior of the program is not affected.
This patch was prepared by Alexander Potapenko (cc'ed)
TBR=dank
Review URL: http://codereview.chromium.org/303019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29633 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This roll should fix a valgrind error (issue 25297).
R=jamesr
BUG=25297
TEST=none
Review URL: http://codereview.chromium.org/292039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29613 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=awalker
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/293041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29605 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=sh tools/valgrind/chrome_tests.sh -t base on a 64 bit build
Review URL: http://codereview.chromium.org/300024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29585 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=jamesr
BUG=25297
TEST=none
Review URL: http://codereview.chromium.org/306003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29505 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=20939
TEST=valgrind_webkit_tests.sh LayoutTests/fast/css/invalid-percentage-property.html
Review URL: http://codereview.chromium.org/273077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29231 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=N/A
Review URL: http://codereview.chromium.org/282009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29180 0039d316-1c4b-4281-b951-d872f2087c98
|