summaryrefslogtreecommitdiffstats
path: root/tools
Commit message (Collapse)AuthorAgeFilesLines
* Fix memory problems.jrg@chromium.org2009-11-031-7/+0
| | | | | | | | | | | | Remove some dead code. Remove valgrind suppression which suppressed this error. BUG=http://crbug.com/26489 TEST=Mac valgrind bot stays green for ui_test BrowserEncodingTest.TestEncodingAliasMapping Review URL: http://codereview.chromium.org/355006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30793 0039d316-1c4b-4281-b951-d872f2087c98
* Fix mem leak in sync tests by ensuring that the destruction tasks get to run.jam@chromium.org2009-11-031-39/+0
| | | | | | | | BUG=26493 Review URL: http://codereview.chromium.org/353011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30789 0039d316-1c4b-4281-b951-d872f2087c98
* Add suppressions for leaks in sync unit tests after adding ChromeThread ↵jam@chromium.org2009-11-021-0/+39
| | | | | | | | | | instances. BUG=26493 TBR=tim Review URL: http://codereview.chromium.org/342081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30728 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress invalid reads in Mac bookmark barstuartmorgan@chromium.org2009-11-021-0/+7
| | | | | | | | | BUG=26489 TEST=Mac UI valgrind bots Review URL: http://codereview.chromium.org/348040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30715 0039d316-1c4b-4281-b951-d872f2087c98
* Add suppression for intentional memory leak in unit test.jam@chromium.org2009-11-021-1/+13
| | | | | | | TBR=darin Review URL: http://codereview.chromium.org/354001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30691 0039d316-1c4b-4281-b951-d872f2087c98
* Tweak perl scripts in memwatcher tool area.jar@chromium.org2009-10-313-42/+84
| | | | | | | | | | | | | | | | | The results are now sorted before being output, so there is no need to pass the results through a sort filter. Byte counts are now printed with comma separators between groups of 3 digits, so that 1234567 is now output as 1,234,567. The summary.pl now has a number of more precise matches to better give a quick estimate of blame for each allocation stack. r=mbelshe Review URL: http://codereview.chromium.org/348034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30673 0039d316-1c4b-4281-b951-d872f2087c98
* Improve memwatch tool.jar@chromium.org2009-10-312-28/+24
| | | | | | | | | | | | | | I removed a leak of "stack" objects, and made them a little more lightweight by removing an unused member. This change is only part of an option for chrome, that is not currently linked in during any tests. It can only currently be used under XP, so build-bot tests are not currently appropriate. r=mbelshe Review URL: http://codereview.chromium.org/345033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30672 0039d316-1c4b-4281-b951-d872f2087c98
* Widen an existing suppression a little bittimurrrr@chromium.org2009-10-311-0/+1
| | | | | | | | TBR=dank TEST=media should stop being flaky on TSAN/Mac bot Review URL: http://codereview.chromium.org/344046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30665 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily make checkbins.py return status 0 until I fix offending binaries.scherkus@chromium.org2009-10-301-1/+2
| | | | | | | | | | BUG=25952 TEST=always exists "successfully" Review URL: http://codereview.chromium.org/343068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30639 0039d316-1c4b-4281-b951-d872f2087c98
* Make --ignore-in-dtor=no the default ThreadSanitizer option.timurrrr@chromium.org2009-10-301-1/+7
| | | | | | | | | | | My local bots (both Linux and Mac) were cycling green with this option all the last week except for one real race (fixed tonight) and two benign reports suppressed recently. This option will help us find more races, especially my beloved ref-counter races. TEST=TSAN bots should remain green Review URL: http://codereview.chromium.org/348020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30636 0039d316-1c4b-4281-b951-d872f2087c98
* Fix missing line in suppression; move the suppression to the more ↵timurrrr@chromium.org2009-10-301-13/+14
| | | | | | | | | appropriate place. TBR=dank Review URL: http://codereview.chromium.org/344040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30635 0039d316-1c4b-4281-b951-d872f2087c98
* Add suppressions for Mac UI valgrind botsstuartmorgan@chromium.org2009-10-302-0/+35
| | | | | | | | | BUG=23314,26324,26326 TEST=Mac UI valgrind bot green-ness Review URL: http://codereview.chromium.org/341053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30589 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress two benign racestimurrrr@chromium.org2009-10-301-0/+23
| | | | | | | | TBR=dank TEST=Linux TSAN bot green on unit_tests Review URL: http://codereview.chromium.org/343058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30579 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress warnings below AudioQueueDisposetimurrrr@chromium.org2009-10-291-0/+8
| | | | | | | | | | | | This CL adds a suppression for a warning reported by ThreadSanitizer with --ignore-in-dtor=no when a ClientAudioQueue object is destroyed. This appears to be a benign one. This patch was prepared by Alexander Potapenko (cc'ed) Review URL: http://codereview.chromium.org/348011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30475 0039d316-1c4b-4281-b951-d872f2087c98
* Fix unit test memory leak introduced by my ChromeThread change.jam@chromium.org2009-10-291-9/+0
| | | | | | | | BUG=26213 Review URL: http://codereview.chromium.org/346014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30468 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress two new valgrind leaksstuartmorgan@chromium.org2009-10-291-0/+16
| | | | | | | | | BUG=26213,26216 TEST=Linix valgrind 1 bot Review URL: http://codereview.chromium.org/339067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30459 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress reports under _dl_closetimurrrr@chromium.org2009-10-291-0/+9
| | | | | | | TBR=dank Review URL: http://codereview.chromium.org/348009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30454 0039d316-1c4b-4281-b951-d872f2087c98
* Fix checkbins.py to find pefile import instead of .bat/.sh wrappers.scherkus@chromium.org2009-10-283-13/+4
| | | | | | | | | BUG=25952 TEST=still executes regardless of where you run the script from Review URL: http://codereview.chromium.org/347008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30396 0039d316-1c4b-4281-b951-d872f2087c98
* Rename checkbin to checkbins (because it checks multiple binaries) and set ↵scherkus@chromium.org2009-10-283-2/+2
| | | | | | | | | | svn properties. TBR=maruel BUG=25952 Review URL: http://codereview.chromium.org/345015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30372 0039d316-1c4b-4281-b951-d872f2087c98
* Checking in checkbin.py, a tool to make sure our Windows binaries were built ↵scherkus@chromium.org2009-10-283-0/+78
| | | | | | | | | | | | | correctly. It looks for binaries built with /NXCOMPAT and /DYNAMICBASE, two important security features for Windows binaries. BUG=25952 TEST=try running it on the output of /src/chrome/Debug Review URL: http://codereview.chromium.org/338052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30304 0039d316-1c4b-4281-b951-d872f2087c98
* Remove ThreadSanitizer suppression for 22272.eroman@chromium.org2009-10-281-7/+0
| | | | | | | | | | The race was specific to unit-test code (see r29826) and should be fixed now. BUG=22272 Review URL: http://codereview.chromium.org/293042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30301 0039d316-1c4b-4281-b951-d872f2087c98
* Add one more suppression for a data race in libjingletimurrrr@chromium.org2009-10-271-1/+7
| | | | | | | | BUG=25913 TBR=dank Review URL: http://codereview.chromium.org/343004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30247 0039d316-1c4b-4281-b951-d872f2087c98
* Added printing of a couple of links to documentation in case warnings are ↵timurrrr@chromium.org2009-10-271-3/+14
| | | | | | | | | reporteed. I think this may increase the popularity and usability of our tools. Review URL: http://codereview.chromium.org/343002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30246 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress one more data race in test_shell on WeakReferencetimurrrr@chromium.org2009-10-271-1/+9
| | | | | | | | BUG=24715 TBR=dank Review URL: http://codereview.chromium.org/339022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30182 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress a data race on vfptr in ipc/ipc_sync_channel_unittest.cctimurrrr@chromium.org2009-10-271-10/+0
| | | | | | | | | | This race was already suppressed, but the existing suppression doesn't work if the order of accesses is different. We can prepare a suppression to make TSAN bots silent but it will be way too wide. I think adding one line of annotation with comment (twice) is better in terms of precision. BUG=25841 Review URL: http://codereview.chromium.org/339008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30181 0039d316-1c4b-4281-b951-d872f2087c98
* Suppressed a few data races in BookmarkModelWorkertimurrrr@chromium.org2009-10-271-0/+6
| | | | | | | | BUG=25915 TBR=dank Review URL: http://codereview.chromium.org/340001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30180 0039d316-1c4b-4281-b951-d872f2087c98
* Suppressed a data race in libjingle, re-grouped suppressions for ↵timurrrr@chromium.org2009-10-271-13/+21
| | | | | | | | | | third_party races. BUG=25913 TBR=dank Review URL: http://codereview.chromium.org/333047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30178 0039d316-1c4b-4281-b951-d872f2087c98
* Reset Windows expectations after new ref build.chase@chromium.org2009-10-271-2/+2
| | | | | | | | | BUG=25200 TEST=perf bots stay green Review URL: http://codereview.chromium.org/334034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30151 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the suppression for a Issue 24307: Data race on reference counternirnimesh@chromium.org2009-10-261-6/+0
| | | | | | | | | BUG=24307 TEST=tsan mac bot should remain green - (http://build.chromium.org/buildbot/waterfall/waterfall?builder=Linux+Tests+(tsan)&builder=Chromium+Mac+(tsan)) Review URL: http://codereview.chromium.org/333029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30120 0039d316-1c4b-4281-b951-d872f2087c98
* Widen a Mac UI valgrind suppression sligthlystuartmorgan@chromium.org2009-10-261-0/+1
| | | | | | | | | BUG=25656 TEST=Mac UI valgrind bots Review URL: http://codereview.chromium.org/330022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30112 0039d316-1c4b-4281-b951-d872f2087c98
* Set GTEST_DEATH_TEST_USE_FORK environment variable to make death tests ↵timurrrr@chromium.org2009-10-262-4/+4
| | | | | | | | | valgrind-friendly BUG=25346 Review URL: http://codereview.chromium.org/335026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30044 0039d316-1c4b-4281-b951-d872f2087c98
* Ignore a few more string functions to suppress reports on *_empty_rep_storage*timurrrr@chromium.org2009-10-261-2/+5
| | | | | | | TBR=dank Review URL: http://codereview.chromium.org/332025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30042 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a valgrind suppression for skia::BGRAConvolve2D() leak. This hasn't ↵senorblanco@chromium.org2009-10-241-25/+0
| | | | | | | | | | | been seen on the bots in a while (if I'm reading the output correctly). BUG=24345 TEST=green valgrind bots Review URL: http://codereview.chromium.org/333014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30005 0039d316-1c4b-4281-b951-d872f2087c98
* donehclam@chromium.org2009-10-231-15/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29952 0039d316-1c4b-4281-b951-d872f2087c98
* Add/widen suppressions for Mac UI valgrind botsstuartmorgan@chromium.org2009-10-232-4/+46
| | | | | | | | | BUG=25648,20814,25656,20113,20508,25661 TEST=Greener Mac UI valgrind bots Review URL: http://codereview.chromium.org/332008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29914 0039d316-1c4b-4281-b951-d872f2087c98
* Added a suppression for http://crbug.com/25645timurrrr@chromium.org2009-10-231-0/+8
| | | | | | | | BUG=25645 TBR=dank Review URL: http://codereview.chromium.org/337001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29894 0039d316-1c4b-4281-b951-d872f2087c98
* Added base::subtle::NoBarrier_CompareAndSwap and base::subtle::NoBarrier_Store timurrrr@chromium.org2009-10-231-0/+2
| | | | | | | | | | to the list of functions ignored by ThreadSanitizer on Mac OS. This patch was prepared by Alexander Potapenko (cc'ed) TBR=dank Review URL: http://codereview.chromium.org/333012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29893 0039d316-1c4b-4281-b951-d872f2087c98
* Fix coverage on the Mac.jrg@chromium.org2009-10-231-9/+32
| | | | | | | | Add extra unit test bundles (all platforms). Review URL: http://codereview.chromium.org/307032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29845 0039d316-1c4b-4281-b951-d872f2087c98
* Remove suppression for probably-fixed bugdkegel@google.com2009-10-221-6/+0
| | | | | | | | | BUG=20805 TEST=green linux ui valgrind bots Review URL: http://codereview.chromium.org/320002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29790 0039d316-1c4b-4281-b951-d872f2087c98
* Remove ThreadSanitizer suppression for bug 15147.eroman@chromium.org2009-10-211-7/+0
| | | | | | | | | | This hasn't reproduced in the past bunch of runs of net_unittests; I believe it was fixed by r26611. BUG=15147 Review URL: http://codereview.chromium.org/294034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29680 0039d316-1c4b-4281-b951-d872f2087c98
* Update valgrind to fix one problem with 64 bit code, and a regression ↵dkegel@google.com2009-10-213-0/+43
| | | | | | | | | | | running wine. BUG=valgrind_210481, valgrind_205541 TEST=valgrind net_unittests --gtest_filter=ProxyResolverV8Test.LoadLog ; valgrind wine's unit tests and see no HEAP_CreateSubHeap valgrind warnings Review URL: http://codereview.chromium.org/306020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29655 0039d316-1c4b-4281-b951-d872f2087c98
* Add new variant of the safe browsing leak.nsylvain@chromium.org2009-10-211-0/+15
| | | | | | | | BUG:19546 Review URL: http://codereview.chromium.org/300038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29649 0039d316-1c4b-4281-b951-d872f2087c98
* Added a suppression for data race on vfptr in base::Threadtimurrrr@chromium.org2009-10-211-1/+8
| | | | | | | | BUG=25385 TBR=dank Review URL: http://codereview.chromium.org/306024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29634 0039d316-1c4b-4281-b951-d872f2087c98
* Added a suppression for another benign race in ICU, widen one old suppression.timurrrr@chromium.org2009-10-211-0/+8
| | | | | | | | | | | | (see third_party/icu/source/common/umutex.c) When two concurrent threads try to call umtx_lock(mutex) for an uninitialized mutex simultaneously, *mutex is read without taking any lock. However, if *mutex is NULL, a DCLP inside umtx_init(mutex) guarantees that *mutex is initialized exactly once. Otherwise, if *mutex is already a valid pthread_mutex_t, the behavior of the program is not affected. This patch was prepared by Alexander Potapenko (cc'ed) TBR=dank Review URL: http://codereview.chromium.org/303019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29633 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit merge 49872:49896.yutak@chromium.org2009-10-211-8/+0
| | | | | | | | | | This roll should fix a valgrind error (issue 25297). R=jamesr BUG=25297 TEST=none Review URL: http://codereview.chromium.org/292039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29613 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress more ScriptString errors.tkent@chromium.org2009-10-211-2/+2
| | | | | | | | | TBR=awalker BUG=none TEST=none Review URL: http://codereview.chromium.org/293041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29605 0039d316-1c4b-4281-b951-d872f2087c98
* Widen one suppression for x86_64, add a new upstream one.dkegel@google.com2009-10-201-1/+11
| | | | | | | | | BUG=none TEST=sh tools/valgrind/chrome_tests.sh -t base on a 64 bit build Review URL: http://codereview.chromium.org/300024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29585 0039d316-1c4b-4281-b951-d872f2087c98
* Add suppression for new memory leak caused by WebKit merge 49830:49844.yutak@chromium.org2009-10-201-0/+8
| | | | | | | | | TBR=jamesr BUG=25297 TEST=none Review URL: http://codereview.chromium.org/306003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29505 0039d316-1c4b-4281-b951-d872f2087c98
* Remove suppression for 20939, fixed in webkit r49609.mattm@chromium.org2009-10-161-7/+0
| | | | | | | | | BUG=20939 TEST=valgrind_webkit_tests.sh LayoutTests/fast/css/invalid-percentage-property.html Review URL: http://codereview.chromium.org/273077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29231 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a stray line from the valgrind suppressionsstuartmorgan@chromium.org2009-10-151-1/+0
| | | | | | | | | BUG=none TEST=N/A Review URL: http://codereview.chromium.org/282009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29180 0039d316-1c4b-4281-b951-d872f2087c98