summaryrefslogtreecommitdiffstats
path: root/tools
Commit message (Collapse)AuthorAgeFilesLines
* This avoids unnecessarily scheduling a callback wrapped inside another ↵ghc@google.com2011-07-261-9/+0
| | | | | | | | | | | | | callback, which was causing a memory leak in unit tests. This change also removes the valgrind leak suppression (bug 89025). Tested by running sync_unit_tests through valgrind with the suppression removed. Also did a manual end-to-end test of cache invalidation with Chrome. Review URL: http://codereview.chromium.org/7514017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94160 0039d316-1c4b-4281-b951-d872f2087c98
* Remove explicit keyword from multi-argument (w/o default values) constructorsdilmah@chromium.org2011-07-261-8/+3
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/7477008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94115 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress leaks in gfx::CanvasSkia::SizeStringInt (issue 70327)glider@chromium.org2011-07-261-0/+65
| | | | | | | | | | | | Add another suppression for issue 48130 (leaks in chromeos::input_method) Suppress a leak in ChromeURLDataManagerBackend::AddDataSource (issue 90521) Extend the suppression for issue 82717 (leak in ChromeContentBrowserClient::BrowserRenderProcessHostCreated) BUG=70327,48130,90521,82717 TBR=timurrrr Review URL: http://codereview.chromium.org/7470021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94106 0039d316-1c4b-4281-b951-d872f2087c98
* Extend the suppression for leaks in NPAPIClient (issue 84223) to match the ↵glider@chromium.org2011-07-261-1/+41
| | | | | | | | | | | | CrOS reports Suppress the leaks in ResourceDispatcherHost callbacks (issue 90496) TBR=timurrrr BUG=84223,90496 Review URL: http://codereview.chromium.org/7461078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94085 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress a leak in URLFetcher::Core::StartURLRequestWhenAppropriate (issue ↵glider@chromium.org2011-07-261-1/+34
| | | | | | | | | | | | | 80663) Suppress a use-after-free in NativeWidgetView::set_delete_native_widget (issue 90484) Suppress a leak in QuotaManager::RegisterClient (issue 90487) BUG=80663,90484,90487 TBR=timurrrr Review URL: http://codereview.chromium.org/7480008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94068 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress leaks in gfx::RenderTextTest* (issue 90370)glider@chromium.org2011-07-262-0/+20
| | | | | | | | | | | Suppress a leak in TabContents::GetWebkitPrefs (issue 90400) Suppress a data race in VideoCaptureController::OnDeviceStopped (issue 86507) BUG=86507,90370,90400 TBR=timurrrr Review URL: http://codereview.chromium.org/7495034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94060 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed memory problem in ProtocolHandlerRegistry unit tests.benwells@chromium.org2011-07-261-7/+0
| | | | | | | | | | | | | | | | | | This memory problem only occurred in tests. It happens because the shell worker, which does stuff on the file thread and is held onto by message loops, was outliving the delegate which it used. Fix is to not pass in a delegate but the only piece of information it needs (whether to fake failure or not). BUG=90248 TEST=Automated tests and valgrind bots Review URL: http://codereview.chromium.org/7461060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94023 0039d316-1c4b-4281-b951-d872f2087c98
* Changed deque to Queue for shard output buffercharleslee@chromium.org2011-07-251-28/+19
| | | | | | | | | Thread safe and no longer any need to sleep when current buffer is empty Review URL: http://codereview.chromium.org/7484069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93959 0039d316-1c4b-4281-b951-d872f2087c98
* Add safely-roll-webkit.py to streamline webkit rolls.maruel@chromium.org2011-07-252-0/+120
| | | | | | | | | | It still needs some work on the commit queue side to work correctly, at the moment it will deny the commit because there is no LGTM. Review URL: http://codereview.chromium.org/7089012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93945 0039d316-1c4b-4281-b951-d872f2087c98
* Views views_unittests FocusManagerTest.FocusNativeControls use after freedhollowa@chromium.org2011-07-251-14/+0
| | | | | | | | | | | | | | | Fixes issue where NativeTabbedPaneGtk gets retained by the top-level FocusManager during the Widget::Close tear-down sequence. This fix clears focus before proceeding with the tear-down. This avoids redundant operations with the FocusManger as views get deleted, specifically in the FocusManager::ViewRemoved() call. Caught by Valgrind as a use after free violation: sh tools/valgrind/chrome_tests.sh views --gtest_filter=FocusManagerTest.FocusNativeControls BUG=89596 TEST=tools/valgrind/chrome_tests.sh views --gtest_filter=FocusManagerTest.FocusNativeControls Review URL: http://codereview.chromium.org/7468037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93894 0039d316-1c4b-4281-b951-d872f2087c98
* Enable gen_keyboard_overlay_data.py to output detailed description for grd ↵mazda@chromium.org2011-07-251-9/+21
| | | | | | | | | | | | | | | messages. I added a 'Description for translaction' column to the source spreadsheet and used the data for generating the detailed description for grd messages. BUG=chromium-os:17152 TEST=Ran the script and checked it generated correct code. Review URL: http://codereview.chromium.org/7491037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93889 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress leaks in PredictorTest.ShutdownWhenResolutionIsPendingTest (issue ↵glider@chromium.org2011-07-251-0/+22
| | | | | | | | | | 90381) TBR=eroman BUG=90381 Review URL: http://codereview.chromium.org/7492047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93882 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress an uninit conditional jump in views::Widget::SetInitialBounds ↵glider@chromium.org2011-07-251-0/+17
| | | | | | | | | | (issue 90376) BUG=90376 TBR=sky Review URL: http://codereview.chromium.org/7461062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93876 0039d316-1c4b-4281-b951-d872f2087c98
* Add fun:gfx::RenderTextTest* suppression for Heapcheck leak.msw@chromium.org2011-07-251-0/+6
| | | | | | | | | | | | I will take a look later today. BUG=90370 TEST=none TBR=hbono Review URL: http://codereview.chromium.org/7495026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93869 0039d316-1c4b-4281-b951-d872f2087c98
* Extend the suppression for issue 81796 (leak in ↵glider@chromium.org2011-07-251-2/+12
| | | | | | | | | | | | IPCChannelTest::ChannelProxyTest) Suppress a leak in ProfileManagerTest.CreateProfilesAsync (issue 90369) BUG=81796,51572,90369 TBR=altimofeev Review URL: http://codereview.chromium.org/7492043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93866 0039d316-1c4b-4281-b951-d872f2087c98
* Sort input method IDs in xkeyboard.cc.mazda@chromium.org2011-07-251-1/+0
| | | | | | | | | | | | Also remove a redundant empty line in the script. BUG=none TEST=Checked the list generated by script equals to the manually sorted list. Review URL: http://codereview.chromium.org/7489037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93850 0039d316-1c4b-4281-b951-d872f2087c98
* Remove recently added suppressions that look attributable to themichaeln@google.com2011-07-242-38/+0
| | | | | | | | | | | problem fixed here... http://codereview.chromium.org/7495015/ TBR=stuartmorgan BUG=90215 TEST=green bots Review URL: http://codereview.chromium.org/7489025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93833 0039d316-1c4b-4281-b951-d872f2087c98
* Roll clang r135314:135823thakis@chromium.org2011-07-241-1/+1
| | | | | | | | | | | | Picking up fix for -Wsign-compare (135664). BUG=none TEST=trybots Review URL: http://codereview.chromium.org/7488030 Patch from Ami Fischman <fischman@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93831 0039d316-1c4b-4281-b951-d872f2087c98
* Adding fake bidi generationofri@google.com2011-07-244-86/+198
| | | | | | | | | | BUG=73052 TEST=NONE Review URL: http://codereview.chromium.org/7246008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93821 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable ChromeAppCacheServiceTest tests under heapcheck.michaeln@google.com2011-07-231-4/+0
| | | | | | | | | TBR=stuartmorgan,marja BUG=90215 TEST=Still green heapcheck bot Review URL: http://codereview.chromium.org/7493031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93741 0039d316-1c4b-4281-b951-d872f2087c98
* Tests that timeout are now printed in summarycharleslee@chromium.org2011-07-221-18/+59
| | | | | | | | | BUG=89168 Review URL: http://codereview.chromium.org/7435006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93735 0039d316-1c4b-4281-b951-d872f2087c98
* Update heapcheck suppressionsstuartmorgan@chromium.org2011-07-221-3/+11
| | | | | | | | | | | | | Update two suppressions that have broken by refactorings, and add one new one. TBR=glider BUG=76354,75224,90271 TEST=Greener valgrind bots Review URL: http://codereview.chromium.org/7461043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93732 0039d316-1c4b-4281-b951-d872f2087c98
* Update CreateNewFullscreenWidget leak suppression for refactoringstuartmorgan@chromium.org2011-07-221-1/+1
| | | | | | | | | | | TBR=glider BUG=52900 TEST=Greener heapcheck bot Review URL: http://codereview.chromium.org/7493028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93721 0039d316-1c4b-4281-b951-d872f2087c98
* Add the heapcheck version of ↵stuartmorgan@chromium.org2011-07-221-0/+7
| | | | | | | | | | | | | ServicesCustomizationDocument::LoadManifestFromString suppression TBR=nkostylev BUG=81782 TEST=Greener heapcheck bot Review URL: http://codereview.chromium.org/7488028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93717 0039d316-1c4b-4281-b951-d872f2087c98
* Stop running ChromeAppCacheServiceTest tests under heapcheckstuartmorgan@chromium.org2011-07-221-0/+4
| | | | | | | | | | | TBR=marja BUG=90215 TEST=Greener heapcheck bot Review URL: http://codereview.chromium.org/7495014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93712 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress an invalid read in the new FakeDelegate used in the protocol ↵stuartmorgan@chromium.org2011-07-221-0/+7
| | | | | | | | | | | | | handler registry TBR=benwells BUG=90248 TEST=Greener valgrind bots Review URL: http://codereview.chromium.org/7493021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93709 0039d316-1c4b-4281-b951-d872f2087c98
* Reving up cros to pickup new chromeos_mount.tbarzic@chromium.org2011-07-221-1/+1
| | | | | | | | TEST=NONE BUG=NONE Review URL: http://codereview.chromium.org/7488024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93705 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unneded supression for ClientSideDetectionHostTestgcasto@chromium.org2011-07-221-12/+0
| | | | | | | | | BUG=89890 TEST=Ran unittest under valgrind Review URL: http://codereview.chromium.org/7484038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93699 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress a leak in PPP_Instance_Private_Proxystuartmorgan@chromium.org2011-07-221-0/+8
| | | | | | | | | | | TBR=dmichael BUG=90240 TEST=Greener valgrind bots Review URL: http://codereview.chromium.org/7484043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93696 0039d316-1c4b-4281-b951-d872f2087c98
* Update SingleLoginAttempt->TestURLRequestContextGetter suppressionstuartmorgan@chromium.org2011-07-221-1/+1
| | | | | | | | | | | | | The namespace on the function changed, breaking the old suppression. TBR=sanjeevr BUG=79651 TEST=Greener valgrind bots Review URL: http://codereview.chromium.org/7495010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93693 0039d316-1c4b-4281-b951-d872f2087c98
* Add valgrind suppressions for several of the current main leaksstuartmorgan@chromium.org2011-07-222-0/+56
| | | | | | | | | | | | | Primarily a wide swath of suppressions for the AppCache leak. TBR=marja BUG=90212,90215 TEST=Greener valgrind bots Review URL: http://codereview.chromium.org/7484036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93679 0039d316-1c4b-4281-b951-d872f2087c98
* Adjust perf expectation for the new pak size increase on linux.nsylvain@chromium.org2011-07-221-2/+2
| | | | | | | | BUG=90150 TBR=cmp Review URL: http://codereview.chromium.org/7488020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93667 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress the leaks in ↵glider@chromium.org2011-07-221-0/+12
| | | | | | | | | | safe_browsing::ClientSideDetectionHost::OnPhishingDetectionDone (issue 89890) TBR=stuartmorgan BUG=89890 Review URL: http://codereview.chromium.org/7495004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93656 0039d316-1c4b-4281-b951-d872f2087c98
* Fix NetworkLibrary memory leaks and warnings.stevenjb@google.com2011-07-221-34/+0
| | | | | | | | | BUG=chromium:89684 TEST=Run linux_chromeos_valgrind and make sure there are no leaks in network_library.cc Review URL: http://codereview.chromium.org/7468035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93653 0039d316-1c4b-4281-b951-d872f2087c98
* Fix memory leaks in client_side_detection_host_unittest.noelutz@google.com2011-07-222-18/+0
| | | | | | | | | | | SAME as http://codereview.chromium.org/7473002/. BUG=89890 TEST=Ran unittest with valgrind. Review URL: http://codereview.chromium.org/7484031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93642 0039d316-1c4b-4281-b951-d872f2087c98
* Make waterfall.sh match "Chromium%20OS%20Heapcheck" as well as ↵glider@chromium.org2011-07-221-1/+1
| | | | | | | | | | "Linux%20Heapcheck" TBR=timurrrr Review URL: http://codereview.chromium.org/7488008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93605 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress real leaks found by the CrOS heapcheck bot:glider@chromium.org2011-07-221-1/+27
| | | | | | | | | | | | TabContentsViewViews::CreateView (issue 90154) NetworkLibraryImplStub::Init (issue 89684) ProfileImpl::OnPrefsLoaded (issue 88640) TBR=stuartmorgan BUG=88640,89684,90154 Review URL: http://codereview.chromium.org/7489008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93604 0039d316-1c4b-4281-b951-d872f2087c98
* Fix browser_tests Valgrind runner; also re-order the other test runners.timurrrr@chromium.org2011-07-221-24/+27
| | | | | | Review URL: http://codereview.chromium.org/7492008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93601 0039d316-1c4b-4281-b951-d872f2087c98
* Exclude DirectoryListerTest.BigDirRecursiveTest from Valgrind runs tootimurrrr@chromium.org2011-07-222-3/+3
| | | | | | | | BUG=61908 TBR=glider Review URL: http://codereview.chromium.org/7461024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93600 0039d316-1c4b-4281-b951-d872f2087c98
* Widen suppression for DiskCache leakstuartmorgan@chromium.org2011-07-211-3/+0
| | | | | | | | | | | TBR=rvargas BUG=87500 TEST=Greener bots Review URL: http://codereview.chromium.org/7482011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93484 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress a CookieMonster leakstuartmorgan@chromium.org2011-07-211-0/+13
| | | | | | | | | | | TBR=ycxiao BUG=90057 TEST=Greener valgrind bots Review URL: http://codereview.chromium.org/7482004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93481 0039d316-1c4b-4281-b951-d872f2087c98
* If good..bad range is all before or after the recent build cutoff, use the ↵jbates@chromium.org2011-07-211-17/+32
| | | | | | | | | | | | | appropriate server. If good..bad straddles the recent build cutoff, test out the oldest recent build. If that build is good, bisect only recent builds from build.chromium.org. If that build is bad, bisect only old builds. BUG=89974 TEST=(1) run bisect-builds.py with defaults; (2) accept default good/bad args; when chrome starts, close it and specify good; verify that further downloads come from build.chromium.org domain. Repeat (1) and (2); specify bad; verify that further downloads come from commondatastorage.googleapis.com. Review URL: http://codereview.chromium.org/7468020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93432 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a suppression for a fixed Dr. Memory false positivetimurrrr@chromium.org2011-07-211-9/+0
| | | | | | | BUG=http://code.google.com/p/drmemory/issues/detail?id=395 Review URL: http://codereview.chromium.org/7467028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93403 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress all the leaks reported by heapcheck that contain an unresolved ↵glider@chromium.org2011-07-211-0/+7
| | | | | | | | | | frame ("fun:??") TBR=stuartmorgan BUG=90013 Review URL: http://codereview.chromium.org/7467025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93391 0039d316-1c4b-4281-b951-d872f2087c98
* Mass-suppress the leaks on the Chrome OS Heapcheck botglider@chromium.org2011-07-211-0/+26
| | | | | | | | BUG=90013 TBR=stuartmorgan Review URL: http://codereview.chromium.org/7473029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93382 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress uninit & unaddr accesses on MessageBox() callstimurrrr@chromium.org2011-07-211-0/+8
| | | | | | | | TBR=bruening BUG=http://code.google.com/p/drmemory/issues/detail?id=60 Review URL: http://codereview.chromium.org/7472035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93378 0039d316-1c4b-4281-b951-d872f2087c98
* Extend the suppression for the leak in IPCChannelTest::ChannelProxyTest ↵glider@chromium.org2011-07-211-2/+22
| | | | | | | | | | | | (issue 81796) Suppress a certificate leak in chromeos build (issue 32623) TBR=stuartmorgan BUG=81796,32623 Review URL: http://codereview.chromium.org/7472032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93371 0039d316-1c4b-4281-b951-d872f2087c98
* Fix gen_keyboard_overlay_data.py not outputting AltGr.mazda@chromium.org2011-07-211-3/+3
| | | | | | | | | | | | Also modify the script to output the sorted lists of input method ID. BUG=none TEST=Checked the script generated correct output. Review URL: http://codereview.chromium.org/7471030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93356 0039d316-1c4b-4281-b951-d872f2087c98
* Activate ibus-mozc-hangul and replace from ibus-hangul.yusukes@google.com2011-07-211-1/+1
| | | | | | | | | | | | BUG=chromium-os:15192 TEST=manually done Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=93310 Review URL: http://codereview.chromium.org/7433004 Patch from Seigo Nonaka <nona@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93341 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Activate ibus-mozc-hangul and replace from ibus-hangul."yusukes@google.com2011-07-211-1/+1
| | | | | | | | | | | | This reverts commit a1aa3f9da8a333098a96c19193c4298a0c9fdd41. BUG=None TEST=None TBR=nona@chromium.org Review URL: http://codereview.chromium.org/7472023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93311 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-18 03:38:51 +0000