summaryrefslogtreecommitdiffstats
path: root/tools
Commit message (Collapse)AuthorAgeFilesLines
* Add ServiceProcessStateFileManipulationTest.DeleteBundle to the Mac Valgrind ↵rsesek@chromium.org2011-03-221-0/+4
| | | | | | | | | | | | skip list. BUG=77064 TEST=Mac Valgrind unit TBR=dmaclach Review URL: http://codereview.chromium.org/6716027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78993 0039d316-1c4b-4281-b951-d872f2087c98
* Add a suppression for a Memcheck:Free in TrashFunc from ↵rsesek@chromium.org2011-03-221-0/+22
| | | | | | | | | | | | service_process_util_unittest.cc BUG=77063 TEST=Mac Valgrind unit TBR=dmaclach Review URL: http://codereview.chromium.org/6716026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78991 0039d316-1c4b-4281-b951-d872f2087c98
* Widen a suppression for a false positive data race report in WebKit (missing ↵timurrrr@chromium.org2011-03-221-1/+1
| | | | | | | | | | | | | annotations) For this report: http://build.chromium.org/p/chromium.memory/builders/Linux%20Tests%20%28tsan%20UI%29%282%29/builds/161/steps/memory%20test%3A%20ui/logs/stdio BUG=70085 TBR=rsesek TEST=TSan/UI bots are less flaky Review URL: http://codereview.chromium.org/6675027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78982 0039d316-1c4b-4281-b951-d872f2087c98
* Add a suppression for a Memcheck:Cond in ↵rsesek@chromium.org2011-03-221-0/+9
| | | | | | | | | | | WebCore::Gradient::sortStopsIfNecessary. BUG=77049 TEST=WebKit valgrind goes green Review URL: http://codereview.chromium.org/6718028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78981 0039d316-1c4b-4281-b951-d872f2087c98
* Add a suppression for the leak in ServiceProcessState::Initialize().rsesek@chromium.org2011-03-221-0/+8
| | | | | | | | | | BUG=77042 TEST=Mac Valgrind TBR=dmaclach Review URL: http://codereview.chromium.org/6708083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78978 0039d316-1c4b-4281-b951-d872f2087c98
* Valgrind/Heapchecker: Suppress leak in TreeNodeModelTest_BasicOperations.thestig@chromium.org2011-03-222-0/+21
| | | | | | | | | BUG=77012 TEST=none TBR=tfarina Review URL: http://codereview.chromium.org/6708078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78963 0039d316-1c4b-4281-b951-d872f2087c98
* Rename valgrind_layout to valgrind_webkitjochen@chromium.org2011-03-211-0/+1
| | | | | | | | | | | | This will allow for more uniform buildbot factories BUG=none TEST=none Review URL: http://codereview.chromium.org/6685121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78927 0039d316-1c4b-4281-b951-d872f2087c98
* Widen a TSan suppression for ↵rsesek@chromium.org2011-03-211-0/+1
| | | | | | | | | | | sync_api::SyncManager::SyncInternal::BootstrapEncryption. BUG=72913 TEST=Linux TSan goes green Review URL: http://codereview.chromium.org/6675007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78924 0039d316-1c4b-4281-b951-d872f2087c98
* WinDDK ATL and MSVC express 2008/2005 compatability mark@chromium.org2011-03-212-2/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Gives 'out of the box' compatability with VC2008 express - i.e. no modifications needed to system headers or .gyp* files or related hacks. Just set the GYP_MSVS_VERSION to 200Xe (e for express, same as the linked blog on the issue and first google hit as well). 1) Changes to build\common.gypi to turn off to define COMPILER_MSVC_EXPRESS if a express is detected (through the GYP_MSVC_VERSION environment variable), turn off the _SECURE_ATL define (which is flagged as an error with WinDDK's ATL, _SECURE_ATL adds [more] CRT checks to other ATL versions) and hard to link to the atl stdthunk library with express editions. Also, explicitly link to the base WinSDK libraries in common.gypi and mini_installer.gypi for MSVC 2005 express. 2) Fixes a few .cc files that have the wrong include order with the ATL headers when using the Windows DDK ATL. The Windows DDK ATL brings in intsafe.h (WinSDK, not WinDDK) with atlwin.h and generates multiple INTXX_MIN/MAX def warnings which get flagged as errors with the warnings as errors flag if not included before other libraries that have the same definitions like ICU. 3) Changes to .rc files to avoid pulling in afxres.h (an MFC header - it's available in the WinDDK) and winres.h which VCExpress doesn't have (it's available in a WinSDK sample, but that kind of the purpose of it). The main Chromium .rc files are already structured this way, I just changed the rest and changed the output of grit to do the same. 4) Removes the memset obj file linking in mini_installer.gyp and simply implements memset for mini_installer.cc. Only changes to the chromium branch now. There are some .rc files in the Python26, Native Client, and Angle in samples that could #3 changes. They are not required for Chromium, however. ------ VC2005SP1 can be downloaded at http://www.microsoft.com/downloads/en/details.aspx?FamilyId=7B0B0339-613A-46E6-AB4D-080D4D4A8C4E&displaylang=en (or non-SP1 at http://download.microsoft.com/download/8/3/a/83aad8f9-38ba-4503-b3cd-ba28c360c27b/ENU/vcsetup.exe) VC2008SP1 can be downloaded at http://www.microsoft.com/downloads/en/details.aspx?FamilyId=F3FBB04E-92C2-4701-B4BA-92E26E408569&displaylang=en currently. The base developer instructions work fine afterwards with a couple tweaks for express versions: http://www.chromium.org/developers/how-tos/build-instructions-windows Under "Additional (free) downloads" under step 2: X) Only the first 3 Non-SP KB Patches are needed for express. Don't forget to forget GYP_MSVS_VERSION environment as appropriate - 2008e for Visual C++ 2008 Express, for example. Under "Additional (free) downloads" after step 5 [These only apply to 2008 express, 2005 works fine out of the box]: 6A) Download the WinDDK for the atl headers and libs - http://msdn.microsoft.com/en-us/windows/hardware/gg487463.aspx. It works fine, but you do not need to install the whole DDK. In the WDK directory just install headers.msi, libs_x86fre.msi, and libs_x64fre.msi; just grab the atl headers and atl*.lib libs; right click the installers and uninstall afterwards. Add the appropriate include and lib paths to your global settings. 6B) To build x64 targets (x64 Native Client) download: http://www.cppblog.com/Files/xcpp/VCE64BIT_WIN7SDK.zip Follow the readme instructions. Further information behind that and x64 target building with express: - http://jenshuebel.wordpress.com/2009/02/12/visual-c-2008-express-edition-and-64-bit-targets/ - http://www.cppblog.com/xcpp/archive/2009/09/09/vc2008express_64bit_win7sdk.html ---------------- BUG=1433, 5026, 72885 TEST=Compiles in both Debug and Release mode in Visual C++ Express 2008/2005 and does not effect other build setups. In addition, the WinDDK ATL compiles with the secure_atl=0 in the GYP_DEFINES environment variable on non-express versions of MSVC. Review URL: http://codereview.chromium.org/6676030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78921 0039d316-1c4b-4281-b951-d872f2087c98
* Put ProfileSyncServicePasswordTest.EmptyNativeEmptySync on the Valgrind Mac ↵rsesek@chromium.org2011-03-211-1/+4
| | | | | | | | | | | | | | gtest_exclude list. It intermittently crashes or fails. BUG=76932 TEST=Mac Valgrind unit goes green. TBR=tim Review URL: http://codereview.chromium.org/6712063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78891 0039d316-1c4b-4281-b951-d872f2087c98
* Update Heapcheck suppressions after r78856.rsesek@chromium.org2011-03-211-1/+1
| | | | | | | | | | BUG=75224,72758 TEST=Linux Heapcheck goes green TBR=tfarina Review URL: http://codereview.chromium.org/6712061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78887 0039d316-1c4b-4281-b951-d872f2087c98
* Don't run URLRequestTest.FileTest under TSantimurrrr@chromium.org2011-03-211-0/+3
| | | | | | | | | BUG=76911 TEST=TSan bot goes green TBR=glider Review URL: http://codereview.chromium.org/6708051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78873 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress a data race under SetPassphrase in synctimurrrr@chromium.org2011-03-211-0/+11
| | | | | | | | | BUG=76908 TBR=tim TEST=TSan bot goes green Review URL: http://codereview.chromium.org/6713067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78872 0039d316-1c4b-4281-b951-d872f2087c98
* Fix flakiness in Alternate-Protocol tests.willchan@chromium.org2011-03-181-4/+0
| | | | | | | | | | | | | They would hit the backup socket timer. This fixes that. I've also removed the test exclusions added to work around the flakiness. BUG=76592 TEST=net_unittests isn't flaky Review URL: http://codereview.chromium.org/6714013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78720 0039d316-1c4b-4281-b951-d872f2087c98
* Normalize the top-level ui/ module.rsesek@chromium.org2011-03-182-7/+7
| | | | | | | | | | | | | | | | This CL creates four .gypi files that are included in /ui/ui.gyp. This allows for a single unittest binary for all the submodules, rather than having individual unittest binaries for each submodule. To not break the buildbot, this creates a fake target that copies ui_unittests to gfx_unittests as temporary scaffolding. BUG=72317 TEST=gfx_unittests (really ui_unittests) passes Review URL: http://codereview.chromium.org/6688007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78711 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress the leak in webkit_glue::BufferedDataSource::CreateResourceLoaderglider@chromium.org2011-03-181-0/+17
| | | | | | | | TBR=timurrrr BUG=76647 Review URL: http://codereview.chromium.org/6688030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78672 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress leaks in UserStyleSheetWatcherglider@chromium.org2011-03-182-1/+19
| | | | | | | | TBR=timurrrr BUG=76644 Review URL: http://codereview.chromium.org/6708022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78671 0039d316-1c4b-4281-b951-d872f2087c98
* Exclude ErrorPageTest.DNSError_GoBack1 to make the TSan/UI bot greenertimurrrr@chromium.org2011-03-171-0/+1
| | | | | | | | BUG=46643 TBR=glider Review URL: http://codereview.chromium.org/6712017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78613 0039d316-1c4b-4281-b951-d872f2087c98
* Exclude a couple of HttpNetworkTransactionTests that fail on the TSan botstimurrrr@chromium.org2011-03-171-0/+4
| | | | | | | | | BUG=76592 TBR=glider TEST=TSan bots go greener Review URL: http://codereview.chromium.org/6710011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78610 0039d316-1c4b-4281-b951-d872f2087c98
* Add resources/touch_ntp/tools/check to whitelist for +x.sadrul@chromium.org2011-03-171-0/+1
| | | | | | TBR=markmentovai@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78609 0039d316-1c4b-4281-b951-d872f2087c98
* Try #3 - move forward cros DEPS file.zelidrag@chromium.org2011-03-171-1/+1
| | | | | | | | | BUG=none TEST=none TBR=stevenjb Review URL: http://codereview.chromium.org/6710008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78600 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 78591 - Try #2 - moving forward libcros deps.zelidrag@chromium.org2011-03-171-1/+1
| | | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6709007 TBR=zelidrag@chromium.org Review URL: http://codereview.chromium.org/6710007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78597 0039d316-1c4b-4281-b951-d872f2087c98
* Try #2 - moving forward libcros deps.zelidrag@chromium.org2011-03-171-1/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6709007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78591 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 78571 - Moved deps forward to catch my mount library rewrite.zelidrag@chromium.org2011-03-171-1/+1
| | | | | | | | | | | | BUG=chromium-os:13190 TEST=none TBR=stevenjb Review URL: http://codereview.chromium.org/6709003 TBR=zelidrag@chromium.org Review URL: http://codereview.chromium.org/6709004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78577 0039d316-1c4b-4281-b951-d872f2087c98
* Moved deps forward to catch my mount library rewrite.zelidrag@chromium.org2011-03-171-1/+1
| | | | | | | | | BUG=chromium-os:13190 TEST=none TBR=stevenjb Review URL: http://codereview.chromium.org/6709003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78571 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a suppression for code that no longer exists.rsesek@chromium.org2011-03-171-8/+0
| | | | | | | | | BUG=32564 TEST=Mac Valgrind unit stays green Review URL: http://codereview.chromium.org/6693026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78544 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress incorrect conditional jump in WebCore::Element::removeAttribute ↵glider@chromium.org2011-03-171-0/+9
| | | | | | | | | | (issue 76490) BUG=76490 TBR=timurrrr Review URL: http://codereview.chromium.org/6674054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78525 0039d316-1c4b-4281-b951-d872f2087c98
* Ignore _pthread_exit and _dispatch_queue_drain on Mac.glider@chromium.org2011-03-171-0/+4
| | | | | | | TBR=timurrrr Review URL: http://codereview.chromium.org/6672073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78524 0039d316-1c4b-4281-b951-d872f2087c98
* Compile the devtools grd file into a .pak file so wetony@chromium.org2011-03-175-5/+53
| | | | | | | | | | | | | | | | can include the data in resources.pak. To avoid resource ids colliding between files, we have a global file, resource_ids, that tracks the starting id values. Since the devtools grd file is generated, it's hard to add an entry to |resource_ids|. To work around this, add support for expanding variables in the |resource_ids|. BUG=35793 Review URL: http://codereview.chromium.org/6685061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78468 0039d316-1c4b-4281-b951-d872f2087c98
* Update cros.DEPS to 114stevenjb@google.com2011-03-161-1/+1
| | | | | | | | | BUG=chromium-os:13089 TEST=Ensure Chrome compiles Review URL: http://codereview.chromium.org/6674033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78426 0039d316-1c4b-4281-b951-d872f2087c98
* Fix speed regressions in clang by changing datastructures used and ↵erg@google.com2011-03-162-22/+19
| | | | | | | | | | | | | | minimizing temporaries. (r78395 regressed the speed of "make -j8 chrome" on linux by 25 seconds; this patch causes a 40 second progression so we're now faster than when I started.) BUG=carnitas TEST=compiles Review URL: http://codereview.chromium.org/6674032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78425 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress probably false-positive/one-time memory leaks in ↵timurrrr@chromium.org2011-03-161-59/+8
| | | | | | | | | | | std::string::_Rep::_S_create BUG=76386,43451,46570 TEST=Memory waterfall is greener Review URL: http://codereview.chromium.org/6676040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78415 0039d316-1c4b-4281-b951-d872f2087c98
* Fix clang bustage on Mac by blacklisting /Developererg@google.com2011-03-161-1/+4
| | | | | | TBR=rshima git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78401 0039d316-1c4b-4281-b951-d872f2087c98
* Warn/error on "using namespace blah;" in headers on clang machines.erg@google.com2011-03-166-31/+128
| | | | | | | | | | | This adds about 25s to "make -j8" on linux. I have a few ideas on how to reduce runtime to compensate though. BUG=carnitas TEST=compiles Review URL: http://codereview.chromium.org/6698051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78395 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress data race reports below ↵timurrrr@chromium.org2011-03-161-6/+7
| | | | | | | | | | | OSAtomicAdd32/base::subtle::Barrier_AtomicIncrement BUG=55946 TEST=TSan/Mac is less flaky TBR=glider Review URL: http://codereview.chromium.org/6672047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78376 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress invalid read reports below media::FFmpegVideoDecodeEngine::Initializetimurrrr@chromium.org2011-03-161-0/+12
| | | | | | | | | BUG=76370 TBR=glider TEST=Mac/Valgrind is greener Review URL: http://codereview.chromium.org/6674026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78363 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress Heapchecker leaks below ↵timurrrr@chromium.org2011-03-161-0/+8
| | | | | | | | | | | ChildProcessHostMsg_ResolveProxy::ChildProcessHostMsg_ResolveProxy as well BUG=76354 TBR=jam TEST=heapchecker bot goes green Review URL: http://codereview.chromium.org/6667043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78359 0039d316-1c4b-4281-b951-d872f2087c98
* Add ChromeOS as product name to the policy template generatorgfeher@chromium.org2011-03-163-20/+8
| | | | | | | | | | | And clean up other obsolate placeholders. BUG=none TEST=python:PolicyTemplateGenearator.* Review URL: http://codereview.chromium.org/6341007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78357 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress a memory leak in ↵timurrrr@chromium.org2011-03-161-0/+10
| | | | | | | | | | | ChildProcessHostMsg_ResolveProxy::ChildProcessHostMsg_ResolveProxy TBR=jam BUG=78225 TEST=Valgrind/unit goes greener Review URL: http://codereview.chromium.org/6672043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78349 0039d316-1c4b-4281-b951-d872f2087c98
* wstring: remove some simple uses of FromWStringHackevan@chromium.org2011-03-151-2/+1
| | | | | | | | BUG=76112 Review URL: http://codereview.chromium.org/6695008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78247 0039d316-1c4b-4281-b951-d872f2087c98
* fav icon -> favicon. Pass 6: GetFavIcon* -> GetFavicon*avi@chromium.org2011-03-151-1/+1
| | | | | | | | | BUG=76073 TEST=none; no visible change Review URL: http://codereview.chromium.org/6694027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78233 0039d316-1c4b-4281-b951-d872f2087c98
* Make OpenGL suppressions more generic for display capture test.lambroslambrou@chromium.org2011-03-151-47/+11
| | | | | | | | | BUG=75037 TEST=Mac valgrind bots stay green. Review URL: http://codereview.chromium.org/6679003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78221 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress InvalidWrites under sqlite/history::InMemoryDBtimurrrr@chromium.org2011-03-152-1/+28
| | | | | | | | | | also widen an existing mac suppression BUG=76197,75714 TEST=Valgrind/Mac is greener TBR=glider Review URL: http://codereview.chromium.org/6696021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78219 0039d316-1c4b-4281-b951-d872f2087c98
* Fix leak in HeartbeatSenderTest.DoSendStanza and remove valgrind suppression.lambroslambrou@chromium.org2011-03-152-17/+0
| | | | | | | | | BUG=74850 TEST=Valgrind bots stay green. Review URL: http://codereview.chromium.org/6624095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78205 0039d316-1c4b-4281-b951-d872f2087c98
* Don't run three more tests failing on a Valgrind assertion under Valgrind/Mactimurrrr@chromium.org2011-03-151-1/+6
| | | | | | | | | BUG=58146,51716 TBR=glider TEST=memory waterfall is greener Review URL: http://codereview.chromium.org/6696019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78199 0039d316-1c4b-4281-b951-d872f2087c98
* Don't run ErrorPageTest.DNSError_GoBack2 under TSantimurrrr@chromium.org2011-03-152-1/+2
| | | | | | | | | | Also, extend the test name regexp in the waterfall.sh script BUG=46643 TEST=TSan/UI(1) goes greener TBR=glider Review URL: http://codereview.chromium.org/6698025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78187 0039d316-1c4b-4281-b951-d872f2087c98
* Pull the latest libcros.yusukes@google.com2011-03-151-1/+1
| | | | | | | | | BUG=chromium-os:13106 TEST=try Review URL: http://codereview.chromium.org/6694016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78168 0039d316-1c4b-4281-b951-d872f2087c98
* Valgrind leak reported in NSInFlightAnimationdhollowa@chromium.org2011-03-151-10/+0
| | | | | | | | | | | | Expands suppression of a Valgrind leak in NSInFlightAnimation. BUG=75714 TEST=Mac Valgrind turns green. TBR=sail@chromium.org Review URL: http://codereview.chromium.org/6698018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78162 0039d316-1c4b-4281-b951-d872f2087c98
* Adjust expectations.cmp@chromium.org2011-03-151-7/+7
| | | | | | | | | | | | | | | | | | - mac-release-10.5/moz/times/t (false positives) - vista-release-single-core/intl1/times/t (fixed ref buid config) - vista-release-single-core/moz/times/t (fixed ref build config) - xp-release-dual-core/intl2/times/t (false positives) - xp-release-dual-core/moz/total_op_b/IO_op_b (improvement from r77288) - xp-release-single-core/dhtml/times/t (fix ref build config) - xp-release-single-core/intl1/times/t (false positives) BUG=none TEST=perf steps are green TBR=nsylvain@chromium.org Review URL: http://codereview.chromium.org/6694012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78157 0039d316-1c4b-4281-b951-d872f2087c98
* Fix memory leak in FileWriterDelegate by passing FileStream::Write a ↵adamk@chromium.org2011-03-151-10/+0
| | | | | | | | | | | | | | callback owned by the delegate. Remove the suppression of this memory leak. R=ericu@chromium.org BUG=75741 TEST=none Review URL: http://codereview.chromium.org/6685056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78148 0039d316-1c4b-4281-b951-d872f2087c98