| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
On developer's Precise machines (but not the bots!), views_unittests stopped
working abruptly. This is a case where I'm not sure how the code ever
worked. This makes various shutdown code work.
BUG=none
Review URL: https://chromiumcodereview.appspot.com/12897005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make RootWindowHostLinux aware whether it resides on internal display.
Required for ChromeOS multi monitor support.
BUG=171310
TEST=Compiles. Manually verified with printouts that is_internal_display_
has correct value when: booting,
switching single / extended desktop / mirror modes and
switching primary display.
Review URL: https://chromiumcodereview.appspot.com/12321086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186836 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Removes the aura::client::SetStackingClient(StackingClient*) interface.
- Moves the ash StackingController from a singleton owned by ash::Shell to one StackingController per RootWindow owned by the ash::RootWindowController. (Also removes a spurious delegate method, where every implementation creates the same object, including tests.)
- Removes the global DesktopStackingClient and related interfaces.
- Fix the ChromeViewsDelegate so that it still sets context in chromeos builds.
- Rename content::ShellStackingClientAsh to content::MinimalAsh to reflect what it really does.
In addition, the following fix ups apply:
- Previously, WebContentsViewAura asserted that it needed a context window. Now if no context window is provided, it isn't added to an aura hierarchy. There are times when that context doesn't exist: various chromeos dialogs that directly invoke WebView and toplevel extension/app windows that are created from background pages that don't have contexts.
- Because of that, added a few of NULL checking to RenderWidgetHostViewAura. (Other methods NULL checked Window::GetRootWindow(), but there were a few that didn't and relied on the old NULL means lookup in the StackingClient behaviour.)
BUG=161882
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177182
Review URL: https://codereview.chromium.org/11829040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178083 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Finally rip the global StackingClient bandaid off.
>
> - Removes the aura::client::SetStackingClient(StackingClient*) interface.
> - Moves the ash StackingController from a singleton owned by ash::Shell to one StackingController per RootWindow owned by the ash::RootWindowController. (Also removes a spurious delegate method, where every implementation creates the same object, including tests.)
> - Removes the global DesktopStackingClient and related interfaces.
> - Fix the ChromeViewsDelegate so that it still sets context in chromeos builds.
> - Rename content::ShellStackingClientAsh to content::MinimalAsh to reflect what it really does.
>
> In addition, the following fix ups apply:
>
> - Previously, WebContentsViewAura asserted that it needed a context window. Now if no context window is provided, it isn't added to an aura hierarchy. There are times when that context doesn't exist: various chromeos dialogs that directly invoke WebView and toplevel extension/app windows that are created from background pages that don't have contexts.
>
> BUG=161882
>
> Review URL: https://codereview.chromium.org/11829040
TBR=erg@chromium.org
Review URL: https://codereview.chromium.org/11962021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177190 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Removes the aura::client::SetStackingClient(StackingClient*) interface.
- Moves the ash StackingController from a singleton owned by ash::Shell to one StackingController per RootWindow owned by the ash::RootWindowController. (Also removes a spurious delegate method, where every implementation creates the same object, including tests.)
- Removes the global DesktopStackingClient and related interfaces.
- Fix the ChromeViewsDelegate so that it still sets context in chromeos builds.
- Rename content::ShellStackingClientAsh to content::MinimalAsh to reflect what it really does.
In addition, the following fix ups apply:
- Previously, WebContentsViewAura asserted that it needed a context window. Now if no context window is provided, it isn't added to an aura hierarchy. There are times when that context doesn't exist: various chromeos dialogs that directly invoke WebView and toplevel extension/app windows that are created from background pages that don't have contexts.
BUG=161882
Review URL: https://codereview.chromium.org/11829040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177182 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds the following APIs.
* CursorClient::DisableMouseEvents: Makes mouse events stop being sent
and hides the cursor if it is visible.
(For now, DisableMouseEvents just clears the hover state and doesn't
prevent mouse events from being generated, though).
* CursorClient::EnableMouseEvents: Makes mouse events start being sent
and shows the cursor if it was hidden with DisableMouseEvents.
* CursorClient::HideCursor: Makes the cursor invisible. This changes
only the cursor visibility and mouse events keep being sent even when
the cursor is invisible.
* CursorClient::ShowCursor: Makes the cursor visible. This does not take
effect When mouse events are disabled.
This CL just replaces the old usages of CursorClient::ShowCursor with
the new APIs to retain existing behavior.
I'll make another CL that uses these APIs in appropriate places.
BUG=153703
TEST=CursorManagerTest.EnableDisableMouseEvents, CursorManagerTest.ShowAndEnable
Review URL: https://chromiumcodereview.appspot.com/11412315
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173933 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We currently make it as far as RootWindowControllerTest.MoveWindows_Basic.
This CL:
- changes ui::EventTarget::CanAcceptEvents to be CanAcceptEvent and take an event. This allows the event type to determine whether or not it can be accepted by the target.
- copy-pasta from ActivationController to AshActivationRules (GetNextWindowToActivate())
- forwarding to target handler for generic events in EventTarget
- RootWindowControllerTest needs to handle activation events @ the target and forward to OnBlur impl.
http://crbug.com/162100
R=sadrul@chromium.org
Review URL: https://codereview.chromium.org/11445023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171583 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
host desktop type.
This is for use in those places where there's no context from which to figure out if something should be popped on the native or ash desktop.
Original approach reviewed here: https://chromiumcodereview.appspot.com/11188064/
BUG=129187
TEST=none
Review URL: https://chromiumcodereview.appspot.com/11358090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168074 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove EventFilter. ui::EventHandler should now be used instead of EventFilters.
An aura window can still have a single 'filter', which is a pre-target
EventHandler owned by the Window.
BUG=159632
Review URL: https://codereview.chromium.org/11312230
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167711 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to ash.DisplayManager/DisplayChangeObserverX11 are in aura for
historical reason, but they no longer have to be in aura.
* Remove SingleDisplayManager as it's no longer necessary.
* Rename MultipleDisplayManager and consolidate into DisplayManager.
* Remove DisplayManager from desktop environment. Screen
information is managed by platform in desktop environment, and
should be provided via gfx::Screen implementation.
- Move DisplayObserver to ui/gfx. This should be consolicated
with other similar features such as WorkAreaWatcherObserver/
DisplaySettingsProvider. It's tracked in crbug.com/122863.
- Misc cleanups
* Test should use test_support_ash instead of including
individual files.
* Use TestScreen where appropriate.
BUG=159710, 122863
TEST=none
Review URL: https://chromiumcodereview.appspot.com/11363124
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As a first step, add pre-target and post-target event handlers in aura::Env. The
EventFilters added in the CompoundEventFilter will be eventually converted to
EventHandlers, and installed on the Env as pre- or post-target handlers. The
RootWindow makes sure that the correct event-handlers from the env gets added to
the appropriate handlers list. This will let us get rid of the event-dispatching
logic in CompoundEventFilter.
BUG=none
Review URL: https://codereview.chromium.org/10960015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158037 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a sketch of a clipboard implementation for linux_aura. Right now, it can only copy/paste plain text types. Dealing with bitmaps is out of scope for this patch and the two unit tests dealing with bitmaps have temporarily been disabled on linux_aura.
Moving parts:
- This moves the current clipboard_{aurax11 => chromeos}.cc so that chromeos isn't broken between now and when I'm done. I intend to remove clipboard_chromeos once I have all the features working.
- This makes what was DispatcherLinux a part of libui.so, renamed to DispatcherAuraX11 and turned into a singleton. It has no aura dependencies, though is only used in aura code. Every usage in aura code previously grabbed the singleton instance from Env and then did an ugly static_cast<> to the other type.
- Moves X11AtomCache from aura to ui. Needs to be used in aurax11 code in ui/base/; has no X11 dependencies.
BUG=130805
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10829341
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The majority of incoming XEvents are related to specific XWindows and need to
be sent to a specific MessagePumpDispatcher. MessagePumpAuraX11 would pass the
XEvent to aura::DispatcherLinux, which would pass it to the next
dispatcher. Because of the chromeos unit tests, which spin up a new XDisplay on
each test, these two objects need to have equivalent lifetimes. Due to the
incoming clipboard support (which this patch was split off from),
DispatcherLinux can't live in aura:: anymore. The solution is to merge the two
objects that have to have equivalent lifetimes together.
The one ui:: specific check was split off into an MessagePumpObserver. This also got rid of those hacks where we would static downcast to DispatcherLinux
from MessagePumpDispatcher.
BUG=130805
Review URL: https://chromiumcodereview.appspot.com/10895020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154174 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=136057
TEST=None
Review URL: https://chromiumcodereview.appspot.com/10829180
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151705 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This moves CursorManager into ash/wm/ and makes it an implementation of a new
CursorClient interface. It's really an implementation detail of ash. Then
create a desktop version of this interface.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10692170
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
multiple root windows.
BUG=136814
TEST=1) the new ash_unittests as well as existing tests passed. 2) ran ash_shell by './out/Release/ash_shell --ash-extended-desktop --aura-host-window-size=100+0-500x500,610+0-300x300 --ash-virtual-screen-coordinates', then move the cursor to the second (right hand side) window, then click the right button. confirmed that the popup menu is shown on the right window.
Review URL: https://chromiumcodereview.appspot.com/10781028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148193 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
OOBE boot:
- Load wallpaper into wallpaper layer and wait till animation finishes
- Load OOBE WebUI
* Create host window at screen lock layer
* Show (produced short white splash if white bg is drawn in OnPaint()
* Load WebUI with transparent background
BUG=131569
TEST=Manual.
Review URL: https://chromiumcodereview.appspot.com/10796009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147624 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Enables the threaded compositor in the browser behind a flag: --ui-enabled-threaded-compositing. There are missing features (such a compositor locks for window resizing) that are not yet implemented.
BUG=135607
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10700081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rename the remaining usage of Monitor to Display
BUG=none
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=144499
Review URL: https://chromiumcodereview.appspot.com/10675011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144585 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Temporarily reverting rename change to investigate 133784
TBR=oshima@chromium.org
BUG=123160
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10689014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144573 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10675011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144499 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=130828
R=oshima@chromium.org
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10540091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141659 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Factor out CursorManager from RootWindowEventFilter
Review URL: https://chromiumcodereview.appspot.com/10444107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140714 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
adds tracking of whether any touch devices are down. I'm going to use
the later from Widget.
BUG=113279
TEST=none
R=sadrul@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10448102
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=104040
R=piman@chromium.org,ben@chromium.org
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10365007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=28581
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9923027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129867 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
using XFIXES to make launcher autohide works smoothlyl.
* Made dtor of ML::Dispatcher publiic and Eliminated aura::Dispatcher
* Refactored DispatcherLinux so that it re-dispatch event per window.
* Removed ConfineToWindow in RHWVA::LockMouse because a) it's not necessary on device (mouse is always confined to root window), b) it should
confine to the RWHVA's window but not root window, so this is not exactly right. I'll work on this in separate CL after m19.
BUG=115510
TEST=none
Review URL: http://codereview.chromium.org/9808010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
test. fixed access-after-free.""
TBR=backer@chromium.org
BUG=chromium-os:28304
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9837046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128509 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
access-after-free."
This causes a black screen on Alex when building from ToT chrome.
BUG=chromium-os:28304
TBR=oshima
TEST=can log in on Alex
Review URL: https://chromiumcodereview.appspot.com/9838060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128507 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* MonitorChangeObserverX11 that listen to Xrandr events and update monitor configurations.
* Message on secondary monitor view
* Accelerator to create/delete/cycle monitors to test multi monitor on linux desktop
* unittest for MultiMonitorManager/MonitorController
BUG=115510
TEST=multi_monitor_manager_unittests
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128330
Review URL: https://chromiumcodereview.appspot.com/9754001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128436 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
update monitor configurations."
TBR=ben@chromium.org
BUG=115510
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9839032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128346 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
configurations.
* Message on secondary monitor view
* Accelerator to create/delete/cycle monitors to test multi monitor on linux desktop
* unittest for MultiMonitorManager/MonitorController
BUG=115510
TEST=multi_monitor_manager_unittests
Review URL: https://chromiumcodereview.appspot.com/9754001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128330 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* MonitorContrler controls root window <-> monitor mapping and resize/reposition root window to match monitor configuration.
* Moved use_fullscreen_host_window to MonitorManager
* Moved compositor initialize/terminate to Env as there can be more than one root window.
BUG=115510
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9701098
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127854 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Moved SingleMonitorManager into separate file. This is a default
MonitorManager and creates RootWindow for PrimaryMonitor.
* Added MonitorObserver and moved monitor change logic to ash.
* MultiMonitorManager class and its layout logic will live in ash too.
* Added ability to move host window so that we can re-arrange root window when
switching primary monitor.
* Removed monitor_manager_x11, which I committed by accident.
* Use (0,0) for monitor/workarea bounds because the coordinate isn't translated yet
for non primary screens.
BUG=115510
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9703083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127231 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is clone of issue 9689027, which I can't access due to some internal error.
BUG=115510
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9699013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126685 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Needed to remove a use of RootWindow::GetInstance().
http://crbug.com/112131
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9478007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123805 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
It can't live on the RootWindow since there's no way to locate a relevant RootWindow when it is called.
http://crbug.com/112131
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9464048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123773 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Like DispatcherWin, DispatcherLinux is owned by the Env singleton.
http://crbug.com/112131
TEST=compiles, tests pass
Review URL: https://chromiumcodereview.appspot.com/9447048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123597 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, you would ask the RootWindow (a singleton) for its dispatcher, which was conveniently the RootWindowHost. Now that we are moving towards many RootWindows, you must ask the new singleton, aura::Env, instead.
This CL also implements a dispatcher for windows. It does not implement the Linux one since that's much larger and I'll do that in a followon CL. I just wanted to change the API. Note there is some transitional ugliness.
http://crbug.com/112131
TEST=existing
Review URL: https://chromiumcodereview.appspot.com/9433072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123268 0039d316-1c4b-4281-b951-d872f2087c98
|
|
observer of a new global singleton "Env". This will allow us to support multiple RootWindows.
http://crbug.com/112131
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9310071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120349 0039d316-1c4b-4281-b951-d872f2087c98
|