summaryrefslogtreecommitdiffstats
path: root/ui/aura
Commit message (Collapse)AuthorAgeFilesLines
* aura: Remove WindowTreeHost::PostNativeEvent().Sadrul Habib Chowdhury2014-11-0717-70/+96
| | | | | | | | | | | | | | | | | WindowTreeHost::PostNativeEvent() is only used in tests. So remove this from the public API. Instead: . For Win32, directly use PostMessage (this is used in only two places). . For Ozone, use EventSourceTestApi to inject the event (this is equivalent to current code, in terms of not doing the right thing when menus are open). . For X11, introduce aura::test::PostEventToWindowTreeHost() instead, and use it in tests. BUG=none R=sky@chromium.org Review URL: https://codereview.chromium.org/710553002 Cr-Commit-Position: refs/heads/master@{#303315}
* Create a subclass of GestureRecognizerTest to setup a switchlanwei2014-11-071-4/+17
| | | | | | | | | | | | | In gesture_recognizer_unittest.cc, we are adding a subclass of GestureRecognizerTest to setup kCompensateForUnstablePinchZoom switch for some particular unit tests, so that the switch will not affect other unit tests which do not require the switch on. BUG=430977 Review URL: https://codereview.chromium.org/702553007 Cr-Commit-Position: refs/heads/master@{#303197}
* GN: Get os="chromeos" use_ozone=true to compiledpranke2014-11-051-5/+9
| | | | | | | | | | | | | | There were a number of ozone targets that had rusted or never been implemented in the GN build for Chrome OS. Fix it! R=cmasone TBR=brettw BUG=424334 TEST=build chrome with os=chromeos use_ozone=true use_clang=true Review URL: https://codereview.chromium.org/705623004 Cr-Commit-Position: refs/heads/master@{#302752}
* Move all event related devices from ui/events/ to ui/events/devices/dnicoara2014-11-041-3/+3
| | | | | | | | BUG=none Review URL: https://codereview.chromium.org/685793002 Cr-Commit-Position: refs/heads/master@{#302647}
* Add input latency histograms for wheel eventsccameron2014-11-031-2/+2
| | | | | | | | | | | | | | | This works for touch events, but not for wheel events. Use the existing touch latency machinery to enable logging of wheel events. Update ComputeInputLatencyHistograms to report latency of INPUT_EVENT_LATENCY_ACK_RWH_COMPONENT in the absence of a INPUT_EVENT_LATENCY_UI_COMPONENT, as it is still valid. BUG=224781 Review URL: https://codereview.chromium.org/681763003 Cr-Commit-Position: refs/heads/master@{#302518}
* Prevent flings in the direction opposite the user's finger movement.tdresser2014-10-281-1/+1
| | | | | | | | | | | | | This previously could occur, as we use a quadratic regression to estimate finger velocity. Rapid deceleration would result in a fling in the wrong direction. BUG=417855 TEST=VelocityTrackerTest.NoDirectionReversal Review URL: https://codereview.chromium.org/610583002 Cr-Commit-Position: refs/heads/master@{#301648}
* Update a bunch of OWNERS files.ben2014-10-281-1/+0
| | | | | | | | | | | Remove v2. R=sky@chromium.org BUG= Review URL: https://codereview.chromium.org/682713003 Cr-Commit-Position: refs/heads/master@{#301493}
* Standardize usage of virtual/override/final specifiers.dcheng2014-10-2724-415/+351
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The Google C++ style guide states: Explicitly annotate overrides of virtual functions or virtual destructors with an override or (less frequently) final specifier. Older (pre-C++11) code will use the virtual keyword as an inferior alternative annotation. For clarity, use exactly one of override, final, or virtual when declaring an override. To better conform to these guidelines, the following constructs have been rewritten: - if a base class has a virtual destructor, then: virtual ~Foo(); -> ~Foo() override; - virtual void Foo() override; -> void Foo() override; - virtual void Foo() override final; -> void Foo() final; This patch was automatically generated. The clang plugin can generate fixit hints, which are suggested edits when it is 100% sure it knows how to fix a problem. The hints from the clang plugin were applied to the source tree using the tool in https://codereview.chromium.org/598073004. BUG=417463 R=thakis@chromium.org Review URL: https://codereview.chromium.org/684483002 Cr-Commit-Position: refs/heads/master@{#301440}
* Adopt ui::GestureConfiguration on Androidlanwei2014-10-274-47/+50
| | | | | | | | | | | | Making GestureConfiguration as an interface to serve all the platforms, so that Aura and Android push to and pull from the same data source, GestureConfiguration, where gesture configuring parameters are. BUG=339203 Review URL: https://codereview.chromium.org/613373004 Cr-Commit-Position: refs/heads/master@{#301393}
* Remove IsDIPEnabled from Screenscottmg2014-10-232-5/+0
| | | | | | | | | | | | Appears to be unused. TBR=ben@chromium.org R=sky@chromium.org BUG=143619 Review URL: https://codereview.chromium.org/672823002 Cr-Commit-Position: refs/heads/master@{#300906}
* Fixing a "use after free".mfomitchev2014-10-212-1/+24
| | | | | | | | BUG=NONE Review URL: https://codereview.chromium.org/651323002 Cr-Commit-Position: refs/heads/master@{#300565}
* aura: Move Window::ContainsMouse() implementation into the test API.Sadrul Habib Chowdhury2014-10-213-14/+8
| | | | | | | | | BUG=none R=sky@chromium.org Review URL: https://codereview.chromium.org/602043006 Cr-Commit-Position: refs/heads/master@{#300540}
* Standardize usage of virtual/override/final in ui/dcheng2014-10-211-12/+11
| | | | | | | | | | | | This patch was automatically generated by applying clang fixit hints generated by the plugin to the source tree. BUG=417463 TBR=sky@chromium.org Review URL: https://codereview.chromium.org/667923002 Cr-Commit-Position: refs/heads/master@{#300446}
* Allows to fire VKEY_UNKNOWN key events.yukishiino2014-10-212-7/+3
| | | | | | | | | | | | | On Linux, we have keys with keycode=VKEY_UNKNOWN, for example, ISO_LEVEL3_LATCH key. We have to emit keydown/up events appropriately even if keycode=VKEY_UNKNOWN. Just FYI: Firefox also fires keyevents with keycode=0, so the behavior will be compatible. Compared to IE and Chrome on Windows, it's still compatible because there is no such key as ISO_LEVEL3_LATCH, etc. on Windows. BUG=402320 TEST=Done manually. Review URL: https://codereview.chromium.org/665863002 Cr-Commit-Position: refs/heads/master@{#300438}
* Convert ARRAYSIZE_UNSAFE -> arraysize in ui/.viettrungluu2014-10-161-1/+1
| | | | | | | | | R=sky@chromium.org BUG=423134 Review URL: https://codereview.chromium.org/656213002 Cr-Commit-Position: refs/heads/master@{#299901}
* Use solid color layer for delegated surface.jbauman2014-10-131-2/+2
| | | | | | | | | | With delegated frames, we either want to display the frame itself or a single color (white). Default the layer for delegated frames to be solid color, and allow the layer to be switched from delegated to solid color when the delegated contents go away. BUG=420832 Review URL: https://codereview.chromium.org/634113002 Cr-Commit-Position: refs/heads/master@{#299353}
* Change GestureConfiguration types to be consistent with each other and with thepkasting2014-10-093-39/+41
| | | | | | | | | | | | | | | | | | types in GestureDetector::Config and other usage points. Basically: * Times should always be ints representing milliseconds * Distances and velocities should always be floats This eliminates a number of implicit type conversions, some of which trigger a (currently disabled) MSVC warning due to possible value truncation. BUG=81439 TEST=none Review URL: https://codereview.chromium.org/630003003 Cr-Commit-Position: refs/heads/master@{#299007}
* Avoid ALLOW_UNUSED (and the like) where it's not necessary or there are betterpkasting2014-10-091-2/+3
| | | | | | | | | | | alternatives. BUG=none TEST=none Review URL: https://codereview.chromium.org/634683004 Cr-Commit-Position: refs/heads/master@{#298947}
* replace OVERRIDE and FINAL with override and final in ui/mostynb2014-10-0930-346/+346
| | | | | | | | BUG=417463 Review URL: https://codereview.chromium.org/623293004 Cr-Commit-Position: refs/heads/master@{#298839}
* Call WindowObserver::OnWindowVisbilityChanged only once per visibility change.oshima2014-10-082-2/+20
| | | | | | | | | BUG=Nonoe TEST=covered by test. Review URL: https://codereview.chromium.org/631333002 Cr-Commit-Position: refs/heads/master@{#298630}
* Reland: Make WindowState::CanMinimize() take into account ↵pkotwicz2014-10-052-0/+4
| | | | | | | | | | | | | | | | | | | WidgetDelegate::CanMinimize() This has the side effect of disallowing minimizing bubbles (e.g. the bookmark bubble) via a gesture BUG=328241 TEST=Manual, see bug R=oshima TBR=sky Committed: https://crrev.com/54e8fe5b00b8d218a0ebe22e5d09386cc28a6151 Cr-Commit-Position: refs/heads/master@{#298108} Review URL: https://codereview.chromium.org/625653002 Cr-Commit-Position: refs/heads/master@{#298187}
* Revert of Reland: Make WindowState::CanMinimize() take into account ↵rouslan2014-10-042-4/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | WidgetDelegate::CanMinimize() (patchset #3 id:40001 of https://codereview.chromium.org/625653002/) Reason for revert: Broke LoginWebDialogTest.CannotMinimize browser_tests on "Linux ChromiumOS Tests (dbg)(1)." Builder: https://build.chromium.org/p/chromium.chromiumos/waterfall?show=Linux%20ChromiumOS%20Tests%20(dbg)(1) First failure: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/32252 Failing test output: LoginWebDialogTest.CannotMinimize (run #1): [ RUN ] LoginWebDialogTest.CannotMinimize [1:1:1003/163823:ERROR:memory_mapped_file.cc(41)] Couldn't open /tmp/run_tha_testu_emfn/out/Debug/chrome_200_percent.pak [1:1:1003/163823:ERROR:data_pack.cc(78)] Failed to mmap datapack [19747:19747:1003/163823:WARNING:chrome_browser_main_chromeos.cc(265)] Running as stub user with profile dir: test-user [19747:19747:1003/163823:ERROR:memory_mapped_file.cc(41)] Couldn't open /tmp/run_tha_testu_emfn/out/Debug/chrome_200_percent.pak [19747:19747:1003/163823:ERROR:data_pack.cc(78)] Failed to mmap datapack [19747:19747:1003/163823:ERROR:logging_chrome.cc(170)] Unable to create symlink /tmp/.org.chromium.Chromium.r5oT7x/dktKdBJ/test-user/chrome_debug.log pointing at /tmp/.org.chromium.Chromium.r5oT7x/dktKdBJ/test-user/chrome_debug_20141003-163823.log: No such file or directory Xlib: extension "RANDR" missing on display ":9". [19747:19747:1003/163823:WARNING:data_reduction_proxy_settings.cc(331)] SPDY proxy OFF at startup [19747:19781:1003/163823:ERROR:owner_key_util_impl.cc(27)] Could not get size of /tmp/.org.chromium.Chromium.r5oT7x/dktKdBJ/stub_owner.key [19747:19781:1003/163823:WARNING:local_extension_cache.cc(199)] Extensions will not be installed from update URLs until /var/cache/external_cache/.initialized exists. [19747:19747:1003/163824:WARNING:freezer_cgroup_process_manager.cc(26)] Cgroup freezer does not exist or is not writable. Unable to freeze renderer processes. [19791:19791:1003/233824:ERROR:vaapi_wrapper.cc(207)] Failed to initialize VAAPI libs [19747:19747:1003/163825:WARNING:channel.cc(177)] WriteMessage() while shutting down [19747:19787:1003/163825:WARNING:message_in_transit_queue.cc(18)] Destroying nonempty message queue [19747:19787:1003/163825:WARNING:file_descriptor_set_posix.cc(30)] FileDescriptorSet destroyed with unconsumed descriptors: 0/1 [19747:19747:1003/163825:WARNING:channel.cc(177)] WriteMessage() while shutting down [19747:19787:1003/163825:WARNING:message_in_transit_queue.cc(18)] Destroying nonempty message queue [19747:19747:1003/163825:FATAL:login_web_dialog.cc(146)] Check failed: false. #0 0x7f9d1622d3de base::debug::StackTrace::StackTrace() #1 0x7f9d162bffd2 logging::LogMessage::~LogMessage() #2 0x0000026163fd chromeos::LoginWebDialog::OnCloseContents() #3 0x7f9d1df3eb00 views::WebDialogView::OnCloseContents() #4 0x7f9d1df3ee55 views::WebDialogView::CloseContents() #5 0x7f9d1df3eeef views::WebDialogView::CloseContents() #6 0x7f9d1efd4a28 content::WebContentsImpl::Close() #7 0x7f9d1efd4a5f content::WebContentsImpl::Close() #8 0x7f9d1ed62c9a content::RenderViewHostImpl::ClosePageIgnoringUnloadEvents() #9 0x7f9d1ed62c41 content::RenderViewHostImpl::ClosePage() #10 0x7f9d1e9509a7 content::RenderFrameHostManager::OnBeforeUnloadACK() #11 0x7f9d1e933fdb content::RenderFrameHostImpl::OnBeforeUnloadACK() #12 0x7f9d1e937bfa content::RenderFrameHostImpl::DispatchBeforeUnload() #13 0x7f9d1efc908f content::WebContentsImpl::DispatchBeforeUnload() #14 0x7f9d1df3df74 views::WebDialogView::CanClose() #15 0x7f9d21e0dac0 views::NonClientView::CanClose() #16 0x7f9d21df265f views::Widget::Close() #17 0x7f9d1df3e959 views::WebDialogView::OnDialogClosed() #18 0x7f9d1df3e1f2 views::WebDialogView::WindowClosing() #19 0x7f9d1df3e22c views::WebDialogView::WindowClosing() #20 0x7f9d21df4571 views::Widget::OnNativeWidgetDestroying() #21 0x7f9d21de950c views::NativeWidgetAura::OnWindowDestroying() #22 0x7f9d21de955f views::NativeWidgetAura::OnWindowDestroying() #23 0x7f9d13a9fc07 aura::Window::~Window() #24 0x7f9d13aa0679 aura::Window::~Window() #25 0x7f9d158566c8 ash::RootWindowController::CloseChildWindows() #26 0x7f9d157c013d ash::DisplayController::CloseChildWindows() #27 0x7f9d158a921b ash::Shell::~Shell() #28 0x7f9d158a9ee9 ash::Shell::~Shell() #29 0x7f9d158a57ef ash::Shell::DeleteInstance() #30 0x000002db0a7b chrome::CloseAsh() #31 0x000002a0ff31 ChromeBrowserMainExtraPartsAsh::PostMainMessageLoopRun() #32 0x000004aa0ff8 ChromeBrowserMainParts::PostMainMessageLoopRun() #33 0x00000245e645 chromeos::ChromeBrowserMainPartsChromeos::PostMainMessageLoopRun() #34 0x7f9d1e733929 content::BrowserMainLoop::ShutdownThreadsAndCleanUp() #35 0x7f9d1e73c739 content::BrowserMainRunnerImpl::Shutdown() #36 0x7f9d1e72ddd8 content::BrowserMain() #37 0x7f9d1e5c536f content::RunNamedProcessTypeMain() #38 0x7f9d1e5c8458 content::ContentMainRunnerImpl::Run() #39 0x7f9d1e5c4915 content::ContentMain() #40 0x00000480705b content::BrowserTestBase::SetUp() #41 0x000002198e3b InProcessBrowserTest::SetUp() #42 0x0000006f6cf3 _ZN7testing8internal12InvokeHelperIvNSt3tr15tupleIJEEEE12InvokeMethodIN10extensions42BluetoothPrivateApiTest_CancelPairing_TestEMNS7_23BluetoothPrivateApiTestEFvvEEEvPT_T0_RKS4_ #43 0x000002385ffe testing::internal::HandleExceptionsInMethodIfSupported\u003C>() #44 0x00000237b103 testing::Test::Run() #45 0x00000237b84b testing::TestInfo::Run() #46 0x00000237be3a testing::TestCase::Run() #47 0x000002381333 testing::internal::UnitTestImpl::RunAllTests() #48 0x00000238e5c3 testing::internal::HandleSehExceptionsInMethodIfSupported\u003C>() #49 0x00000238774e testing::internal::HandleExceptionsInMethodIfSupported\u003C>() #50 0x000002380fd1 testing::UnitTest::Run() #51 0x00000223cfe1 RUN_ALL_TESTS() #52 0x00000223bfb7 base::TestSuite::Run() #53 0x000001376532 ChromeBrowserTestSuiteRunner::RunTestSuite() #54 0x000002197128 (anonymous namespace)::ChromeTestLauncherDelegate::RunTestSuite() #55 0x00000485373e content::LaunchTests() #56 0x000002197059 LaunchChromeTests() #57 0x00000137648e main #58 0x7f9d0e8ae76d __libc_start_main #59 0x000000668105 \u003Cunknown> LoginWebDialogTest.CannotMinimize (run #2): [ RUN ] LoginWebDialogTest.CannotMinimize [1:1:1003/164204:ERROR:memory_mapped_file.cc(41)] Couldn't open /tmp/run_tha_testu_emfn/out/Debug/chrome_200_percent.pak [1:1:1003/164204:ERROR:data_pack.cc(78)] Failed to mmap datapack [31329:31329:1003/164205:WARNING:chrome_browser_main_chromeos.cc(265)] Running as stub user with profile dir: test-user [31329:31329:1003/164205:ERROR:memory_mapped_file.cc(41)] Couldn't open /tmp/run_tha_testu_emfn/out/Debug/chrome_200_percent.pak [31329:31329:1003/164205:ERROR:data_pack.cc(78)] Failed to mmap datapack [31329:31329:1003/164205:ERROR:logging_chrome.cc(170)] Unable to create symlink /tmp/.org.chromium.Chromium.r5oT7x/drKJeND/test-user/chrome_debug.log pointing at /tmp/.org.chromium.Chromium.r5oT7x/drKJeND/test-user/chrome_debug_20141003-164205.log: No such file or directory Xlib: extension "RANDR" missing on display ":9". [31329:31329:1003/164205:WARNING:data_reduction_proxy_settings.cc(331)] SPDY proxy OFF at startup [31329:31361:1003/164205:ERROR:owner_key_util_impl.cc(27)] Could not get size of /tmp/.org.chromium.Chromium.r5oT7x/drKJeND/stub_owner.key [31329:31346:1003/164205:WARNING:local_extension_cache.cc(199)] Extensions will not be installed from update URLs until /var/cache/external_cache/.initialized exists. [31329:31329:1003/164205:WARNING:freezer_cgroup_process_manager.cc(26)] Cgroup freezer does not exist or is not writable. Unable to freeze renderer processes. [31356:31356:1003/234205:ERROR:vaapi_wrapper.cc(207)] Failed to initialize VAAPI libs [31329:31329:1003/164206:WARNING:channel.cc(177)] WriteMessage() while shutting down [31329:31352:1003/164206:WARNING:message_in_transit_queue.cc(18)] Destroying nonempty message queue [31329:31352:1003/164206:WARNING:file_descriptor_set_posix.cc(30)] FileDescriptorSet destroyed with unconsumed descriptors: 0/1 [31329:31329:1003/164206:WARNING:channel.cc(177)] WriteMessage() while shutting down [31329:31352:1003/164206:WARNING:message_in_transit_queue.cc(18)] Destroying nonempty message queue [31329:31329:1003/164206:FATAL:login_web_dialog.cc(146)] Check failed: false. #0 0x7f6bcf46b3de base::debug::StackTrace::StackTrace() #1 0x7f6bcf4fdfd2 logging::LogMessage::~LogMessage() #2 0x0000026163fd chromeos::LoginWebDialog::OnCloseContents() #3 0x7f6bd717cb00 views::WebDialogView::OnCloseContents() #4 0x7f6bd717ce55 views::WebDialogView::CloseContents() #5 0x7f6bd717ceef views::WebDialogView::CloseContents() #6 0x7f6bd8212a28 content::WebContentsImpl::Close() #7 0x7f6bd8212a5f content::WebContentsImpl::Close() #8 0x7f6bd7fa0c9a content::RenderViewHostImpl::ClosePageIgnoringUnloadEvents() #9 0x7f6bd7fa0c41 content::RenderViewHostImpl::ClosePage() #10 0x7f6bd7b8e9a7 content::RenderFrameHostManager::OnBeforeUnloadACK() #11 0x7f6bd7b71fdb content::RenderFrameHostImpl::OnBeforeUnloadACK() #12 0x7f6bd7b75bfa content::RenderFrameHostImpl::DispatchBeforeUnload() #13 0x7f6bd820708f content::WebContentsImpl::DispatchBeforeUnload() #14 0x7f6bd717bf74 views::WebDialogView::CanClose() #15 0x7f6bdb04bac0 views::NonClientView::CanClose() #16 0x7f6bdb03065f views::Widget::Close() #17 0x7f6bd717c959 views::WebDialogView::OnDialogClosed() #18 0x7f6bd717c1f2 views::WebDialogView::WindowClosing() #19 0x7f6bd717c22c views::WebDialogView::WindowClosing() #20 0x7f6bdb032571 views::Widget::OnNativeWidgetDestroying() #21 0x7f6bdb02750c views::NativeWidgetAura::OnWindowDestroying() #22 0x7f6bdb02755f views::NativeWidgetAura::OnWindowDestroying() #23 0x7f6bcccddc07 aura::Window::~Window() #24 0x7f6bcccde679 aura::Window::~Window() #25 0x7f6bcea946c8 ash::RootWindowController::CloseChildWindows() #26 0x7f6bce9fe13d ash::DisplayController::CloseChildWindows() #27 0x7f6bceae721b ash::Shell::~Shell() #28 0x7f6bceae7ee9 ash::Shell::~Shell() #29 0x7f6bceae37ef ash::Shell::DeleteInstance() #30 0x000002db0a7b chrome::CloseAsh() #31 0x000002a0ff31 ChromeBrowserMainExtraPartsAsh::PostMainMessageLoopRun() #32 0x000004aa0ff8 ChromeBrowserMainParts::PostMainMessageLoopRun() #33 0x00000245e645 chromeos::ChromeBrowserMainPartsChromeos::PostMainMessageLoopRun() #34 0x7f6bd7971929 content::BrowserMainLoop::ShutdownThreadsAndCleanUp() #35 0x7f6bd797a739 content::BrowserMainRunnerImpl::Shutdown() #36 0x7f6bd796bdd8 content::BrowserMain() #37 0x7f6bd780336f content::RunNamedProcessTypeMain() #38 0x7f6bd7806458 content::ContentMainRunnerImpl::Run() #39 0x7f6bd7802915 content::ContentMain() #40 0x00000480705b content::BrowserTestBase::SetUp() #41 0x000002198e3b InProcessBrowserTest::SetUp() #42 0x0000006f6cf3 _ZN7testing8internal12InvokeHelperIvNSt3tr15tupleIJEEEE12InvokeMethodIN10extensions42BluetoothPrivateApiTest_CancelPairing_TestEMNS7_23BluetoothPrivateApiTestEFvvEEEvPT_T0_RKS4_ #43 0x000002385ffe testing::internal::HandleExceptionsInMethodIfSupported\u003C>() #44 0x00000237b103 testing::Test::Run() #45 0x00000237b84b testing::TestInfo::Run() #46 0x00000237be3a testing::TestCase::Run() #47 0x000002381333 testing::internal::UnitTestImpl::RunAllTests() #48 0x00000238e5c3 testing::internal::HandleSehExceptionsInMethodIfSupported\u003C>() #49 0x00000238774e testing::internal::HandleExceptionsInMethodIfSupported\u003C>() #50 0x000002380fd1 testing::UnitTest::Run() #51 0x00000223cfe1 RUN_ALL_TESTS() #52 0x00000223bfb7 base::TestSuite::Run() #53 0x000001376532 ChromeBrowserTestSuiteRunner::RunTestSuite() #54 0x000002197128 (anonymous namespace)::ChromeTestLauncherDelegate::RunTestSuite() #55 0x00000485373e content::LaunchTests() #56 0x000002197059 LaunchChromeTests() #57 0x00000137648e main #58 0x7f6bc7aec76d __libc_start_main #59 0x000000668105 \u003Cunknown> LoginWebDialogTest.CannotMinimize (run #3): [ RUN ] LoginWebDialogTest.CannotMinimize [1:1:1003/164207:ERROR:memory_mapped_file.cc(41)] Couldn't open /tmp/run_tha_testu_emfn/out/Debug/chrome_200_percent.pak [1:1:1003/164207:ERROR:data_pack.cc(78)] Failed to mmap datapack [31389:31389:1003/164208:WARNING:chrome_browser_main_chromeos.cc(265)] Running as stub user with profile dir: test-user [31389:31389:1003/164208:ERROR:memory_mapped_file.cc(41)] Couldn't open /tmp/run_tha_testu_emfn/out/Debug/chrome_200_percent.pak [31389:31389:1003/164208:ERROR:data_pack.cc(78)] Failed to mmap datapack [31389:31389:1003/164208:ERROR:logging_chrome.cc(170)] Unable to create symlink /tmp/.org.chromium.Chromium.r5oT7x/dlJ4c6O/test-user/chrome_debug.log pointing at /tmp/.org.chromium.Chromium.r5oT7x/dlJ4c6O/test-user/chrome_debug_20141003-164208.log: No such file or directory Xlib: extension "RANDR" missing on display ":9". [31389:31389:1003/164208:WARNING:data_reduction_proxy_settings.cc(331)] SPDY proxy OFF at startup [31389:31406:1003/164208:ERROR:owner_key_util_impl.cc(27)] Could not get size of /tmp/.org.chromium.Chromium.r5oT7x/dlJ4c6O/stub_owner.key [31389:31421:1003/164208:WARNING:local_extension_cache.cc(199)] Extensions will not be installed from update URLs until /var/cache/external_cache/.initialized exists. [31389:31389:1003/164208:WARNING:freezer_cgroup_process_manager.cc(26)] Cgroup freezer does not exist or is not writable. Unable to freeze renderer processes. [31416:31416:1003/234208:ERROR:vaapi_wrapper.cc(207)] Failed to initialize VAAPI libs [31389:31389:1003/164209:WARNING:channel.cc(177)] WriteMessage() while shutting down [31389:31412:1003/164209:WARNING:message_in_transit_queue.cc(18)] Destroying nonempty message queue [31389:31412:1003/164209:WARNING:file_descriptor_set_posix.cc(30)] FileDescriptorSet destroyed with unconsumed descriptors: 0/1 [31389:31389:1003/164209:WARNING:channel.cc(177)] WriteMessage() while shutting down [31389:31412:1003/164209:WARNING:message_in_transit_queue.cc(18)] Destroying nonempty message queue [31389:31389:1003/164209:FATAL:login_web_dialog.cc(146)] Check failed: false. #0 0x7f4c57aef3de base::debug::StackTrace::StackTrace() #1 0x7f4c57b81fd2 logging::LogMessage::~LogMessage() #2 0x0000026163fd chromeos::LoginWebDialog::OnCloseContents() #3 0x7f4c5f800b00 views::WebDialogView::OnCloseContents() #4 0x7f4c5f800e55 views::WebDialogView::CloseContents() #5 0x7f4c5f800eef views::WebDialogView::CloseContents() #6 0x7f4c60896a28 content::WebContentsImpl::Close() #7 0x7f4c60896a5f content::WebContentsImpl::Close() #8 0x7f4c60624c9a content::RenderViewHostImpl::ClosePageIgnoringUnloadEvents() #9 0x7f4c60624c41 content::RenderViewHostImpl::ClosePage() #10 0x7f4c602129a7 content::RenderFrameHostManager::OnBeforeUnloadACK() #11 0x7f4c601f5fdb content::RenderFrameHostImpl::OnBeforeUnloadACK() #12 0x7f4c601f9bfa content::RenderFrameHostImpl::DispatchBeforeUnload() #13 0x7f4c6088b08f content::WebContentsImpl::DispatchBeforeUnload() #14 0x7f4c5f7fff74 views::WebDialogView::CanClose() #15 0x7f4c636cfac0 views::NonClientView::CanClose() #16 0x7f4c636b465f views::Widget::Close() #17 0x7f4c5f800959 views::WebDialogView::OnDialogClosed() #18 0x7f4c5f8001f2 views::WebDialogView::WindowClosing() #19 0x7f4c5f80022c views::WebDialogView::WindowClosing() #20 0x7f4c636b6571 views::Widget::OnNativeWidgetDestroying() #21 0x7f4c636ab50c views::NativeWidgetAura::OnWindowDestroying() #22 0x7f4c636ab55f views::NativeWidgetAura::OnWindowDestroying() #23 0x7f4c55361c07 aura::Window::~Window() #24 0x7f4c55362679 aura::Window::~Window() #25 0x7f4c571186c8 ash::RootWindowController::CloseChildWindows() #26 0x7f4c5708213d ash::DisplayController::CloseChildWindows() #27 0x7f4c5716b21b ash::Shell::~Shell() #28 0x7f4c5716bee9 ash::Shell::~Shell() #29 0x7f4c571677ef ash::Shell::DeleteInstance() #30 0x000002db0a7b chrome::CloseAsh() #31 0x000002a0ff31 ChromeBrowserMainExtraPartsAsh::PostMainMessageLoopRun() #32 0x000004aa0ff8 ChromeBrowserMainParts::PostMainMessageLoopRun() #33 0x00000245e645 chromeos::ChromeBrowserMainPartsChromeos::PostMainMessageLoopRun() #34 0x7f4c5fff5929 content::BrowserMainLoop::ShutdownThreadsAndCleanUp() #35 0x7f4c5fffe739 content::BrowserMainRunnerImpl::Shutdown() #36 0x7f4c5ffefdd8 content::BrowserMain() #37 0x7f4c5fe8736f content::RunNamedProcessTypeMain() #38 0x7f4c5fe8a458 content::ContentMainRunnerImpl::Run() #39 0x7f4c5fe86915 content::ContentMain() #40 0x00000480705b content::BrowserTestBase::SetUp() #41 0x000002198e3b InProcessBrowserTest::SetUp() #42 0x0000006f6cf3 _ZN7testing8internal12InvokeHelperIvNSt3tr15tupleIJEEEE12InvokeMethodIN10extensions42BluetoothPrivateApiTest_CancelPairing_TestEMNS7_23BluetoothPrivateApiTestEFvvEEEvPT_T0_RKS4_ #43 0x000002385ffe testing::internal::HandleExceptionsInMethodIfSupported\u003C>() #44 0x00000237b103 testing::Test::Run() #45 0x00000237b84b testing::TestInfo::Run() #46 0x00000237be3a testing::TestCase::Run() #47 0x000002381333 testing::internal::UnitTestImpl::RunAllTests() #48 0x00000238e5c3 testing::internal::HandleSehExceptionsInMethodIfSupported\u003C>() #49 0x00000238774e testing::internal::HandleExceptionsInMethodIfSupported\u003C>() #50 0x000002380fd1 testing::UnitTest::Run() #51 0x00000223cfe1 RUN_ALL_TESTS() #52 0x00000223bfb7 base::TestSuite::Run() #53 0x000001376532 ChromeBrowserTestSuiteRunner::RunTestSuite() #54 0x000002197128 (anonymous namespace)::ChromeTestLauncherDelegate::RunTestSuite() #55 0x00000485373e content::LaunchTests() #56 0x000002197059 LaunchChromeTests() #57 0x00000137648e main #58 0x7f4c5017076d __libc_start_main #59 0x000000668105 \u003Cunknown> LoginWebDialogTest.CannotMinimize (run #4): [ RUN ] LoginWebDialogTest.CannotMinimize [1:1:1003/164210:ERROR:memory_mapped_file.cc(41)] Couldn't open /tmp/run_tha_testu_emfn/out/Debug/chrome_200_percent.pak [1:1:1003/164210:ERROR:data_pack.cc(78)] Failed to mmap datapack [31449:31449:1003/164211:WARNING:chrome_browser_main_chromeos.cc(265)] Running as stub user with profile dir: test-user [31449:31449:1003/164211:ERROR:memory_mapped_file.cc(41)] Couldn't open /tmp/run_tha_testu_emfn/out/Debug/chrome_200_percent.pak [31449:31449:1003/164211:ERROR:data_pack.cc(78)] Failed to mmap datapack [31449:31449:1003/164211:ERROR:logging_chrome.cc(170)] Unable to create symlink /tmp/.org.chromium.Chromium.r5oT7x/dwzfYTg/test-user/chrome_debug.log pointing at /tmp/.org.chromium.Chromium.r5oT7x/dwzfYTg/test-user/chrome_debug_20141003-164211.log: No such file or directory Xlib: extension "RANDR" missing on display ":9". [31449:31449:1003/164211:WARNING:data_reduction_proxy_settings.cc(331)] SPDY proxy OFF at startup [31449:31481:1003/164211:ERROR:owner_key_util_impl.cc(27)] Could not get size of /tmp/.org.chromium.Chromium.r5oT7x/dwzfYTg/stub_owner.key [31449:31466:1003/164211:WARNING:local_extension_cache.cc(199)] Extensions will not be installed from update URLs until /var/cache/external_cache/.initialized exists. [31449:31449:1003/164211:WARNING:freezer_cgroup_process_manager.cc(26)] Cgroup freezer does not exist or is not writable. Unable to freeze renderer processes. [31476:31476:1003/234211:ERROR:vaapi_wrapper.cc(207)] Failed to initialize VAAPI libs [31449:31449:1003/164212:WARNING:channel.cc(177)] WriteMessage() while shutting down [31449:31472:1003/164212:WARNING:message_in_transit_queue.cc(18)] Destroying nonempty message queue [31449:31472:1003/164212:WARNING:file_descriptor_set_posix.cc(30)] FileDescriptorSet destroyed with unconsumed descriptors: 0/1 [31449:31449:1003/164212:WARNING:channel.cc(177)] WriteMessage() while shutting down [31449:31472:1003/164212:WARNING:message_in_transit_queue.cc(18)] Destroying nonempty message queue [31449:31449:1003/164212:FATAL:login_web_dialog.cc(146)] Check failed: false. #0 0x7fded5d263de base::debug::StackTrace::StackTrace() #1 0x7fded5db8fd2 logging::LogMessage::~LogMessage() #2 0x0000026163fd chromeos::LoginWebDialog::OnCloseContents() #3 0x7fdedda37b00 views::WebDialogView::OnCloseContents() #4 0x7fdedda37e55 views::WebDialogView::CloseContents() #5 0x7fdedda37eef views::WebDialogView::CloseContents() #6 0x7fdedeacda28 content::WebContentsImpl::Close() #7 0x7fdedeacda5f content::WebContentsImpl::Close() #8 0x7fdede85bc9a content::RenderViewHostImpl::ClosePageIgnoringUnloadEvents() #9 0x7fdede85bc41 content::RenderViewHostImpl::ClosePage() #10 0x7fdede4499a7 content::RenderFrameHostManager::OnBeforeUnloadACK() #11 0x7fdede42cfdb content::RenderFrameHostImpl::OnBeforeUnloadACK() #12 0x7fdede430bfa content::RenderFrameHostImpl::DispatchBeforeUnload() #13 0x7fdedeac208f content::WebContentsImpl::DispatchBeforeUnload() #14 0x7fdedda36f74 views::WebDialogView::CanClose() #15 0x7fdee1906ac0 views::NonClientView::CanClose() #16 0x7fdee18eb65f views::Widget::Close() #17 0x7fdedda37959 views::WebDialogView::OnDialogClosed() #18 0x7fdedda371f2 views::WebDialogView::WindowClosing() #19 0x7fdedda3722c views::WebDialogView::WindowClosing() #20 0x7fdee18ed571 views::Widget::OnNativeWidgetDestroying() #21 0x7fdee18e250c views::NativeWidgetAura::OnWindowDestroying() #22 0x7fdee18e255f views::NativeWidgetAura::OnWindowDestroying() #23 0x7fded3598c07 aura::Window::~Window() #24 0x7fded3599679 aura::Window::~Window() #25 0x7fded534f6c8 ash::RootWindowController::CloseChildWindows() #26 0x7fded52b913d ash::DisplayController::CloseChildWindows() #27 0x7fded53a221b ash::Shell::~Shell() #28 0x7fded53a2ee9 ash::Shell::~Shell() #29 0x7fded539e7ef ash::Shell::DeleteInstance() #30 0x000002db0a7b chrome::CloseAsh() #31 0x000002a0ff31 ChromeBrowserMainExtraPartsAsh::PostMainMessageLoopRun() #32 0x000004aa0ff8 ChromeBrowserMainParts::PostMainMessageLoopRun() #33 0x00000245e645 chromeos::ChromeBrowserMainPartsChromeos::PostMainMessageLoopRun() #34 0x7fdede22c929 content::BrowserMainLoop::ShutdownThreadsAndCleanUp() #35 0x7fdede235739 content::BrowserMainRunnerImpl::Shutdown() #36 0x7fdede226dd8 content::BrowserMain() #37 0x7fdede0be36f content::RunNamedProcessTypeMain() #38 0x7fdede0c1458 content::ContentMainRunnerImpl::Run() #39 0x7fdede0bd915 content::ContentMain() #40 0x00000480705b content::BrowserTestBase::SetUp() #41 0x000002198e3b InProcessBrowserTest::SetUp() #42 0x0000006f6cf3 _ZN7testing8internal12InvokeHelperIvNSt3tr15tupleIJEEEE12InvokeMethodIN10extensions42BluetoothPrivateApiTest_CancelPairing_TestEMNS7_23BluetoothPrivateApiTestEFvvEEEvPT_T0_RKS4_ #43 0x000002385ffe testing::internal::HandleExceptionsInMethodIfSupported\u003C>() #44 0x00000237b103 testing::Test::Run() #45 0x00000237b84b testing::TestInfo::Run() #46 0x00000237be3a testing::TestCase::Run() #47 0x000002381333 testing::internal::UnitTestImpl::RunAllTests() #48 0x00000238e5c3 testing::internal::HandleSehExceptionsInMethodIfSupported\u003C>() #49 0x00000238774e testing::internal::HandleExceptionsInMethodIfSupported\u003C>() #50 0x000002380fd1 testing::UnitTest::Run() #51 0x00000223cfe1 RUN_ALL_TESTS() #52 0x00000223bfb7 base::TestSuite::Run() #53 0x000001376532 ChromeBrowserTestSuiteRunner::RunTestSuite() #54 0x000002197128 (anonymous namespace)::ChromeTestLauncherDelegate::RunTestSuite() #55 0x00000485373e content::LaunchTests() #56 0x000002197059 LaunchChromeTests() #57 0x00000137648e main #58 0x7fdece3a776d __libc_start_main #59 0x000000668105 \u003Cunknown> Original issue's description: > Reland: Make WindowState::CanMinimize() take into account WidgetDelegate::CanMinimize() > > This has the side effect of disallowing minimizing bubbles (e.g. the bookmark > bubble) via a gesture > > BUG=328241 > TEST=Manual, see bug > R=oshima > TBR=sky > > Committed: https://crrev.com/54e8fe5b00b8d218a0ebe22e5d09386cc28a6151 > Cr-Commit-Position: refs/heads/master@{#298108} TBR=oshima@chromium.org,pkotwicz@chromium.org NOTREECHECKS=true NOTRY=true BUG=328241 Review URL: https://codereview.chromium.org/627813003 Cr-Commit-Position: refs/heads/master@{#298132}
* Reland: Make WindowState::CanMinimize() take into account ↵pkotwicz2014-10-032-0/+4
| | | | | | | | | | | | | | | | WidgetDelegate::CanMinimize() This has the side effect of disallowing minimizing bubbles (e.g. the bookmark bubble) via a gesture BUG=328241 TEST=Manual, see bug R=oshima TBR=sky Review URL: https://codereview.chromium.org/625653002 Cr-Commit-Position: refs/heads/master@{#298108}
* Revert of Make WindowState::CanMinimize() take into account ↵tapted2014-10-022-4/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | WidgetDelegate::CanMinimize() (patchset #3 id:120001 of https://codereview.chromium.org/613563002/) Reason for revert: Suspected for failures on Linux ChromiumOS Tests (dbg)(1) link: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/32143 browser_test LoginWebDialogTest.CannotMinimize failing with: [12496:12496:1001/170357:FATAL:login_web_dialog.cc(148)] Check failed: false. #2 0x0000026179dd chromeos::LoginWebDialog::OnCloseContents() #3 0x7f542cba9b00 views::WebDialogView::OnCloseContents() /* snip */ #24 0x7f5422726679 aura::Window::~Window() #25 0x7f54244db0f8 ash::RootWindowController::CloseChildWindows() #26 0x7f5424444bad ash::DisplayController::CloseChildWindows() #27 0x7f542452db9b ash::Shell::~Shell() #28 0x7f542452e869 ash::Shell::~Shell() #29 0x7f542452a16f ash::Shell::DeleteInstance() #30 0x000002dac13b chrome::CloseAsh() #31 0x000002a0e111 ChromeBrowserMainExtraPartsAsh::PostMainMessageLoopRun() Original issue's description: > Make WindowState::CanMinimize() take into account WidgetDelegate::CanMinimize() > > This has the side effect of disallowing minimizing bubbles (e.g. the bookmark > bubble) via a gesture > > BUG=328241 > TEST=Manual, see bug > > Committed: https://crrev.com/ffacfd8c2841480e1e5775c124b63b351bddca69 > Cr-Commit-Position: refs/heads/master@{#297732} TBR=oshima@chromium.org,sky@chromium.org,pkotwicz@chromium.org NOTREECHECKS=true NOTRY=true BUG=328241 Review URL: https://codereview.chromium.org/623613004 Cr-Commit-Position: refs/heads/master@{#297750}
* Make WindowState::CanMinimize() take into account WidgetDelegate::CanMinimize()pkotwicz2014-10-012-0/+4
| | | | | | | | | | | | This has the side effect of disallowing minimizing bubbles (e.g. the bookmark bubble) via a gesture BUG=328241 TEST=Manual, see bug Review URL: https://codereview.chromium.org/613563002 Cr-Commit-Position: refs/heads/master@{#297732}
* Introduce EventProcessor::OnEventProcessingStarted()tdanderson2014-09-303-11/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | Introduce EventProcessor::OnEventProcessingStarted(), to be called at the beginning of event-processing in EventProcessor::OnEventFromSource() before any targeting takes place. OnEventProcessingStarted() marks the event as handled if it is not to be dispatched, otherwise it optionally prepares the event for targeting and/or updates any state variables in the event processor. OnEventProcessingStarted() replaces EventProcessor::PrepareEventForDispatch() and allows us to remove all overrides of EventProcessor::OnEventFromSource() which are not part of unit tests. BUG=412776 TEST=EventProcessorTest.OnEventProcessingStarted, WidgetTest.GestureEventsNotProcessed, WindowEventDispatcherTest.MouseMovesHeld changed, WidgetTest.GestureEndEvents changed Review URL: https://codereview.chromium.org/552503003 Cr-Commit-Position: refs/heads/master@{#297521}
* ui: Fix the test names for ui/aura and ui/base.tfarina2014-09-281-2/+1
| | | | | | | | | | | | | | | | Brett prefers we go with foo_unittests, it makes Windows users life easier. And others easier, so they don't need to know/remember the other possibility: /path/to:unittests BUG=None TEST=gn gen out_gn/Debug && ninja -C out_gn/Debug aura_unittests ui_unittests R=brettw@chromium.org TBR=sky@chromium.org Review URL: https://codereview.chromium.org/601753003 Cr-Commit-Position: refs/heads/master@{#297128}
* Moves ui/wm/public/window_types.h into aura.gyp/BUILD.gnsky2014-09-272-0/+2
| | | | | | | | | | BUG=408650 TEST=none R=ben@chromium.org Review URL: https://codereview.chromium.org/567743005 Cr-Commit-Position: refs/heads/master@{#297081}
* Revert of Revert of Add test for ChromeVox keyboard commands. (patchset #1 ↵jam2014-09-251-2/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | id:1 of https://codereview.chromium.org/603823002/) Reason for revert: sorry I reverted this incorrectly, the problem was that the isolate needed a nacl file. I'm not sure why it only needed it on debug cros and not release. I landed it in https://codereview.chromium.org/597283004/ Original issue's description: > Revert of Add test for ChromeVox keyboard commands. (patchset #21 id:390004 of https://codereview.chromium.org/490443002/) > > Reason for revert: > flakes, see http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/31850 > > failures: > TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxPrefixKey/0 > TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxPrefixKey/1 > TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxShiftSearch/1 > TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxShiftSearch/0 > LoggedInSpokenFeedbackTest.AddBookmark > > Original issue's description: > > Add test for ChromeVox keyboard commands. > > > > This is just a couple of quick sanity checks to prevent future regressions > > like the one in the linked bug. It tests both a Search+Shift shortcut and > > the corresponding Prefix Key shortcut. > > > > Adds support for sending the meta modifier key in > > aura/x11 tests. > > > > BUG=404470 > > > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291547 > > > > Committed: https://chromium.googlesource.com/chromium/src/+/8cab2737f1cb6e6011b0946f6bef5027868602c0 > > > > Committed: https://crrev.com/91703961c10dfa0f452999ed7cb87945ea817362 > > Cr-Commit-Position: refs/heads/master@{#293687} > > > > Committed: https://crrev.com/15ea141544fedaf306c94890b5be19b7c5df885a > > Cr-Commit-Position: refs/heads/master@{#296074} > > TBR=dtseng@chromium.org,sky@chromium.org,dmazzoni@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=404470 > > Committed: https://crrev.com/14e5bdf573d0621dfdd553888a5d3c557fb699a0 > Cr-Commit-Position: refs/heads/master@{#296627} TBR=dtseng@chromium.org,sky@chromium.org,dmazzoni@chromium.org NOTREECHECKS=true NOTRY=true BUG=404470 Review URL: https://codereview.chromium.org/600373002 Cr-Commit-Position: refs/heads/master@{#296670}
* fling: Remove a bunch of code for configuring fling curves.Sadrul Habib Chowdhury2014-09-251-8/+0
| | | | | | | | | | | | | | The fling curve for touchpad and touchscreen used to be configurable for experimenting with, but these parameters have been stable for a long time now. So make the values default, and remove all the code and preferences that were necessary for the configurability. BUG=none R=avi@chromium.org, kenrb@chromium.org, sky@chromium.org, wjmaclean@chromium.org Review URL: https://codereview.chromium.org/586933003 Cr-Commit-Position: refs/heads/master@{#296652}
* Revert of Add test for ChromeVox keyboard commands. (patchset #21 id:390004 ↵jam2014-09-251-10/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | of https://codereview.chromium.org/490443002/) Reason for revert: flakes, see http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/31850 failures: TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxPrefixKey/0 TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxPrefixKey/1 TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxShiftSearch/1 TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxShiftSearch/0 LoggedInSpokenFeedbackTest.AddBookmark Original issue's description: > Add test for ChromeVox keyboard commands. > > This is just a couple of quick sanity checks to prevent future regressions > like the one in the linked bug. It tests both a Search+Shift shortcut and > the corresponding Prefix Key shortcut. > > Adds support for sending the meta modifier key in > aura/x11 tests. > > BUG=404470 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291547 > > Committed: https://chromium.googlesource.com/chromium/src/+/8cab2737f1cb6e6011b0946f6bef5027868602c0 > > Committed: https://crrev.com/91703961c10dfa0f452999ed7cb87945ea817362 > Cr-Commit-Position: refs/heads/master@{#293687} > > Committed: https://crrev.com/15ea141544fedaf306c94890b5be19b7c5df885a > Cr-Commit-Position: refs/heads/master@{#296074} TBR=dtseng@chromium.org,sky@chromium.org,dmazzoni@chromium.org NOTREECHECKS=true NOTRY=true BUG=404470 Review URL: https://codereview.chromium.org/603823002 Cr-Commit-Position: refs/heads/master@{#296627}
* Fix WeakPtrFactory member ordering in uimohan.reddy2014-09-241-1/+0
| | | | | | | | | | | | | Changing in the intialization order of WeakPtrFactory such that all member variables should appear before the WeakPtrFactory to ensure that any WeakPtrs to Controller are invalidated before its members variable's destructors are executed, rendering them invalid. BUG=303818 Review URL: https://codereview.chromium.org/589413002 Cr-Commit-Position: refs/heads/master@{#296468}
* Add test for ChromeVox keyboard commands.dmazzoni2014-09-221-2/+10
| | | | | | | | | | | | | | | | | | | | | | This is just a couple of quick sanity checks to prevent future regressions like the one in the linked bug. It tests both a Search+Shift shortcut and the corresponding Prefix Key shortcut. Adds support for sending the meta modifier key in aura/x11 tests. BUG=404470 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291547 Committed: https://chromium.googlesource.com/chromium/src/+/8cab2737f1cb6e6011b0946f6bef5027868602c0 Committed: https://crrev.com/91703961c10dfa0f452999ed7cb87945ea817362 Cr-Commit-Position: refs/heads/master@{#293687} Review URL: https://codereview.chromium.org/490443002 Cr-Commit-Position: refs/heads/master@{#296074}
* Improve GN header checker, make "check" on //ui/* pass.Brett Wilson2014-09-191-8/+4
| | | | | | | | | | | | | | | | | | | | I went through and made "gn check //ui/*" pass, and did a lot of enhancements for the bugs I found. Fixes a big bug in the header checker where it did not consider direct private dependencies to be OK from a header include perspective. However, private deps only change things when there are intermediate targets. This patch marks direct deps OK, and changes the variable names from is_public to is_permitted (since it may not actually be public). Allow includes to be permitted if any target allows the include, rather than all of them. This happens if multiple targets have the same file as sources. Strip the generated file directory from the beginning of sources. Previously, this was only for outputs (since typically they're included assuming the root gen dir is on the path). This comes up when an action generates a file, and then it's put into a source set (which we do a lot). This change allows a public dependency on the source set to count for header include purposes. Track public/private deps in the dependency path finder so the error message can show which deps are private that break the chain. This was really helpful when tracking down errors. Add deps and public deps to the build to make check pass. R=scottmg@chromium.org Review URL: https://codereview.chromium.org/584683002 Cr-Commit-Position: refs/heads/master@{#295783}
* Clean up GestureEventDetails constructors and fix unit tests.lanwei2014-09-192-2/+2
| | | | | | | | | | | | | | | Reland the code change for Issue 573963005: Clean up GestureEventDetails constructors and fix unit tests: https://codereview.chromium.org/573963005/. The code does not change, just merge two commits into one. BUG=350942 TBR=tdresser@chromium.org,jdduke@chromium.org,sadrul@chromium.org,sky@chromium.org Review URL: https://codereview.chromium.org/581963004 Cr-Commit-Position: refs/heads/master@{#295706}
* Reland Track the active ExtensionKeybindingRegistry and make it available to ↵dtseng2014-09-181-2/+4
| | | | | | | | | | | | | | EventRewriter. Original issue https://codereview.chromium.org/553243002/ TBR=dtseng@chromium.org BUG=410944 Review URL: https://codereview.chromium.org/576413002 Cr-Commit-Position: refs/heads/master@{#295411}
* Revert "Clean up GestureEventDetails constructors and fix unit tests."Dirk Pranke2014-09-172-2/+2
| | | | | | | | | | | | | | | | | | | | | | | This reverts commit b44589c531098bbe739ccc7066f41e17fc5b9287. > Clean up GestureEventDetails constructors and fix unit tests. > > A new version of Issue 565583005: Clean up GestureEventDetails > constructors > https://codereview.chromium.org/565583005/ > BUG=350942 > TBR=tdresser@chromium.org, jdduke@chromium.org, sadrul@chromium.org Patch set 9ec877c2d256a538b1c9af2fbed736aad8406e66 was reverted recently, but without that fix, this change doesn't work right (i.e., both patches needed to be reverted). TBR=dbeam@chromium.org, erg@chromium.org, lanwei@chromium.org BUG=350954 Review URL: https://codereview.chromium.org/576373002 Cr-Commit-Position: refs/heads/master@{#295370}
* Revert of Track the active ExtensionKeybindingRegistry and make it available ↵erg2014-09-171-4/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | to EventRewriter. (patchset #22 id:480001 of https://codereview.chromium.org/553243002/) Reason for revert: The new tests fail on Linux Chromeos (ozone). http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Tests%20%282%29/builds/1998/steps/interactive_ui_tests/logs/ChromeOSConversions Original issue's description: > Track the active ExtensionKeybindingRegistry and make it available to EventRewriter. > > Add the ability to query globally if a shortcut > is registered by an extension and use that to avoid unnecessarily rewriting > Chrome OS keys. > > BUG=410944 > > Committed: https://crrev.com/4264d2c4b5d217e1c5dbc2ae80ab6ce595f9b6d3 > Cr-Commit-Position: refs/heads/master@{#295284} TBR=finnur@chromium.org,sky@chromium.org,rdevlin.cronin@chromium.org,dtseng@chromium.org NOTREECHECKS=true NOTRY=true BUG=410944 Review URL: https://codereview.chromium.org/575093003 Cr-Commit-Position: refs/heads/master@{#295324}
* Clean up GestureEventDetails constructors and fix unit tests.lanwei2014-09-172-2/+2
| | | | | | | | | | | | | | | | | A new version of Issue 565583005: Clean up GestureEventDetails constructors https://codereview.chromium.org/565583005/ BUG=350942 TBR=tdresser@chromium.org, jdduke@chromium.org, sadrul@chromium.org Committed: https://crrev.com/874611d5ab5b879648682c1ea41062bebc9c95e5 Cr-Commit-Position: refs/heads/master@{#295144} Review URL: https://codereview.chromium.org/573963005 Cr-Commit-Position: refs/heads/master@{#295296}
* Track the active ExtensionKeybindingRegistry and make it available to ↵dtseng2014-09-171-2/+4
| | | | | | | | | | | | | | EventRewriter. Add the ability to query globally if a shortcut is registered by an extension and use that to avoid unnecessarily rewriting Chrome OS keys. BUG=410944 Review URL: https://codereview.chromium.org/553243002 Cr-Commit-Position: refs/heads/master@{#295284}
* Revert of Clean up GestureEventDetails constructors and fix unit tests ↵horo2014-09-172-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #1 id:20001 of https://codereview.chromium.org/573963005/) Reason for revert: This broke TouchEditableImplAuraTest.TouchSelectionOnLongPressTest. [24874:24874:0916/151803:584385367:FATAL:gesture_event_details.cc(54)] Check failed: false. Invalid event type for constructor: 32 http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=undefined&tests=TouchEditableImplAuraTest.TouchSelectionOnLongPressTest&testType=content_browsertests http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=undefined&tests=TouchEditableImplAuraTest.TouchSelectionOnLongPressTest&testType=content_browsertests Original issue's description: > Clean up GestureEventDetails constructors and fix unit tests. > > A new version of Issue 565583005: Clean up GestureEventDetails > constructors > https://codereview.chromium.org/565583005/ > > BUG=350942 > > TBR=tdresser@chromium.org, jdduke@chromium.org, sadrul@chromium.org > > Committed: https://crrev.com/874611d5ab5b879648682c1ea41062bebc9c95e5 > Cr-Commit-Position: refs/heads/master@{#295144} TBR=sky@chromium.org,lanwei@chromium.org NOTREECHECKS=true NOTRY=true BUG=350942 Review URL: https://codereview.chromium.org/577833003 Cr-Commit-Position: refs/heads/master@{#295223}
* Clean up GestureEventDetails constructors and fix unit tests.lanwei2014-09-162-2/+2
| | | | | | | | | | | | | | A new version of Issue 565583005: Clean up GestureEventDetails constructors https://codereview.chromium.org/565583005/ BUG=350942 TBR=tdresser@chromium.org, jdduke@chromium.org, sadrul@chromium.org Review URL: https://codereview.chromium.org/573963005 Cr-Commit-Position: refs/heads/master@{#295144}
* Remove unsupported parameters by the unified gesture detector from Gesture ↵lanwei2014-09-162-31/+47
| | | | | | | | | | | | | | | | | | | | | | Configuration. There are some parameters in the Gesture Configuration which are no longer used for unified gesture detector: max_radius_; min_flick_speed_squared_ min_rail_break_velocity_ min_scroll_delta_squared_ min_touch_down_duration_in_seconds_for_click_ rail_break_proportion_ rail_start_proportion_ scroll_prediction_seconds_ points_buffered_for_velocity_ BUG=380131 Review URL: https://codereview.chromium.org/570633002 Cr-Commit-Position: refs/heads/master@{#294975}
* GN: Create a :gles2_interface target to resolve some check errors in //cc.jbroman2014-09-161-0/+1
| | | | | | | | | | | | | | gles2_interface.h defines a pure virtual interface; targets which use it should depend on it, but not necessarily on an implementation target. Consequently, a //gpu/command_buffer/client:gles2_interface target was created to reflect the dependency on this interface without linking a particular implementation. This resolves an issue with //cc trying to use this header without having a dependency on a target which includes it. Review URL: https://codereview.chromium.org/464153002 Cr-Commit-Position: refs/heads/master@{#294956}
* Revert of Clean up GestureEventDetails constructors (patchset #4 id:100001 ↵nhiroki2014-09-152-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | of https://codereview.chromium.org/565583005/) Reason for revert: This seems to fail the following tests in "athena_unittests" on "Linux ChromiumOS Tests (dbg)(3)" - HomeCardGestureManagerTest.Basic - HomeCardGestureManagerTest.StartCentered http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%283%29/builds/36778 Original issue's description: > Clean up GestureEventDetails' constructors. > > In one of the GestureEventDetails' constructors, the arguments > delta_x, delta_y sometime are not used, so we should make a new > constructor which only takes one argument EventType. > > BUG=350942 > > Committed: https://crrev.com/b5e408e7bffd3d1e6b60612f65c0538a90329c59 > Cr-Commit-Position: refs/heads/master@{#294760} TBR=tdresser@chromium.org,jdduke@chromium.org,sadrul@chromium.org,sky@chromium.org,lanwei@chromium.org NOTREECHECKS=true NOTRY=true BUG=350942 Review URL: https://codereview.chromium.org/572593002 Cr-Commit-Position: refs/heads/master@{#294776}
* Clean up GestureEventDetails' constructors.lanwei2014-09-142-2/+2
| | | | | | | | | | | | In one of the GestureEventDetails' constructors, the arguments delta_x, delta_y sometime are not used, so we should make a new constructor which only takes one argument EventType. BUG=350942 Review URL: https://codereview.chromium.org/565583005 Cr-Commit-Position: refs/heads/master@{#294760}
* Test that gesture events are created with correct coordinates.tdresser2014-09-121-0/+63
| | | | | | | | | BUG=412875 TEST=WindowEventDispatcherTest.GestureEventCoordinates Review URL: https://codereview.chromium.org/564923003 Cr-Commit-Position: refs/heads/master@{#294626}
* Ensure that mouse lock works correctly on Chrome ASH in Windows 8.ananta2014-09-112-6/+6
| | | | | | | | | | | | | | | | | | | | | The lock mouse operation invoked by plugins or pages hides the mouse cursor and ensures that the cursor stays within the bounds of the webpage. To ensure that the mouse stays within the bounds of the page, the SetCursorPos operation is executed by the host. In ASH, the SetCursorPos API is executed by the viewer process for historical reasons. As a result on Windows 8 there is a faint possibility that the user may move the mouse to the charms section of the OS, which causes the cursor to become visible. Fix for this is to track if the mouse changed from what was last set in the viewer process and restore it. The other change is in the RemoteWindowTreeHostWin class where the member ignore_mouse_moves_until_set_cursor_ack_ has been changed to a count from a bool flag. This is because the RemoteWindowTreeHostWin::MoveCursorToNative function can be called multiple times before the acks are received causing DCHECKs to fire on the ignore_mouse_moves_until_set_cursor_ack_ flag. BUG=398792 Review URL: https://codereview.chromium.org/560633002 Cr-Commit-Position: refs/heads/master@{#294274}
* Propagate window transformed notification to child hierarchymohsen2014-09-104-0/+64
| | | | | | | | BUG=407659 Review URL: https://codereview.chromium.org/558203002 Cr-Commit-Position: refs/heads/master@{#294235}
* Fix incorrect touch transform before gesture recognition.tdresser2014-09-102-5/+4
| | | | | | | | | | TEST=see crbug.com/412875 BUG=412749 Review URL: https://codereview.chromium.org/565433002 Cr-Commit-Position: refs/heads/master@{#294220}
generated by cgit v1.1 at 2025-02-07 19:46:03 +0000