| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
kLoginScreen
kLoginScreenSize
kAshBootAnimationFunction2
kAshBootAnimationFunction3
kAshDisableBootAnimation2
+ related flags
See also https://gerrit.chromium.org/gerrit/#/c/56735/
BUG=244224
TEST=compiles, existing browser_tests and autotests work
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/16105005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=236029
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/14061025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We have too many ways to do the same thing in gfx::Transform, and their names
can lead to confusion. We have the notion of Concat-ing and Preconcat-ing.
We've borrowed this verbage from skia. a.preConcat(b) means a = a * b. This may
seem counter-intuitive, but is the correct definition if we are multiplying our
points/vectors on the right.
That said, we almost always want to pre-concat. This what is done throughout
WebKit. To simplify matters, rather than having ConcatFoo and PreconcatFoo, we
will now only have Foo which does what PreconcatFoo used to.
Furthermore, we also have SetFoo which is almost always used immediately after
a transform is created, so Foo would do fine (with the optimization mentioned
below).
Another bit of redundant code eliminated by this CL is
InterpolatedTransform::FactorTRS. This function was brittle and naive, and now
that gfx::Transform::Blend exists, it needs to go away.
Other minor changes rolled into this cleanup:
- RotateAbout now takes the newly minted Vector3dF
- The Foo functions mentioned above also check for identity to avoid
needless matrix multiplications.
BUG=159972
Review URL: https://chromiumcodereview.appspot.com/11418040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169476 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Point3F::AsPoint() method converts from float to integer by doing an
implicit floor() on the values. Instead, we should have AsPointF() return
floating point values, and use the ToFlooredPoint() conversion method to
explicitly floor the values at the call-site if desired.
Also, move the point3.h header to point3_f.h so that it is consistent with
other geometry header file namings.
BUG=147395
R=sky
Review URL: https://chromiumcodereview.appspot.com/11301043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=157981
TEST=None
Review URL: https://codereview.chromium.org/11274063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164399 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
It is more appropriate for Transform class to belong with its fellow
geometry classes in the gfx namespace.
Review URL: https://chromiumcodereview.appspot.com/11145005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161809 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=141988
Review URL: https://chromiumcodereview.appspot.com/10960034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158079 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
a. Show login webUI as soon as possible (don't wait for wallpaper animation to finish).
b. Use different type of animation tween.
c. NOT increasing wallpaper animation time from 1s to 2s as it turns out that slows down login webUI even with a. (profiling is needed)
BUG=141988
Review URL: https://codereview.chromium.org/10938013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157535 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=146892
TEST=none
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10910143
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155544 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=115047
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10905053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154606 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As a part of the new constrained window look and feel we're changing the the solid gray overlay to a gradient overlay. The overlay fades in on show and fades out on hide.
Screenshots:
light background: http://i.imgur.com/GJj6L.png
dark background: http://i.imgur.com/s37da.png
BUG=140520
TEST=Run with --enable-frameless-constrained-dialogs.
Navigate to http://www.imagemator.com/
Click "Click to pick an image."
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152059
Review URL: https://chromiumcodereview.appspot.com/10855151
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152065 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As a part of the new constrained window look and feel we're changing the the solid gray overlay to a gradient overlay. The overlay fades in on show and fades out on hide.
Screenshots:
light background: http://i.imgur.com/GJj6L.png
dark background: http://i.imgur.com/s37da.png
BUG=140520
TEST=Run with --enable-frameless-constrained-dialogs.
Navigate to http://www.imagemator.com/
Click "Click to pick an image."
Review URL: https://chromiumcodereview.appspot.com/10855151
TBR=sail@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10823387
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152062 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As a part of the new constrained window look and feel we're changing the the solid gray overlay to a gradient overlay. The overlay fades in on show and fades out on hide.
Screenshots:
light background: http://i.imgur.com/GJj6L.png
dark background: http://i.imgur.com/s37da.png
BUG=140520
TEST=Run with --enable-frameless-constrained-dialogs.
Navigate to http://www.imagemator.com/
Click "Click to pick an image."
Review URL: https://chromiumcodereview.appspot.com/10855151
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152059 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
After discussion with Glen and some digging into svn history we don't know why this was set to 50 Hz and not 60 Hz. In testing on Chromebooks and Linux hardware we can easily animate at 60 Hz for most animations. We're going to try setting it to 60 Hz and see how things behave.
Also added some unit tests around SlideAnimation.
BUG=136910
TEST=SlideAnimationTest in ui_unittests
Review URL: https://chromiumcodereview.appspot.com/10703153
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146490 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
For context see this thread:
https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II
TBR=thakis,pkasting,jam
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=119965
TEST=BrowserLauncherItemControllerTest.FlashWindow
Review URL: https://chromiumcodereview.appspot.com/10392173
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137993 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=119965
TEST=LauncherViewTest.LauncherItemStatus
Review URL: https://chromiumcodereview.appspot.com/10386212
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137878 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
snap/minimize/maximize windows.
BUG=121140
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10067011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds necessary pieces to get the WebKit compositor working with
compositor_unittests target on Mac. Required gyp build flags are:
'use_aura': 1,
'use_webkit_compositor': 1,
'use_skia': 1,
BUG=104390, 104555
TEST=compositor_unittests --gtest_filter=LayerWithRealCompositorTest.* passes and shows correct visual results.
Review URL: http://codereview.chromium.org/8486020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110875 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=104314
TEST=
Review URL: http://codereview.chromium.org/8468021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110209 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL depends on http://codereview.chromium.org/8395046/
The fix boils down to two changes to the layer animator:
1. When calling Set*** we must start a zero duration animation and not short circuit. The animator needs to be able to update its state, and the preemption strategy needs to be applied.
2. Always be aware that progressing or aborting animation may affect the list of running animation and take appropriate precautions.
I have added a unit test to make sure the fix for 102413 doesn't regress and updated the existing unit tests for the new behavior (specifically, we now get notified that a sequence has ended whenever we call Set*** because of 1. above).
BUG=102413
TEST=compositor_unittests
Review URL: http://codereview.chromium.org/8387051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108546 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
High level description:
- LayerPropertySetter is now LayerAnimator since it manages implicit/explicit animations and the animation queue.
- LayerAnimationElement represents an animation curve.
- LayerAnimationSequence owns a collection of elements.
- The animator works as follows:
o Has a queue of sequences and a collection of running sequences.
o It knows the start time of each running sequence.
o While there are running sequences, LayerAnimator::Step(base::TimeTicks now) is called periodically, and each of the running sequences are updated.
BUG=None
TEST=compositor_unittests, base_unittests
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106768
Review URL: http://codereview.chromium.org/8247009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106915 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
High level description:
- LayerPropertySetter is now LayerAnimator since it manages implicit/explicit animations and the animation queue.
- LayerAnimationElement represents an animation curve.
- LayerAnimationSequence owns a collection of elements.
- The animator works as follows:
o Has a queue of sequences and a collection of running sequences.
o It knows the start time of each running sequence.
o While there are running sequences, LayerAnimator::Step(base::TimeTicks now) is called periodically, and each of the running sequences are updated.
BUG=None
TEST=compositor_unittests, base_unittests
Review URL: http://codereview.chromium.org/8247009
TBR=vollick@chromium.org
Review URL: http://codereview.chromium.org/8375008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106774 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
High level description:
- LayerPropertySetter is now LayerAnimator since it manages implicit/explicit animations and the animation queue.
- LayerAnimationElement represents an animation curve.
- LayerAnimationSequence owns a collection of elements.
- The animator works as follows:
o Has a queue of sequences and a collection of running sequences.
o It knows the start time of each running sequence.
o While there are running sequences, LayerAnimator::Step(base::TimeTicks now) is called periodically, and each of the running sequences are updated.
BUG=None
TEST=compositor_unittests, base_unittests
Review URL: http://codereview.chromium.org/8247009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106768 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
original CL w/LGTMs: http://codereview.chromium.org/7812036/
Review URL: http://codereview.chromium.org/7824041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
so the original code that created the delayed callback is lost."
This reverts commit 4cf5cf73d319b69c32ad30af8954235755856455. (r99284)
TBR=jbates@chromium.org
Review URL: http://codereview.chromium.org/7825026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99290 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the original code that created the delayed callback is lost.
This change adds a tracked_objects::Location parameter to the APIs in base/timer.h so we can trace the PostTask callbacks. The other files are touched to add the FROM_HERE Location parameter.
Review URL: http://codereview.chromium.org/7812036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99284 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
R=rvargas@chromium.org
Review URL: http://codereview.chromium.org/7569005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95730 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
R=sky@chromium.org,rvargas@chromium.org
Review URL: http://codereview.chromium.org/7493017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
R=ben@chromium.org
Review URL: http://codereview.chromium.org/7328011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92819 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The TEST() macro is used to define and name a test function, the first argument
is the test case name and thus doesn't need to be a typedef of testing::Test.
BUG=None
TEST=ui_unittests
R=phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/7262022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90567 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes multiple test failures on the new Lucid bots, like:
MultiAnimationTest.Basic:
ui/base/animation/multi_animation_unittest.cc:32: Failure
Value of: animation.GetCurrentValue()
Actual: 0.36
Expected: Tween::CalculateValue(Tween::EASE_OUT, .2)
Which is: 0.36
BUG=
TEST=Fix printing_unittests, app_unittests, and gfx_unittests on new Lucid official builder.
Review URL: http://codereview.chromium.org/6811036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
raw_scoped_refptr_mismatch_checker.h
ref_counted.cc
ref_counted.h
ref_counted_memory.cc
ref_counted_memory.h
ref_counted_unittest.cc
scoped_callback_factory.h
scoped_comptr_win.h
scoped_handle.h
scoped_native_library.cc
scoped_native_library.h
scoped_native_library_unittest.cc
scoped_nsobject.h
scoped_open_process.h
scoped_ptr.h
scoped_ptr_unittest.cc
scoped_temp_dir.cc
scoped_temp_dir.h
scoped_temp_dir_unittest.cc
scoped_vector.h
singleton.h
singleton_objc.h
singleton_unittest.cc
linked_ptr.h
linked_ptr_unittest.cc
weak_ptr.cc
weak_ptr.h
weak_ptr_unittest.cc
BUG=None
TEST=Compile
Review URL: http://codereview.chromium.org/6714032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=71063
TEST=compiled
Review URL: http://codereview.chromium.org/6312156
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
BUG=none
TEST=none
TBR=brettw
Review URL: http://codereview.chromium.org/6154001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70743 0039d316-1c4b-4281-b951-d872f2087c98
|