| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Linux PlatformFont implementation no longer has any
dependencies on Pango. Rename it and compile it
unconditionally on Linux. Also drop some Pango build
dependencies and delete the now-unneeded PlatformFontOzone
implementation.
BUG=398885,393067
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/912293006
Cr-Commit-Position: refs/heads/master@{#315874}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move FontListImpl's description-string-parsing code into a
static FontList::ParseDescription() method that
PlatformFontPango will be able to call to parse descriptions
on Chrome OS.
Also make parsing stricter, add tests, and delete unused
SetUpPangoLayout() and GetFontDescriptionString().
BUG=398885,393067
Review URL: https://codereview.chromium.org/903423002
Cr-Commit-Position: refs/heads/master@{#315559}
|
|
|
|
|
|
|
|
|
| |
BUG=449276
R=tony@chromium.org
Review URL: https://codereview.chromium.org/854923002
Cr-Commit-Position: refs/heads/master@{#311793}
|
|
|
|
|
|
|
|
|
| |
BUG=442514
R=sky@chromium.org
Review URL: https://codereview.chromium.org/828633002
Cr-Commit-Position: refs/heads/master@{#311435}
|
|
|
|
|
|
|
|
|
|
| |
BUG=447834
R=oshima@chromium.org, tony@chromium.org
TEST=see the bug, especially the screenshots
Review URL: https://codereview.chromium.org/831213003
Cr-Commit-Position: refs/heads/master@{#311080}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The geometry headers were moved from /ui/gfx/ to ui/gfx/geometry, so
we are updating the include paths to fix this.
BUG=395370
TEST=compiles
TBR=sky@chromium.org,danakj@chromium.org
Review URL: https://codereview.chromium.org/832953002
Cr-Commit-Position: refs/heads/master@{#309873}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The geometry headers were moved from /ui/gfx/ to ui/gfx/geometry, so
we are updating the include paths to fix this.
BUG=395370
TEST=ui_base_unittests && gfx_unittests
TBR=sky@chromium.org,danakj@chromium.org
Review URL: https://codereview.chromium.org/820913002
Cr-Commit-Position: refs/heads/master@{#309372}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of mac_util.h.
BUG=none
TEST=none
TBR=ben@chromium.org
NOTRY=TRUE
Review URL: https://codereview.chromium.org/817153002
Cr-Commit-Position: refs/heads/master@{#309368}
|
|
|
|
|
|
|
|
|
|
| |
BUG=318840
TEST=ui_base_unittests
R=sky@chromium.org
Review URL: https://codereview.chromium.org/798143003
Cr-Commit-Position: refs/heads/master@{#308736}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Use make_scoped_ptr() when possible (less typing/noise).
* Return nullptr whenever possible.
The entries were found with the following command line:
$ git grep -E '(=|\breturn)\s*scoped_ptr<.*?>([^)]+)' ui/aura
BUG=None
TEST=ui_base_unittests
R=sky@chromium.org
Review URL: https://codereview.chromium.org/792503004
Cr-Commit-Position: refs/heads/master@{#307902}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a flag (about:flags) to use Roboto as the UI font. When the flag is
on, replace 'Noto Sans UI' with 'Roboto' for both native UI and web UI.
With this CL and a CL to add Roboto to CrOS, all the native UI will use
Roboto when 'enable-roboto-font-ui' is on.
In web UI, some places will use Roboto, but other places with 'Noto Sans UI'
hardcoded in CSS will not change regardless of the flag's status. bug 409047
will deal with that issue.
BUG=434400
TEST=Once Roboto is added to CrOS (bug 303849), the native UI (omnibox, menu, etc) uses Roboto for Latin-Greek-Cyrillic. In addition, web ui pages without hardcoded font-family also uses Roboto (e.g. Settings page, chrome://flags, etc)
Review URL: https://codereview.chromium.org/776753003
Cr-Commit-Position: refs/heads/master@{#307393}
|
|
|
|
|
|
|
|
|
|
|
| |
After the fix, jankiness disappeared from this task.
BUG=422489
TBR=tony@chromium.org, danakj@chromium.org, thestig@chromium.org, finnur@chromium.org, michaeln@chromium.org, avi@chromium.org
Review URL: https://codereview.chromium.org/747443002
Cr-Commit-Position: refs/heads/master@{#305037}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This should have come out with https://codereview.chromium.org/646773004
but I missed it. Now that 300P pak files are supported on iOS, the
source_scale should match the target scale (unless fallback is required)
BUG=423762, 431310
Review URL: https://codereview.chromium.org/710683002
Cr-Commit-Position: refs/heads/master@{#303260}
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/689563002
Cr-Commit-Position: refs/heads/master@{#303095}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will disable the instrumentations in all channels except Canary, and developer build. Instrumentations are only enabled in Browser process.
This will prevent Stable from sending increased amounts of UMA logs. Also, this will let us observe "true" (untouched by instrumentations) jankiness numbers every week in Dev channel.
BUG=401560
Review URL: https://codereview.chromium.org/686963002
Cr-Commit-Position: refs/heads/master@{#301950}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Google C++ style guide states:
Explicitly annotate overrides of virtual functions or virtual
destructors with an override or (less frequently) final specifier.
Older (pre-C++11) code will use the virtual keyword as an inferior
alternative annotation. For clarity, use exactly one of override,
final, or virtual when declaring an override.
To better conform to these guidelines, the following constructs have
been rewritten:
- if a base class has a virtual destructor, then:
virtual ~Foo(); -> ~Foo() override;
- virtual void Foo() override; -> void Foo() override;
- virtual void Foo() override final; -> void Foo() final;
This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.
BUG=417463
R=sky@chromium.org
Review URL: https://codereview.chromium.org/670923003
Cr-Commit-Position: refs/heads/master@{#301914}
|
|
|
|
|
|
|
|
|
|
|
| |
Also use that in one place to forward-declare an enum, to make sure it actually
works. No behavior change.
BUG=none
Review URL: https://codereview.chromium.org/678333004
Cr-Commit-Position: refs/heads/master@{#301766}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mechanical change that adds instrumentation required to locate the source of jankiness (i.e. a long-running fragment of code executed as a part of the task that causes jank) in the code. See the bug for details on what kind of jank we are after.
A number of similar CLs were landed, and none of them caused issues. They've helped to find and fix janky code. The code of the instrumentation is highly optimized and is not expected to affect performance. The code simply creates a diagnostic task which is identical to ones created by PostTask or IPC message handlers.
Landing as TBR since this is a mechanical, safe and temporary change.
This CL instruments code invoked from URLRequestResourceBundleJob::GetData, which has 19.3 jph
BUG=422489
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/663893006
Cr-Commit-Position: refs/heads/master@{#301262}
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds support for loading assets from the chrome_300_percent.pak
file on devices that support @3x scale.
BUG=423762
Review URL: https://codereview.chromium.org/646773004
Cr-Commit-Position: refs/heads/master@{#301142}
|
|
|
|
|
|
|
|
|
| |
R=sky@chromium.org
BUG=143619
Review URL: https://codereview.chromium.org/672673005
Cr-Commit-Position: refs/heads/master@{#300986}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Unnecessary wrapper.
TBR=jam@chromium.org
R=sky@chromium.org
BUG=143619
Review URL: https://codereview.chromium.org/672583003
Cr-Commit-Position: refs/heads/master@{#300923}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch was automatically generated by applying clang fixit hints
generated by the plugin to the source tree.
BUG=417463
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/667923002
Cr-Commit-Position: refs/heads/master@{#300446}
|
|
|
|
|
|
|
|
|
|
|
| |
This is mostly to fix MSVC warnings about possible value truncation.
BUG=81439
TEST=none
Review URL: https://codereview.chromium.org/660173002
Cr-Commit-Position: refs/heads/master@{#300412}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
#18 id:340001 of https://codereview.chromium.org/537063002/)
Reason for revert:
Causing content_browsertests failures due to pak loading failure.
Original issue's description:
> Eliminate silently letting errors pass on pak loading.
>
> BUG=410411
> TEST=no visible change
>
> Committed: https://crrev.com/03c8c9d936594163d43222a3da0268b3dd9af656
> Cr-Commit-Position: refs/heads/master@{#299717}
TBR=bengr@chromium.org,caitkp@chromium.org,tfarina@chromium.org,tony@chromium.org,avi@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=410411
Review URL: https://codereview.chromium.org/661503003
Cr-Commit-Position: refs/heads/master@{#299794}
|
|
|
|
|
|
|
|
|
| |
BUG=410411
TEST=no visible change
Review URL: https://codereview.chromium.org/537063002
Cr-Commit-Position: refs/heads/master@{#299717}
|
|
|
|
|
|
|
|
| |
BUG=417463
Review URL: https://codereview.chromium.org/623293004
Cr-Commit-Position: refs/heads/master@{#298839}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Unify the behavior of the windows and posix implementations of these
functions.
- Simplify the interface by having them just indicate success or failure
instead of making callers deal with partial writes.
BUG=418837
Signed-off-by: Chirantan Ekbote <chirantan@chromium.org>
Review URL: https://codereview.chromium.org/614893004
Cr-Commit-Position: refs/heads/master@{#298604}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of disabling it through a file under build/android, better to
disable it directory in C++ source code to avoid sutle issues in the
bots that was caused when renaming the test or the test suite target
name.
BUG=339980
TEST=ui_unittests_apk
R=sky@chromium.org,primiano@chromium.org
Review URL: https://codereview.chromium.org/611513003
Cr-Commit-Position: refs/heads/master@{#297637}
|
|
|
|
|
|
|
|
|
|
|
|
| |
- kEmptyPakContents was malformed; fix it
- chrome.pak was deleted half a year ago for iOS Chrome; don't try to load it
BUG=410411
TEST=no visible change
Review URL: https://codereview.chromium.org/611103002
Cr-Commit-Position: refs/heads/master@{#297210}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fallback images should always have a source scale factor of 1.0, even on 300P
devices.
BUG=413300,415616
TEST=None
Review URL: https://codereview.chromium.org/579383003
Cr-Commit-Position: refs/heads/master@{#295703}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The code will continue to load the 200P pak file and fall back to those
resources, but the supported scale factor on @3x devices will now be 300P.
This CL adds a unittest to ensure that image conversion works properly when the
scale factor of the source image does not match the current supported scale
factor of the system.
BUG=413300
TEST=None
Review URL: https://codereview.chromium.org/574663003
Cr-Commit-Position: refs/heads/master@{#295160}
|
|
|
|
|
|
|
|
|
|
| |
As a temporary solution, use 2x assets on 3x screens.
BUG=413300
Review URL: https://codereview.chromium.org/563713003
Cr-Commit-Position: refs/heads/master@{#294434}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is necessary as we don't always load 1x resources. In particular
when I run views_example_exe with --force-device-scale-factor=2 then
1x isn't loaded.
BUG=none
TEST=none
R=oshima@chromium.org
Review URL: https://codereview.chromium.org/564473002
Cr-Commit-Position: refs/heads/master@{#294196}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
They are:
- app_locale_settings.h
- ui_unscaled_resources.h
- webui_resources.h
BUG=401588
TEST=None
R=thestig@chromium.org,thakis@chromium.org
TBR=darin@chromium.org
Review URL: https://codereview.chromium.org/530623002
Cr-Commit-Position: refs/heads/master@{#293655}
|
|
|
|
|
|
|
|
|
|
| |
google_apis, printing, sql, ui, and webkit.
TBR=jochen@chromium.org,rogerta@chromium.org,shess@chromium.org,ben@chromium.org,jamesr@chromium.org
Review URL: https://codereview.chromium.org/529273002
Cr-Commit-Position: refs/heads/master@{#293479}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Test plan:
First: download chrome-mac.zip from https://download-chromium.appspot.com/?platform=Mac
Then:
$ unzip chrome-mac.zip
$ cd chrome-mac
$ find . -name "*.pak" | grep chrome
./Chromium.app/Contents/Versions/39.0.2136.0/Chromium Framework.framework/Resources/chrome_200_percent.pak
./Chromium.app/Contents/Versions/39.0.2136.0/Chromium Framework.framework/Resources/chrome_100_percent.pak
$ find . | grep content
0 # no results
Check with python:
$ cd ~/chromium/src/tools/grit
$ python
>>> from grit.format import data_pack
>>> pack = data_pack.ReadDataPack('
~/Download/chrome-mac/Chromium.app/Contents/Versions/39.0.2136.0/Chromium
Framework.framework/Resources/chrome_100_percent.pak')
>>> pack.resources[4700]
>>>'\x89PNG\r\n\x1a\n\x00\x00\x00\rIHDR\x00\x00\x00\x0e\x00\x00\x00\x10\x08\x06\x00\x00\x00&\x94N:\x00\x00\x01\x87IDAT(S\x8d\x90I/CQ\x18\x86\xbf\xb5_\x84\xa5\x84\x9f6XX\xb3\xb0\xb7"$j\xe8\xc05T\xe7\x95H\x8cM\xec\xc4XA\xd5\x90\xe2VU\x1a\xa5\x86xb8\xb4h\xaf\xd7\xf9\x0e\xb7Q\xb9\xa2o\xf2,\xce9\xcf\xb39\x14\x08\x04P\nDTF?\xe7\xf7\x07\xa0e?\xf0\x981\xe7)\xa3CQ\x14\xb0W\x14\xfb|~\x9c\xdf\xe98N\xe7LI\xde\xbc\xcb\x90\xc7n!\xf6z\xbd8\xb9\xd6\x119}\x93\x183\xcej\xea\xb5\x10\xf2\xd8\x97\xb1\xdb\xedA\xfcJ\xc7v\xe2\x15\xbf\xc7wG"\xb4\xd9lEpC.\x97[\x86f\xdb\x8ag\x11\x89k\xb8\xb8\xcb\xe1^\xcbK\xf8?\xb8!\xa7s\x0c\xf1K\x1d\x1b\xc7/\xa6\x84O2\xd8Ofqp\xf6E\xeaV\x0774:\xeaD,\x9dGH}.\tv\xb9\xa1\xe1\xe1\x11\xa8\xe2\xb0v\xa8\x95\x04\xbb\xa2!R\x94!\xa8\x17y\xacD\xb5\x02\xcb\xd1G\xccD\xa2\x08\xee\xc4\x8a\xee\x19\xe1rC48\xa8\xe0H\x84\x8b{\x0f\x12Oh\x1e\xb5\xe3\xe5\xa8\x9b\xac\x904\xcf5b6\xac\x1a\xef$\\n\x88\x1c\x8e\x01\x1c\x9e\xe7\xb1\xb0\xfb\x00\xdb\x92W\xc8\x95\x85\xc8\xa0~\xb2\n\x13\x9b\x11\x12\x0e\tW6d\xb7;d\xe8Z\r\x9aF\xdfP\xc3T5\xcd\x85\x13\x1c\x82\x1b\xb2Z\xedXO\xa4\xd18]\xf3gd\xd0\x12lB4\xf5\x0en\xa8\xbf\xdf\x8a\xb6\x85\xd6\x7f#\xe3\xaew\xad\x07\xbd\xd6>Pgg\x17\xda\xdb;\xcc\xa0\x1f\x14\xbdu[,\xf8\x04*e\x8e;5\xb6\x8b\x00\x00\x00\x00IEND\xaeB`\x82'
NOTE: 4700 is the ID of IDR_BROKENIMAGE defined in
out/Debug/gen/content/app/resources/grit/content_resources.h, which
shows content_resources_100_percent.pak gets included within
chrome_100_percent.pak
BUG=176960
TEST=see test plan above
R=tony@chromium.org
Review URL: https://codereview.chromium.org/521473002
Cr-Commit-Position: refs/heads/master@{#293219}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
And while I'm at it, change the includes to use the qualified path for
the grit generated header file
($gen_dir/content/app/resources/grit/content_resources.h).
BUG=338338
TEST=None
R=avi@chromium.org,jamesr@chromium.org,thestig@chromium.org,tony@chromium.org
TBR=darin@chromium.org
Review URL: https://codereview.chromium.org/486573002
Cr-Commit-Position: refs/heads/master@{#291369}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=401588
TEST=None
R=thestig@chromium.org,thakis@chromium.org
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/480693002
Cr-Commit-Position: refs/heads/master@{#290178}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290178 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
InitSharedInstanceWithLocale().
Both methods do almost the same and just difer on whether or not to load
the common resources (aka chrome pak files!).
BUG=340082
TEST=None
R=tony@chromium.org,lambroslambrou@chromium.org
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/457103003
Cr-Commit-Position: refs/heads/master@{#289435}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We always pass false to it, so we will never load the common resources.
The benefit of doing this is that it allow us to remove a call to LoadCommonResources(), which we are trying to remove.
BUG=176960
TEST=None
R=tony@chromium.org
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/451283002
Cr-Commit-Position: refs/heads/master@{#288978}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288978 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes it possible for the ResourceBundle class to 'see' .pak
files directly embedded in the apk. This enables the webview to directly
mmap the files without extracting them to disk first.
BUG=394502
Review URL: https://codereview.chromium.org/422533004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286324 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Change the android_webview_apk gyp files to include the en-US.pak
file in the apk, which was erroneously missing.
- Add the do_not_compress gyp plumbing to store and zipalign paks in
the apk (only for the android_webview_apk target).
- Stop decompressing pak files in the android webview shell apk.
- Change aw_browser_main_parts.cc to take advantage of the new AwAssets
and DataPack/ResourceBundle *FromRegion methods (mmap from the apk).
- Add temporary workaround which loads always the en-US.pak locale, in
lack of a proper refactoring of i10n_utils and ResourceBundle.
BUG=394502
Review URL: https://codereview.chromium.org/402603006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286258 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is to support a new use case for Android: mmap a pak file
directly from the APK (where it will be stored uncompressed)
without extracting it first. This would save both precious space
on the flash and startup time on the first run.
This CL introduces:
- the necessary changes to base::File to memory map arbitrary
regions of a file.
- The corresponding changes (plus unittests) in DataPack and
ResourceBundle to take advantage of the new support.
At present state, this CL is not intended to introduce any
behavioral change.
BUG=394502
Review URL: https://codereview.chromium.org/394313002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285945 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=178543
TEST=build embedded content shell with chromeos=1 and embedded=1
Review URL: https://codereview.chromium.org/400793002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284759 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is to facilitate overriding UI strings from the variations service.
BUG=370033
Review URL: https://codereview.chromium.org/322523002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282758 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
kPMColor_SkColorType -> kN32_SkColorType
BUG=
Review URL: https://codereview.chromium.org/361643002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280863 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=372212
R=mukai@chromium.org
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/326073005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=372212
R=ananta@chromium.org, sky@chromium.org
Review URL: https://codereview.chromium.org/325773002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275959 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is to ensure that we don't use GDI to query the device scale factor in renderer processes.
This is in preparation for setting the MITIGATION_WIN32K_DISABLE policy on renderer processes, which
will lock them out from making user32/gdi32 calls which enter win32k.sys.
BUG=365160
Review URL: https://codereview.chromium.org/308003020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In order to iOS to find the test data files, we need to copy them into
the device. To do this we need the help of
build/copy_test_data_ios.gypi.
This patch includes it in the ui_unittests target when the platform is
iOS and fix the TODO in data_pack_unittests.
By doing that we were able to ASSERT_TRUE the PathService::Get() call.
BUG=None
TEST=ui_unittests on iOS bots.
R=tony@chromium.org
Review URL: https://codereview.chromium.org/297183005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273398 0039d316-1c4b-4281-b951-d872f2087c98
|