| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
Unfortunately there is an issue with font metrics on the platform that cause some tests to fail. See
crbug.com/154019 for details.
BUG=None
Review URL: https://chromiumcodereview.appspot.com/11038059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162814 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
views::Label control first calculates the size of the text,
and then tries to render the text in the exact size of rectangle.
If < is used instead of <= in the patched line, the control
flows to the BreakIterator mode, that sometimes computes a
larger width value and causes truncation.
BUG=155663
Review URL: https://codereview.chromium.org/11150013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162308 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TEST() macro should be used instead.
TEST=ui_unittests
R=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10808072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
net/base/registry_controlled_domains/ subdirectory.
This includes net/base/registry_controlled_domain.* and net/base/effective_tld_names*
BUG=138047
TEST=covered by existing tests
Review URL: https://chromiumcodereview.appspot.com/10796033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147641 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
For context see this thread:
https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II
TBR=thakis,pkasting,jam
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Trailing whitespace without a \n character is still trimmed away.
Adds additional tests for this.
Also, makes the code use ContainsOnlyWhitespace() from base
and makes the implementation of ContainsOnlyWhitespace()
shorter (based on the code that was in text_elider.cc.)
BUG=126297
TEST=New tests in text_elider_unittest.cc
Review URL: https://chromiumcodereview.appspot.com/10386016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137061 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
build into the right state.
TBR=pfeldman
Review URL: https://chromiumcodereview.appspot.com/9956101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130363 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=114484
TEST=existing filesystem tests don't break
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128753
Review URL: https://chromiumcodereview.appspot.com/7811006
TBR=ericu@google.com
Review URL: https://chromiumcodereview.appspot.com/9950079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130293 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=114484
TEST=existing filesystem tests don't break
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128753
Review URL: https://chromiumcodereview.appspot.com/7811006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130248 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=114484
TEST=existing filesystem tests don't break
Review URL: https://chromiumcodereview.appspot.com/7811006
TBR=ericu@google.com
Review URL: https://chromiumcodereview.appspot.com/9808101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128757 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=114484
TEST=existing filesystem tests don't break
Review URL: https://chromiumcodereview.appspot.com/7811006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NOTE: This CL now only adds eliding functionality, but doesn't use it in the UI just yet.
Refer to bug 113133 for details (refer to comment 22 for a screenshot of the result: http://code.google.com/p/chromium/issues/detail?id=113133#c22).
BUG=113133
TEST=Make sure ui_unittests (ElideEmail and ElideEmailMoreSpace) pass.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126445
Review URL: http://codereview.chromium.org/9489011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127175 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NOTE: This CL now only adds eliding functionality, but doesn't use it in the UI just yet.
Refer to bug 113133 for details (refer to comment 22 for a screenshot of the result: http://code.google.com/p/chromium/issues/detail?id=113133#c22).
BUG=113133
TEST=Make sure ui_unittests (ElideEmail and ElideEmailMoreSpace) pass.
Review URL: http://codereview.chromium.org/9489011
TBR=gab@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9693058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126451 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NOTE: This CL now only adds eliding functionality, but doesn't use it in the UI just yet.
Refer to bug 113133 for details (refer to comment 22 for a screenshot of the result: http://code.google.com/p/chromium/issues/detail?id=113133#c22).
BUG=113133
TEST=Make sure ui_unittests (ElideEmail and ElideEmailMoreSpace) pass.
Review URL: http://codereview.chromium.org/9489011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126445 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:22812
TEST=Open task manager or downloads, and observe KB instead of kB.
Review URL: http://codereview.chromium.org/9490008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124947 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
displayed as '*', was implemented in NativeTextfieldViews
via TextfieldViewsModel::GetVisibleText() (issue 5857002),
but the refactoring into RenderText (issue 7265011) removed
all calls of that method.
I moved the password handling code into RenderText because I
think it's logically a visual style (although RenderText
also contains a lot of model-related stuff right now).
RenderText now has a password property (in earlier patchsets
it was an attribute in StyleRange).
BUG=105054
TEST=unit tests and manual testing of the wifi login dialog
Review URL: https://chromiumcodereview.appspot.com/8747001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This function was only used for the Url eliding tests, so it makes it clearer.
Also fixed a typo.
BUG=
TEST=Make sure ui_unittests still pass.
Review URL: http://codereview.chromium.org/9455074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124201 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
These were brought up during my C++ readability review.
BUG=none
TEST=existing unit tests
Review URL: http://codereview.chromium.org/9226009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117912 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is needed for my upcoming change to use this functionality
in a new CanvasSkia text drawing implementation.
This is exposed as a standalone function in text_elider.h but
implemented using an internal helper class in text_elider.cc.
This is similar to how the existing |ElideRectangleString()|
is implemented.
The new function provides four modes of dealing with long words
when wrapping text which correspond to the different ways the
current implementation of |CanvasSkia::DrawStringInt()| can wrap
text, based on the input flags.
BUG=105550
TEST=New unit tests added to text_elider_unittest.cc
Review URL: http://codereview.chromium.org/8234003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114727 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=107703
TEST=New unit test in text_elider_unittest.cc.
Review URL: http://codereview.chromium.org/8910018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114705 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The new truncate mode is needed by my upcoming changes to
rewrite CanvasSkia::DrawText().
Part of the change is changing the binary search code to a
more traditional form that also makes the truncate mode
work correctly. This is covered by the new unit tests.
BUG=105550
TEST=New and existing tests in text_elider_unittest.cc.
Review URL: http://codereview.chromium.org/8917011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114063 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8690004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=64263
TEST=None
R=willchan@chromium.org
Review URL: http://codereview.chromium.org/8552002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110085 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=101600,94925
TEST=none
Review URL: http://codereview.chromium.org/8475006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108688 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Build
Review URL: http://codereview.chromium.org/8372068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108410 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
having the pass a flag. This will be used on the try bots.
BUG=96753
Review URL: http://codereview.chromium.org/7719007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102017 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fix remaining users to use base/memory/scoped_ptr.h.
BUG=
TEST=
Review URL: http://codereview.chromium.org/7930009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101715 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was r97750, which was reverted at r97756. This patch, in addition to all
the other things it did, marks OwnedWidgetGtk for export and moves it to the
ui:: namespace.
Original list of things this patch does:
- OwnedWidgetGtk now goes in ui/base/gtk/
- TruncateString moved from l10n_util:: to ui::
- GtkIMContextWrapper has part of its code split into chrome/ (IDC using code goes in RenderViewContextMenu) and the rest go in content/ (gtk using code goes with GtkIMContextWrapper).
- gtk_key_bindings_handler[_unittest] now goes in content, as it's a utility class to RenderWidgetHostGtk.
BUG=93804
TEST=existing unit tests
Original Review URL: http://codereview.chromium.org/7669040
Review URL: http://codereview.chromium.org/7708021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97889 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
content/
This also moves some other files:
- OwnedWidgetGtk now goes in ui/base/gtk/
- TruncateString moved from l10n_util:: to ui::
- GtkIMContextWrapper has part of its code split into chrome/ (IDC using code goes in RenderViewContextMenu) and the rest go in content/ (gtk using code goes with GtkIMContextWrapper).
- gtk_key_bindings_handler[_unittest] now goes in content, as it's a utility class to RenderWidgetHostGtk.
BUG=93804
TEST=existing unit tests
Review URL: http://codereview.chromium.org/7669040
TBR=erg@google.com
Review URL: http://codereview.chromium.org/7708017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97756 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This also moves some other files:
- OwnedWidgetGtk now goes in ui/base/gtk/
- TruncateString moved from l10n_util:: to ui::
- GtkIMContextWrapper has part of its code split into chrome/ (IDC using code goes in RenderViewContextMenu) and the rest go in content/ (gtk using code goes with GtkIMContextWrapper).
- gtk_key_bindings_handler[_unittest] now goes in content, as it's a utility class to RenderWidgetHostGtk.
BUG=93804
TEST=existing unit tests
Review URL: http://codereview.chromium.org/7669040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
R=rvargas@chromium.org
Review URL: http://codereview.chromium.org/7569005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95730 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
R=ben@chromium.org
Review URL: http://codereview.chromium.org/7328011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92819 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=72317
TEST=None
R=rsesek@chromium.org, tony@chromium.org
Review URL: http://codereview.chromium.org/7210060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91704 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moved patch to new issue from my google account
BUG=79968
TEST=
Review URL: http://codereview.chromium.org/7253034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=86527
TEST=run in non-English. For European languages, during a download the decimal separators should be commas (e.g. "0,0 MB"). (The speeds are in strings files and might take a little time to run through the translation machinery.)
Review URL: http://codereview.chromium.org/7189076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90092 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
CID=9269,13399,14520
BUG=none
TEST=none
R=vandebo@chromium.org
Review URL: http://codereview.chromium.org/7216031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
uses width of total string instead of sum of widths of substring, addressing subtle kerning/ligature issues.
BUG=8061
TEST=none
Review URL: http://codereview.chromium.org/7064036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86912 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=out/Debug/base_unittests --gtest_filter=BreakIteratorTest.*
R=tsepez@chromium.org,evan@chromium.org
Review URL: http://codereview.chromium.org/7008005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86689 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
R=brettw@chromium.org
Review URL: http://codereview.chromium.org/7034012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85525 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
net/base/escape.h, and net/base/net_util.h, and reduce the API surfaces in various places slightly where possible.
BUG=23581
TEST=none
Review URL: http://codereview.chromium.org/6898026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83948 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=77883
TEST=no code change
Review URL: http://codereview.chromium.org/6756022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79815 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
where we can't trust the window system to behave properly. Even so, only
break long words, assuming that spaces are properly triggering breaks.
BUG=77231
TEST=Goto URL javascript:alert(""It looks like you're in the middle of composing another message. Are you sure you want to continue? This may affect any unsaved drafts."); and ensure no break between "unsaved" and "drafts".
Review URL: http://codereview.chromium.org/6696074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79692 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
raw_scoped_refptr_mismatch_checker.h
ref_counted.cc
ref_counted.h
ref_counted_memory.cc
ref_counted_memory.h
ref_counted_unittest.cc
scoped_callback_factory.h
scoped_comptr_win.h
scoped_handle.h
scoped_native_library.cc
scoped_native_library.h
scoped_native_library_unittest.cc
scoped_nsobject.h
scoped_open_process.h
scoped_ptr.h
scoped_ptr_unittest.cc
scoped_temp_dir.cc
scoped_temp_dir.h
scoped_temp_dir_unittest.cc
scoped_vector.h
singleton.h
singleton_objc.h
singleton_unittest.cc
linked_ptr.h
linked_ptr_unittest.cc
weak_ptr.cc
weak_ptr.h
weak_ptr_unittest.cc
BUG=None
TEST=Compile
Review URL: http://codereview.chromium.org/6714032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=69304
TEST=Make sure the tab titles are displayed as spec'd, and that there isn't any performance issues.
Review URL: http://codereview.chromium.org/6579050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77860 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The last param is for languages, which is already a std::string in
most places.
BUG=23581
Review URL: http://codereview.chromium.org/6627061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=23581
Review URL: http://codereview.chromium.org/6526027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75641 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=71063
TEST=compiled
Review URL: http://codereview.chromium.org/6312156
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
BUG=none
TEST=none
TBR=brettw
Review URL: http://codereview.chromium.org/6257006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71970 0039d316-1c4b-4281-b951-d872f2087c98
|