| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
TBR=kerz@chromium.org
Review URL: http://codereview.chromium.org/7327026
git-svn-id: svn://svn.chromium.org/chrome/branches/742e/src@91909 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/branches/742/src@87560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/branches/742/src@86541 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
browser as part of ChromeFrame. The crash
occurs while casting the GWLP_USERDATA pointer from a window owned by IE to a WidgetWin pointer and
dereferencing it. We arrive at the IE window while enumerating the parents of the ExternalTabContainer window.
BUG=none
TEST=chrome frame tests should not crash
Review URL: http://codereview.chromium.org/7043008
TBR=ananta@chromium.org
Review URL: http://codereview.chromium.org/7039046
git-svn-id: svn://svn.chromium.org/chrome/branches/742/src@85801 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=79358
TEST=Manual.
Review URL: http://codereview.chromium.org/6902179
TBR=dimich@chromium.org
Review URL: http://codereview.chromium.org/6922003
git-svn-id: svn://svn.chromium.org/chrome/branches/742/src@83987 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
fixing
this I'm centralizing how we notify the view of menu showing/hiding.
BUG=80099 80879
TEST=none
R=estade@chromium.org,ben@chromium.org
Review URL: http://codereview.chromium.org/6901075
TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/6889006
git-svn-id: svn://svn.chromium.org/chrome/branches/742/src@83780 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/branches/742/src@82965 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
have caused a perf regression. To verify I'm reverting the following chnages: commit 3a360c6b3d2fc174cb7597d6365cfc5418d1442b r82326 Disable loading high res icons on Mac commit 3c39226937a39d0042b8a794f13505c7a25ca58b r82247 Fix reload button unit test commit f87ab117fc159566868e71e4df5672852bebd718 r82245 Unregister toolbar view from window notifications commit 0b287ba4a4ad5c19d901f973eb9af594dcf3dba1 r82239 Fix failing Mac unit tests commit 8b681c46a139d12151323952c58122f6805d7597 r82236 Mac: Remove custom drawn buttons commit 6ae8a2fe40485731b86267e362936db16b4c0706 r82209 Fix clang build break commit e8a19d1e0c76f204c834318566e4206320583449 r82185 Add support for multi resolution iconsBUG=NoneTEST=ComplingReview URL: http://codereview.chromium.org/6878077
TBR=sail@chromium.org
Review URL: http://codereview.chromium.org/6881114
git-svn-id: svn://svn.chromium.org/chrome/branches/742/src@82542 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I split the IPC up into two parts on Linux--one that reads the image on the UI
thread, and a second part that encodes the image on the file thread before
replying. I've also switched it to send the data over shared memory instead of passing a (potentially) huge blob of data over IPC.
BUG=75237
TEST=Local testing.
Review URL: http://codereview.chromium.org/6871001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82212 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To support HiDPI we need a way to load two copies of icons, a low resolution version and a high resolution version.
To support this, this change does the following:
- split theme_resource.grd into three files:
- theme_resources.grd: icons that only have one resolution
- theme_resources_standard.grd: low resolution icons
- theme_resources_large.grd: high resolution icons
- theme_resource.grd and theme_resources_standard.grd and compiled into chrome.pak/chrome.rc for all platforms.
- theme_resources_large.grd is compiled into theme_resources_large.pak for platforms that want high resolution icons (currently only Mac)
- gfx::Image now support icons with multiple resolution
Currently not all ThemeService APIs return multi-resolution images. Once this is checked in I'll work on converting them as I go.
Note, this change will have to be coordinated with the change to reorganize theme resources. I'll work with saintlou on that.
BUG=75812
TEST=Added a TIFF to theme_resources.grd. Verified that the toolbar icon had a mutliresolution image. Verified that unit tests passed.
Review URL: http://codereview.chromium.org/6849030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82185 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows the PNG compression to be offloaded to another thread as
appropriate.
BUG=75237
TEST=Local testing.
Review URL: http://codereview.chromium.org/6835036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82142 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=ben@chromium.org
Review URL: http://codereview.chromium.org/6880034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82137 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The crash happens if mmap_ is null in DataPack so I just added some
null checks. Some features still won't work (inspector, bookmark
manager, about:net-internals, etc), but we shouldn't crash.
I'm going to write a follow up patch that brings up a dialog asking to reinstall
and check for quarantined files if resources.pak fails to load (kind of like the
dialog that comes up when the history db can't be loaded).
BUG=79252
TEST=covered by app_unittests
Review URL: http://codereview.chromium.org/6835034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82111 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
occurred for two reasons:
. window class name changing out from under us.
. CreateWindow returning NULL because we're out of memory.
I've changed the following:
. Left in CHECK on return from CreateWindow.
. Removed dependency on class name. We don't really need it anyway.
I've also changed View::PaintFocusableBorder to check focusable last,
as that requires looking up the FocusManager
BUG=77651
TEST=none
Review URL: http://codereview.chromium.org/6865023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81812 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=75237
TEST=Local testing.
Review URL: http://codereview.chromium.org/6825064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81809 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:13117
TEST=at login screen show the language list and check that
Chinese(Traditional Han, Hong Kong) is not displayed.
In the current version of third_party/icu/source/data/locale/zh*,
zh_hant_hk, zh_hant_mo, and zh_hans_sg is aliased in addtion to
zh_hans_cn and zh_hant_tw. So this patch adds checks for them
in IsDuplicateName.
The patch fixes another tiny problem related to locale names;
in CheckAndResolveLocale, zh-mk should be zh-mo.
See: http://en.wikipedia.org/wiki/ISO_3166-2:MO (Macau)
http://en.wikipedia.org/wiki/ISO_3166-2:MK (Macedonia)
I'm sorry that the previous patch
http://codereview.chromium.org/6835017/
broke an unittest (which asserts zh-mk is resolved to zh-tw,
but it shouldn't). This new patch includes an adjustment of
the unittest, too.
Review URL: http://codereview.chromium.org/6840045
Patch from Kazuhiro Inaba <kinaba@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81534 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This reverts commit 6060502aa52b752f488f98a800e1f886f3ffd7c1.
TBR=kinaba@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81529 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:13117
TEST=at login screen show the language list and check that
Chinese(Traditional Han, Hong Kong) is not displayed.
In the current version of third_party/icu/source/data/locale/zh*,
zh_hant_hk, zh_hant_mo, and zh_hans_sg is aliased in addtion to
zh_hans_cn and zh_hant_tw. So this patch adds checks for them
in IsDuplicateName.
The patch fixes another tiny problem related to locale names;
in CheckAndResolveLocale, zh-mk should be zh-mo.
Review URL: http://codereview.chromium.org/6835017
Patch from Kazuhiro Inaba <kinaba@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81526 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=75237
TEST=Local HTTP testing with data-transfer-items-image-png.html
Review URL: http://codereview.chromium.org/6824063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81508 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=77651
TEST=none
R=ben@chromium.org
Review URL: http://codereview.chromium.org/6834006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81363 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81351 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81345 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix up all the callers to use the new location and namespace.
Also, delete the stub file since it isn't included by anyone more.
(Note: This was a TODO for brettw).
BUG=None
TEST=None
R=brettw@chromium.org
Review URL: http://codereview.chromium.org/6825055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81303 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a super early first cut of global menu support. It works by creating a GtkMenuBar inside chrome, attaching it to the widget hierarchy and then never showing it. This is sufficient for global menu support to detect the menu, at least on the Natty betas.
There's a lot to do before this is considered done. I haven't added Bookmark and History menus, which will need custom handling to keep state up to date with the main window. Some items may need to be moved from one menu to another to fit with Linux conventions.
Contains a bunch of new strings for global menu support. These need to go in before the M12 branch point. (I can iterate on the design afterwards; strings need translation.)
BUG=30213
TEST=Open a window on Unity. A minimal menu is in the menu bar.
Review URL: http://codereview.chromium.org/6812037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81170 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
reason for crash appears to be because we can't find the WindowWin for
an hwnd.
I'm also removing a comment that is no longer relevant, and nuking a
call in window_win to ui::SetWindowUserData that is already done in
WindowImpl.
BUG=77651
TEST=none
R=ben@chromium.org
Review URL: http://codereview.chromium.org/6825045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81150 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=manual testing
Review URL: http://codereview.chromium.org/6820023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81025 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=75237
TEST=Local testing.
Review URL: http://codereview.chromium.org/6823019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81015 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
also fix some style problems with ActiveWindowWatcherX
BUG=78634
TEST=manual
Review URL: http://codereview.chromium.org/6814006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes multiple test failures on the new Lucid bots, like:
MultiAnimationTest.Basic:
ui/base/animation/multi_animation_unittest.cc:32: Failure
Value of: animation.GetCurrentValue()
Actual: 0.36
Expected: Tween::CalculateValue(Tween::EASE_OUT, .2)
Which is: 0.36
BUG=
TEST=Fix printing_unittests, app_unittests, and gfx_unittests on new Lucid official builder.
Review URL: http://codereview.chromium.org/6811036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch is just a start. When locale changes through the
login screen UI, the fonts in ResourceBundle and
PlatformFontGtk are updated, and the password fields and
username labels are redrawn with the correct font. In the
future, all widgets in the login screen would be redrawn
with the correct font.
When the locale changes upon login, the fonts are updated,
though not all widgets are redrawn correctly yet.
BUG=chromium-os:13450
TEST=manually
Review URL: http://codereview.chromium.org/6788004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80579 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Clean up gfx NativeThemeLinux/Chromeos code to use ResourceBundle.
This should also fix valgrind failures in issue 77712 and 77721.
- Remove no longer needed gfx_module and gfx_resource_provider files.
- Update linux/chromeos test_shell and DumpRenderTree to use
ResourceBundle as well.
BUG=77712,77721
TEST=Build should pass and valgrind failure in issue 77712 and 77721 should be gone.
Review URL: http://codereview.chromium.org/6773021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80319 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6793012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80307 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=77883
TEST=no code change
Review URL: http://codereview.chromium.org/6756022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79815 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
where we can't trust the window system to behave properly. Even so, only
break long words, assuming that spaces are properly triggering breaks.
BUG=77231
TEST=Goto URL javascript:alert(""It looks like you're in the middle of composing another message. Are you sure you want to continue? This may affect any unsaved drafts."); and ensure no break between "unsaved" and "drafts".
Review URL: http://codereview.chromium.org/6696074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79692 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add two gypi files to src/build for the boilerplate added to targets and actions
- Update grit_info to also support the -E flag so it can share more of the grit build commandline
- switch over all but the webkit and webkit glue grd files to use the common support
BUG=22247
TEST=everything still localized correctly
Review URL: http://codereview.chromium.org/6705030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79548 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
raw_scoped_refptr_mismatch_checker.h
ref_counted.cc
ref_counted.h
ref_counted_memory.cc
ref_counted_memory.h
ref_counted_unittest.cc
scoped_callback_factory.h
scoped_comptr_win.h
scoped_handle.h
scoped_native_library.cc
scoped_native_library.h
scoped_native_library_unittest.cc
scoped_nsobject.h
scoped_open_process.h
scoped_ptr.h
scoped_ptr_unittest.cc
scoped_temp_dir.cc
scoped_temp_dir.h
scoped_temp_dir_unittest.cc
scoped_vector.h
singleton.h
singleton_objc.h
singleton_unittest.cc
linked_ptr.h
linked_ptr_unittest.cc
weak_ptr.cc
weak_ptr.h
weak_ptr_unittest.cc
BUG=None
TEST=Compile
Review URL: http://codereview.chromium.org/6714032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Originally, this CL was to add 20+ languages, but I'm scaling down for the branch check-in (M10 and M11) because that requires follow-up changes in ICU and else where and it takes more time than this one-line change.
BUG=62715
TEST=Go to the Preference/settings page - Under the hood - Language settings. Press 'add' button and find Latin American Spanish is shown in the drop-down list.
Review URL: http://codereview.chromium.org/6713022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79420 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=72040
TEST=none
R=erg@chromium.org,estade@chromium.org
Review URL: http://codereview.chromium.org/6719006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79279 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Move ExtractCompositionInfo method in chrome/browser/renderer_host/gtk_im_context_wrapper.cc to ui/base/gtk/gtk_im_context_util.cc
BUG=75003
TEST=none
Review URL: http://codereview.chromium.org/6709023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79214 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=72040
TEST=none
Review URL: http://codereview.chromium.org/6719006
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/6696053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79212 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=72040
TEST=none
Review URL: http://codereview.chromium.org/6719006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=77012
TEST=app_unittests --gtest_filter=TreeNodeModelTest.BasicOperations
R=thestig@chromium.org
Review URL: http://codereview.chromium.org/6717022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79044 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Loads favicons when openning back/forward menu for any urls that don't
have favicons.
BUG=5679
TEST=Restore a tab with a navigation history, check favicons.
Review URL: http://codereview.chromium.org/6708029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79000 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now it uses the same algorithm used in ui/views/view.[cc,h] of RemoveChildView.
R=sky@chromium.org
BUG=None
TEST=out/Debug/app_unittests --gtest_filter=TreeNodeModelTest.*
Review URL: http://codereview.chromium.org/6714034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78953 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Turns out that we need declare both constructor and destructor for
complex class/struct.
BUG=none
TEST=none
TBR=oshima@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78797 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=oshima@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78795 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds following common data types for input method support:
1. struct CompositionUnderline
2. struct Composition
3. enum TextInputType
BUG=75003
TEST=none
Review URL: http://codereview.chromium.org/6711008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78793 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is so it matches with the signature used in View class.
BUG=None
TEST=None
R=sky@chromium.org
Review URL: http://codereview.chromium.org/6683024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78712 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL creates four .gypi files that are included in /ui/ui.gyp. This allows
for a single unittest binary for all the submodules, rather than having
individual unittest binaries for each submodule.
To not break the buildbot, this creates a fake target that copies ui_unittests
to gfx_unittests as temporary scaffolding.
BUG=72317
TEST=gfx_unittests (really ui_unittests) passes
Review URL: http://codereview.chromium.org/6688007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78711 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:10120
TEST=Switch to Russian keyboard layout, try accelerators like ctrl-t, ctrl-w, etc.
Review URL: http://codereview.chromium.org/6674052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78565 0039d316-1c4b-4281-b951-d872f2087c98
|