| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is 2nd try of https://codereview.chromium.org/12093105/
This test verifies that the TextInputType should change expected value when the focused node is changed by JavaScript.
This CL is a pilot change to check interactive_ui_tests can perform text input related testing.
We can't use browser_tests because text input related tests require unique focus and UI interaction.
If this patch works fine, I will introduce more tests to increase test coverage.
Review URL: https://chromiumcodereview.appspot.com/12210011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180964 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Automated clean up of style checker errors that were missed due to the plugin
not being executed on implementation files.
BUG=115047
Review URL: https://chromiumcodereview.appspot.com/12217031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180955 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
iOS doesn't use the Skia image path, so 1x images in the 200 resource
bundles with the magic fallback draw at half size.
This adds matching support on iOS, to scaled fallback images up and
optionally add a visual indication of the fallback.
BUG=None
Review URL: https://chromiumcodereview.appspot.com/11896014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180946 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change depends on https://codereview.chromium.org/12041064/
Introduces a new scale factor for Nexus 7: SCALE_FACTOR_133P.
Uses max available density on Android instead of SCALE_FACTOR_100P.
BUG=172048
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/12084003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180518 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Introduce TextInputBrowsertest.
>
> This test verifies that the TextInputType should change expected value when the focused node is changed by JavaScript.
>
> This CL is a pilot change to check interactive_ui_tests can perform text input related testing.
> We can't use browser_tests because text input related tests require unique focus and UI interaction.
> If this patch works fine, I will introduce more tests to increase test coverage.
>
> BUG=173951
> TEST=try bots
>
> Review URL: https://chromiumcodereview.appspot.com/12093105
TBR=nona@chromium.org
Review URL: https://codereview.chromium.org/12178014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180371 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This test verifies that the TextInputType should change expected value when the focused node is changed by JavaScript.
This CL is a pilot change to check interactive_ui_tests can perform text input related testing.
We can't use browser_tests because text input related tests require unique focus and UI interaction.
If this patch works fine, I will introduce more tests to increase test coverage.
BUG=173951
TEST=try bots
Review URL: https://chromiumcodereview.appspot.com/12093105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180360 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
get rid of GetDisplayLayout(), but that'll have to happen after we
make aura the default (since we still use LAYOUT_TOUCH for metro).
BUG=none
TEST=none
R=ben@chromium.org
Review URL: https://codereview.chromium.org/12089115
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180292 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
This updates headers that forward-declare it and a few random places to use the namespace explicitly. There us a using declaration in file_path.h that makes the rest compile, which we can do in future passes.
Review URL: https://codereview.chromium.org/12163003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/12087091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome://touch-icon URL
This allows Android to use window.devicePixelRatio with chrome://touch-icon
Bug=172048
Test=WebUIUtilTest.ParsePathAndScale
Review URL: https://chromiumcodereview.appspot.com/12041064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179907 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=149881
Review URL: https://chromiumcodereview.appspot.com/11953054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179899 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ibus namespace is temporary introduced for avoiding name collision with libibus.
So it's time to remove ibus namespace because libibus is already gone.
BUG=None
TEST=try bots.
Review URL: https://chromiumcodereview.appspot.com/11783053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179889 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179782 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
Review URL: https://chromiumcodereview.appspot.com/12095038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179734 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ClipboardUtil::GetUrl sets the title, so there is no need to set the
title on if GetUrl is successful.
BUG=172615
TEST=see bug
R=tony@chromium.org,tfarina@chromium.org
Review URL: https://chromiumcodereview.appspot.com/12089073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179691 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Current Chrome does not emit SetCursorLocation message to ibus-daemon because both candidate window and input context is in same process.
It was achieved by injecting IBusClient into ui::InputMethodIBus, but we are now able to bypass them only in chromeos/ directory.
With this refactoring, we can remove ui::internal::IBusClient, IBusChromeOSClientImpl and their injection code.
The concept of this refactoring is...
1) ui::InputMethodIBus should communicate with only chromeos::IBus*.
Do not bypass chromeos::IBus* even if bypassing ibus-daemon.
2) chrome/browser/chromeos/input_method should communicate with only chromeos::IBus*
current code handles SetCursorLocation as special case, but I think it shouldn't consider where the event is come from.
Such special logic should be in chromeos/.
With this patch, we can remove IBusUiController.
BUG=None
TEST=Manually done on lumpy.
Review URL: https://chromiumcodereview.appspot.com/11956008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179644 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Bug=900
Test=Right-click on the tray and select 'Cascade'. Chrome should cascade along with other windows
Review URL: https://chromiumcodereview.appspot.com/11946005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179528 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=172654
TEST=N/A
Review URL: https://chromiumcodereview.appspot.com/12088025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179449 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This has been split out from https://codereview.chromium.org/11881042
BUG=124830
TEST=None
Review URL: https://codereview.chromium.org/12088015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=171609
TEST=building aura_builder
Review URL: https://chromiumcodereview.appspot.com/12042044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178730 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This improves how ChromeOS handles mouse button presses
outside of a context menu. On mouse button presses not
only is the context menu and is message loop exited, but
the event is processed with the same result as if the
context menu had not been present. For example, a window
may be activated, another context menu may be brought up,
a new tab button may be executed, etc. This CL does not
yet handle touch events (separate issue).
The behavior is now more similar to how it works on Windows.
BUG=151074, 162172
TEST=manual
Bring up various context menus, then click various mouse
buttons outside of it.
Review URL: https://chromiumcodereview.appspot.com/11761027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178717 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=148699
Review URL: https://chromiumcodereview.appspot.com/11049026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL is second try of https://codereview.chromium.org/12017010/
Current Chrome does not emit SetCursorLocation message to ibus-daemon because both candidate window and input context is in same process.
It was achieved by injecting IBusClient into ui::InputMethodIBus, but we are now able to bypass them only in chromeos/ directory.
With this refactoring, we can remove ui::internal::IBusClient, IBusChromeOSClientImpl and their injection code.
This patch introduces bypass code for SetCursorLocation, but not used yet.
BUG=None
TEST=Manually done on lumpy.
Review URL: https://chromiumcodereview.appspot.com/12039019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178543 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Text input module used in ChromeOS requires dbus stuff because it communicates with external process(ibus-daemon) with dbus.
Now we have new text input framework based on Chrome Extension, and we have plan to migrate current all legacy ime to it.
The new implementation is no longer requires dbus stuff, so the location should be chromeos/ime rather than chromeos/dbus.
We can omit chromeos/dbus dependency from ui/base/ime once all migration is finished.
BUG=171351
TEST=None
Review URL: https://chromiumcodereview.appspot.com/12036025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178538 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Splits and moves Android's display DeviceInfo from content to gfx;
- Uses DeviceInfo for Android's Screen implementation;
- Uses PrimaryDisplay's scale to figure out favicon scale factor.
BUG=168319
BUG=117839
TEST=manual as in 168319; AwSettingsTest#testUseWideViewportLayoutWidth
Review URL: https://chromiumcodereview.appspot.com/11886074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=170189
TEST=no change
Review URL: https://chromiumcodereview.appspot.com/12052012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178470 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
gfx::ImageSkia::ImageSkia(const SkBitmap&) to gfx::Image::CreateFrom1xBitmap(const SkBitmap&) and gfx::ImageSkia::CreateFrom1xBitmap(const SkBitmap&) respectively
Hopefully these changes will make the constructors / factory methods less confusing and prevent bugs as a result of confusion about what the constructors do.
Review URL: https://chromiumcodereview.appspot.com/11970013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
Review URL: https://codereview.chromium.org/12039032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178309 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
So client code of histogram will see a simpler interface. This also makes adding SparseHistogram to existing metrics framework possible.
This CL depends on https://codereview.chromium.org/11682003/
So please review that one first.
TBR=sky@chromium.org,erikwright@chromium.org
BUG=139612
Review URL: https://chromiumcodereview.appspot.com/11615008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=sky
BUG=160158
Relanding https://codereview.chromium.org/11365160/ in pieces.
Review URL: https://chromiumcodereview.appspot.com/12033023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178201 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
ui\base\window_open_disposition.h. They'll be needed in code that will move to ui\webui.
BUG=169170,132903
Review URL: https://codereview.chromium.org/11896047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178192 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
ui\shell_dialogs.
BUG=170483
Review URL: https://codereview.chromium.org/11926023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178177 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
always."
This reverts commit 190d06bf03d4c310f042396046b2b5b5f7af43cf.
TBR=sky
> ui: Remove gfx::Size::ClampToNonNegative, prevent negative sizes always.
>
> This was added with the intention of using Size as a vector, replacing use of
> IntSize. Since we have Vector2d now, negative sizes should not exist, so clamp
> them in set_width/set_height and the constructor.
>
> Not covered by tests, as we can't test DCHECKs.
>
> TBR=sky
> BUG=160158
> Relanding: https://codereview.chromium.org/11365160/
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175535
Review URL: https://codereview.chromium.org/12049019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178162 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
chrome\app\resources\locale_settings*.grd to ui\base\strings\app_locale_settings.grd.
BUG=169170
TEST=font on webui pages doesn't change
Review URL: https://codereview.chromium.org/12039006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178117 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reduces one more dependency on webkit from chrome.
BUG=146251
R=jam@chromium.org,ben@chromium.org
TBR=darin@chromium.org,tsepez@chromium.org
Review URL: https://codereview.chromium.org/12036003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178082 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Introduce bypass logic for SetCursorLocation message.
>
> Current Chrome does not emit SetCursorLocation message to ibus-daemon because both candidate window and input context is in same process.
> It was achieved by injecting IBusClient into ui::InputMethodIBus, but we are now able to bypass them only in chromeos/ directory.
> With this refactoring, we can remove ui::internal::IBusClient, IBusChromeOSClientImpl and their injection code.
>
> This patch introduces bypass code for SetCursorLocation, but not used yet.
>
> BUG=None
> TEST=Manually done on lumpy.
>
> Review URL: https://chromiumcodereview.appspot.com/12017010
TBR=nona@chromium.org
Review URL: https://codereview.chromium.org/12040015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178000 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Current Chrome does not emit SetCursorLocation message to ibus-daemon because both candidate window and input context is in same process.
It was achieved by injecting IBusClient into ui::InputMethodIBus, but we are now able to bypass them only in chromeos/ directory.
With this refactoring, we can remove ui::internal::IBusClient, IBusChromeOSClientImpl and their injection code.
This patch introduces bypass code for SetCursorLocation, but not used yet.
BUG=None
TEST=Manually done on lumpy.
Review URL: https://chromiumcodereview.appspot.com/12017010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177995 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is preparation for ibus-daemon bypass implementation.
Using interface is same as other modules in chromeos/dbus/ibus.
BUG=None
TEST=Manually done on lumpy and ran chromeos_unittests
Review URL: https://chromiumcodereview.appspot.com/11970032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177894 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With this patch set, Metro Chrome uses dedicated set of
DocumentMgr/Context/TextStore for each TextInputType so that appropriate
InputScope can be associated.
This patch also cleans up the existing code.
BUG=150077
Review URL: https://chromiumcodereview.appspot.com/11871033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I pushed the code there. Additionally the places that tested this or
tried to implement it did so incorrectly.
BUG=none
TEST=none
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/12025003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177763 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(non-Metro) Chrome.
We need SetInputScope API to support InputScope in desktop (non-Metro) Chrome.
This patch set adds a wrapper to this API into TSFInputScope.
This patch set also refactors TSFInputScope.
BUG=150077
Review URL: https://chromiumcodereview.appspot.com/12026009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177671 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The AURA specific changes have been isolated in select_file_dialog_win.cc where we retrieve the
top level window handle from the AURA root window.
As per a discussion with Ben fixed the layering violation where in ui\base was depending on
gfx::NativeView/NativeWindow which led to a layering violation on AURA. This was via ui\base\dialogs
Moved the files out of ui\base\dialogs into a new gypi file shell_dialogs.gypi which lives in ui. It
is included by ui.gyp
The relevant code in chrome browser now depends on the shell_dialogs target created by shell_dialogs.gypi.
The ui/base/dialogs folder will be deleted in a subsequent change. There were problems applying this patch on the
try bots when I added the deletes to this change.
BUG=170483
Review URL: https://codereview.chromium.org/11956031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177533 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=161052
R=miket@chromium.org
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11882036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177296 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=109874
R=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11878022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177238 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
So, move it to c/b/ui/gtk/bookmarks. Where it's more appropriate.
BUG=144783
R=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11827058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177137 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Previous implementation always used |document_manager_for_editable_| to create an instance of ITfContext but it was incorrect. We should use corresponding document manager for each case.
BUG=149136
TEST=Manually tested on Windows 8 with --enable-text-services-framework
Review URL: https://chromiumcodereview.appspot.com/11779010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts r174754 (and the followup r175255) due to it regressing startup speed.
BUG=170189
TEST=no change
Review URL: https://codereview.chromium.org/11947002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177064 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Some |int|s that should be |ptrdiff_t|s.
- Icon structures are packing to known size (same signs).
- GetWindowLong needs to be GetWindowLongPtr to work on 32 & 64.
R=ben@chromium.org, jschuh@chromium.org
BUG=167187, 166496
Review URL: https://chromiumcodereview.appspot.com/11889017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176860 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
on-going composition.
Currently TSFBridgeDelegate::CancelComposition cannot work well against MS-IME 2012 Japanese when it is showing its suggest/candidate window. This patch set fixes such problem.
See the bug page for details.
BUG=169664
TEST=Manually done with --enable-text-services-framework command-line option
Review URL: https://chromiumcodereview.appspot.com/11877010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176627 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's safe if nitems == offset + extension_size, since the code will
touch at most prop[offset + extension_size - 1]. The test has passed
unexpectedly since arraysize() for a string literal will be 1-byte
larger for the ending NULL character.
BUG=141005
TEST=ui_unittests passed with new code
Review URL: https://chromiumcodereview.appspot.com/11876006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176599 0039d316-1c4b-4281-b951-d872f2087c98
|