| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
PendingCreateICRequest is no longer necessary because the libibus dependent code is gone, just state flag is fine.
In addition to this, PendingCreateICRequest cause memory leak if the response from ibus-daemon is lost.
BUG=134717,135049
TEST=ran ui_unittests and manually check on lumpy.
Review URL: https://chromiumcodereview.appspot.com/10834175
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150517 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
single pak files.
This broke Google Chrome Linux builders which are still looking for theme_resources_100_percent.pak.
BUG=139803
TEST=Chrome runs with ui and theme resources correctly loaded.
Review URL: https://chromiumcodereview.appspot.com/10825111
TBR=flackr@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10825234
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150450 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=139803
TEST=Chrome runs with ui and theme resources correctly loaded.
Review URL: https://chromiumcodereview.appspot.com/10825111
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150411 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
for real.
Change in the radius for any of the touch-points changes the bounding box of the points,
but in such cases, we do not want to trigger either scroll or pinch updates.
BUG=none
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10837107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There are 2 kinds of issues to make it failed:
1) pak files are stored in a different directory on Android other
than other platforms.
2) The setting and getting locale is different from Linux, but
similar with ChromiumOS.
BUG=
TEST=run_tests.py -s ui_unittests
Review URL: https://chromiumcodereview.appspot.com/10825007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150261 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chrome uses "id" as the Indonesian language code while Android uses the
deprecated code "in". Similarly for Yiddish. This handles translating
between the two.
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10701179
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150115 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
However, Chrome generates images which are a combination of the toolbar icon from the default theme + a tint.
Added the ability for themes to store hidpi assets in the data pack such that the few hidpi assets which are generated are preserved when a user closes Chrome and reopens it.
Repro steps/steps for testing:
1) Run chrome with --force-device-scale-factor=2
2) Change the theme.
3) Close Chrome and relaunch with --force-device-scale-factor=2
4) Ensure that the toolbar buttons are still hidpi
Test=Manual, see instructions above
Bug=136888
Review URL: https://chromiumcodereview.appspot.com/10783015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150054 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
unfortunate side effect of this leak was that GestureSequence objects hold a pointer to the GR's parent window (helper_) that is no longer valid after the dtor is called. They also hold a callback timer, which fires for a long press...
This CL fixes the crash in issue 139420, but it doesn't fix the full bug. Specifically, the popup menu is still not responding to touch.
BUG=139420
Review URL: https://chromiumcodereview.appspot.com/10826117
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149957 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/125937
TEST=existing
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149888
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149916
Review URL: https://chromiumcodereview.appspot.com/10831137
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149954 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is necessary to support the generation of the correct dblclick event sequence in WebKit.
Remove evil generic_x/generic_y from GestureEventDetails (some event types have data other than floats in that position of the union, this wasn't typesafe).
Adds missing double tap gesture recognizer unit tests.
This makes ET_GESTURE_DOUBLE_TAP pretty pointless now. I've filed crbug.com/140382 to track removing it.
BUG=115486
Review URL: https://chromiumcodereview.appspot.com/10824158
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149935 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/125937
TEST=existing
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149888
Review URL: https://chromiumcodereview.appspot.com/10831137
TBR=beng@google.com
Review URL: https://chromiumcodereview.appspot.com/10827162
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149921 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/125937
TEST=existing
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149888
Review URL: https://chromiumcodereview.appspot.com/10831137
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149916 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/125937
TEST=existing
Review URL: https://chromiumcodereview.appspot.com/10831137
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10830166
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149889 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/125937
TEST=existing
Review URL: https://chromiumcodereview.appspot.com/10831137
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
pak files and native libraries.
This patch adds a new value to the PathService to implement the resource pak override and update the places that load pak files to take advantage of it.
Also adds a function for embedders to set the path to native libraries.
Review URL: https://chromiumcodereview.appspot.com/10802065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149842 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This cl does not support fully surrounding text retrieval, but it is enough to send selection text for reverse conversion.
I will revisit fully SetSurroundingText implementation when it is required.
BUG=127032
TEST=ran content_unittests, ui_unittests, chromeos_unittests
Review URL: https://chromiumcodereview.appspot.com/10823141
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149824 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=125043
Review URL: https://chromiumcodereview.appspot.com/10823067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149775 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
detaching. Without this the hwnd would remain parented so that if
the widget containing the NativeViewHost was destroyed then the
hwnd would get destroyed by virtue of being a child.
Previously we had this logic in NativeTabContentsViewWin (lost in
WebView refactoring), but it seems better to promote to
NativeViewHostWin.
BUG=132090
TEST=none
R=ben@chromium.org,jam@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10832011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149459 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10830101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149456 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=139326
TEST=aura_unittests and views_unittests compile and run
Review URL: https://chromiumcodereview.appspot.com/10824064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149356 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move webkit_resource.grd to be in the same directory as all the resources.
This is consistent with what we do elsewhere, and avoids a limitation of the
new grit support for chrome_scaled_image (it expects 'context' to be a specific
form).
Move all the current images into a default_100_percent sub-directory.
Images were added to their new location separately (due to try/cq limitations
on binary files) here: http://src.chromium.org/viewvc/chrome?view=rev&revision=148389
Add support for the 2x text area resize corner image.
Note that I didn't make the .cur files support multiple resolutions because
.cur files themselves can contain multiple resolutions, and when we support
high-DPI on windows (the only place these are used), we'll probably want to
use multi-resolution .cur files so that the cursor seamlessly changes when
moving between different density screens.
Also fixes the addition of 'hand' cursors to be windows specific (as all the other
cursors are now).
TBR=sky@chromium.org
BUG=134046
TEST=
Review URL: https://chromiumcodereview.appspot.com/10701105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149290 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=139407
TEST=None
Review URL: https://chromiumcodereview.appspot.com/10832055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149112 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The new APIs enable saving of general NSURLs. Strip NSURLs that
aren't isFileURLs.
The old apis are deprecated in the 10.8 sdk.
BUG=139138
TBR=sky
Review URL: https://chromiumcodereview.appspot.com/10829053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148818 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
They payoff for the last month of refactoring: We now use the LinuxUI interface
to generate gtk file selection dialogs from the shim library. We could
theoretically make a Qt or EFL shim and get those desktops' native open
dialogs.
BUG=136909, 134167
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10829021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148813 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Accumulating all the positions of the touch-events of a single touch-point
during its entire lifetime is not very useful. So instead, stop accumulating the
positions when the point leaves the manhattan square.
BUG=139175
TEST=none
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10831043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TEST() macro should be used instead.
TEST=ui_unittests
R=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10808072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CID_COUNT=7
CID=13432,14429,16922,101542,101734,102304,102305
BUG=none
TEST=none
R=tbreisacher
TBR=jam@chromium.org,tommi@chromium.org,ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10830021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148592 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=137676
TEST=compiles
TBR=OWNERS
Review URL: https://chromiumcodereview.appspot.com/10831025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We short circuit emulated mouse events (they are emulated on a touch) so
that these events don't get passed to javascript. The short circuit logic
also short-circuited the mouse capture/release logic, which caused failure
when touch happened during a mouse-capture.
This commit ensures that only the call to ForwardMouseEvent is short-
circuited for emulated events.
BUG=132068
TEST=
Review URL: https://chromiumcodereview.appspot.com/10802085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148547 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The problem is dialog passes file's local cache path in
FileSelected. Last selected directory paths get set to cache
dir, which file manager does not understand, so it opens
default dir. In order to properly remember last selected
dir, we should also pass file's drive path to dialog
listeners and use it to remember last selected dir.
BUG=126923
TEST=manual
Review URL: https://chromiumcodereview.appspot.com/10804026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148492 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CID_COUNT=6
CID=102321,102647,102678,102810,103294,103381
BUG=none
TEST=none
R=tbreisacher@chromium.org
TBR=mirandac@chromium.org, jam@chromium.org,dcheng@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10833013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This moves the gtk and kde implementations to a common directory so a search will get all the code when we need to remove the normal gtk port.
This isn't a pure move. Parts of SelectFileDialogImplKDE had to be rewritten to not use BrowserThread.
BUG=134529
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10790083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148235 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ui_resources_standard.pak => ui_resources_100_percent.pak
ui_resources_2x.pak => ui_resources_200_percent.pak
ui_resources_standard.rc => ui_resources_100_percent.rc
theme_resources_standard.pak => theme_resources_100_percent.pak
theme_resources_2x.pak => theme_resources_200_percent.pak
theme_resources_standard.rc => theme_resources_100_percent.rc
BUG=120185
TEST=run chome,ash_shell confirm assets loaded
Review URL: https://chromiumcodereview.appspot.com/10694170
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148232 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
separate it into Paint, PaintDirect, and PaintIndirect (formerly
PaintToNonPlatformCanvas).
Force "known problematic UI elements" to go through the
PaintIndirect path to fix-up their alpha values. This list
includes scrollbars in Windows XP or Windows Vista+ with
the Windows Classic theme enabled.
BUG=131588, 133881, 24524
TEST=
Review URL: https://chromiumcodereview.appspot.com/10807023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148215 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also stop supporting non-square widgets, no other browser seems to do this and it exposes bugs in web pages.
This is re-landing r147887 (reverted in r147899 due to breaking WebKit pixel tests).
Temporarily suppresses the WebKit pixel test failures. I've reviewed each by hand to make sure the only change is what we expect with this style change. The baseline will be updated (and these expectations reverted) with the next WebKit roll.
TBR=sky@chromium.org (identical to r147887 already reviewed)
BUG=125773
TEST=A bunch of WebKit pixel tests
Review URL: https://chromiumcodereview.appspot.com/10805068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148161 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Bug=None
Test=Compiles on Mac and CrOS
R=oshima,sky
TBR=sadrul,sail
Review URL: https://chromiumcodereview.appspot.com/10701063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148123 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Message loop captured in constructor is not the UI loop. Get a UI message loop
proxy in the ExecuteParams constructor and use that instead.
BUG=138087
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10815057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147976 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The bounding box is the smallest axis-aligned rectangle that encloses all the
bounding-boxes of all the touch-points in the gesture.
BUG=none
TEST=existing aura_unittests
Review URL: https://chromiumcodereview.appspot.com/10808083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reverting because composite_unittests were failing on Linux (aura) and Linux ChromeOS Tests bots.
Bug=None
Test=Compiles on Mac and CrOS
R=oshima,sky
TBR=sadrul,sail
Review URL: https://chromiumcodereview.appspot.com/10701063
TBR=pkotwicz@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10790128
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Bug=None
Test=Compiles on Mac and CrOS
R=oshima,sky
TBR=sadrul,sail
Review URL: https://chromiumcodereview.appspot.com/10701063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147915 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=138544
TEST=manually
Review URL: https://chromiumcodereview.appspot.com/10790123
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147912 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Broke WebKit layout tests, will update and reland.
Also stop supporting non-square widgets, no other browser seems to do this and
it exposes bugs in web pages.
BUG=125773
TEST=
Review URL: https://chromiumcodereview.appspot.com/10796071
TBR=rbyers@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10810060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147899 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also stop supporting non-square widgets, no other browser seems to do this and
it exposes bugs in web pages.
BUG=125773
TEST=
Review URL: https://chromiumcodereview.appspot.com/10796071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Notable changes:
* Expose GestureEventDetails::touch_points for all kinds of gestures (instead of just BEGIN/END). This makes it possible to count when 3-finger swipes vs 4/4-finger swipes separately.
* Instead of using poorly-defined param_first/param_second when constructing a GestureEvent, use better-defined GestureEventDetails.
BUG=121179
TEST=covered by existing tests
Review URL: https://chromiumcodereview.appspot.com/10816008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147855 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Step 2: https://bugs.webkit.org/show_bug.cgi?id=91654
Step 3: Add compile asserts in render_widget.cc for new enum values.
Review URL: https://chromiumcodereview.appspot.com/10809019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147759 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Prefer forward declarations in header files, and instead include the singleton.h
in the source file.
R=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10795024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147660 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
net/base/registry_controlled_domains/ subdirectory.
This includes net/base/registry_controlled_domain.* and net/base/effective_tld_names*
BUG=138047
TEST=covered by existing tests
Review URL: https://chromiumcodereview.appspot.com/10796033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147641 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=134529
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10804013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147508 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes ScopedVector's clear() method destroy the
elements before clearing the internal vector, matching the
behavior of the erase() method. I'm moving clear()'s
previous element-preserving behavior into a new weak_clear()
method, matching weak_erase().
I'm also removing ScopedVector::reset(), as it duplicated
clear()'s new behavior and isn't a part of std::vector.
BUG=137909
TEST=added
Review URL: https://chromiumcodereview.appspot.com/10797017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147360 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bug=None
Test=Manual, see below.
Run Chrome with --force-device-scale-factor=2
Go to google.com and download web page.
When download is completed, drag download item. Make sure that the text shown while dragging is not blurry.
Review URL: https://chromiumcodereview.appspot.com/10785036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147294 0039d316-1c4b-4281-b951-d872f2087c98
|