| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also only shutdown initialized services in ChromeBrowserMainParts to reduce warning spam.
BUG=159854
For chrome/browser:
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11332005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166769 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The ResourceBundle unittests previously failed on iOS because they expected a
locale.pak file to exist in the bundle for English-US, and no such locale.pak
file existed. Fix this problem by extending the
ui_strings.gyp:ui_unittest_strings target, which solves a similar problem for
other platforms, to solve this problem for iOS as well.
Review URL: https://chromiumcodereview.appspot.com/11361126
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166544 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome_200_percent.pak appears to only be built on chromeos. Each time a
process is spawned, several lines related to failing to load this data pak are
printed. #ifdefing it out stops the console sapm.
BUG=142661
Review URL: https://codereview.chromium.org/11362122
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Instead move the only function from there to event_utils.h
R=ben@chromium.org,sadrul@chromium.org
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/11360118
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=159725
Test=valgrind stops complaining
R=oshima
TBR=sail
Review URL: https://chromiumcodereview.appspot.com/11293138
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166402 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some Thai input requires surrounding text feature.
This patch implement full-spec surrounding text feature for ibus.
BUG=158111
TEST=Ran ui_unittests and manually done on lumpy.
Review URL: https://chromiumcodereview.appspot.com/11275148
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166383 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=114755
Review URL: https://chromiumcodereview.appspot.com/11368072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166278 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
environment. Theres a bit of cruft here, I'm hoping that'll be cleaned
up once we standardize on the one true menu.
BUG=none
TEST=none
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11363092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166266 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A linear multiplier from measured finger velocity to fling velocity did not
feel particularly satisfying. This CL changes this linear multiplier to a
cubic function of the absolute velocity.
BUG=141653
Review URL: https://chromiumcodereview.appspot.com/11361047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166216 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch fixes broken alt+(shift)+tab accelerator handling. In some situations pressing this accelerator did not invoke switching windows. This patch fixes that issue and significantly simplifies nonrepeative accelerators handling. Moreover, from now adding new nonrepeative accelerators will be very easy.
TEST=Open more than two windows, press alt+tab, release alt first then release tab. Press alt+tab again.
BUG=158213
Review URL: https://chromiumcodereview.appspot.com/11344008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
Test=ResourceBundleTest.*
Review URL: https://chromiumcodereview.appspot.com/11358014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166134 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11362078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166059 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
-Wheel, r-click and l-click now discriminated
-More efficient, clean mouse event handling
Note; wheel event not properly handled. That is a bigger CL
that will come later.
BUG=151718
TEST= right click and left click
Review URL: https://codereview.chromium.org/11312025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166034 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=159355
Review URL: https://chromiumcodereview.appspot.com/11275144
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165957 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
Review URL: https://codereview.chromium.org/11367084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
Review URL: https://chromiumcodereview.appspot.com/11358072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165927 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
Review URL: https://codereview.chromium.org/11364062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165877 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL introduces GetMaxScaleFactor in layout.h and uses it for determining the
resolution of thumbnails.
Original CL: http://codereview.chromium.org/11264025/
This CL is slightly modified to sort the supported scale factors.
BUG=155065
TEST=updated LayoutTest
Review URL: https://chromiumcodereview.appspot.com/11367064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165797 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NativeScrollBarWrapper::GetHorizontalScrollBarHeight() was called.
Required handling scrollbar NativeThemeWin::GetWindowsPart() and NativeThemeWin::GetWindowsState().
BUG=159149
TEST=Aura desktop no longer crashes after opening a few windows and fooling around (couldn't actually find exact repro steps for the original failure -- had something to do with any window needing to know the size of scrollbars which happens in various scenarios).
Review URL: https://chromiumcodereview.appspot.com/11368052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165765 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This clean up CL contains:
1. Rename TSF acronym from Tsf to TSF based on 11141019.
2. Use STDMETHOD_ instead of STDMETHODIMP suggested on 11235023.
3. Use override comment suggested on 11235023
BUG=None
TBR=mark@chromium.org
TEST=checked on Windows 8 and try bots
Review URL: https://chromiumcodereview.appspot.com/11341036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165700 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
default NativeTheme be NativeThemeWin under aura. Apparently a couple
of places (scrollbars for one) are using some types only defined in
NativeThemeAura. This patch goes back to defaulting to NativeThemeAura
on win-aura.
TBR to get win_aura green again.
BUG=none
TEST=none
TBR=ben@chromium.org
R=ben@chromium.org
Review URL: https://codereview.chromium.org/11362061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165690 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On tmz.com, pressing escape to exit fullscreen Flash would cause the currently playing movie to close.
The problem was that the fullscreen window was closing on a key down event and the key up event was going to the parent site.
My fix is to suppress the key up event on the parent view.
BUG=155492
Review URL: https://chromiumcodereview.appspot.com/11188027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165615 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
tap after long press.
BUG=114755
Review URL: https://chromiumcodereview.appspot.com/11365020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165603 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
bit is in DesktopRootWindowHostWin that decides when to use the native
or aura versions.
BUG=none
TEST=none
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11367041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165585 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This moves the flash clipboard interface to the new pepper proxy. It also adds support for copying/pasting data of custom data formats (which is needed for flash).
BUG=154497
TEST=Added new pepper tests
Review URL: https://chromiumcodereview.appspot.com/11225021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165548 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
this as win on aura uses PlatformCanvasSkia, which is not backed by an HBITMAP.
BUG=none
TEST=none
R=asvitkine@chromium.org,ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11365043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165540 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- DesktopRootWindowHostLinux should use DesktopCursorClient now that
the client sets the platform cursor correctly.
- Remove weird hack that was clearing the shared, X11 cursor cache. There
can be multiple CursorLoaderX11 objects, and if one of them frees the
other's cursors, you'll get a BadCursor crash the next time an X11
command is processed on that window. Nonlocal crashes suck.
BUG=none
Review URL: https://chromiumcodereview.appspot.com/11363023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165537 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This removes a lot of necessary reference to SCALE_FACTOR_NONE, and eliminate layout.h
I'll cleanup ContentClient in separate CL.
BUG=156569
TEST=none. no functional change.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=165444
Review URL: https://chromiumcodereview.appspot.com/11341003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165500 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
please review everything,
sky: Please review the changes to ui and chrome\browser.
We need to send character events to the RenderViewHost class in addition to the KeyDown/Keyup events
for this to work.
To achieve this we register the character received event on the Windows 8 CoreWindow class and send the
character info via a new IPC message MetroViewerHostMsg_Character.
The chrome side handling for this message is performed in the MockInputMethod::DispatchFabricatedKeyEvent
function where we dispatch the message to the focused TextInputClient.
While working on this I also noticed that we were not sending the event flags like shift/alt/Ctrl, etc to
Chrome from the Metro code. Added support for that. This ensures that we are able to select text in the edit
fields on the page and the omnibox, etc.
The above changes will most likely not work with IME's. Will look into that in a subsequent change.
BUG=158637
R=cpu,sky
Review URL: https://codereview.chromium.org/11348053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165496 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
There are two other CLs on the Chrome-OS side.
One is at https://gerrit.chromium.org/gerrit/#/c/36597/ and
the other is internal.
BUG=126735
TEST=Start ChromeOS in zh-CN or zh-TW and make sure that the UI font is sans-serif.
Review URL: https://codereview.chromium.org/11029040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165458 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=oshima@chromium.org
BUG=none
TEST=none
Review URL: https://codereview.chromium.org/11360041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165445 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This removes a lot of necessary reference to SCALE_FACTOR_NONE, and eliminate layout.h
I'll cleanup ContentClient in separate CL.
BUG=156569
TEST=none. no functional change.
Review URL: https://chromiumcodereview.appspot.com/11341003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
See http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium/handling-a-failing-test
and https://groups.google.com/a/chromium.org/d/topic/chromium-dev/_OwJ_GWfOaY/discussion
BUG=none
Review URL: https://codereview.chromium.org/11293028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165415 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=154291
TEST=None
Review URL: https://chromiumcodereview.appspot.com/11361009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Tabs are now draggable into a window.
- You can no longer drag with the right mouse button.
- We now create an invisible window over the screen while dragging a
tab. Previously, if you moved your mouse cursor quickly, you could
end up with your cursor outside the window you were dragging and
this broke tab dragging.
BUG=125106
Review URL: https://chromiumcodereview.appspot.com/11364013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165335 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
state to per object state.
R=ben@chromium.org
BUG=none
Review URL: https://chromiumcodereview.appspot.com/11367017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165305 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The EventDispatcher interface is not acually used for dispatching events yet.
That will happen once RootView is turned into an EventDispatcher. But this first
step prepares scroll, touch, and gesture event dispatching in views so that it
is compatible with the EventDispatcher interface.
BUG=none
Review URL: https://codereview.chromium.org/11364015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165288 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously Point served two purposes, to be a position in 2d space, and also
an offset from the origin. This introduces a Vector2d class to represent an
offset, allowing typesafety checks for geometric operations.
The following are now the case:
Point +/- Vector = Point
- A point plus/minus an offset gives you a point at a position offset by the
vector.
Vector +/- Vector = Vector
- Two offsets can be added together to make a new offset.
Point - Point = Vector
- Subtracting one point from another gives you the offset between the two
points.
We add some new methods to perform these operations:
Rect::OffsetFromOrigin() gives the offset between the position of the rect
and the origin.
Point::OffsetFromOrigin() gives the offset between the point and the origin.
PointAtOffsetFromOrigin(Vector2d) converts a Vector2d to a Point at the given
offset away from the origin.
Rect::Offset(), Point::Add(), and Point::Subtract() now receive a Vector2d
instead of a point.
BUG=147395
R=sky
Review URL: https://codereview.chromium.org/11269022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165198 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Point3F::AsPoint() method converts from float to integer by doing an
implicit floor() on the values. Instead, we should have AsPointF() return
floating point values, and use the ToFlooredPoint() conversion method to
explicitly floor the values at the call-site if desired.
Also, move the point3.h header to point3_f.h so that it is consistent with
other geometry header file namings.
BUG=147395
R=sky
Review URL: https://chromiumcodereview.appspot.com/11301043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Stop event processing if the event target is invalidated or deleted during
processing of a list of events.
BUG=158332
TEST=added to ui_unittests:EventDispatcherTest
Review URL: https://chromiumcodereview.appspot.com/11339052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165045 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=154934
Review URL: https://chromiumcodereview.appspot.com/11346033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164985 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL is dependent on http://codereview.chromium.org/11189099/
This will complete the migration of the message center code from Ash to UI so that it can be used on other Views platforms.
BUG=150872
Review URL: https://chromiumcodereview.appspot.com/11229022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
dispatching an event.
BUG=158351
Review URL: https://codereview.chromium.org/11342018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164846 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This makes it easier to merge with both removing ModelChanged http://codereview.chromium.org/10928119/ and passing DownloadItem to OnDownloadStarted http://codereview.chromium.org/11068027/
Review URL: https://chromiumcodereview.appspot.com/11029059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164833 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=158389
Review URL: https://chromiumcodereview.appspot.com/11348014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164810 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Incremental page search does not work due to TSF unawareness of NativeTextField.
I introduced the same approach used in Omnibox (http://crrev.com/163233).
BUG=157702
TEST=Manually done on Windows 8
Review URL: https://chromiumcodereview.appspot.com/11305002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164667 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Introduce WaitUntilReceivedGesture to make sure the timing-dependant gestures
(e.g. long-press) are tested properly. Also, fix a case of calling a virtual
function from the GestureSequence constructor.
BUG=157596
Review URL: https://codereview.chromium.org/11348003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164658 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I will rename all acronym from Tsf to TSF in the next change.
BUG=156867
TEST=Manually done on Win8
Review URL: https://chromiumcodereview.appspot.com/11235023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=157981
TEST=None
Review URL: https://codereview.chromium.org/11274063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164399 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
iOS looks for Brazilian Portuguese under pt, not pt-BR. Remap the grd
output from pt-BR to pt on iOS so that it ends up in the right place.
BUG=None
Review URL: https://chromiumcodereview.appspot.com/11276003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164312 0039d316-1c4b-4281-b951-d872f2087c98
|