summaryrefslogtreecommitdiffstats
path: root/ui/base
Commit message (Collapse)AuthorAgeFilesLines
* Revert 120005 - Enabled pressing TAB to traverse through the Omnibox ↵kinuko@chromium.org2012-02-012-4/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | results, removed moving the caret to the end of the line with TAB, and filtered out redundant URLs. This adds the ability to move through Omnibox result matches using TAB in addition to the arrow keys. To enable this, pressing TAB to move the caret to the end of the line was removed and the keyword hint/shortcut logic has been modified. The Omnibox popup now shows keyword markers on the right side of matches that have associated keywords (represented by a right arrow). When this kind of match is selected, and the keyword is accepted, the match changes appearance by animating in the associated keyword match from the right to display the "Search X for <>" message. If multiple matches have the same keyword then only the most relevant match will display the keyword marker and hint. Pressing TAB while a keyword hint is shown will enter keyword mode in place; the results will no longer change when keyword mode is entered. Additionally, substituting keyword provider matches will only be shown if a keyword substitution is available. Finally, results with redundant destination URLs (e.g., "foo.com", "www.foo.com") will have the less relevant URLs filtered out. This also addresses some GTK omnibox browsertest flakiness; see bug 112041. Contributed by aaron.randolph@gmail.com BUG=57748,76278,77662,80934,84420 TEST=Press TAB to move the selection down the list of results, SHIFT+TAB to move up. Review URL: http://codereview.chromium.org/6731036 TBR=aaron.randolph@gmail.com Review URL: https://chromiumcodereview.appspot.com/9310017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120018 0039d316-1c4b-4281-b951-d872f2087c98
* Enabled pressing TAB to traverse through the Omnibox results, removed moving ↵aaron.randolph@gmail.com2012-02-012-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | the caret to the end of the line with TAB, and filtered out redundant URLs. This adds the ability to move through Omnibox result matches using TAB in addition to the arrow keys. To enable this, pressing TAB to move the caret to the end of the line was removed and the keyword hint/shortcut logic has been modified. The Omnibox popup now shows keyword markers on the right side of matches that have associated keywords (represented by a right arrow). When this kind of match is selected, and the keyword is accepted, the match changes appearance by animating in the associated keyword match from the right to display the "Search X for <>" message. If multiple matches have the same keyword then only the most relevant match will display the keyword marker and hint. Pressing TAB while a keyword hint is shown will enter keyword mode in place; the results will no longer change when keyword mode is entered. Additionally, substituting keyword provider matches will only be shown if a keyword substitution is available. Finally, results with redundant destination URLs (e.g., "foo.com", "www.foo.com") will have the less relevant URLs filtered out. This also addresses some GTK omnibox browsertest flakiness; see bug 112041. Contributed by aaron.randolph@gmail.com BUG=57748,76278,77662,80934,84420 TEST=Press TAB to move the selection down the list of results, SHIFT+TAB to move up. Review URL: http://codereview.chromium.org/6731036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120005 0039d316-1c4b-4281-b951-d872f2087c98
* Remove cygwin dependency, no longer required.scottmg@google.com2012-01-301-5/+0
| | | | | | | | | | No longer necessary because cygwin set up is now done in gclient runhooks, rather than every build. BUG=111731 Review URL: https://chromiumcodereview.appspot.com/9301011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119768 0039d316-1c4b-4281-b951-d872f2087c98
* content: Modfiy ResourceBundle and content_shell to run with alternative pak ↵erg@chromium.org2012-01-282-4/+5
| | | | | | | | | | | | files. BUG=111326 R=jam TBR=sky,tony,ajwong,ananta Review URL: http://codereview.chromium.org/9232060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119566 0039d316-1c4b-4281-b951-d872f2087c98
* Add Malay as a translation.tony@chromium.org2012-01-284-7/+12
| | | | | | | | | | | | The language code is ms. This adds the necessary files to generate the locale pak file. Translations will arrive later. BUG=111670 TBR=gfeher Review URL: http://codereview.chromium.org/9232056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119548 0039d316-1c4b-4281-b951-d872f2087c98
* aura: Add event queues in the GestureRecognizer.sadrul@chromium.org2012-01-261-1/+3
| | | | | | | | | | | | | | | | | Event-queues allow the GestureRecognizer to maintain multiple states for different gestures. Especially, this makes it possible to correctly process queued up (asynchronous) touch-events at the same time it processes synchronous touch-events. Throttling/filtering touch-events that go to the renderer is now removed. This may be added back at a later time. BUG=110230 TEST=none (will be added in a future CL: http://codereview.chromium.org/9129012/) Review URL: https://chromiumcodereview.appspot.com/9150046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119278 0039d316-1c4b-4281-b951-d872f2087c98
* Transition to base/mac/bundle_locations.h step 3jeremy@chromium.org2012-01-251-2/+3
| | | | | | | | | | | | Convert some instances of [NSBundle mainBundle] to equivalent calls in base/mac/bundle_locations.h BUG=None TEST=Code should compile and all unit tests should pass. Review URL: http://codereview.chromium.org/9240004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119030 0039d316-1c4b-4281-b951-d872f2087c98
* Do not send a key press/release event to ibus-daemon when xkb IME is in use.yusukes@chromium.org2012-01-256-1/+28
| | | | | | | | | | | In that case, sending the event to the daemon is unnecessary since 1) xkb IME always returns 'not consume the key' and 2) Chrome itself can perform dead key composition. BUG=chromium-os:25273 TEST=ran ui_unittest Review URL: http://codereview.chromium.org/9235006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119012 0039d316-1c4b-4281-b951-d872f2087c98
* Updating XTBs based on .GRDs from branch 963kerz@chromium.org2012-01-251-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118969 0039d316-1c4b-4281-b951-d872f2087c98
* Do not send an IBus IPC message for updating a cursor location.yusukes@chromium.org2012-01-242-5/+3
| | | | | | | | | | | | Currently, every time the location of the input cursor in Chrome changes, ui::InputMethodIBus sends an IPC message to ibus-daemon by calling ibus_input_context_set_cursor_location API so that the IME candidate window could be shown in a proper position. However, the IPC is actually unnecessary since the candidate window is shown by the Chrome browser process itself. Instead of the IPC, we should update member variables in chromeos::input_method::IBusUiControllerImpl. BUG=chromium-os:25332 TEST=try Review URL: http://codereview.chromium.org/9241033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118851 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Fix uninitialized member variables.kmadhusu@chromium.org2012-01-241-1/+2
| | | | | | | | | | CID=102647, 102333, 102332, 102303, 102302, 102299, 102297, 102296, 102048, 102032, 102031, 102030, 102029, 102028, 102010, 101681, 101657, 101655, 101438 BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/9005031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118848 0039d316-1c4b-4281-b951-d872f2087c98
* Aura: apply UI font list to cros.xji@chromium.org2012-01-241-1/+1
| | | | | | | | | | | | | | | | | | - change IDS_UI_FONT_FAMILY_CROS back to 12px in default. - GetDefaultFont() in platform_font_pango.cc returns IDS_UI_FONT_FAMILY_CROS for Aura Chrome OS. - views::NativeTextfieldViews::UpdateFont() applies the size from the passed-in font on Chrome OS - OmniboxViewViews requests a larger font size. - Correspondingly, decrease OmniboxViewViews's vertical margin so that the display area has greater height to accommodate larger font size. BUG=103860, 109961 TEST=visual on omnibox and popup, bookmark bubble, findbar, and omnibox in popup. Review URL: http://codereview.chromium.org/9192018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118802 0039d316-1c4b-4281-b951-d872f2087c98
* Change class -> struct to avoid compile error in clang.mukai@chromium.org2012-01-211-1/+1
| | | | | | | | | | BUG=110851 TEST=build succeeded locally Review URL: http://codereview.chromium.org/9141003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118623 0039d316-1c4b-4281-b951-d872f2087c98
* Reland "aura/chromeos: Avoid suspending while video is playing."derat@chromium.org2012-01-192-0/+45
| | | | | | | | | | | | | | | | | | | | This reverts r118199, which was a revert of r118171. aura::VideoPropertyWriter (not ash::VideoDetector -- made a typo in the revert's description) was outliving the ash::Shell singleton. Now we explicitly destroy the VideoPropertyWriter before the shell. The only differences from r118171 are the addition of the final chunk in chrome_browser_main_chromeos.cc and a change to reparent a window in VideoDetectorTest.WindowNotVisible needed in response to r118259. BUG=110114 TEST=avoided missing DCHECK on shutdown in trybot logs this time Review URL: http://codereview.chromium.org/9254018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118375 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up uses of static data around singletons.rsesek@chromium.org2012-01-191-2/+5
| | | | | | | | | | | | This is in preparation for destroying singletons between each test. BUG=110594 TEST=Test suites. Review URL: http://codereview.chromium.org/9255020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118320 0039d316-1c4b-4281-b951-d872f2087c98
* Transition to base/mac/bundle_locations.h step 2jeremy@chromium.org2012-01-191-6/+7
| | | | | | | | | | | Remove MainAppBundle() in favor of FrameworkBundle() and update all callsites + code comments. BUG=None TEST=Code should compile and all unit tests should pass. Review URL: https://chromiumcodereview.appspot.com/9220005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118293 0039d316-1c4b-4281-b951-d872f2087c98
* Aura Shell needs to exist on Macdhollowa@chromium.org2012-01-194-15/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Adds first cut at "Aura Shell.app" on Mac. The 'ash_shell' is extended to generate a Cocoa application. This application brings up a single window containing the Aura desktop. The main view of this window provides an accelerated surface to Aura in which it can composite and draw its results. What works: - The application launches and renders the Aura desktop and background - Mouse movement, clicking, double-clicking, and interactions with Aura windows and widgets - Text buttons render with Skia text (needs improvement) - Non-modal transient window button - Window-modal window button - System-modal window button - Example Widgets button (checkboxes, radios, buttons) - Lock Screen button - Create Non-Resizable window button - Create Pointy Bubble button - Create Widow button - Switcher and Taskbar What doesn't work: - Open Views Examples Window button - Views menus - Views scrollbars - Views accelerators - Views tooltips - Drag and drop - Anything involving MessageLoop dispatcher logic - Mouse movement doesn't pass through to Aura when mouse button is up Note: Required .gyp flags are: 'use_aura': 1, 'use_webkit_compositor': 1, BUG=109946 TEST=Manual tests. R=sky@chromium.org, thakis@chromium.org Review URL: https://chromiumcodereview.appspot.com/9232028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118222 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "aura/chromeos: Avoid suspending while video is playing."derat@chromium.org2012-01-192-45/+0
| | | | | | | | | | | | | This reverts r118171. There's an issue in the destruction order of ash::VideoDetector vs. ash::Shell. BUG=110114 TEST=built it TBR=apatrick Review URL: https://chromiumcodereview.appspot.com/9232037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118199 0039d316-1c4b-4281-b951-d872f2087c98
* aura/chromeos: Avoid suspending while video is playing.derat@chromium.org2012-01-182-0/+45
| | | | | | | | | | | | | | | | | | | This adds an ash::VideoDetector class that watches for layer updates and attempts to detect the playback of video. A Chrome OS-specific observer updates a _CHROME_VIDEO_TIME property on the X root window, which is used by the power manager to defer screen dimming or other power management features. This matches the implementation currently in use on Chrome OS, with Chrome taking the X window manager's role for detecting video and setting the property. BUG=110114 TEST=added; also manually checked that the property is updated Review URL: http://codereview.chromium.org/9249004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118171 0039d316-1c4b-4281-b951-d872f2087c98
* Do not map XK_Meta_L/R to VKEY_L/RWIN.yusukes@chromium.org2012-01-181-4/+2
| | | | | | | | | | | BUG=110361 BUG=110129 TEST=try Review URL: http://codereview.chromium.org/9241002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118103 0039d316-1c4b-4281-b951-d872f2087c98
* Add a comment to InitXKeyEventForTesting. No code change.yusukes@chromium.org2012-01-181-1/+2
| | | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/9240003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118066 0039d316-1c4b-4281-b951-d872f2087c98
* ui::EF_ALT_DOWN is missing from XKeyEventStateyusukes@chromium.org2012-01-181-0/+1
| | | | | | | | | | BUG=None TEST=try Review URL: http://codereview.chromium.org/9243004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118040 0039d316-1c4b-4281-b951-d872f2087c98
* Implement Native EventTimeFromNative on Macdhollowa@chromium.org2012-01-171-1/+7
| | | | | | | | | | | | | Implements Mac version of new |EventTimeFromNative| function. Introduced in r117907 on other platforms. BUG=109946 TEST=Manual testing with Aura Shell on Mac R=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/9242019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117978 0039d316-1c4b-4281-b951-d872f2087c98
* Tracking ctrl, shift, alt and caps lock state information for floating touchbshe@chromium.org2012-01-171-2/+71
| | | | | | | | | | | | | | | devices. BUG=106426 TEST=Build chrome with Aura=1 -> Launch browser in a touch sreen -> verify if the touch sreen is a floating device -> ctrl + m to open file manager in chrome -> holding ctrl key and tap -> verify if you can select multiple files. Review URL: http://codereview.chromium.org/8994006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117958 0039d316-1c4b-4281-b951-d872f2087c98
* Some style cleanups for text_elider.asvitkine@chromium.org2012-01-173-176/+197
| | | | | | | | | | | These were brought up during my C++ readability review. BUG=none TEST=existing unit tests Review URL: http://codereview.chromium.org/9226009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117912 0039d316-1c4b-4281-b951-d872f2087c98
* Use times from the initiation of events to determine whether twodavemoore@chromium.org2012-01-173-43/+146
| | | | | | | | | | | | | successive clicks should be considered a double click. Also implements triple click for web content in aura. BUG=None TEST=aura_unittests::EventTest.* Review URL: https://chromiumcodereview.appspot.com/9133013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117907 0039d316-1c4b-4281-b951-d872f2087c98
* Initial views touchui Gesture Recognizer supportvollick@google.com2012-01-171-1/+19
| | | | | | | | | | | | | This is just a merge of Gajen's patch (http://codereview.chromium.org/8364039/) with ToT. BUG=101645 TEST=views_unittest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117869 Review URL: https://chromiumcodereview.appspot.com/9076002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117894 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 117869 - Initial views touchui Gesture Recognizer supportvollick@google.com2012-01-171-19/+1
| | | | | | | | | | | | | | | This is just a merge of Gajen's patch (http://codereview.chromium.org/8364039/) with ToT. BUG=101645 TEST=views_unittest Review URL: http://codereview.chromium.org/9076002 TBR=vollick@chromium.org Review URL: https://chromiumcodereview.appspot.com/9231013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117870 0039d316-1c4b-4281-b951-d872f2087c98
* Initial views touchui Gesture Recognizer supportvollick@chromium.org2012-01-171-1/+19
| | | | | | | | | | | | This is just a merge of Gajen's patch (http://codereview.chromium.org/8364039/) with ToT. BUG=101645 TEST=views_unittest Review URL: http://codereview.chromium.org/9076002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117869 0039d316-1c4b-4281-b951-d872f2087c98
* Support custom data formats for dragging on Windows.dcheng@chromium.org2012-01-143-31/+62
| | | | | | | | | BUG=31037 TEST=manual Review URL: http://codereview.chromium.org/9185040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117805 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Clipboard::IsFormatAvailable on GTK so that the workaround for broken ↵dcheng@chromium.org2012-01-141-30/+25
| | | | | | | | | | | | | | | | apps actually works Some apps don't properly set the TARGETS they support. In that case, we assume text. However, the logic for that was after the logic for checking TARGETS, so it was never hit. BUG=30372 TEST=manual test using xcb Review URL: http://codereview.chromium.org/9168039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117759 0039d316-1c4b-4281-b951-d872f2087c98
* Implement off-the-spot mode for Aura-IBus IME.kinaba@chromium.org2012-01-1413-12/+63
| | | | | | | | | | | When a PPAPI plugin does not support drawing composition text by themselves, the browser is expected to do it instead. This patch is for implementing it for Aura IME. BUG=97189 TEST=Manually tested on ppapi_example_ime. Review URL: http://codereview.chromium.org/9199004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117751 0039d316-1c4b-4281-b951-d872f2087c98
* Remove false warnings on startup.yusukes@chromium.org2012-01-131-1/+23
| | | | | | | | | | BUG=109843 TEST=build Chrome for Linux, start Chrome, confirm no keysym warning is shown. Review URL: http://codereview.chromium.org/9185004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117614 0039d316-1c4b-4281-b951-d872f2087c98
* Don't build the general ResourceBundle::GetLocaleFilePath for Android either.peter@chromium.org2012-01-121-1/+1
| | | | | | | | | | BUG= TEST= Review URL: http://codereview.chromium.org/9197001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117470 0039d316-1c4b-4281-b951-d872f2087c98
* Add ui/base/ime/ime.gypi.yusukes@chromium.org2012-01-122-0/+93
| | | | | | | | | | | BUG=chromium-os:24780 TEST=ran try bots by $ for i in linux_chromeos_aura win_aura linux_chromeos linux win linux_shared win_shared cros_aura cros_x86 ; do git try -b $i -c ; done TEST=built ui, ui_unittests, and chrome locally from scratch on Goobuntu with and without chromeos=1/aura=1 by $ for i in 0 1 ; do for j in 0 1 ; do export GYP_DEFINES="chromeos=$i use_aura=$j" ; ( gclient runhooks && rm -rf out/ && make ui && rm -rf out/ && make ui_unittests && out/Debug/ui_unittests --gtest_filter='*IBus*' && out/Debug/ui_unittests --gtest_filter='*Compose*' && rm -rf out/ && make chrome ) || break 2; done ; done Review URL: http://codereview.chromium.org/9155004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117392 0039d316-1c4b-4281-b951-d872f2087c98
* Remove almost all remaining TOUCH_UIs.bryeung@chromium.org2012-01-111-1/+1
| | | | | | | | | | TEST=ran tests BUG=105046 Review URL: http://codereview.chromium.org/9078005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117291 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: More GSEALing.erg@chromium.org2012-01-111-0/+4
| | | | | | | | | | BUG=79722 TEST=none Review URL: http://codereview.chromium.org/9147044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117267 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Seal up GSEALs, focusing on GtkSelectionData.erg@chromium.org2012-01-105-22/+41
| | | | | | | | | | BUG=79722 TEST=compiles First Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116956 Review URL: http://codereview.chromium.org/9151007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117070 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 116956 - GTK: Seal up GSEALs, focusing on GtkSelectionData.erg@google.com2012-01-104-37/+22
| | | | | | | | | | | | | BUG=79722 TEST=compiles Review URL: http://codereview.chromium.org/9151007 TBR=erg@chromium.org Review URL: http://codereview.chromium.org/9167002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116977 0039d316-1c4b-4281-b951-d872f2087c98
* On FreeBSD we can't access the shared memory after it was marked forrobert.nagy@gmail.com2012-01-091-0/+18
| | | | | | | | | | | | | | | | | | deletion, unless this behaviour is explicitly enabled by the user. This behaviour can be enabled with the kern.ipc.shm_allow_removed sysctl variable which is set to 0 by default. In case it's not enabled we disable shm support. This is not an issue on OpenBSD because we are allowing this by default to follow what Linux does because most people will expect that. BUG= TEST= Review URL: http://codereview.chromium.org/8910016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116959 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Seal up GSEALs, focusing on GtkSelectionData.erg@chromium.org2012-01-094-22/+37
| | | | | | | | | | BUG=79722 TEST=compiles Review URL: http://codereview.chromium.org/9151007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116956 0039d316-1c4b-4281-b951-d872f2087c98
* Protect access to locale resources with a lock.derat@chromium.org2012-01-094-37/+42
| | | | | | | | | | | | | | | In the case of Chrome OS, locale resources can be reloaded. We've seen crashes in testing code that suggest that this is happening while the resources are being accessed from another thread. BUG=chromium-os:11102,chromium-os:19204 TEST=none TBR=glotov,arv Review URL: http://codereview.chromium.org/9124031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116939 0039d316-1c4b-4281-b951-d872f2087c98
* aura: refactor clipboard code and implement format conversion and basicvarunjain@chromium.org2012-01-091-84/+343
| | | | | | | | | | | | versioning. BUG=97845 TEST=clipboard unittests pass. Review URL: http://codereview.chromium.org/9120009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116918 0039d316-1c4b-4281-b951-d872f2087c98
* In default X11 error handler, do not post task to message loop if there is ↵apatrick@chromium.org2012-01-061-3/+12
| | | | | | | | | | | | | | | no message loop. There might not be a message loop if the X11 error happens early in initialization. This is the case for GLX initialization in the GPU process. If there is no message loop, a simple error is logged containing the serial, error code, request code and minor code. The purpose of posting a task to the message loop is to output a more descriptive error, involving calling various X11 functions such as XGetErrorText, which cannot be called in the error handler itself becasue of reentrancy issues. BUG=109180 Review URL: http://codereview.chromium.org/9114014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116713 0039d316-1c4b-4281-b951-d872f2087c98
* [aura] touch move's location is not window's coordinates in ubuntu 11.10.msw@chromium.org2012-01-061-1/+10
| | | | | | | | | BUG=107203 TEST=manually Review URL: http://codereview.chromium.org/8923003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116680 0039d316-1c4b-4281-b951-d872f2087c98
* Write unit tests for ui::InputMethodIBus.yusukes@chromium.org2012-01-0610-250/+1367
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since the IME binding will be used in production soon, I'd like to add unit tests for the class to prevent future regressions. ibus_client.h - Define ui::IBusClient interface which abstracts ibus IPC and makes it possible to remove ibus function calls from ui::InputMethodIBus. ibus_client_impl.cc ibus_client_impl.h - A very thin wrapper around ibus which implements ui::IBusClient. libibus-dependent parts in ui::InputMethodIBus are moved to this class. input_method_ibus.cc - Removed all ibus related code. It uses ui::IBusClient interface instead to communicate with ibus-daemon. - Now the class is testable since it does not communicate with ibus-daemon directly, and can compile on build bots where HAVE_IBUS is not #defined. input_method_ibus_unittest.cc - The test. mock_ibus_client.cc mock_ibus_client.h - A dummy IBusClient implementation for the test. The dummy implementation requires neither ibus-daemon nor ibus header files. composition_text.h composition_underline.h - Add operator== and operator!=. ui.gyp - Compile mock_ibus_client, character_composer and input_method_ibus when use_aura==1 and use_x11==1. Note that these files do not depend on ibus. - Compile ibus_client_impl when use_aura==1 and use_ibus==1. ui_unittests.gypi - Compile character_composer_unittest and input_method_ibus_unittest when use_aura==1 and use_x11==1. The test does not depend on ibus. BUG=108172 TEST=ran linux_chromeos_aura bot Review URL: http://codereview.chromium.org/9005006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116654 0039d316-1c4b-4281-b951-d872f2087c98
* Makes Widget modality a 3-state type rather than a boolean.ben@chromium.org2012-01-061-1/+9
| | | | | | | | | | | | | There are actually two types of modality that the WM might care about - window modality and system modality. See the definitions of these in ui/base/ui_base_types.h. This is a precursor to adding support for window modality to Ash. Right now we only do system modality which is undesirable for almost all cases of window modality. http://crbug.com/109290 TEST=none Review URL: http://codereview.chromium.org/9109035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116644 0039d316-1c4b-4281-b951-d872f2087c98
* Settings button not switching visibility on enter/leave on panels in Aura.prasadt@chromium.org2012-01-052-2/+12
| | | | | | | | | | BUG=109222 TEST=Follow steps in bug report. Review URL: http://codereview.chromium.org/9115001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116563 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Make the minimal required GTK version in Google Chrome builds 2.18.thestig@chromium.org2012-01-051-6/+6
| | | | | | | | | BUG=106689 TEST=Official builders go green. TBR=erg,cmp Review URL: http://codereview.chromium.org/9108017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116534 0039d316-1c4b-4281-b951-d872f2087c98
* cleanup: Use IsTextInputTypeNone() in OnInputMethodChanged().yusukes@chromium.org2012-01-052-4/+4
| | | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/8986010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116461 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-18 19:48:23 +0000