| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=450703
R=mukai@chromium.org
Review URL: https://codereview.chromium.org/866403006
Cr-Commit-Position: refs/heads/master@{#313156}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently we trigger network connect failure notifications when a call
from ui::NetworkConnect::ConnectToNetwork() fails.
The problem with this approach is that connect calls from elsewhere
(e.g. through the networkingPrivate API) will not trigger notifications.
This CL makes NetworkStateNotifier a NetworkConnectionObserver and
triggers the failure notification on ConnectFailed events instead of the
NetworkConnect failure callback so that other failures will also
generate notifications.
This does not affect spawining of new UI (e.g. network configuration UI)
on failure (when appropriate) since that is expected to be handled by any
new UI that uses the networkingPrivate API.
BUG=434112
Review URL: https://codereview.chromium.org/762633002
Cr-Commit-Position: refs/heads/master@{#312879}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL move the test target from build/config/BUILDCONFIG.gn to testing/test.gni
It also update the test template to automatically build an apk on Android.
R=cjhopman@chromium.org,brettw@chromium.org
Review URL: https://codereview.chromium.org/824263004
Cr-Commit-Position: refs/heads/master@{#312396}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add missing dependencies that caused build failures with this flag.
(I did similar changes in the BUILD.gn files too, but blindly.)
BUG=371125
R=derat@chromium.org, thestig@chromium.org
TBR=antrim, bshe, thestig, timvolodine
Review URL: https://codereview.chromium.org/857353004
Cr-Commit-Position: refs/heads/master@{#312280}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.
This patch was automatically generated with a ChromeOS build using a
variation of https://codereview.chromium.org/598073004.
BUG=417463
R=avi@chromium.org
Review URL: https://codereview.chromium.org/853073002
Cr-Commit-Position: refs/heads/master@{#311759}
|
|
|
|
|
|
|
|
|
| |
BUG=None
R=jamescook@chromium.org
Review URL: https://codereview.chromium.org/817983004
Cr-Commit-Position: refs/heads/master@{#311569}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adopt shill's kSecurityClassProperty, in place of shill's
kSecurityProperty. This eliminates the need for Chrome to understand
the equivalence of WPA and RSN networks.
This CL introduces only one functional change. Namely,
NetworkState::GetSpecifier will now collapse WPA and RSN networks into
one class (by virtue of using kSecurityClassProperty). The previous
behavior is considered a bug.
After this CL, only WifiAccessPointInfoProviderChromeOs still uses
kSecurityProperty. In that one case, we want to break out WPA and RSN
networks, to understand what fraction of systems are connecting
through older APs.
While there: remove a couple of unused files in chromeos/test/data/network/policy/.
BUG=chromium:440032
TEST=ManagedNetworkConfigurationHandlerTest.*
TEST=ONC*
Review URL: https://codereview.chromium.org/788633003
Cr-Commit-Position: refs/heads/master@{#310840}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move UserActivityDetector and UserActivityObserver out of
ui/wm/core/ so that other classes in ui/base/ can depend on
them. This is needed in order to be able to later move
chrome/browser/idle_chromeos.cc out of chrome/ so that the
chrome.idle API can eventually be moved to extensions/.
BUG=446320
Review URL: https://codereview.chromium.org/833893003
Cr-Commit-Position: refs/heads/master@{#310773}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL does the following:
* Cleans up some redundant code in the network UI.
* Disassociates Network UI updates from dbus calls and limits the
frequency of UI updates by using a timer to trigger updates.
* Adds NET_LOG_IF_SLOW to device_event_log.h to log slow network events.
Note: I also did virtual/override cleanup while in there and ran clang format on the changed files.
Original CL (reverted):
https://codereview.chromium.org/811623002
BUG=441650
Review URL: https://codereview.chromium.org/800893003
Cr-Commit-Position: refs/heads/master@{#310659}
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=gn gen --args='os="chromeos"' out_gn/Debug
R=jamescook@chromium.org
Review URL: https://codereview.chromium.org/833043002
Cr-Commit-Position: refs/heads/master@{#310211}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously when the GestureProviderAura ignored a touch event for some
reason, the TouchExplorationController would ack it anyways, resulting
in some failing CHECKs.
BUG=442773
Review URL: https://codereview.chromium.org/824473005
Cr-Commit-Position: refs/heads/master@{#309952}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The geometry headers were moved from /ui/gfx/ to ui/gfx/geometry, so
we are updating the include paths to fix this.
BUG=395370
TEST=compiles
TBR=sky@chromium.org,danakj@chromium.org
Review URL: https://codereview.chromium.org/832953002
Cr-Commit-Position: refs/heads/master@{#309873}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The geometry headers were moved from /ui/gfx/ to ui/gfx/geometry, so
we are updating the include paths to fix this.
BUG=395370
TEST=compiles
TBR=sky@chromium.org,danakj@chromium.org
Review URL: https://codereview.chromium.org/823133004
Cr-Commit-Position: refs/heads/master@{#309814}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the text eliding may happen, views::Label needs to check whether
it needs to elide the text or not, which computes the same text
rendering twice.
Because IME candidate UI has the logic to keep the enough space
to show the text, this logic is simply unnecessary and the computation
causes some slow down in case the text contains time-consuming
factors such like emoji.
BUG=442180
R=shuchen@chromium.org, nona@chromium.org
TEST=on peppy, chrome://tracing. Rendering an emoji character is
decreased about half (~160 msec -> ~75 msec)
Review URL: https://codereview.chromium.org/799013003
Cr-Commit-Position: refs/heads/master@{#309136}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 9cfc3f8f868ec7c38f1e5025554c0caf837750a5.
A number of interactive_ui_tests where broken by this change:
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/53716
BUG=
TBR=satorux@chromium.org,oshima@chromium.org,stevenjb@chromium.org
Review URL: https://codereview.chromium.org/815023002
Cr-Commit-Position: refs/heads/master@{#309111}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL does the following:
* Cleans up some redundant code in the network UI.
* Disassociates Network UI updates from dbus calls and limits the
frequency of UI updates by using a timer to trigger updates.
* Adds NET_LOG_IF_SLOW to device_event_log.h to log slow network events.
Note: I also did virtual/override cleanup while in there and ran clang format on the changed files.
BUG=441650
Review URL: https://codereview.chromium.org/811623002
Cr-Commit-Position: refs/heads/master@{#309083}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Provide generic desktop and mobile gesture configurations, in addition
to the native platform configuration. This will allow devtools touch
emulation to more faithfully emulate a particular device.
Note that this change involved decoupling the TouchEventQueue from
platform-specific slop region constants, afforded by a WebTouchEvent
flag indicating whether the event may cause scrolling as a default
action.
BUG=425586
Review URL: https://codereview.chromium.org/679633005
Cr-Commit-Position: refs/heads/master@{#308429}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This enables eager gesture recognition on Aura for the unified gesture
detector.
The previous attempt at enabling eager gesture recognition
(crrev.com/393953012) failed.
See crbug.com/408594 for details.
See https://codereview.chromium.org/551373006/ for some additional history.
BUG=332418
TEST=GestureRecognizerTest.{*,EagerGestureDetection}
Also manually tested on Cros and Windows.
Review URL: https://codereview.chromium.org/680413006
Cr-Commit-Position: refs/heads/master@{#307548}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #18 id:340001 of https://codereview.chromium.org/727143002/)"
This reverts commit 857735b6255938981bf2dec4aee80e7bc6523631.
This is the 2nd attempt of cl https://codereview.chromium.org/727143002,
which broke build of Linux ChromiumOS GN.
This cl removes the entries of mock_component_extension_ime_manager_delegate.{cc|h}
in chromeos/ime/BUILD.gn file which should fix the problem.
TBR=stevenjb@chromium.org,pkasting@chromium.org,sky@chromium.org,mukai@chromium.org,derat@chromium.org
BUG=431863
TEST=Verified on linux_chromeos.
Review URL: https://codereview.chromium.org/765833002
Cr-Commit-Position: refs/heads/master@{#306002}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
#18 id:340001 of https://codereview.chromium.org/727143002/)
Reason for revert:
fails to compile on Linux ChromiumOS GN
clang: error: no such file or directory: '../../chromeos/ime/mock_component_extension_ime_manager_delegate.cc'
Original issue's description:
> Moves code from chromeos/ime to ui/base/ime/chromeos.
>
> This is because the code under chromeos/ime has inappropriate dependencies to src/ui.
> This cl doesn't include any logic changes in code, and only contains changes of moving files, changing includes, and necessary changes in GYPs and build rules.
>
> Note:
> 1) the input_methods.txt & gen_input_methods.py remain unchanged because auto-test requires input_methods.txt file to be available, and input_method_whitelist needs the generated input_methods.h for compile. It could be moved in later CLs.
> 2) We've been discussing the naming for ui/chromeos/ime, which could be renamed to something for "views". It can be done in a separated cl.
>
> TBR=sky@chromium.org
> BUG=431863
> TEST=Verified on linux_chromeos.
>
> Committed: https://crrev.com/9917a3671cafa9d31a071a530b9ce10ce0661bc9
> Cr-Commit-Position: refs/heads/master@{#305964}
TBR=yukishiino@chromium.org,stevenjb@chromium.org,sky@chromium.org,mukai@chromium.org,pkasting@chromium.org,derat@chromium.org,shuchen@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=431863
Review URL: https://codereview.chromium.org/750353004
Cr-Commit-Position: refs/heads/master@{#305965}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is because the code under chromeos/ime has inappropriate dependencies to src/ui.
This cl doesn't include any logic changes in code, and only contains changes of moving files, changing includes, and necessary changes in GYPs and build rules.
Note:
1) the input_methods.txt & gen_input_methods.py remain unchanged because auto-test requires input_methods.txt file to be available, and input_method_whitelist needs the generated input_methods.h for compile. It could be moved in later CLs.
2) We've been discussing the naming for ui/chromeos/ime, which could be renamed to something for "views". It can be done in a separated cl.
TBR=sky@chromium.org
BUG=431863
TEST=Verified on linux_chromeos.
Review URL: https://codereview.chromium.org/727143002
Cr-Commit-Position: refs/heads/master@{#305964}
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=432538
TEST=None
R=skuhne,phajdan.jr,oshima,thestig
TBR=sky (For reverting changes to ui/base added in https://codereview.chromium.org/680383008/)
Review URL: https://codereview.chromium.org/738513002
Cr-Commit-Position: refs/heads/master@{#304825}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bots and everything else should be now using ui_base_unittests.
BUG=331829, 373148, 299841, 103304
TEST=None
R=sky@chromium.org,thestig@chromium.org,maruel@chromium.org
Review URL: https://codereview.chromium.org/731883002
Cr-Commit-Position: refs/heads/master@{#304615}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
following events occur:
ConfigurationCreated
ConfigurationRemoved
PropertiesSet
ConfigurationProfileChanged
BUG=427638
For athena/system/network_selector.cc:
TBR=oshima@chromium.org
Review URL: https://codereview.chromium.org/679323002
Cr-Commit-Position: refs/heads/master@{#304523}
|
|
|
|
|
|
|
|
|
|
|
|
| |
to compile Athena without compiling Ash
BUG=426561
TEST=None
R=oshima, shuchen, sky
Review URL: https://codereview.chromium.org/680383008
Cr-Commit-Position: refs/heads/master@{#304271}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL:
- Moves the constants in magnifier_constants.h and accessibility_delegate.h
to ui/chromeos/accessibility_types.
- Stops compiling MagnificationManager on Athena
BUG=426561, 408733
TEST=None
Review URL: https://codereview.chromium.org/682943002
Cr-Commit-Position: refs/heads/master@{#302218}
|
|
|
|
|
|
|
|
|
|
|
| |
Original CL: Review URL: https://codereview.chromium.org/686503002
BUG=425996
TBR=oshima, sadrul, tbarzic
Review URL: https://codereview.chromium.org/690943003
Cr-Commit-Position: refs/heads/master@{#302142}
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit c49ac404f05590cd8834c5fe3db7915c02af6910.
TBR=stevenjb@chromium.org
BUG=
Review URL: https://codereview.chromium.org/693493003
Cr-Commit-Position: refs/heads/master@{#302096}
|
|
|
|
|
|
|
|
| |
BUG=425996
Review URL: https://codereview.chromium.org/686503002
Cr-Commit-Position: refs/heads/master@{#302092}
|
|
|
|
|
|
| |
This reverts commit 4056c3244391cbd2103e402ceaf557924d452783.
Cr-Commit-Position: refs/heads/master@{#301641}
|
|
|
|
|
|
|
|
|
|
| |
BUG=426561
TEST=None
R=oshima@chromium.org
Review URL: https://codereview.chromium.org/678633002
Cr-Commit-Position: refs/heads/master@{#301640}
|
|
|
|
|
|
|
|
|
| |
R=cmasone@chromium.org
BUG=424337
Review URL: https://codereview.chromium.org/652893004
Cr-Commit-Position: refs/heads/master@{#300863}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Otherwise component build causes linker errors.
BUG=None
R=oshima@chromium.org
TEST=manually
Review URL: https://codereview.chromium.org/656153002
Cr-Commit-Position: refs/heads/master@{#299947}
|
|
|
|
|
|
|
|
|
|
|
| |
alternatives.
BUG=none
TEST=none
Review URL: https://codereview.chromium.org/634683004
Cr-Commit-Position: refs/heads/master@{#298947}
|
|
|
|
|
|
|
|
| |
BUG=417463
Review URL: https://codereview.chromium.org/623293004
Cr-Commit-Position: refs/heads/master@{#298839}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This causes a warning with some compiler flag.
BUG=None
R=oshima@chromium.org
TEST=None
Review URL: https://codereview.chromium.org/623843003
Cr-Commit-Position: refs/heads/master@{#298147}
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
R=cmasone@chromium.org, sky@chromium.org, oshima@chromium.org
TEST=manually
Review URL: https://codereview.chromium.org/618123002
Cr-Commit-Position: refs/heads/master@{#297558}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
[20526:20526:0815/151613:1174431576:FATAL:touch_exploration_controller.cc(763)] Check failed: false. tap timer fired in unrecognized state: CORNER_PASSTHROUGH
#0 0x7f485532361e base::debug::StackTrace::StackTrace()
#1 0x7f48553ba882 logging::LogMessage::~LogMessage()
#2 0x7f485314bcfc ui::TouchExplorationController::OnTapTimerFired()
#3 0x7f485314af2b ui::TouchExplorationController::RewriteEvent()
#4 0x7f48531c89a6 ui::EventSource::SendEventToProcessor()
#5 0x0000005f6bc0 ui::EventSourceTestApi::SendEventToProcessor()
#6 0x0000005f396f ui::test::EventGenerator::DoDispatchEvent()
#7 0x0000005f1480 ui::test::EventGenerator::Dispatch()
#8 0x00000051a1a5 ui::TouchExplorationTest::AssertCornerPassthroughWorking()
#9 0x0000005153fb ui::TouchExplorationTest_ActivateLeftCornerPassthrough_Test::TestBody()
#10 0x0000005a49f3 testing::internal::HandleSehExceptionsInMethodIfSupported\u003C>()
#11 0x00000059005e testing::internal::HandleExceptionsInMethodIfSupported\u003C>()
#12 0x000000583ed5 testing::Test::Run()
#13 0x0000005845db testing::TestInfo::Run()
In ActivateLeftCornerPassthrough, ActivateRightCornerPassthrough, and SingleTapLongPress tests.
> Modified state flow for touch explore released in touch_exploration_controller.
>
> Now when performing single tap, the tap timer to begin one finger passthrough is not started. This problem originally arose because touch explore released state and single tap released state are treated similarly in the code, but one finger passthrough should be a state reachable only from single tap released.
>
> Another state change is that if the user presses in single tap/touch explore released and there is no previous touch exploration location, the user is redirected to the wait state.
>
> TEST=TouchExplorationTest.SingleTapLongPress
> BUG=402544
>
> Review URL: https://codereview.chromium.org/465543003
TBR=evy@chromium.org
Review URL: https://codereview.chromium.org/483443002
Cr-Commit-Position: refs/heads/master@{#290092}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290092 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now when performing single tap, the tap timer to begin one finger passthrough is not started. This problem originally arose because touch explore released state and single tap released state are treated similarly in the code, but one finger passthrough should be a state reachable only from single tap released.
Another state change is that if the user presses in single tap/touch explore released and there is no previous touch exploration location, the user is redirected to the wait state.
TEST=TouchExplorationTest.SingleTapLongPress
BUG=402544
Review URL: https://codereview.chromium.org/465543003
Cr-Commit-Position: refs/heads/master@{#290001}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290001 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now if the user leaves a generous slop with either finger during split tap, the press is cancelled.
TEST= TouchExplorationTest.SplitTapLeavesSlop
BUG= 401222
Review URL: https://codereview.chromium.org/447903002
Cr-Commit-Position: refs/heads/master@{#289845}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289845 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
controller is on.
If the user presses and holds the bottom right or left
corner of the screen past a time delay, an earcon will
sound, and then any subsequent fingers added onto the
screen will send touch events as normal (passed through)
as long as one finger is at a corner of the screen. Once
the finger on the corner of the screen has lifted, then
nothing will happen until all the fingers on the screen
have been lifted.
UPDATE: Added earcons (short sound notifications) to
indicate to the user if they have moved their finger off
the screen or onto the screen or if they are in passthrough.
BUG=396310
Review URL: https://codereview.chromium.org/410783002
Cr-Commit-Position: refs/heads/master@{#289468}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Two fingers: up is go to top, down is read from here, left is browser back, right is browser forward.
Three fingers: up and down map to page up/down.
Four fingers: up is home page, down is refresh.
Three/four finger left/right mappings to be added to the CL soon!
BUG=387304
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288857
Review URL: https://codereview.chromium.org/429633002
Cr-Commit-Position: refs/heads/master@{#289334}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289334 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
If spoken feedback is reading and a user performs a two
finger tap anywhere on the screen, it will silence spoken feedback.
BUG= 399380
Review URL: https://codereview.chromium.org/420073003
Cr-Commit-Position: refs/heads/master@{#289035}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/429633002/)
Reason for revert:
tree-closer ui_unittests failing on Linux Chromium OS ASan LSan Tests (3)
test TouchExplorationTest.AllFingerPermutations
failing since
http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%283%29/builds/2708
I don't think the failing test itself is generating output, but
there are some LOG(INFO)s that have been snuck through
with the VLOG(0) trick which might help diagnose.
Original issue's description:
> Added multi-finger gestures to touch_exploration_controller
>
> Two fingers: up is go to top, down is read from here, left is browser back, right is browser forward.
> Three fingers: up and down map to page up/down.
> Four fingers: up is home page, down is refresh.
>
> Three/four finger left/right mappings to be added to the CL soon!
>
> NOTRY=true (failing android dbg tests - this is not related to Android)
> BUG=387304
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288857
TBR=dmazzoni@chromium.org,aboxhall@chromium.org,mfomitchev@chromium.org,lisayin@chromium.org,evy@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=387304
Review URL: https://codereview.chromium.org/466653002
Cr-Commit-Position: refs/heads/master@{#288914}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288914 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Two fingers: up is go to top, down is read from here, left is browser back, right is browser forward.
Three fingers: up and down map to page up/down.
Four fingers: up is home page, down is refresh.
Three/four finger left/right mappings to be added to the CL soon!
NOTRY=true (failing android dbg tests - this is not related to Android)
BUG=387304
Review URL: https://codereview.chromium.org/429633002
Cr-Commit-Position: refs/heads/master@{#288857}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/459553002
Cr-Commit-Position: refs/heads/master@{#288567}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288567 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously landed here:
https://codereview.chromium.org/428673002/
Reverted here:
https://codereview.chromium.org/428643008/
due to failures on the asan bots.
BUG=398106
Review URL: https://codereview.chromium.org/422233007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286397 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The widget allows selecting a network to connect to. It also has basic support
for connecting to password protected networks.
BUG=387199
R=derat@chromium.org, oshima@chromium.org
Review URL: https://codereview.chromium.org/425783003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286142 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
detection. (https://codereview.chromium.org/428673002/)
Reason for revert:
The "TouchExplorationTest.RewritesEventsWhenOn" test failing on "Linux Chromium OS ASan LSan Tests (2)": http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%282%29/builds/2152
Original issue's description:
> Fix Touch Exploration tests so they don't break eager gesture detection.
>
> Eager gesture detection is a little bit stricter about requiring
> a valid event stream. The touch exploration tests give the
> gesture detector an invalid event stream in a few places.
>
> BUG=398106
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285983
TBR=dmazzoni@chromium.org,lisayin@chromium.org,mfomitchev@chromium.org,tdresser@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=398106
Review URL: https://codereview.chromium.org/428643008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286104 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Passthrough is now one finger only and can be triggered by double tapping and holding with a single finger.
TEST=TouchExplorationTest.DoubleTapPassthrough
BUG=388520
Review URL: https://codereview.chromium.org/394883009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286093 0039d316-1c4b-4281-b951-d872f2087c98
|