| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ash::DisplayController was still depending on Display::kInvalidDisplayID
in a way that emitted static initializers. Just initialize it to -1;
DisplayController::DisplayController() still sets the value during its
constructor.
Remove one more instance of <iostream>. I was confused by the output
because there were actually two different files called debug_utils.cc in
the ash build which weren't in the normal linux build which both were
including <iostream>.
BUG=300084
R=sky@chromium.org
Review URL: https://codereview.chromium.org/272133003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In particular they both need to move all of the children from the old
layer to the newly created layer.
BUG=none
TEST=covered by test now
R=oshima@chromium.org
Review URL: https://codereview.chromium.org/204793004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258115 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=330556
TEST=no change
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/106383004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242504 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
These methods now take pointers instead of non-const references, this was
previously a violation of the style guide.
R=vollick@chromium.org
BUG=160417
Review URL: https://chromiumcodereview.appspot.com/23724024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222864 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This issue was found by a linter.
R=vollick@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/22845006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218737 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/16175008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Needed to troubleshoot end-user UI lockups on Chrome OS Ash.
BUG=196626
TEST=manual, hit Ctrl-Alt-Shift-U and see more info in the logs
TBR=sky@chromium.org for logging-only changes in ui/*
Review URL: https://chromiumcodereview.appspot.com/12494011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188561 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We have too many ways to do the same thing in gfx::Transform, and their names
can lead to confusion. We have the notion of Concat-ing and Preconcat-ing.
We've borrowed this verbage from skia. a.preConcat(b) means a = a * b. This may
seem counter-intuitive, but is the correct definition if we are multiplying our
points/vectors on the right.
That said, we almost always want to pre-concat. This what is done throughout
WebKit. To simplify matters, rather than having ConcatFoo and PreconcatFoo, we
will now only have Foo which does what PreconcatFoo used to.
Furthermore, we also have SetFoo which is almost always used immediately after
a transform is created, so Foo would do fine (with the optimization mentioned
below).
Another bit of redundant code eliminated by this CL is
InterpolatedTransform::FactorTRS. This function was brittle and naive, and now
that gfx::Transform::Blend exists, it needs to go away.
Other minor changes rolled into this cleanup:
- RotateAbout now takes the newly minted Vector3dF
- The Foo functions mentioned above also check for identity to avoid
needless matrix multiplications.
BUG=159972
Review URL: https://chromiumcodereview.appspot.com/11418040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169476 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We've been using macros and our own hand-rolled versions of these functions.
No need to continue doing this. There are a few other minor clean-ups rolled
into this change. Leaving the big API clean-up (Removing SetXXX and ConcatXXX,
and s/PreconcatXXX/XXX/) for another CL.
Note: div-by-zero checks are due to shawnsingh@. I couldn't muck with this file and leave them there after seeing his fix.
BUG=None
Review URL: https://chromiumcodereview.appspot.com/11348090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Point3F::AsPoint() method converts from float to integer by doing an
implicit floor() on the values. Instead, we should have AsPointF() return
floating point values, and use the ToFlooredPoint() conversion method to
explicitly floor the values at the call-site if desired.
Also, move the point3.h header to point3_f.h so that it is consistent with
other geometry header file namings.
BUG=147395
R=sky
Review URL: https://chromiumcodereview.appspot.com/11301043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Converts SearchViewController to use live NTP content using views::WebView
instead of placeholder solid rect views::View.
TEST=Launch CrOS/Aura with --enabled-instant-extended-api, observe interactive "Most Visited" section on NTP
BUG=133529
R=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10787028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148438 0039d316-1c4b-4281-b951-d872f2087c98
|
|
BUG=104040
R=piman@chromium.org,ben@chromium.org
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10365007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135560 0039d316-1c4b-4281-b951-d872f2087c98
|