| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
CID=102647, 102333, 102332, 102303, 102302, 102299, 102297, 102296, 102048, 102032, 102031, 102030, 102029, 102028, 102010, 101681, 101657, 101655, 101438
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9005031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118848 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/9242017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118192 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9070004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=100898
R=pkasting@chromium.org
TBR=ben@chromium.org,stevenjb@chromium.org
Review URL: http://codereview.chromium.org/8990003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115046 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the 2 attempt, as the first patch was reverted by rsleevi at crrev.com/111323
BUG=100898
R=pkasting@chromium.org
TBR=ben@chromium.org,mirandac@chromium.org
Review URL: http://codereview.chromium.org/8983004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114925 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ui/gfx: Convert Canvas::DrawRectInt() to use gfx::Rect.
BUG=100898
R=pkasting@chromium.org
Review URL: http://codereview.chromium.org/8476019
TBR=tfarina@chromium.org
Review URL: http://codereview.chromium.org/8681001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111323 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=100898
R=pkasting@chromium.org
Review URL: http://codereview.chromium.org/8476019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111288 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=100898
R=pkasting@chromium.org
Review URL: http://codereview.chromium.org/8390037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=100898
R=pkasting@chromium.org
Review URL: http://codereview.chromium.org/8383028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107276 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/8122013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104146 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For strings coming from webpage (such as alert in JS), its directionality is set according to the directionality of its first strong character's directionality.
For chrome's UI string, its directionality is set as RTL if the UI is RTL and the string contains strong RTL characters.
BUG=91698
TEST=start chrome in RTL locale, check about:crash, "!" should be displayed at very left. check the directionality of alert() with bidi text in LTR and RTL chrome, the directionality should be determined by its first strong directionality character.
Review URL: http://codereview.chromium.org/7655037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7670016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97286 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
functions were duplicated for both SkCanvas and SkDevice instances.
This CL unifies these calls to only make use of the SkCanvas entries.
This is CL part of a larger goal to remove the PlatformDevice class.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/7168022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89410 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of PlatformDevice within Chrome. The Skia library now provides multiple back-ends for the SkDevice class, so PlatformDevice's inheritance of SkDevice, and the assumption of instances of PlatformDevice limits the use of these new back-ends.
A new set of helper functions is provided for the PlatformDevice entry points. Upon construction of a PlatformDevice, a pointer to the interface is cached in the parent SkDevice's SkMetaData. The new helper functions forward calls to the interface cached in the metadata.
BUG=NONE
TEST=NONE
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86625
Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=86625
Review URL: http://codereview.chromium.org/7019013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86823 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the dependency of PlatformDevice within Chrome. The Skia library now provides multiple back-ends for the SkDevice class, so PlatformDevice's inheritance of SkDevice, and the assumption of instances of PlatformDevice limits the use of these new back-ends.
A new set of helper functions is provided for the PlatformDevice entry points. Upon construction of a PlatformDevice, a pointer to the interface is cached in the parent SkDevice's SkMetaData. The new helper functions forward calls to the interface cached in the metadata.
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/7019013
TBR=twiz@chromium.org
Review URL: http://codereview.chromium.org/6987019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86629 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
of PlatformDevice within Chrome. The Skia library now provides multiple back-ends for the SkDevice class, so PlatformDevice's inheritance of SkDevice, and the assumption of instances of PlatformDevice limits the use of these new back-ends.
A new set of helper functions is provided for the PlatformDevice entry points. Upon construction of a PlatformDevice, a pointer to the interface is cached in the parent SkDevice's SkMetaData. The new helper functions forward calls to the interface cached in the metadata.
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/7019013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86625 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Green or blue tab titles would draw incorrectly.
The problem was a typo in my drawing code that swapped the blue and green values.
BUG=82233
TEST=Ran and verified that the tab title color were correct.
Review URL: http://codereview.chromium.org/6990053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86380 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When fading tab titles we would sometimes have some glitches when transitioning from the solid title to the faded title.
The problem was that we were switching the front from normal clear type to cleartype off. This changed caused visible glitches when transitioning between the two fonts.
Initially I switched clear type off to make it easier to calculate the alpha of the text. msw recomended using the luminosity of the text to determine the alpha. It turns out that this works great and we no longer have to turn off clear type in the faded sections.
BUG=78869
TEST=Reproduced the bug. Applied my patch and verified that the bug no longer reproduced.
Review URL: http://codereview.chromium.org/6902016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
My fade tab title code was leaking a HFONT everytime a tab title was drawn.
I think this leak is what's causing the CreateDIBSection() call to fail.
BUG=78857
TEST=Reproduced the original bug by opening lots of tabs. Applied my fix and verified that I could no longer reproduce the bug.
Review URL: http://codereview.chromium.org/6813098
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81207 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The fade tab title change is causing the browser to crash on some computers.
It looks like the problem is in BitmapPlatformDevice::create(). For some reason it's returning NULL.
This change just adds a NULL check and falls back to the old drawing code.
Once this is checked in I'll investigate what the root cause is.
BUG=78857
TEST=Compiled and ran.
Review URL: http://codereview.chromium.org/6823020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81026 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change fades tab titles instead of truncating them with a "...".
I tried to copy the Mac implemenation from here:
http://code.google.com/p/google-toolbox-for-mac/source/browse/trunk/AppKit/GTMFadeTruncatingTextFieldCell.m
but my version is not as good since I couldn't figure out how to draw text on a transparent background.
BUG=69301
TEST=Ran Chromium and verified that things looked ok.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80416
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80748
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80870
Review URL: http://codereview.chromium.org/6695043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
truncating them with a "...".I tried to copy the Mac implemenation from here:http://code.google.com/p/google-toolbox-for-mac/source/browse/trunk/AppKit/GTMFadeTruncatingTextFieldCell.mbut my version is not as good since I couldn't figure out how to draw text on a transparent background.BUG=69301TEST=Ran Chromium and verified that things looked ok.Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80416Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80748Review URL: http://codereview.chromium.org/6695043
TBR=sail@chromium.org
Review URL: http://codereview.chromium.org/6815022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80871 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change fades tab titles instead of truncating them with a "...".
I tried to copy the Mac implemenation from here:
http://code.google.com/p/google-toolbox-for-mac/source/browse/trunk/AppKit/GTMFadeTruncatingTextFieldCell.m
but my version is not as good since I couldn't figure out how to draw text on a transparent background.
BUG=69301
TEST=Ran Chromium and verified that things looked ok.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80416
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80748
Review URL: http://codereview.chromium.org/6695043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80870 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
truncating them with a "...".I tried to copy the Mac implemenation from here:http://code.google.com/p/google-toolbox-for-mac/source/browse/trunk/AppKit/GTMFadeTruncatingTextFieldCell.mbut my version is not as good since I couldn't figure out how to draw text on a transparent background.BUG=69301TEST=Ran Chromium and verified that things looked ok.Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80416Review URL: http://codereview.chromium.org/6695043
TBR=sail@chromium.org
Review URL: http://codereview.chromium.org/6815004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change fades tab titles instead of truncating them with a "...".
I tried to copy the Mac implemenation from here:
http://code.google.com/p/google-toolbox-for-mac/source/browse/trunk/AppKit/GTMFadeTruncatingTextFieldCell.m
but my version is not as good since I couldn't figure out how to draw text on a transparent background.
BUG=69301
TEST=Ran Chromium and verified that things looked ok.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80416
Review URL: http://codereview.chromium.org/6695043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change fades tab titles instead of truncating them with a "...".
I tried to copy the Mac implemenation from here:
http://code.google.com/p/google-toolbox-for-mac/source/browse/trunk/AppKit/GTMFadeTruncatingTextFieldCell.m
but my version is not as good since I couldn't figure out how to draw text on a transparent background.
BUG=69301
TEST=Ran Chromium and verified that things looked ok.
Review URL: http://codereview.chromium.org/6695043
TBR=sail@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80418 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change fades tab titles instead of truncating them with a "...".
I tried to copy the Mac implemenation from here:
http://code.google.com/p/google-toolbox-for-mac/source/browse/trunk/AppKit/GTMFadeTruncatingTextFieldCell.m
but my version is not as good since I couldn't figure out how to draw text on a transparent background.
BUG=69301
TEST=Ran Chromium and verified that things looked ok.
Review URL: http://codereview.chromium.org/6695043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80416 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As a first step, maintain a skia canvas in each transformed view. Each
transformed view will acquire a texture-id for the canvas it owns. Whenever the
canvas is updated, it will trigger a refresh in the compositor tree.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6594125
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=71063
TEST=compiled
Review URL: http://codereview.chromium.org/6312156
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
To reduce the size of this change I've left stub header files in src/gfx/. Once all includes have been updated I'll delete the stub files.
BUG=71063
TEST=Still doing test builds.
Review URL: http://codereview.chromium.org/6246027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73530 0039d316-1c4b-4281-b951-d872f2087c98
|