| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
This also cleans up some of the visibility code in Message
Center.
BUG=228974
Review URL: https://chromiumcodereview.appspot.com/23636010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222536 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It will remove unnecessary methods. Also, each ash notifications
has its own notifier id as SYSTEM_COMPONENT. Then we can distinguish
those notification types, which means this will enable to allow
some urgent system notifications (like power) in the lock screen.
BUG=250937
R=dewittj@chromium.org, stevenjb@chromium.org
TEST=no breaks on existing tests
Review URL: https://chromiumcodereview.appspot.com/23340002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219437 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=263627
R=mukai@chromium.org
Review URL: https://codereview.chromium.org/19471016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213335 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The message center has been re-organized to get rid of unused classes
since we don't need the rounded corners and the arrow. This redesign
affects Linux (Aura) and Windows builds
BUG=249482, 259577
Review URL: https://chromiumcodereview.appspot.com/18003003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212007 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
r=mukai@chromium.org,stevenjb@chromium.org
TBR=johnnyg@chromium.org
BUG=254719
Review URL: https://chromiumcodereview.appspot.com/18247002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210425 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=245869
R=dewittj@chromium.org, rsesek@chromium.org
TEST=manually / don't break existing tests
Review URL: https://chromiumcodereview.appspot.com/16867003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207466 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
views::ContextMenuController::ShowContextMenuForView.
This will help bring context menu positioning logic to one place and unify the
positioning logic for all views.
BUG=239110
Review URL: https://chromiumcodereview.appspot.com/16979002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207019 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NotificationView::Create now accepts a parameter to specify whether
they are top-level or rendered inside another window. Shadows are
created when the toasts is rendered on another window (e.g. message
center) and no shadows are created otherwise. This is a workaround at
least until background transparency works properly on Linux Aura.
BUG=NONE
Review URL: https://chromiumcodereview.appspot.com/16818009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206965 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also no animation for hovering over expand button.
BUG=249113
TEST=Manual test by hovering over close button
Review URL: https://chromiumcodereview.appspot.com/17283004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206823 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
No functionality change.
Requested by dharcourt in https://codereview.chromium.org/15050006/
BUG=none
TBR=dharcourt@chromium.org
Review URL: https://codereview.chromium.org/15685007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201624 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=239187
TEST=manually
Review URL: https://chromiumcodereview.appspot.com/14875010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200983 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This adds the status bar item to the menubar, and it creates a window and
view controller to display notifications in the message center.
BUG=238244
Review URL: https://chromiumcodereview.appspot.com/14864032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200640 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- close button and expand button didn't have accessible name, set them
- set the accessible name of notification's action buttons
- should call parent class's OnFocus if overridden. Otherwise
accessibility event is never triggerred
- a notifier settings item is essentially a checkbox, so make it
behaves as a checkbox from a11y code
- EntryView is just a container, so delegate a11y to its content
BUG=239185
R=dewittj@chromium.org,dharcourt@chromium.org
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/14604004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199094 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=237070, 237049
Review URL: https://chromiumcodereview.appspot.com/14745002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197819 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
See discussion in chromium-dev mailing list:
https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/2EdybzAxSu8
The consensul was to remove it as it hasn't been providing us much value.
BUG=234765
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/14271017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196051 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Changes code to use the images committed with http://crrev.com/14362011.
BUG=232963
Review URL: https://codereview.chromium.org/14189012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195404 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=232282
TEST=manually
Review URL: https://chromiumcodereview.appspot.com/14225010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195088 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=220240
R=dharcourt@chromium.org
Review URL: https://chromiumcodereview.appspot.com/14188010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194812 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=224974
Review URL: https://codereview.chromium.org/14198004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194699 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now MessageCenter class is the owner of the notification list.
All of the clients may request the add/remove, and all changes
will be distributed to the observers.
BUG=224967
TEST=trybots
TBR=sky@chromium.org,
Review URL: https://chromiumcodereview.appspot.com/13490002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194014 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- The 'display_source' field should specify the extension's name.
It seems to be the field for such purpose (see DisplayNameForOrigin()
method in DesktopNotificationService for example)
- Fix the strings of 'disable extension' menu item to show the
extension's name.
- Fix the behavior of 'DisableExtension' in MessageCenterNotificationManager.
It should not disable the extension itself, rather disable the notification
ability for the extension.
BUG=226185
TEST=manually
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/13421008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192907 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- somehow it's disabled. enabled.
- always show 'settings' when rich notification is enabled
- opens the settings dialog instead of settings page when rich notification is enabled
BUG=225052
Review URL: https://chromiumcodereview.appspot.com/13379002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191731 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MenuModelAdapter.
BUG=none
TEST=none
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/13201003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191274 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
notification.
This UI is not visible at all at the moment since no window hosts this view.
BUG=179904
Review URL: https://chromiumcodereview.appspot.com/12521018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190818 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch adds focusability to all the buttons on a notification:
"X", "...", button1/2, Settings, and Clear All.
BUG=179431
Review URL: https://chromiumcodereview.appspot.com/12545045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188466 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This involved two changes: 1) How notification views are updated; and
2) How notification views are laid out.
1) Previously notification views were updated by deleting and recreating
all of their subviews. This would be too cumbersome to do with text line
limits because those require notification views to be updated every time
their bounds change (because bounds changes can cause text to go over
or under their line limits and this would require showing or hiding the
expand button). To avoid this problem updating has been changed to
use view hiding/showing (SetVisible()) instead of deletion/recreation.
2) Laying out hidden views was too cumbersome with a GridLayout, so this
was replaced with a couple of easier to deal with BoxLayout subviews.
A side effect of #1 is that expansion buttons are now hidden when they
are not needed. This should be the only user visible change introduced
by this change list as its purpose is just to lay the ground work for
text line limits. Those limits will come in a different change list.
BUG=168939
Review URL: https://chromiumcodereview.appspot.com/12638033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=181541
TEST=unittest
Review URL: https://chromiumcodereview.appspot.com/12518012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187769 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implemented collapse/expand for notifications in the notification
center. Notifications are collapsed by default and can be expanded by
pressing their expand button. Once expanded, they can't be collapsed
again.
Limitations of this version are:
1) Notifications in alerts/toasts are not affected (they're always expanded).
2) Notifications get expand buttons even if they have no content to expand.
3) Collapsed text is always collapsed to 1 lines (not 2 or 3 as required) and expanded text
is always expanded to its full height (not limited to 7 lines as
required).
4) Notification expansion is lost when notifications are
added to the notification center or when the notification center is
closed and opened again. These issues will be addressed in separate
change lists.
BUG=161098
TBR=stevenjb@chromium.org
Review URL: https://chromiumcodereview.appspot.com/12326091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186873 0039d316-1c4b-4281-b951-d872f2087c98
|
|
BUG=179916
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/12377086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186005 0039d316-1c4b-4281-b951-d872f2087c98
|