| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Propagate system theme (high contrast, etc.) changes throughout Views.
(Win UI wasn't being notified; omnibox, find bar, etc. were broken, now aren't).
(Linux Aura didn't update on changes with "Use Classic Theme", now it does).
Make NativeTheme hold an observer list to be notified of changes.
NotifyObservers of system color changes on Win via SysColorChangeListener.
Nix NativeTheme duties for ThemeServiceAuraX11, and LinuxUI / Gtk2UI.
Make Widget a NativeThemeObserver to call PropagateNativeThemeChanged.
Start observing the relevant NativeTheme after native widget initialization.
Make View::AddChildViewAt only update child views, not itself and siblings.
(this was invoking redundant calls on itself as the parent and sibling views)
Implement the BrowserView::OnNativeThemeChanged override.
(update the frame and trigger a repaint with UserChangedTheme)
(call MaybeShowInvertBubbleView, nix SysColorChangeListener impl)
TODO(followup): Audit Views that need OnNativeThemeChanged overrides.
BUG=134766
TEST=Win/Linux UI updates better when applying high contrast black/inverse system themes.
R=erg@chromium.org, estade@chromium.org, sky@chromium.org
Review URL: https://codereview.chromium.org/239093007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266232 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
MENU_VARIATION_COMPACT_2 and colors from MENU_VARIATION_CONTRAST
BUG=267620, 266696
Review URL: https://chromiumcodereview.appspot.com/23447024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222901 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
PM and UI designer wants to try more compact menu style and more contrast menu version. So added two compact menu experiments and one with more contrast.
BUG=157692
Review URL: https://chromiumcodereview.appspot.com/14881003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198436 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=157692
Review URL: https://chromiumcodereview.appspot.com/13949002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193801 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The finch experiment of
https://chromiumcodereview.appspot.com/12549009
Causes aura windows to crash because the random folks refactoring
code are also subject of finch experiments, so for example this CL
https://chromiumcodereview.appspot.com/12483006
Broke us in debug on windows and gives random colors on release.
TBR=sky
BUG=157692
TEST=see bug
Review URL: https://codereview.chromium.org/13065003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190714 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Histogram to track if anything was selected or not.
Histogram to track time to selection
Histogram to track selection index
BUG=180420
Review URL: https://chromiumcodereview.appspot.com/12549009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187057 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=157692
Review URL: https://chromiumcodereview.appspot.com/11775007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make LocationBarView::GetColor use NativeTheme colors.
(except the CrOS transparent Omnibox background color)
Add NativeTheme read-only textfield color/background IDs.
Cache a set of Windows system colors in NativeThemeWin.
Update cached colors via gfx::SysColorChangeListener impl.
Init colors in NativeTextfieldViews, not TextfieldViewsModel.
Refactor Textfield and NativeTextfieldViews color code.
Nix frivolous AutocompleteTextfield::PaintChildren OVERRIDE.
Nix Textfield cursor color settings and visibility kludge.
(replace with proper cursor enabled accessors for views)
TODO(followup): Fix related existing issues (not affected here):
(existing textfields don't update with system color changes)
(bubbles seem to cache the system colors at startup...)
BUG=134766
TEST=Views textfields are created with the current system colors.
R=sky@chromium.org,varunjain@chromium.org,samarth@chromium.org
TBR=marja@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11421204
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172142 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Changed so far: menu background, no gutter, separator, border with round corners (corners are not transparent yet).
This is work in progress, just want to keep change size manageable.
BUG=157692
Review URL: https://chromiumcodereview.appspot.com/11348055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168671 0039d316-1c4b-4281-b951-d872f2087c98
|
|
BUG=103304
R=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11275322
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168194 0039d316-1c4b-4281-b951-d872f2087c98
|