summaryrefslogtreecommitdiffstats
path: root/ui/oak/oak_window.cc
Commit message (Collapse)AuthorAgeFilesLines
* Reland 179231xiyuan@chromium.org2013-01-301-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | > views: Fix a Widget destruction crash. > > For WIDGET_OWNS_NATIVE_WIDGET widget, we destroy root view before we delete > |native_widget_|. If a WidgetDelegateView is in root view's hierarchy, the > native widget destruction would crash because |widget_delegate_| is accessed > in OnNativeWidgetDestroying but it is deleted with root view already. > > This CL marks WidgetDelegateView as owned by client so that it does not go > away with the root view hierarchy and be deleted on DeleteDelegate. > > BUG=164791 > TEST=Covered with a new unit test. > > R=ben@chromium.org BUG=164791,172842 TEST=No memory leak as in 172842. Review URL: https://chromiumcodereview.appspot.com/11953066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179694 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 179231 as it has introduced a large number of memory leaks to ↵timurrrr@chromium.org2013-01-291-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | ash_unittests BUG=172842 > views: Fix a Widget destruction crash. > > For WIDGET_OWNS_NATIVE_WIDGET widget, we destroy root view before we delete > |native_widget_|. If a WidgetDelegateView is in root view's hierarchy, the > native widget destruction would crash because |widget_delegate_| is accessed > in OnNativeWidgetDestroying but it is deleted with root view already. > > This CL marks WidgetDelegateView as owned by client so that it does not go > away with the root view hierarchy and be deleted on DeleteDelegate. > > BUG=164791 > TEST=Covered with a new unit test. > > R=ben@chromium.org > > > Review URL: https://chromiumcodereview.appspot.com/11953066 TBR=xiyuan@chromium.org Review URL: https://codereview.chromium.org/12084041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179308 0039d316-1c4b-4281-b951-d872f2087c98
* views: Fix a Widget destruction crash.xiyuan@chromium.org2013-01-291-0/+1
| | | | | | | | | | | | | | | | | | | | For WIDGET_OWNS_NATIVE_WIDGET widget, we destroy root view before we delete |native_widget_|. If a WidgetDelegateView is in root view's hierarchy, the native widget destruction would crash because |widget_delegate_| is accessed in OnNativeWidgetDestroying but it is deleted with root view already. This CL marks WidgetDelegateView as owned by client so that it does not go away with the root view hierarchy and be deleted on DeleteDelegate. BUG=164791 TEST=Covered with a new unit test. R=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/11953066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179231 0039d316-1c4b-4281-b951-d872f2087c98
* More work to make ash_unittests pass when we require context.erg@chromium.org2013-01-091-3/+6
| | | | | | | | | | | With the context checking DCHECK, ash_unittests and unit_tests now run on chromeos. BUG=161882 Review URL: https://chromiumcodereview.appspot.com/11801027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175892 0039d316-1c4b-4281-b951-d872f2087c98
* Converts remainder of ui (except for ui/app_list) and ↵pkotwicz@chromium.org2012-05-311-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | chrome/browser/ui/views/frame to use ImageSkia Do conversion using the same sed script as for 10437006 Modified by hand afterwards: 1 chrome/browser/download/download_util.cc 2 chrome/browser/ui/panels/panel_browser_frame_view.cc 3 chrome/browser/ui/panels/panel_browser_frame_view.h 4 chrome/browser/ui/toolbar/wrench_menu_model.cc 5 chrome/browser/ui/views/ash/browser_non_client_frame_view_ash.cc 6 chrome/browser/ui/views/ash/browser_non_client_frame_view_ash.h 7 chrome/browser/ui/views/constrained_window_views.cc 8 chrome/browser/ui/views/frame/glass_browser_frame_view.cc 9 chrome/browser/ui/views/tab_icon_view.h 10 ui/base/dragdrop/drag_utils.h 11 ui/base/dragdrop/drag_utils_gtk.cc 12 ui/base/dragdrop/drag_utils_win.cc 13 ui/base/native_theme/native_theme_android.cc 14 ui/base/native_theme/native_theme_android.h 15 ui/base/native_theme/native_theme_base.cc 16 ui/base/native_theme/native_theme_base.h 17 ui/views/widget/native_widget_private.h 18 ui/views/window/frame_background.h 19 ui/views/window/window_resources.h Line wrapping and include fixes chrome/browser/ui/views/frame/app_panel_browser_frame_view.cc 1 chrome/browser/ui/views/frame/browser_view.cc 2 chrome/browser/ui/views/frame/opaque_browser_frame_view.cc 3 ui/base/dragdrop/drag_utils_aura.cc 4 ui/base/dragdrop/os_exchange_data_provider_aura.h 5 ui/base/native_theme/native_theme_aura.cc 6 ui/views/button_drag_utils.h 7 ui/views/painter.cc 8 ui/views/painter.h 9 ui/views/widget/native_widget_aura.cc 10 ui/views/widget/widget_delegate.h 11 ui/views/window/custom_frame_view.cc 12 ui/views/window/custom_frame_view.h Test=Compiles, Webkit layout tests fast/ pass Bug=124566 Review URL: https://chromiumcodereview.appspot.com/10447053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139734 0039d316-1c4b-4281-b951-d872f2087c98
* oak: Fix component build.tfarina@chromium.org2012-05-251-0/+1
| | | | | | | | | | | | | | | | | | | | | | | The first patch that tried to convert oak from static_library to component was r136217, but later it was reverted in r136229 because it broke the aura compile on Linux and Windows with the following error: out/Release/../../third_party/gold/gold64: out/Release/obj.target/ash/libash.so:error: undefined reference to 'oak::ShowOakWindow()'to... The only change here from the first patch was the addition of oak.h include in oak_window.cc, and that addition seems to have fixed the above issue. I'll make sure it passes linux_aura,win_aura before landing this again. TEST=run out/Debug/ash_shell --ash-enable-oak, press Ctrl+Shift+F1, the Oak window should appear and it should work fine. R=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10453007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139036 0039d316-1c4b-4281-b951-d872f2087c98
* views: Have a more accurate name for View parent_owned accessors.tfarina@chromium.org2012-05-121-2/+2
| | | | | | | | | | | | Remove the getter accessor of parent_owned() because it's used only internally by View. And change the setter accessor from set_parent_owned() to set_owned_by_client(). BUG=122384 R=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10384068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136766 0039d316-1c4b-4281-b951-d872f2087c98
* Replaced sk_canvas()->drawPath() with DrawPath()pkotwicz@chromium.org2012-04-101-1/+1
| | | | | | | | | | | | | | Replaced sk_canvas()->drawColor() with DrawColor() Removed any instances of #include "third_party/skia/include/core/SkCanvas.h" Replaced DrawPath in touch_selection_controller_impl with DrawCircle call manually Bug=114665 Test=Compiles Review URL: http://codereview.chromium.org/10025011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131618 0039d316-1c4b-4281-b951-d872f2087c98
* Adds window property display. A table view (acting as a list) with formatted ↵ben@chromium.org2012-03-131-21/+22
| | | | | | | | | | content below the tree view. This will do for now. http://crbug.com/97266 TEST=none Review URL: https://chromiumcodereview.appspot.com/9689039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126492 0039d316-1c4b-4281-b951-d872f2087c98
* Basic skeleton of a window/layer/view inspector.ben@chromium.org2012-03-121-0/+156
Ctrl+Shift+F1 brings it up. http://crbug.com/97266 TEST=none Review URL: https://chromiumcodereview.appspot.com/9662022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126207 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-10 16:05:11 +0000